You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@knox.apache.org by "Kevin Risden (JIRA)" <ji...@apache.org> on 2018/12/03 15:03:00 UTC

[jira] [Commented] (KNOX-1647) Identity Assertion should not modify order of query params

    [ https://issues.apache.org/jira/browse/KNOX-1647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16707321#comment-16707321 ] 

Kevin Risden commented on KNOX-1647:
------------------------------------

HttpUtils currently handles the splitting of the query string. It looks like the current HttpUtils#splitQuery comes from [https://stackoverflow.com/questions/13592236/parse-a-uri-string-into-name-value-collection]

A quick solution is to use LinkedHashMap instead of a plain hashmap. This will ensure that keys are kept in insertion order. We would need to ensure that callers of HttpUtils.splitQuery also keep using LinkedHashMap where applicable.

We could also look at using HttpClient URLEncodedUtils since that is maintained by the Apache Http client folks specifically for this task of splitting a query string.

> Identity Assertion should not modify order of query params
> ----------------------------------------------------------
>
>                 Key: KNOX-1647
>                 URL: https://issues.apache.org/jira/browse/KNOX-1647
>             Project: Apache Knox
>          Issue Type: Bug
>            Reporter: Kevin Risden
>            Priority: Major
>             Fix For: 1.3.0
>
>
> IdentityAssertion currently breaks apart the query string into parameters and doesn't preserve the order. This order should be preserved.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)