You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kafka.apache.org by mj...@apache.org on 2024/08/23 01:33:05 UTC

(kafka) branch 3.6 updated: MINOR: fix HTML for topology.optimization config (#16953)

This is an automated email from the ASF dual-hosted git repository.

mjsax pushed a commit to branch 3.6
in repository https://gitbox.apache.org/repos/asf/kafka.git


The following commit(s) were added to refs/heads/3.6 by this push:
     new c888ab9c612 MINOR: fix HTML for topology.optimization config (#16953)
c888ab9c612 is described below

commit c888ab9c612ee492c0bb31495efefff0aba6e2ea
Author: Matthias J. Sax <ma...@confluent.io>
AuthorDate: Thu Aug 22 00:24:16 2024 -0700

    MINOR: fix HTML for topology.optimization config (#16953)
    
    The HTML rendering broke via https://issues.apache.org/jira/browse/KAFKA-14209 in 3.4 release. The currently shown value is some garbage org.apache.kafka.streams.StreamsConfig$$Lambda$20/0x0000000800c0cf18@b1bc7ed
    
    cf https://kafka.apache.org/documentation/#streamsconfigs_topology.optimization
    
    Verified the fix via running StreamsConfig#main() locally.
    
    Reviewers: Bill Bejeck <bi...@confluent.io>, Chia-Ping Tsai <ch...@gmail.com>
---
 .../main/java/org/apache/kafka/streams/StreamsConfig.java    | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java b/streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java
index 1cd80b2093d..edf807eb723 100644
--- a/streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java
+++ b/streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java
@@ -965,7 +965,17 @@ public class StreamsConfig extends AbstractConfig {
             .define(TOPOLOGY_OPTIMIZATION_CONFIG,
                     Type.STRING,
                     NO_OPTIMIZATION,
-                    (name, value) -> verifyTopologyOptimizationConfigs((String) value),
+                    new ConfigDef.Validator() {
+                        @Override
+                        public void ensureValid(final String name, final Object value) {
+                            verifyTopologyOptimizationConfigs((String) value);
+                        }
+
+                        @Override
+                        public String toString() {
+                            return TOPOLOGY_OPTIMIZATION_CONFIGS.toString();
+                        }
+                    },
                     Importance.MEDIUM,
                     TOPOLOGY_OPTIMIZATION_DOC)