You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/10/08 05:19:01 UTC
[GitHub] [spark] xwu99 commented on a change in pull request #33941: [WIP][SPARK-36699][Core] Reuse compatible executors for stage-level scheduling
xwu99 commented on a change in pull request #33941:
URL: https://github.com/apache/spark/pull/33941#discussion_r724707608
##########
File path: core/src/main/scala/org/apache/spark/internal/config/package.scala
##########
@@ -572,6 +572,12 @@ package object config {
.booleanConf
.createWithDefault(false)
+ private[spark] val DYN_ALLOCATION_REUSE_EXECUTORS =
+ ConfigBuilder("spark.dynamicAllocation.reuseExecutors")
Review comment:
It will impact both dynamic allocation and scheduling. For end user it make sense to put it under scheduler. Also need to document how it would impact the behavior of spark.dynamicAllocation.init/min/max executors for different resource profiles.
Will update version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org