You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@age.apache.org by GitBox <gi...@apache.org> on 2021/12/21 07:47:47 UTC
[GitHub] [incubator-age] deem0n opened a new pull request #166: pg_dump support
deem0n opened a new pull request #166:
URL: https://github.com/apache/incubator-age/pull/166
Allow pg_dump to dump content of the `ag_catalog.*` tables
Fix typo in the `flush_label_oid_cache`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-age] JoshInnis commented on a change in pull request #166: pg_dump support
Posted by GitBox <gi...@apache.org>.
JoshInnis commented on a change in pull request #166:
URL: https://github.com/apache/incubator-age/pull/166#discussion_r778984171
##########
File path: src/backend/utils/cache/ag_cache.c
##########
@@ -633,7 +633,7 @@ static void flush_label_oid_cache(void)
{
HASH_SEQ_STATUS hash_seq;
- hash_seq_init(&hash_seq, label_name_graph_cache_hash);
+ hash_seq_init(&hash_seq, label_oid_cache_hash);
Review comment:
What was your reasoning for doing this? Our goal is to move away from oids?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-age] JoshInnis commented on pull request #166: pg_dump support
Posted by GitBox <gi...@apache.org>.
JoshInnis commented on pull request #166:
URL: https://github.com/apache/incubator-age/pull/166#issuecomment-1085257235
@deem0n Please provide a pull request that only includes adding our ag_catalog tables as configuration tables, the saved_result_relinfo issue looks to be a separate issue, given what the next line is. We need to review that as a separate issue from the pg_dump support issue that is the primary change in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-age] emotionbug commented on pull request #166: pg_dump support
Posted by GitBox <gi...@apache.org>.
emotionbug commented on pull request #166:
URL: https://github.com/apache/incubator-age/pull/166#issuecomment-1021782006
Looks good to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-age] deem0n commented on a change in pull request #166: pg_dump support
Posted by GitBox <gi...@apache.org>.
deem0n commented on a change in pull request #166:
URL: https://github.com/apache/incubator-age/pull/166#discussion_r782045361
##########
File path: src/backend/utils/cache/ag_cache.c
##########
@@ -633,7 +633,7 @@ static void flush_label_oid_cache(void)
{
HASH_SEQ_STATUS hash_seq;
- hash_seq_init(&hash_seq, label_name_graph_cache_hash);
+ hash_seq_init(&hash_seq, label_oid_cache_hash);
Review comment:
We doing tests with dump & restore of the database with AGE extension and some graph data. After restore we have broken oids in the ag_catalog.* tables. Which can be easily fixed and I will commit the fix procedure later. But even after the oid fix we still have errors in the `flush_label_oid_cache(void)`. I think that using `label_name_graph_cache_hash` is just a typo. At least after my fix we see no errors with broken cache anymore after dump & restore and oid fixes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-age] deem0n commented on a change in pull request #166: pg_dump support
Posted by GitBox <gi...@apache.org>.
deem0n commented on a change in pull request #166:
URL: https://github.com/apache/incubator-age/pull/166#discussion_r782048154
##########
File path: src/backend/utils/cache/ag_cache.c
##########
@@ -633,7 +633,7 @@ static void flush_label_oid_cache(void)
{
HASH_SEQ_STATUS hash_seq;
- hash_seq_init(&hash_seq, label_name_graph_cache_hash);
+ hash_seq_init(&hash_seq, label_oid_cache_hash);
Review comment:
Eliminating oids would make dump&restore a breeze, but probably will impact query speed ? I did not spent much time in AGE internals to participate in decision making, I guess.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org