You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by cloverhearts <gi...@git.apache.org> on 2017/04/28 07:12:38 UTC
[GitHub] zeppelin pull request #2298: [ZEPPELIN-2466] Chart resize problem
GitHub user cloverhearts opened a pull request:
https://github.com/apache/zeppelin/pull/2298
[ZEPPELIN-2466] Chart resize problem
### What is this PR for?
If you change the size of the chart after changing the mode of the chart,
The chart size is not reflected.
### What type of PR is it?
Bug Fix
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2466
### How should this be tested?
1. resize for your browser.
2. chart toggle -> for example, bar chart -> table -> bar chart
3. and try resize for browser.
### Screenshots (if appropriate)
#### bug
#### fixed
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cloverhearts/zeppelin fix/resize-problem-chart
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2298.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2298
----
commit 1dcf660e95f49abac4156a0ee7026870c9f1606c
Author: CloverHearts <cl...@gmail.com>
Date: 2017-04-28T07:06:34Z
fix resize problem
commit 13dee7630a28544633cf0312af2b0fec9948b542
Author: CloverHearts <cl...@gmail.com>
Date: 2017-04-28T07:11:49Z
remove semi colon
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2298: [ZEPPELIN-2466] Chart resize problem
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2298
Tested and works as described. LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2298: [ZEPPELIN-2466] Chart resize problem
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts commented on the issue:
https://github.com/apache/zeppelin/pull/2298
more fix
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2298: [ZEPPELIN-2466] Chart resize problem
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts closed the pull request at:
https://github.com/apache/zeppelin/pull/2298
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2298: [ZEPPELIN-2466] Chart resize problem
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2298
Was this merged into master already?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2298: [ZEPPELIN-2466] Chart resize problem
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts commented on the issue:
https://github.com/apache/zeppelin/pull/2298
@1ambda
Sorry for my late answer.
Implementation changed.
I will create a new PR. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2298: [ZEPPELIN-2466] Chart resize problem
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts commented on the issue:
https://github.com/apache/zeppelin/pull/2298
Fixed nvd3 basic resize event.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---