You are viewing a plain text version of this content. The canonical link for it is here.
Posted to solr-dev@lucene.apache.org by "Lars Kotthoff (JIRA)" <ji...@apache.org> on 2008/07/24 07:15:31 UTC
[jira] Created: (SOLR-650) facet.field should accept field names
separated by spaces or commas
facet.field should accept field names separated by spaces or commas
-------------------------------------------------------------------
Key: SOLR-650
URL: https://issues.apache.org/jira/browse/SOLR-650
Project: Solr
Issue Type: Improvement
Affects Versions: 1.3
Reporter: Lars Kotthoff
Priority: Minor
The current version of SimpleFacets does not support specifying several fields to facet on in a single facet.field parameter; it has to be specified for each field. This behaviour is inconcistent with the other parameters which accept field names as arguments -- they allow specifying multiple field names either as a comma- or space-separated list or by specifying the parameter multiple times.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-650) facet.field should accept field names
separated by spaces or commas
Posted by "Lars Kotthoff (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12616354#action_12616354 ]
Lars Kotthoff commented on SOLR-650:
------------------------------------
bq. ...among other things it breaks backwards compatibility for people who currently use facet.field on field names that contain whitespace.
Do you think that this would be much of an issue? Using field names with whitespace in them breaks almost everywhere else (retrieving fields, highlighting...) -- I don't think that many people are using fields with whitespace in them at all. Obviously I can only speculate about this though, so do correct me if I'm wrong.
bq. The only way i'm going to be on board with something like this is if it's a customization via some sort of general field name aliasing/globing configuration mechanism...
I think making the way parameters like this are handled consistent is a first step in that direction. It's going to be much easier to design and implement general field configuration parameters when they are handled in a uniform way.
bq. Wouldn't your approach be inconsistent with the way multi-valued parameters are handled in HTTP?
Sort of, but so is the rest of Solr.
bq. I'd say put multiple parameters separated by comma only when order is important (e.g. sort).
...which is also inconsistent with multi-valued parameter handling in HTTP :)
I think it doesn't really matter that Solr is inconsistent with HTTP parameter handling as long as it's consistently inconsistent.
> facet.field should accept field names separated by spaces or commas
> -------------------------------------------------------------------
>
> Key: SOLR-650
> URL: https://issues.apache.org/jira/browse/SOLR-650
> Project: Solr
> Issue Type: Improvement
> Affects Versions: 1.3
> Reporter: Lars Kotthoff
> Priority: Minor
> Attachments: SOLR-650.patch
>
>
> The current version of SimpleFacets does not support specifying several fields to facet on in a single facet.field parameter; it has to be specified for each field. This behaviour is inconcistent with the other parameters which accept field names as arguments -- they allow specifying multiple field names either as a comma- or space-separated list or by specifying the parameter multiple times.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-650) facet.field should accept field names
separated by spaces or commas
Posted by "Shalin Shekhar Mangar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12616350#action_12616350 ]
Shalin Shekhar Mangar commented on SOLR-650:
--------------------------------------------
I agree with Hoss. Wouldn't your approach be inconsistent with the way multi-valued parameters are handled in HTTP? I'd say put multiple parameters separated by comma only when order is important (e.g. sort).
> facet.field should accept field names separated by spaces or commas
> -------------------------------------------------------------------
>
> Key: SOLR-650
> URL: https://issues.apache.org/jira/browse/SOLR-650
> Project: Solr
> Issue Type: Improvement
> Affects Versions: 1.3
> Reporter: Lars Kotthoff
> Priority: Minor
> Attachments: SOLR-650.patch
>
>
> The current version of SimpleFacets does not support specifying several fields to facet on in a single facet.field parameter; it has to be specified for each field. This behaviour is inconcistent with the other parameters which accept field names as arguments -- they allow specifying multiple field names either as a comma- or space-separated list or by specifying the parameter multiple times.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-650) facet.field should accept field names
separated by spaces or commas
Posted by "Lars Kotthoff (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Kotthoff updated SOLR-650:
-------------------------------
Attachment: SOLR-650.patch
Syncing patch with trunk.
> facet.field should accept field names separated by spaces or commas
> -------------------------------------------------------------------
>
> Key: SOLR-650
> URL: https://issues.apache.org/jira/browse/SOLR-650
> Project: Solr
> Issue Type: Improvement
> Affects Versions: 1.3
> Reporter: Lars Kotthoff
> Priority: Minor
> Attachments: SOLR-650.patch, SOLR-650.patch, SOLR-650.patch
>
>
> The current version of SimpleFacets does not support specifying several fields to facet on in a single facet.field parameter; it has to be specified for each field. This behaviour is inconcistent with the other parameters which accept field names as arguments -- they allow specifying multiple field names either as a comma- or space-separated list or by specifying the parameter multiple times.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-650) facet.field should accept field names
separated by spaces or commas
Posted by "Lars Kotthoff (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Kotthoff updated SOLR-650:
-------------------------------
Attachment: SOLR-650.patch
Attaching new patch which applies cleanly to current TRUNK.
> facet.field should accept field names separated by spaces or commas
> -------------------------------------------------------------------
>
> Key: SOLR-650
> URL: https://issues.apache.org/jira/browse/SOLR-650
> Project: Solr
> Issue Type: Improvement
> Affects Versions: 1.3
> Reporter: Lars Kotthoff
> Priority: Minor
> Attachments: SOLR-650.patch, SOLR-650.patch
>
>
> The current version of SimpleFacets does not support specifying several fields to facet on in a single facet.field parameter; it has to be specified for each field. This behaviour is inconcistent with the other parameters which accept field names as arguments -- they allow specifying multiple field names either as a comma- or space-separated list or by specifying the parameter multiple times.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-650) facet.field should accept field names
separated by spaces or commas
Posted by "Hoss Man (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12616349#action_12616349 ]
Hoss Man commented on SOLR-650:
-------------------------------
-1
this idea has been discussed before, and i'm still opposed to it...
http://www.nabble.com/new-user%3A-some-questions-about-parameters-and-query-syntax-to17514279.html#a17572002
http://www.nabble.com/Re%3A--jira--Commented%3A-%28SOLR-247%29-Allow-facet.field%3D*-to-facet-on-all-fields-%28without-knowing-what-they-are%29-p10771433.html
...among other things it breaks backwards compatibility for people who currently use facet.field on field names that contain whitespace. If being consistent were worth breaking back compatibility then I would rather see us remove the "split" call for all params where it is currently used, then to add splitting to any existing params.
The only way i'm going to be on board with something like this is if it's a customization via some sort of general field name aliasing/globing configuration mechanism...
http://wiki.apache.org/solr/FieldAliasesAndGlobsInParams
> facet.field should accept field names separated by spaces or commas
> -------------------------------------------------------------------
>
> Key: SOLR-650
> URL: https://issues.apache.org/jira/browse/SOLR-650
> Project: Solr
> Issue Type: Improvement
> Affects Versions: 1.3
> Reporter: Lars Kotthoff
> Priority: Minor
> Attachments: SOLR-650.patch
>
>
> The current version of SimpleFacets does not support specifying several fields to facet on in a single facet.field parameter; it has to be specified for each field. This behaviour is inconcistent with the other parameters which accept field names as arguments -- they allow specifying multiple field names either as a comma- or space-separated list or by specifying the parameter multiple times.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-650) facet.field should accept field names
separated by spaces or commas
Posted by "Lars Kotthoff (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Kotthoff updated SOLR-650:
-------------------------------
Attachment: SOLR-650.patch
Patch implementing described funtionality and adding unit tests to verify it.
Note that the patch needs to be adapted if either of SOLR-247 or SOLR-645 are applied before this one.
> facet.field should accept field names separated by spaces or commas
> -------------------------------------------------------------------
>
> Key: SOLR-650
> URL: https://issues.apache.org/jira/browse/SOLR-650
> Project: Solr
> Issue Type: Improvement
> Affects Versions: 1.3
> Reporter: Lars Kotthoff
> Priority: Minor
> Attachments: SOLR-650.patch
>
>
> The current version of SimpleFacets does not support specifying several fields to facet on in a single facet.field parameter; it has to be specified for each field. This behaviour is inconcistent with the other parameters which accept field names as arguments -- they allow specifying multiple field names either as a comma- or space-separated list or by specifying the parameter multiple times.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.