You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2023/01/03 06:53:12 UTC

[GitHub] [kafka] ivanyu commented on pull request #13067: KAFKA-14524: Rewrite KafkaMetricsGroup in Java

ivanyu commented on PR #13067:
URL: https://github.com/apache/kafka/pull/13067#issuecomment-1369441609

   @ijuma @satishd what do you think about this approach to rewriting `KafkaMetricsGroup` in Java? Currently, classes-users of the `KafkaMetricsGroup` trait sometimes override its methods to tune its behavior (mostly, names). Instead, they can create anonymous subclasses. In this PR I only demonstrate the idea. If you think it's viable, I can spread it and get rid of the `KafkaMetricsGroup` trait.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org