You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Sanjay Radia (Created) (JIRA)" <ji...@apache.org> on 2011/12/13 08:05:32 UTC
[jira] [Created] (HADOOP-7913) Fix bug in ProtoBufRpcEngine -
Fix bug in ProtoBufRpcEngine -
-------------------------------
Key: HADOOP-7913
URL: https://issues.apache.org/jira/browse/HADOOP-7913
Project: Hadoop Common
Issue Type: Sub-task
Reporter: Sanjay Radia
Assignee: Sanjay Radia
The parent Jira moved the multiple protocol support to lower layer; it introduced a bug: the paramCLass parameter to
#server() constructor should be null so that it uses the registered rpc request deserializers.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7913) Fix bug in ProtoBufRpcEngine -
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13168428#comment-13168428 ]
Hudson commented on HADOOP-7913:
--------------------------------
Integrated in Hadoop-Hdfs-trunk #893 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/893/])
HADOOP-7913 Fix bug in ProtoBufRpcEngine (sanjay)
sradia : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1213619
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
> Fix bug in ProtoBufRpcEngine -
> -------------------------------
>
> Key: HADOOP-7913
> URL: https://issues.apache.org/jira/browse/HADOOP-7913
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: ipc
> Reporter: Sanjay Radia
> Assignee: Sanjay Radia
> Fix For: 0.24.0
>
> Attachments: hadoop-7913.patch, hadoop-7913.patch
>
>
> The parent Jira moved the multiple protocol support to lower layer; it introduced a bug: the paramCLass parameter to
> #server() constructor should be null so that it uses the registered rpc request deserializers.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7913) Fix bug in ProtoBufRpcEngine -
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13168247#comment-13168247 ]
Hadoop QA commented on HADOOP-7913:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12507148/hadoop-7913.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
-1 javadoc. The javadoc tool appears to have generated 5 warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in .
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/470//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/470//console
This message is automatically generated.
> Fix bug in ProtoBufRpcEngine -
> -------------------------------
>
> Key: HADOOP-7913
> URL: https://issues.apache.org/jira/browse/HADOOP-7913
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: ipc
> Reporter: Sanjay Radia
> Assignee: Sanjay Radia
> Attachments: hadoop-7913.patch, hadoop-7913.patch
>
>
> The parent Jira moved the multiple protocol support to lower layer; it introduced a bug: the paramCLass parameter to
> #server() constructor should be null so that it uses the registered rpc request deserializers.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7913) Fix bug in ProtoBufRpcEngine -
Posted by "Sanjay Radia (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sanjay Radia updated HADOOP-7913:
---------------------------------
Attachment: hadoop-7913.patch
> Fix bug in ProtoBufRpcEngine -
> -------------------------------
>
> Key: HADOOP-7913
> URL: https://issues.apache.org/jira/browse/HADOOP-7913
> Project: Hadoop Common
> Issue Type: Sub-task
> Reporter: Sanjay Radia
> Assignee: Sanjay Radia
> Attachments: hadoop-7913.patch
>
>
> The parent Jira moved the multiple protocol support to lower layer; it introduced a bug: the paramCLass parameter to
> #server() constructor should be null so that it uses the registered rpc request deserializers.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7913) Fix bug in ProtoBufRpcEngine -
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13168260#comment-13168260 ]
Hudson commented on HADOOP-7913:
--------------------------------
Integrated in Hadoop-Hdfs-trunk-Commit #1484 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1484/])
HADOOP-7913 Fix bug in ProtoBufRpcEngine (sanjay)
sradia : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1213619
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
> Fix bug in ProtoBufRpcEngine -
> -------------------------------
>
> Key: HADOOP-7913
> URL: https://issues.apache.org/jira/browse/HADOOP-7913
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: ipc
> Reporter: Sanjay Radia
> Assignee: Sanjay Radia
> Attachments: hadoop-7913.patch, hadoop-7913.patch
>
>
> The parent Jira moved the multiple protocol support to lower layer; it introduced a bug: the paramCLass parameter to
> #server() constructor should be null so that it uses the registered rpc request deserializers.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7913) Fix bug in ProtoBufRpcEngine -
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13168444#comment-13168444 ]
Hudson commented on HADOOP-7913:
--------------------------------
Integrated in Hadoop-Mapreduce-trunk #926 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/926/])
HADOOP-7913 Fix bug in ProtoBufRpcEngine (sanjay)
sradia : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1213619
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
> Fix bug in ProtoBufRpcEngine -
> -------------------------------
>
> Key: HADOOP-7913
> URL: https://issues.apache.org/jira/browse/HADOOP-7913
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: ipc
> Reporter: Sanjay Radia
> Assignee: Sanjay Radia
> Fix For: 0.24.0
>
> Attachments: hadoop-7913.patch, hadoop-7913.patch
>
>
> The parent Jira moved the multiple protocol support to lower layer; it introduced a bug: the paramCLass parameter to
> #server() constructor should be null so that it uses the registered rpc request deserializers.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7913) Fix bug in ProtoBufRpcEngine -
Posted by "Sanjay Radia (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sanjay Radia updated HADOOP-7913:
---------------------------------
Resolution: Fixed
Fix Version/s: 0.24.0
Status: Resolved (was: Patch Available)
> Fix bug in ProtoBufRpcEngine -
> -------------------------------
>
> Key: HADOOP-7913
> URL: https://issues.apache.org/jira/browse/HADOOP-7913
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: ipc
> Reporter: Sanjay Radia
> Assignee: Sanjay Radia
> Fix For: 0.24.0
>
> Attachments: hadoop-7913.patch, hadoop-7913.patch
>
>
> The parent Jira moved the multiple protocol support to lower layer; it introduced a bug: the paramCLass parameter to
> #server() constructor should be null so that it uses the registered rpc request deserializers.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7913) Fix bug in ProtoBufRpcEngine -
Posted by "Sanjay Radia (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sanjay Radia updated HADOOP-7913:
---------------------------------
Attachment: hadoop-7913.patch
> Fix bug in ProtoBufRpcEngine -
> -------------------------------
>
> Key: HADOOP-7913
> URL: https://issues.apache.org/jira/browse/HADOOP-7913
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: ipc
> Reporter: Sanjay Radia
> Assignee: Sanjay Radia
> Attachments: hadoop-7913.patch, hadoop-7913.patch
>
>
> The parent Jira moved the multiple protocol support to lower layer; it introduced a bug: the paramCLass parameter to
> #server() constructor should be null so that it uses the registered rpc request deserializers.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7913) Fix bug in ProtoBufRpcEngine -
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13168254#comment-13168254 ]
Hudson commented on HADOOP-7913:
--------------------------------
Integrated in Hadoop-Common-trunk-Commit #1410 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1410/])
HADOOP-7913 Fix bug in ProtoBufRpcEngine (sanjay)
sradia : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1213619
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
> Fix bug in ProtoBufRpcEngine -
> -------------------------------
>
> Key: HADOOP-7913
> URL: https://issues.apache.org/jira/browse/HADOOP-7913
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: ipc
> Reporter: Sanjay Radia
> Assignee: Sanjay Radia
> Attachments: hadoop-7913.patch, hadoop-7913.patch
>
>
> The parent Jira moved the multiple protocol support to lower layer; it introduced a bug: the paramCLass parameter to
> #server() constructor should be null so that it uses the registered rpc request deserializers.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7913) Fix bug in ProtoBufRpcEngine -
Posted by "Tsz Wo (Nicholas), SZE (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-7913:
-------------------------------------------
Fix Version/s: 0.23.3
I have merged this to 0.23.
> Fix bug in ProtoBufRpcEngine -
> -------------------------------
>
> Key: HADOOP-7913
> URL: https://issues.apache.org/jira/browse/HADOOP-7913
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: ipc
> Reporter: Sanjay Radia
> Assignee: Sanjay Radia
> Fix For: 0.24.0, 0.23.3
>
> Attachments: hadoop-7913.patch, hadoop-7913.patch
>
>
> The parent Jira moved the multiple protocol support to lower layer; it introduced a bug: the paramCLass parameter to
> #server() constructor should be null so that it uses the registered rpc request deserializers.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7913) Fix bug in ProtoBufRpcEngine -
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13168269#comment-13168269 ]
Hudson commented on HADOOP-7913:
--------------------------------
Integrated in Hadoop-Mapreduce-trunk-Commit #1434 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1434/])
HADOOP-7913 Fix bug in ProtoBufRpcEngine (sanjay)
sradia : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1213619
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
> Fix bug in ProtoBufRpcEngine -
> -------------------------------
>
> Key: HADOOP-7913
> URL: https://issues.apache.org/jira/browse/HADOOP-7913
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: ipc
> Reporter: Sanjay Radia
> Assignee: Sanjay Radia
> Fix For: 0.24.0
>
> Attachments: hadoop-7913.patch, hadoop-7913.patch
>
>
> The parent Jira moved the multiple protocol support to lower layer; it introduced a bug: the paramCLass parameter to
> #server() constructor should be null so that it uses the registered rpc request deserializers.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7913) Fix bug in ProtoBufRpcEngine -
Posted by "Tsz Wo (Nicholas), SZE (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-7913:
-------------------------------------------
Component/s: ipc
Hadoop Flags: Reviewed
+1 patch looks good.
Minor: need a space before "for".
{code}
+ this.protocolName + "for rpcKind " + header.getkind(), t);
{code}
> Fix bug in ProtoBufRpcEngine -
> -------------------------------
>
> Key: HADOOP-7913
> URL: https://issues.apache.org/jira/browse/HADOOP-7913
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: ipc
> Reporter: Sanjay Radia
> Assignee: Sanjay Radia
> Attachments: hadoop-7913.patch
>
>
> The parent Jira moved the multiple protocol support to lower layer; it introduced a bug: the paramCLass parameter to
> #server() constructor should be null so that it uses the registered rpc request deserializers.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7913) Fix bug in ProtoBufRpcEngine -
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13168198#comment-13168198 ]
Hadoop QA commented on HADOOP-7913:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12507142/hadoop-7913.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
-1 javadoc. The javadoc tool appears to have generated 5 warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in .
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/468//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/468//console
This message is automatically generated.
> Fix bug in ProtoBufRpcEngine -
> -------------------------------
>
> Key: HADOOP-7913
> URL: https://issues.apache.org/jira/browse/HADOOP-7913
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: ipc
> Reporter: Sanjay Radia
> Assignee: Sanjay Radia
> Attachments: hadoop-7913.patch
>
>
> The parent Jira moved the multiple protocol support to lower layer; it introduced a bug: the paramCLass parameter to
> #server() constructor should be null so that it uses the registered rpc request deserializers.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7913) Fix bug in ProtoBufRpcEngine -
Posted by "Sanjay Radia (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sanjay Radia updated HADOOP-7913:
---------------------------------
Status: Patch Available (was: Open)
> Fix bug in ProtoBufRpcEngine -
> -------------------------------
>
> Key: HADOOP-7913
> URL: https://issues.apache.org/jira/browse/HADOOP-7913
> Project: Hadoop Common
> Issue Type: Sub-task
> Reporter: Sanjay Radia
> Assignee: Sanjay Radia
> Attachments: hadoop-7913.patch
>
>
> The parent Jira moved the multiple protocol support to lower layer; it introduced a bug: the paramCLass parameter to
> #server() constructor should be null so that it uses the registered rpc request deserializers.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira