You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@rocketmq.apache.org by "biulebiu (via GitHub)" <gi...@apache.org> on 2026/07/23 10:53:11 UTC

[PR] [ISSUE #239] Deduplicate messages by msgId in queryMessageByTopic [rocketmq-dashboard]

biulebiu opened a new pull request, #503:
URL: https://github.com/apache/rocketmq-dashboard/pull/503

     ## What is the purpose of the change
     Fixes #239. On the Message page, querying a topic by time can display the same message twice. `queryMessageByTopic` accumulates pulled messages with `addAll` without deduplicating by msgId; when the same queue
     is enumerated under different broker names (stale route after a brokerName change, proxy re-registration, etc.), the same message is pulled twice.
   
     ## Brief changelog
     - `MessageServiceImpl#queryMessageByTopic`: deduplicate the result list by `msgId` (order-preserving `LinkedHashMap`) before returning.
     - Add unit test `MessageServiceImplTest#testQueryMessageByTopicDeduplicatesByMsgId`.
   
     ## Verifying this change
     `mvn test -Dtest='MessageServiceImplTest#testQueryMessageByTopicDeduplicatesByMsgId'`
     - Before fix: fails with `expected:<1> but was:<2>`
     - After fix: `Tests run: 1, Failures: 0`
     Existing `testQueryMessageByTopic` / `testQueryMessageByTopicWithOutOfRangeTimestamps` still pass.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [ISSUE #239] Deduplicate messages by msgId in queryMessageByTopic [rocketmq-dashboard]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.

github-actions[bot] closed pull request #503: [ISSUE #239] Deduplicate messages by msgId in queryMessageByTopic
URL: https://github.com/apache/rocketmq-dashboard/pull/503


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [ISSUE #239] Deduplicate messages by msgId in queryMessageByTopic [rocketmq-dashboard]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.

github-actions[bot] commented on PR #503:
URL: https://github.com/apache/rocketmq-dashboard/pull/503#issuecomment-5137711369

   This pull request has been automatically closed because there has been no activity for 7 days. If you would like to continue working on this, please reopen the PR with updated changes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org