[GitHub] [nifi] pvillard31 commented on a change in pull request #4410: NIFI-7642: KafkaConsumers - improve batching into FlowFiles under high latency conditions

[GitBox <gi...@apache.org>]

pvillard31 commented on a change in pull request #4410:
URL: https://github.com/apache/nifi/pull/4410#discussion_r456316349



##########
File path: nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-1-0-processors/src/main/java/org/apache/nifi/processors/kafka/pubsub/ConsumerLease.java
##########
@@ -174,7 +177,7 @@ void poll() {
          * This behavior has been fixed via Kafka KIP-62 and available from Kafka client 0.10.1.0.
          */
         try {
-            final ConsumerRecords<byte[], byte[]> records = kafkaConsumer.poll(10);
+            final ConsumerRecords<byte[], byte[]> records = kafkaConsumer.poll(maxWaitMillis / 10);

Review comment:
       Why are we doing ``maxWaitMillis / 10`` instead of just ``maxWaitMillis``?
   (sorry for the possibly dumb question here)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org