You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2018/08/02 12:51:51 UTC
[GitHub] StefanRRichter commented on a change in pull request #6467:
[FLINK-9887] Ensure serializer upgrades work with timer service remake
StefanRRichter commented on a change in pull request #6467: [FLINK-9887] Ensure serializer upgrades work with timer service remake
URL: https://github.com/apache/flink/pull/6467#discussion_r207213479
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/TimerSerializer.java
##########
@@ -230,16 +264,29 @@ public TypeSerializerConfigSnapshot snapshotConfiguration() {
*/
public static class TimerSerializerConfigSnapshot<K, N> extends CompositeTypeSerializerConfigSnapshot {
+ private static final int VERSION = 0;
+
public TimerSerializerConfigSnapshot() {
}
- public TimerSerializerConfigSnapshot(TypeSerializer<K> keySerializer, TypeSerializer<N> namespaceSerializer) {
- super(keySerializer, namespaceSerializer);
+ public TimerSerializerConfigSnapshot(
+ @Nonnull TypeSerializer<K> keySerializer,
+ @Nonnull TypeSerializer<N> namespaceSerializer) {
+ super(init(keySerializer, namespaceSerializer));
Review comment:
Yes, it is a bit more solid like this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services