You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/07/12 06:34:21 UTC

[GitHub] [iceberg] Fokko commented on a diff in pull request #5201: Python: Move Snapshot to Pydantic

Fokko commented on code in PR #5201:
URL: https://github.com/apache/iceberg/pull/5201#discussion_r918596475


##########
python/pyiceberg/utils/iceberg_base_model.py:
##########
@@ -38,6 +42,7 @@ class Config:
         keep_untouched = (cached_property,)
         allow_population_by_field_name = True
         frozen = True
+        json_encoders = {"Summary": test_encoder}

Review Comment:
   Ah, that was some spielerij.  Instead of using a custom encoder, I ended up making the root of the Summary a Dict, which solved it in a much nicer way.



##########
python/pyiceberg/utils/iceberg_base_model.py:
##########
@@ -38,6 +42,7 @@ class Config:
         keep_untouched = (cached_property,)
         allow_population_by_field_name = True
         frozen = True
+        json_encoders = {"Summary": test_encoder}

Review Comment:
   I've removed this



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org