You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2022/08/19 21:56:27 UTC
[GitHub] [bookkeeper] StevenLuMT opened a new pull request, #3451: bugfix for project's .asf.yaml
StevenLuMT opened a new pull request, #3451:
URL: https://github.com/apache/bookkeeper/pull/3451
Descriptions of the changes in this PR:
### Motivation
using [.asf.yaml](https://cwiki.apache.org/confluence/display/INFRA/Git+-+.asf.yaml+features#Git.asf.yamlfeatures-Branchprotection) to configure the project,
but there 's some config bugfix for project's .asf.yaml
### Changes
1. update the names of checks
2. change required_approving_review_count to 2 person
3. update README.md for workflows
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] zymap merged pull request #3451: bugfix for project's .asf.yaml
Posted by GitBox <gi...@apache.org>.
zymap merged PR #3451:
URL: https://github.com/apache/bookkeeper/pull/3451
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] eolivelli commented on a diff in pull request #3451: bugfix for project's .asf.yaml
Posted by GitBox <gi...@apache.org>.
eolivelli commented on code in PR #3451:
URL: https://github.com/apache/bookkeeper/pull/3451#discussion_r950660562
##########
.asf.yaml:
##########
@@ -63,7 +63,7 @@ github:
required_pull_request_reviews:
dismiss_stale_reviews: false
require_code_owner_reviews: true
- required_approving_review_count: 1
+ required_approving_review_count: 2
Review Comment:
This is wrong.
Otherwise committers won't be able to commit their own patches with only one approval from another committer.
The rule is that you need two +1 from people with committer karma.
So if a committer sends a patch,he needs only 1 binding +1
@StevenLuMT @zymap
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on a diff in pull request #3451: bugfix for project's .asf.yaml
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on code in PR #3451:
URL: https://github.com/apache/bookkeeper/pull/3451#discussion_r950699800
##########
.asf.yaml:
##########
@@ -63,7 +63,7 @@ github:
required_pull_request_reviews:
dismiss_stale_reviews: false
require_code_owner_reviews: true
- required_approving_review_count: 1
+ required_approving_review_count: 2
Review Comment:
@eolivelli @zymap More content can be discussed, I will initiate a discussion, let’s determine the final .asf.yaml
please see the mail [https://lists.apache.org/thread/o75xogn8r7zylqlwnno84dsm9nqoh5rs](https://lists.apache.org/thread/o75xogn8r7zylqlwnno84dsm9nqoh5rs)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on pull request #3451: bugfix for project's .asf.yaml
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on PR #3451:
URL: https://github.com/apache/bookkeeper/pull/3451#issuecomment-1221199257
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] tisonkun commented on a diff in pull request #3451: bugfix for project's .asf.yaml
Posted by GitBox <gi...@apache.org>.
tisonkun commented on code in PR #3451:
URL: https://github.com/apache/bookkeeper/pull/3451#discussion_r950661059
##########
.asf.yaml:
##########
@@ -63,7 +63,7 @@ github:
required_pull_request_reviews:
dismiss_stale_reviews: false
require_code_owner_reviews: true
- required_approving_review_count: 1
+ required_approving_review_count: 2
Review Comment:
Basically, I'd prefer not to set it as a strict rule since a committer should be confident to merge a typo fix. Committers share a high trust level. They know when to request one more reviewer.
##########
.asf.yaml:
##########
@@ -63,7 +63,7 @@ github:
required_pull_request_reviews:
dismiss_stale_reviews: false
require_code_owner_reviews: true
- required_approving_review_count: 1
+ required_approving_review_count: 2
Review Comment:
Basically, I'd prefer not to set it as a strict rule since a committer should be confident to merge a typo fix directly. Committers share a high trust level. They know when to request one more reviewer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org