You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2022/12/19 07:37:23 UTC
[GitHub] [kylin] liuzhao-lz opened a new pull request, #2049: KYLIN-5371 fix segment prune
liuzhao-lz opened a new pull request, #2049:
URL: https://github.com/apache/kylin/pull/2049
## Proposed changes
创建model是在partition部分指定了天分区和时分区，格式分别为：yyyy-MM-dd、HH，在根据天分区值查询时结果非预期。原因是这种场景下segment裁剪有bug。
--不加天分区过滤得到的结果
--加天分区在修复前查询结果
--加天分区在修复后查询结果
## Branch to commit
- [ ] Branch **kylin3** for v2.x to v3.x
- [x] Branch **kylin4** for v4.x
- [ ] Branch **kylin5** for v5.x
## Types of changes
What types of changes does your code introduce to Kylin?
_Put an `x` in the boxes that apply_
- [x] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Documentation Update (if none of the other choices apply)
## Checklist
_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
- [x] I have created an issue on [Kylin's jira](https://issues.apache.org/jira/browse/KYLIN), and have described the bug/feature there in detail
- [x] Commit messages in my PR start with the related jira ID, like "KYLIN-0000 Make Kylin project open-source"
- [ ] Compiling and unit tests pass locally with my changes
- [x] I have added tests that prove my fix is effective or that my feature works
- [ ] I have added necessary documentation (if appropriate)
- [ ] Any dependent changes have been merged
## Further comments
If this is a relatively large or complex change, kick off the discussion at user@kylin.apache.org or dev@kylin.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kylin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] Mukvin commented on pull request #2049: KYLIN-5371 fix segment prune
Posted by GitBox <gi...@apache.org>.
Mukvin commented on PR #2049:
URL: https://github.com/apache/kylin/pull/2049#issuecomment-1366411948
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kylin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] liuzhao-lz commented on a diff in pull request #2049: KYLIN-5371 fix segment prune
Posted by GitBox <gi...@apache.org>.
liuzhao-lz commented on code in PR #2049:
URL: https://github.com/apache/kylin/pull/2049#discussion_r1057488331
##########
core-common/src/main/java/org/apache/kylin/common/util/DateFormat.java:
##########
@@ -194,4 +202,18 @@ public static boolean isDatePattern(String ptn) {
return COMPACT_DATE_PATTERN.equals(ptn) || YYYYMMDDHH.equals(ptn) || YYYYMMDDHHMM.equals(ptn)
|| YYYYMMDDHHMMSS.equals(ptn);
}
+
+ public static Long getFormatTimeStamp(long time, String pattern) {
+ try {
+ if (StringUtils.isNotBlank(pattern)) {
+ SimpleDateFormat sdf = new SimpleDateFormat(pattern, Locale.getDefault(Locale.Category.FORMAT));
+ sdf.setTimeZone(TimeZone.getTimeZone("GMT"));
Review Comment:
##########
kylin-spark-project/kylin-spark-common/src/main/scala/org/apache/spark/sql/execution/datasource/FilePruner.scala:
##########
@@ -366,7 +366,9 @@ class FilePruner(cubeInstance: CubeInstance,
val pruned = segDirs.filter {
e => {
val tsRange = cubeInstance.getSegment(e.segmentName, SegmentStatusEnum.READY).getTSRange
- SegFilters(tsRange.startValue, tsRange.endValue, pattern)
+ // tsRange: 20221219000000_20221219010000、20221219010000_20221219020000, pattern: yyyy-MM-dd
+ val start = DateFormat.getFormatTimeStamp(tsRange.startValue, pattern)
+ SegFilters(start, tsRange.endValue, pattern)
Review Comment:
tsRange.endValue 不需要考虑，DateFormat.getFormatTimeStamp(tsRange.startValue, pattern) 这个的作用是将 startValue 格式化成天的时间戳值（忽略小时），原因是 SegFilters 的 foldFilter 中是按天格式化where 分区字段值的（记作ts），后续比较也是 “ts >= start && ts < end” end 如果是到时间其对应的时间戳一定是大于天的时间戳值因而可以不用处理。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kylin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] liuzhao-lz commented on pull request #2049: KYLIN-5371 fix segment prune
Posted by GitBox <gi...@apache.org>.
liuzhao-lz commented on PR #2049:
URL: https://github.com/apache/kylin/pull/2049#issuecomment-1365673651
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kylin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] Mukvin commented on a diff in pull request #2049: KYLIN-5371 fix segment prune
Posted by GitBox <gi...@apache.org>.
Mukvin commented on code in PR #2049:
URL: https://github.com/apache/kylin/pull/2049#discussion_r1057461579
##########
kylin-spark-project/kylin-spark-common/src/main/scala/org/apache/spark/sql/execution/datasource/FilePruner.scala:
##########
@@ -366,7 +366,9 @@ class FilePruner(cubeInstance: CubeInstance,
val pruned = segDirs.filter {
e => {
val tsRange = cubeInstance.getSegment(e.segmentName, SegmentStatusEnum.READY).getTSRange
- SegFilters(tsRange.startValue, tsRange.endValue, pattern)
+ // tsRange: 20221219000000_20221219010000、20221219010000_20221219020000, pattern: yyyy-MM-dd
+ val start = DateFormat.getFormatTimeStamp(tsRange.startValue, pattern)
+ SegFilters(start, tsRange.endValue, pattern)
Review Comment:
how about tsRange.endValue? is it same as `start`?
##########
core-common/src/main/java/org/apache/kylin/common/util/DateFormat.java:
##########
@@ -194,4 +202,18 @@ public static boolean isDatePattern(String ptn) {
return COMPACT_DATE_PATTERN.equals(ptn) || YYYYMMDDHH.equals(ptn) || YYYYMMDDHHMM.equals(ptn)
|| YYYYMMDDHHMMSS.equals(ptn);
}
+
+ public static Long getFormatTimeStamp(long time, String pattern) {
+ try {
+ if (StringUtils.isNotBlank(pattern)) {
+ SimpleDateFormat sdf = new SimpleDateFormat(pattern, Locale.getDefault(Locale.Category.FORMAT));
+ sdf.setTimeZone(TimeZone.getTimeZone("GMT"));
Review Comment:
This is hard code for timezone, please reference to org.apache.kylin.common.KylinConfigBase#getTimeZone
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kylin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] Mukvin commented on a diff in pull request #2049: KYLIN-5371 fix segment prune
Posted by GitBox <gi...@apache.org>.
Mukvin commented on code in PR #2049:
URL: https://github.com/apache/kylin/pull/2049#discussion_r1058096474
##########
kylin-spark-project/kylin-spark-common/src/main/scala/org/apache/spark/sql/execution/datasource/FilePruner.scala:
##########
@@ -366,7 +366,9 @@ class FilePruner(cubeInstance: CubeInstance,
val pruned = segDirs.filter {
e => {
val tsRange = cubeInstance.getSegment(e.segmentName, SegmentStatusEnum.READY).getTSRange
- SegFilters(tsRange.startValue, tsRange.endValue, pattern)
+ // tsRange: 20221219000000_20221219010000、20221219010000_20221219020000, pattern: yyyy-MM-dd
+ val start = DateFormat.getFormatTimeStamp(tsRange.startValue, pattern)
+ SegFilters(start, tsRange.endValue, pattern)
Review Comment:
As for clearance, please comment on the place of tsRange.endValue then help others to understand.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kylin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org