[jira] [Commented] (SLING-5726) Allow ValueMapInjector and ResourcePathInjector to act directly on SlingHttpServletRequest

["Konrad Windszus (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SLING-5726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16853008#comment-16853008 ] 

Konrad Windszus commented on SLING-5726:
----------------------------------------

This issue was also mentioned in the context of https://github.com/Adobe-Consulting-Services/acs-aem-commons/pull/1920, so it seems there is a real need for making the injectors as agnostic towards the adaptable as possible.
As each {{SlingHttpServletRequest}} implicitly carries a {{Resource}} I would still vote for enriching the 
* {{ValueMapInjector}}
* {{ChildResourceInjector}}
* {{ResourcePathInjector}}
for being able to directly act upon the adaptable {{SlingHttpServletRequest}} (in addition to {{Resource}}).
[~sseifert] WDYT?
I fail to see any issue with backwards-compatibility and the proposed via enhancement sounds way too complicated to me.

> Allow ValueMapInjector and ResourcePathInjector to act directly on SlingHttpServletRequest
> ------------------------------------------------------------------------------------------
>
>                 Key: SLING-5726
>                 URL: https://issues.apache.org/jira/browse/SLING-5726
>             Project: Sling
>          Issue Type: Bug
>          Components: Extensions
>    Affects Versions: Sling Models Impl 1.2.8
>            Reporter: Konrad Windszus
>            Assignee: Konrad Windszus
>            Priority: Major
>         Attachments: SLING-5726.patch
>
>
> Currently both injectors only work correctly on objects being adaptable to a {{ValueMap}}. For {{ValueMapInjector}} this is documented but for {{ResourcePathInjector}} it is not (http://sling.apache.org/documentation/bundles/models.html#available-injectors), although for the latter it does only matter if the path is given through a resource property and not in a static way.
> This should be relaxed that both also work with {{SlingHttpServletRequest}} as that always carries the current resource from which the {{ValueMap}} can be easily retrieved.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)