You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by jbertram <gi...@git.apache.org> on 2017/11/28 16:22:46 UTC

[GitHub] activemq-artemis issue #1677: Allow mqtt with dynamic cluster

Github user jbertram commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1677
  
    Your commits should be broken into logical units with clear descriptions of what you're fixing and why. Looking at the commits you should probably have 1 where you add the example and then another where you fix the problem.
    
    To be clear, I'm not indicating the fix is valid at this point as it's not clear to me what specifically you're fixing and why.  The commits need to be better organized before I can actually get to that point.


---