You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by mn-mikke <gi...@git.apache.org> on 2018/05/25 16:48:29 UTC

[GitHub] spark pull request #21434: [SPARK-24331][SparkR][SQL] Adding arrays_overlap,...

GitHub user mn-mikke opened a pull request:

    https://github.com/apache/spark/pull/21434

    [SPARK-24331][SparkR][SQL] Adding arrays_overlap, array_repeat, map_entries to SparkR

    ## What changes were proposed in this pull request?
    
    The PR adds functions `arrays_overlap`, `array_repeat`, `map_entries` to SparkR.
    
    ## How was this patch tested?
    
    Tests added into R/pkg/tests/fulltests/test_sparkSQL.R
    
    ## Examples
    ### arrays_overlap
    ```
    df <- createDataFrame(list(list(list(1L, 2L), list(3L, 1L)),
                               list(list(1L, 2L), list(3L, 4L)),
                               list(list(1L, NA), list(3L, 4L))))
    collect(select(df, arrays_overlap(df[[1]], df[[2]])))
    ```
    ```
      arrays_overlap(_1, _2)
    1                   TRUE
    2                  FALSE
    3                     NA
    ```
    ### array_repeat
    ```
    df <- createDataFrame(list(list("a", 3L), list("b", 2L)))
    collect(select(df, array_repeat(df[[1]], df[[2]])))
    ```
    ```
      array_repeat(_1, _2)
    1              a, a, a
    2                 b, b
    ```
    ### map_entries
    ```
    df <- createDataFrame(list(list(map = as.environment(list(x = 1, y = 2)))))
    collect(select(df, map_entries(df$map)))
    ```
    ```
      map_entries(map)
    1       x, 1, y, 2
    ```

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mn-mikke/spark SPARK-24331

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/21434.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #21434
    
----
commit 5d80ad669db4a89089378716fdf5d8258987bd97
Author: Marek Novotny <mn...@...>
Date:   2018-05-25T16:30:50Z

    [SPARK-24331][SparkR][SQL] Adding functions arrays_overlap, array_repeat, map_entries to SparkR

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #21434: [SPARK-24331][SparkR][SQL] Adding arrays_overlap, array_...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/21434
  
    **[Test build #91169 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91169/testReport)** for PR 21434 at commit [`5d80ad6`](https://github.com/apache/spark/commit/5d80ad669db4a89089378716fdf5d8258987bd97).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #21434: [SPARK-24331][SparkR][SQL] Adding arrays_overlap, array_...

Posted by mn-mikke <gi...@git.apache.org>.
Github user mn-mikke commented on the issue:

    https://github.com/apache/spark/pull/21434
  
    cc @HyukjinKwon @felixcheung 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #21434: [SPARK-24331][SparkR][SQL] Adding arrays_overlap, array_...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/21434
  
    Test FAILed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91169/
    Test FAILed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request #21434: [SPARK-24331][SparkR][SQL] Adding arrays_overlap,...

Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21434#discussion_r191090863
  
    --- Diff: R/pkg/R/functions.R ---
    @@ -3048,6 +3048,26 @@ setMethod("array_position",
                 column(jc)
               })
     
    +#' @details
    +#' \code{array_repeat}: Creates an array containing the left argument repeated the number of times
    +#' given by the right argument.
    +#'
    +#' @param count Column or constant determining the number of repetitions.
    +#' @rdname column_collection_functions
    +#' @aliases array_repeat array_repeat,Column,numericOrColumn-method
    +#' @note array_repeat since 2.4.0
    +setMethod("array_repeat",
    +          signature(x = "Column", count = "numericOrColumn"),
    +          function(x, count) {
    +            if (class(count) == "Column") {
    +                count <- count@jc
    +            } else {
    +                count <- as.integer(count)
    --- End diff --
    
    indent is 2 space actually, could you update this and line L3063


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #21434: [SPARK-24331][SparkR][SQL] Adding arrays_overlap, array_...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/21434
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request #21434: [SPARK-24331][SparkR][SQL] Adding arrays_overlap,...

Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21434#discussion_r191090953
  
    --- Diff: R/pkg/R/functions.R ---
    @@ -3062,6 +3077,21 @@ setMethod("array_sort",
                 column(jc)
               })
     
    +#' @details
    +#' \code{arrays_overlap}: Returns true if the input arrays have at least one non-null element in
    +#' common. If not and both arrays are non-empty and any of them contains a null, it returns null.
    +#' It returns false otherwise.
    +#'
    +#' @rdname column_collection_functions
    +#' @aliases arrays_overlap arrays_overlap,Column-method
    +#' @note arrays_overlap since 2.4.0
    +setMethod("arrays_overlap",
    +          signature(y = "Column", x = "Column"),
    --- End diff --
    
    right, I don't know why they were (y, x) either. for some (one?) it was to match existing parameter names (like `atan2`), and then it sticks.
    
    I think we should first - name the first column `x`, second - stay close to the parameter name in Scala for everything else.



---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request #21434: [SPARK-24331][SparkR][SQL] Adding arrays_overlap,...

Posted by mn-mikke <gi...@git.apache.org>.
Github user mn-mikke commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21434#discussion_r191071987
  
    --- Diff: R/pkg/R/functions.R ---
    @@ -3062,6 +3077,21 @@ setMethod("array_sort",
                 column(jc)
               })
     
    +#' @details
    +#' \code{arrays_overlap}: Returns true if the input arrays have at least one non-null element in
    +#' common. If not and both arrays are non-empty and any of them contains a null, it returns null.
    +#' It returns false otherwise.
    +#'
    +#' @rdname column_collection_functions
    +#' @aliases arrays_overlap arrays_overlap,Column-method
    +#' @note arrays_overlap since 2.4.0
    +setMethod("arrays_overlap",
    +          signature(y = "Column", x = "Column"),
    --- End diff --
    
    Just noticed that "y" is specified as first for other binary methods (e.g. `datediff`, `nanvl`, `shiftLeft`, ...). No serious reason, I can change it. 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request #21434: [SPARK-24331][SparkR][SQL] Adding arrays_overlap,...

Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21434#discussion_r191090696
  
    --- Diff: R/pkg/R/functions.R ---
    @@ -3048,6 +3048,26 @@ setMethod("array_position",
                 column(jc)
               })
     
    +#' @details
    +#' \code{array_repeat}: Creates an array containing the left argument repeated the number of times
    +#' given by the right argument.
    +#'
    +#' @param count Column or constant determining the number of repetitions.
    --- End diff --
    
    change to `@param count a Column or constant determining the number of repetitions.`


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request #21434: [SPARK-24331][SparkR][SQL] Adding arrays_overlap,...

Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21434#discussion_r191090725
  
    --- Diff: R/pkg/R/functions.R ---
    @@ -3048,6 +3048,26 @@ setMethod("array_position",
                 column(jc)
               })
     
    +#' @details
    +#' \code{array_repeat}: Creates an array containing the left argument repeated the number of times
    +#' given by the right argument.
    --- End diff --
    
    let's change this to
    ```
    #' \code{array_repeat}: Creates an array containing \code{x} repeated the number of times
    #' given by \code{count}.
    ```


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #21434: [SPARK-24331][SparkR][SQL] Adding arrays_overlap, array_...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/21434
  
    **[Test build #91222 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91222/testReport)** for PR 21434 at commit [`31a8204`](https://github.com/apache/spark/commit/31a820463c3920ea99f82ee66ca5a68ec5c700e0).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #21434: [SPARK-24331][SparkR][SQL] Adding arrays_overlap, array_...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/21434
  
    **[Test build #91200 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91200/testReport)** for PR 21434 at commit [`6526faa`](https://github.com/apache/spark/commit/6526faa260a54333e0ab87ef9a10c910859b7fc9).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #21434: [SPARK-24331][SparkR][SQL] Adding arrays_overlap, array_...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/21434
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91183/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #21434: [SPARK-24331][SparkR][SQL] Adding arrays_overlap, array_...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/21434
  
    Merged build finished. Test FAILed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request #21434: [SPARK-24331][SparkR][SQL] Adding arrays_overlap,...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/spark/pull/21434


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #21434: [SPARK-24331][SparkR][SQL] Adding arrays_overlap, array_...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/21434
  
    **[Test build #91162 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91162/testReport)** for PR 21434 at commit [`5d80ad6`](https://github.com/apache/spark/commit/5d80ad669db4a89089378716fdf5d8258987bd97).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #21434: [SPARK-24331][SparkR][SQL] Adding arrays_overlap, array_...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/21434
  
    **[Test build #91222 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91222/testReport)** for PR 21434 at commit [`31a8204`](https://github.com/apache/spark/commit/31a820463c3920ea99f82ee66ca5a68ec5c700e0).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #21434: [SPARK-24331][SparkR][SQL] Adding arrays_overlap, array_...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/21434
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request #21434: [SPARK-24331][SparkR][SQL] Adding arrays_overlap,...

Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21434#discussion_r191056304
  
    --- Diff: R/pkg/R/functions.R ---
    @@ -3062,6 +3077,21 @@ setMethod("array_sort",
                 column(jc)
               })
     
    +#' @details
    +#' \code{arrays_overlap}: Returns true if the input arrays have at least one non-null element in
    +#' common. If not and both arrays are non-empty and any of them contains a null, it returns null.
    +#' It returns false otherwise.
    +#'
    +#' @rdname column_collection_functions
    +#' @aliases arrays_overlap arrays_overlap,Column-method
    +#' @note arrays_overlap since 2.4.0
    +setMethod("arrays_overlap",
    +          signature(y = "Column", x = "Column"),
    --- End diff --
    
    is there a reason this is "y" and then "x" and not "x" and then "y"?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #21434: [SPARK-24331][SparkR][SQL] Adding arrays_overlap, array_...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/21434
  
    **[Test build #91200 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91200/testReport)** for PR 21434 at commit [`6526faa`](https://github.com/apache/spark/commit/6526faa260a54333e0ab87ef9a10c910859b7fc9).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #21434: [SPARK-24331][SparkR][SQL] Adding arrays_overlap, array_...

Posted by mn-mikke <gi...@git.apache.org>.
Github user mn-mikke commented on the issue:

    https://github.com/apache/spark/pull/21434
  
    retest this please


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #21434: [SPARK-24331][SparkR][SQL] Adding arrays_overlap, array_...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/21434
  
    Can one of the admins verify this patch?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request #21434: [SPARK-24331][SparkR][SQL] Adding arrays_overlap,...

Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21434#discussion_r191090619
  
    --- Diff: R/pkg/R/functions.R ---
    @@ -207,7 +208,7 @@ NULL
     #' tmp <- mutate(df, v1 = create_array(df$mpg, df$cyl, df$hp))
     #' head(select(tmp, array_contains(tmp$v1, 21), size(tmp$v1)))
     #' head(select(tmp, array_max(tmp$v1), array_min(tmp$v1)))
    -#' head(select(tmp, array_position(tmp$v1, 21), array_sort(tmp$v1)))
    +#' head(select(tmp, array_position(tmp$v1, 21), array_repeat(21, 5L), array_sort(tmp$v1)))
    --- End diff --
    
    this example is a bit unusual? do you intend for the first param to be `21` the constant? (also, does that work?)


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #21434: [SPARK-24331][SparkR][SQL] Adding arrays_overlap, array_...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/21434
  
    Test FAILed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91162/
    Test FAILed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #21434: [SPARK-24331][SparkR][SQL] Adding arrays_overlap, array_...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/21434
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request #21434: [SPARK-24331][SparkR][SQL] Adding arrays_overlap,...

Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21434#discussion_r191056286
  
    --- Diff: R/pkg/R/functions.R ---
    @@ -3048,6 +3048,21 @@ setMethod("array_position",
                 column(jc)
               })
     
    +#' @details
    +#' \code{array_repeat}: Creates an array containing the left argument repeated the number of times
    +#' given by the right argument.
    +#'
    +#' @param n Column determining the number of repetitions.
    +#' @rdname column_collection_functions
    +#' @aliases array_repeat array_repeat,Column-method
    +#' @note array_repeat since 2.4.0
    +setMethod("array_repeat",
    +          signature(x = "Column", n = "Column"),
    --- End diff --
    
    Scala has this as "col" and "count" so how about either "x" and "count" or "x" and "value" (value already is in used in column_collection_functions)


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #21434: [SPARK-24331][SparkR][SQL] Adding arrays_overlap, array_...

Posted by mn-mikke <gi...@git.apache.org>.
Github user mn-mikke commented on the issue:

    https://github.com/apache/spark/pull/21434
  
    Thanks!


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #21434: [SPARK-24331][SparkR][SQL] Adding arrays_overlap, array_...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/21434
  
    Merged build finished. Test FAILed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #21434: [SPARK-24331][SparkR][SQL] Adding arrays_overlap, array_...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/21434
  
    **[Test build #91162 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91162/testReport)** for PR 21434 at commit [`5d80ad6`](https://github.com/apache/spark/commit/5d80ad669db4a89089378716fdf5d8258987bd97).
     * This patch **fails SparkR unit tests**.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #21434: [SPARK-24331][SparkR][SQL] Adding arrays_overlap, array_...

Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:

    https://github.com/apache/spark/pull/21434
  
    merged to master, thanks!


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request #21434: [SPARK-24331][SparkR][SQL] Adding arrays_overlap,...

Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21434#discussion_r191090821
  
    --- Diff: R/pkg/R/functions.R ---
    @@ -207,7 +208,7 @@ NULL
     #' tmp <- mutate(df, v1 = create_array(df$mpg, df$cyl, df$hp))
     #' head(select(tmp, array_contains(tmp$v1, 21), size(tmp$v1)))
     #' head(select(tmp, array_max(tmp$v1), array_min(tmp$v1)))
    -#' head(select(tmp, array_position(tmp$v1, 21), array_sort(tmp$v1)))
    +#' head(select(tmp, array_position(tmp$v1, 21), array_repeat(21, 5L), array_sort(tmp$v1)))
    --- End diff --
    
    also for `5L`, `5` should be ok and more clear as well


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #21434: [SPARK-24331][SparkR][SQL] Adding arrays_overlap, array_...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/21434
  
    **[Test build #91183 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91183/testReport)** for PR 21434 at commit [`ffb34ee`](https://github.com/apache/spark/commit/ffb34ee89f5544c4354f083c4364feeb5b59c586).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #21434: [SPARK-24331][SparkR][SQL] Adding arrays_overlap, array_...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/21434
  
    **[Test build #91169 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91169/testReport)** for PR 21434 at commit [`5d80ad6`](https://github.com/apache/spark/commit/5d80ad669db4a89089378716fdf5d8258987bd97).
     * This patch **fails SparkR unit tests**.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #21434: [SPARK-24331][SparkR][SQL] Adding arrays_overlap, array_...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/21434
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91200/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #21434: [SPARK-24331][SparkR][SQL] Adding arrays_overlap, array_...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/21434
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91222/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #21434: [SPARK-24331][SparkR][SQL] Adding arrays_overlap, array_...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/21434
  
    **[Test build #91183 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91183/testReport)** for PR 21434 at commit [`ffb34ee`](https://github.com/apache/spark/commit/ffb34ee89f5544c4354f083c4364feeb5b59c586).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org