[GitHub] [buildstream] gtristan commented on issue #1119: BuildStream fails to detect missing source alias if already cached

[GitBox <gi...@apache.org>]

gtristan commented on issue #1119:
URL: https://github.com/apache/buildstream/issues/1119#issuecomment-894613336


   @palvarez89 @cs-shadow 
   
   > So, I think the problem comes from the fact that BuildStream is (at least currently) unable to distinguish between an untargetted alias and a legitimate URL.
   
   This isn't actually the case here, we're already employing an ugly workaround which implicitly denies the user the ability to use typical URI schemas as alias names. utils.py in master has:
   
   ```python
   _URI_SCHEMES = ["http", "https", "ftp", "file", "git", "sftp", "ssh"]
   ```
   So according to BuildStream, those are the only URI schemas which have ever, or will ever exist... probably we need to change the substitution in master to be more like variable substitution (but we don't wan to use variable substitution for this because it is useful for the core to treat aliases specially).
   
   That said, the horrible URI scheme handling can be considered orthogonal to this issue, BuildStream is quite capable of raising an error at load time, when an alias is not available in the project (more than this, I think a fatal-able warning should be raised when the source YAML fails to specify any alias at all).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org