[GitHub] [tvm] areusch commented on a diff in pull request #12168: [hexagon][testing] sequential input tensors

[GitBox <gi...@apache.org>]

areusch commented on code in PR #12168:
URL: https://github.com/apache/tvm/pull/12168#discussion_r929146793


##########
tests/python/contrib/test_hexagon/pytest_util.py:
##########
@@ -109,25 +113,32 @@ def get_multitest_ids(
     ]
 
 
-def get_numpy_dtype_info(np_dtype_name: str) -> Union[np.finfo, np.iinfo]:
+def get_numpy_dtype_info(dtype: Union[str, np.dtype]) -> Union[np.finfo, np.iinfo]:
     """
     Return an appropriate 'np.iinfo' or 'np.finfo' object corresponding to
-    the specified dtype.
+    the specified Numpy dtype.
     """
-    np_dtype = np.dtype(np_dtype_name)
+
+    if type(dtype) == str:

Review Comment:
   isinstance(dtype, str)



##########
tests/python/contrib/test_hexagon/pytest_util.py:
##########
@@ -109,25 +113,32 @@ def get_multitest_ids(
     ]
 
 
-def get_numpy_dtype_info(np_dtype_name: str) -> Union[np.finfo, np.iinfo]:
+def get_numpy_dtype_info(dtype: Union[str, np.dtype]) -> Union[np.finfo, np.iinfo]:
     """
     Return an appropriate 'np.iinfo' or 'np.finfo' object corresponding to
-    the specified dtype.
+    the specified Numpy dtype.
     """
-    np_dtype = np.dtype(np_dtype_name)
+
+    if type(dtype) == str:
+        np_dtype = np.dtype(np_dtype_name)
+    else:
+        assert isinstance(dtype, np.dtype)

Review Comment:
   can you add an explainer when this assert fails:
   ```suggestion
           assert isinstance(dtype, np.dtype), f"dtype: want str or np.dtype, got {dtype!r}"
   ```



##########
tests/python/contrib/test_hexagon/pytest_util.py:
##########
@@ -155,5 +166,15 @@ def create_populated_numpy_ndarray(
     elif type(itp) == TensorContentRandom:
         return np.random.random(input_shape).astype(dtype)
 
+    elif type(itp) == TensorContentSequentialCOrder:
+        a = np.empty(tuple(input_shape), dtype)
+
+        with np.nditer(a, op_flags=["writeonly"], order="C") as it:

Review Comment:
   wondering if this should get a unittest



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org