You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@activemq.apache.org by cl...@apache.org on 2016/06/13 18:21:22 UTC

[1/7] activemq-artemis git commit: Update maven-checkstyle-plugin to 2.17

Repository: activemq-artemis
Updated Branches:
  refs/heads/master a624a818c -> 369f2e006


Update maven-checkstyle-plugin to 2.17


Project: http://git-wip-us.apache.org/repos/asf/activemq-artemis/repo
Commit: http://git-wip-us.apache.org/repos/asf/activemq-artemis/commit/fb56cc74
Tree: http://git-wip-us.apache.org/repos/asf/activemq-artemis/tree/fb56cc74
Diff: http://git-wip-us.apache.org/repos/asf/activemq-artemis/diff/fb56cc74

Branch: refs/heads/master
Commit: fb56cc7414592777d4e0f3d2ff0b7a5e3a592213
Parents: a624a81
Author: Ville Skytt� <vi...@iki.fi>
Authored: Mon Jun 13 16:46:41 2016 +0300
Committer: Ville Skytt� <vi...@iki.fi>
Committed: Mon Jun 13 16:46:41 2016 +0300

----------------------------------------------------------------------
 pom.xml                            | 2 +-
 tests/activemq5-unit-tests/pom.xml | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/fb56cc74/pom.xml
----------------------------------------------------------------------
diff --git a/pom.xml b/pom.xml
index 7384d1f..40e7562 100644
--- a/pom.xml
+++ b/pom.xml
@@ -1060,7 +1060,7 @@
          <plugin>
             <groupId>org.apache.maven.plugins</groupId>
             <artifactId>maven-checkstyle-plugin</artifactId>
-            <version>2.16</version>
+            <version>2.17</version>
             <dependencies>
                <!-- This was initially done to enforce name on Parameter annotation
                     I've developed a customized check and I needed this jar to deploy the specialized checkstyle -->

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/fb56cc74/tests/activemq5-unit-tests/pom.xml
----------------------------------------------------------------------
diff --git a/tests/activemq5-unit-tests/pom.xml b/tests/activemq5-unit-tests/pom.xml
index de64fc2..9885601 100644
--- a/tests/activemq5-unit-tests/pom.xml
+++ b/tests/activemq5-unit-tests/pom.xml
@@ -403,7 +403,7 @@
          <plugin>
             <groupId>org.apache.maven.plugins</groupId>
             <artifactId>maven-checkstyle-plugin</artifactId>
-            <version>2.16</version>
+            <version>2.17</version>
             <configuration>
                <skip>true</skip>
             </configuration>


[6/7] activemq-artemis git commit: Fix checkstyle redundant modifier violations

Posted by cl...@apache.org.
Fix checkstyle redundant modifier violations


Project: http://git-wip-us.apache.org/repos/asf/activemq-artemis/repo
Commit: http://git-wip-us.apache.org/repos/asf/activemq-artemis/commit/3923ae45
Tree: http://git-wip-us.apache.org/repos/asf/activemq-artemis/tree/3923ae45
Diff: http://git-wip-us.apache.org/repos/asf/activemq-artemis/diff/3923ae45

Branch: refs/heads/master
Commit: 3923ae45f42c34778b12863be7cafe360e379276
Parents: d0d023b
Author: Ville Skytt� <vi...@iki.fi>
Authored: Mon Jun 13 18:49:01 2016 +0300
Committer: Ville Skytt� <vi...@iki.fi>
Committed: Mon Jun 13 20:03:54 2016 +0300

----------------------------------------------------------------------
 .../artemis/cli/commands/tools/PrintData.java   |  2 +-
 .../cli/commands/tools/XmlDataExporter.java     |  2 +-
 .../activemq/artemis/utils/ReusableLatch.java   |  2 +-
 .../activemq/artemis/utils/TypedProperties.java | 42 ++++++++++----------
 .../api/core/UDPBroadcastEndpointFactory.java   |  2 +-
 .../core/management/CoreNotificationType.java   |  2 +-
 .../core/client/impl/ClientMessageImpl.java     |  2 +-
 .../CompressedLargeMessageControllerImpl.java   |  2 +-
 .../client/impl/LargeMessageControllerImpl.java |  6 +--
 .../core/client/impl/ServerLocatorImpl.java     |  2 +-
 .../artemis/core/message/impl/MessageImpl.java  |  2 +-
 .../remoting/impl/netty/NettyConnector.java     |  4 +-
 .../artemis/utils/OrderedExecutorFactory.java   |  2 +-
 .../artemis/utils/SoftValueHashMap.java         |  2 +-
 .../apache/activemq/artemis/dto/XmlUtil.java    |  2 +-
 .../jdbc/store/journal/TransactionHolder.java   |  2 +-
 .../file/JDBCSequentialFileFactoryTest.java     |  2 +-
 .../artemis/jms/client/ActiveMQJMSConsumer.java |  2 +-
 .../artemis/jms/client/ActiveMQJMSProducer.java |  2 +-
 .../jms/client/ActiveMQMessageProducer.java     |  6 +--
 .../artemis/jms/bridge/impl/JMSBridgeImpl.java  |  4 +-
 .../server/management/JMSNotificationType.java  |  2 +-
 .../core/io/aio/AIOSequentialFileFactory.java   |  2 +-
 .../artemis/core/journal/impl/JournalBase.java  |  2 +-
 .../core/journal/impl/JournalCompactor.java     |  8 ++--
 .../artemis/core/journal/impl/JournalImpl.java  |  2 +-
 .../artemis/jlibaio/test/LibaioTest.java        |  2 +-
 .../core/protocol/mqtt/MQTTProtocolManager.java |  2 +-
 .../org/proton/plug/util/CreditsSemaphore.java  |  2 +-
 .../org/proton/plug/util/ReusableLatch.java     |  2 +-
 .../context/AbstractConnectionContextTest.java  |  2 +-
 .../plug/test/minimalserver/MinimalServer.java  |  2 +-
 .../protocol/stomp/ActiveMQStompException.java  |  2 +-
 .../protocol/stomp/StompProtocolManager.java    |  8 ++--
 .../core/protocol/stomp/StompVersions.java      |  2 +-
 .../stomp/v11/StompFrameHandlerV11.java         |  2 +-
 .../artemis/rest/test/AutoAckTopicTest.java     |  4 +-
 .../selector/filter/ComparisonExpression.java   |  2 +-
 .../selector/filter/ConstantExpression.java     |  2 +-
 .../selector/filter/UnaryExpression.java        |  2 +-
 .../artemis/osgi/ProtocolTrackerTest.java       |  2 +-
 .../core/config/HAPolicyConfiguration.java      |  2 +-
 .../artemis/core/config/StoreConfiguration.java |  2 +-
 .../artemis/core/filter/impl/FilterImpl.java    |  2 +-
 .../core/paging/cursor/impl/PageCacheImpl.java  |  2 +-
 .../impl/PageSubscriptionCounterImpl.java       |  2 +-
 .../cursor/impl/PageSubscriptionImpl.java       |  4 +-
 .../paging/impl/PageTransactionInfoImpl.java    |  4 +-
 .../core/paging/impl/PagingStoreImpl.java       |  6 +--
 .../core/persistence/StorageManager.java        |  2 +-
 .../nullpm/NullStorageLargeServerMessage.java   |  4 +-
 .../artemis/core/protocol/ProtocolHandler.java  |  2 +-
 .../protocol/core/impl/CoreProtocolManager.java | 10 ++---
 .../BackupReplicationStartFailedMessage.java    |  2 +-
 .../ReplicationLiveIsStoppingMessage.java       |  2 +-
 .../wireformat/ReplicationStartSyncMessage.java |  2 +-
 .../wireformat/ReplicationSyncFileMessage.java  |  2 +-
 .../impl/netty/HttpAcceptorHandler.java         |  6 +--
 .../core/server/cluster/BackupManager.java      | 28 ++++++-------
 .../core/server/cluster/ClusterController.java  | 10 ++---
 .../core/server/cluster/impl/BridgeImpl.java    |  4 +-
 .../cluster/impl/ClusterConnectionImpl.java     | 16 ++++----
 .../server/cluster/qourum/QuorumManager.java    |  4 +-
 .../server/impl/BackupTopologyListener.java     |  2 +-
 .../core/server/impl/ColocatedActivation.java   |  6 +--
 .../artemis/core/server/impl/QueueImpl.java     |  6 +--
 .../core/server/impl/ReplicationError.java      |  2 +-
 .../impl/ScheduledDeliveryHandlerImpl.java      |  2 +-
 .../core/server/impl/ServerConsumerImpl.java    |  2 +-
 .../impl/SharedNothingLiveActivation.java       |  2 +-
 .../artemis/core/transaction/Transaction.java   |  2 +-
 .../transaction/impl/ResourceManagerImpl.java   |  2 +-
 .../jaas/PropertiesLoginModuleTest.java         |  2 +-
 .../cluster/impl/BroadcastGroupImplTest.java    |  2 +-
 .../impl/ScheduledDeliveryHandlerTest.java      |  2 +-
 .../artemis/core/settings/RepositoryTest.java   |  2 +-
 .../artemis/tests/util/ActiveMQTestBase.java    |  2 +-
 .../cli/test/WebServerComponentTest.java        |  2 +-
 .../activemq/artemis/jms/example/PerfBase.java  |  2 +-
 .../jms/example/MessageGroupExample.java        |  2 +-
 .../jms/example/MessageGroup2Example.java       |  2 +-
 .../jms/example/MessagePriorityExample.java     |  2 +-
 .../jms/example/QueueSelectorExample.java       |  2 +-
 .../jms/example/StaticSelectorExample.java      |  2 +-
 .../jms/example/TopicSelectorExample2.java      |  2 +-
 .../artemis/jms/example/XASendExample.java      |  2 +-
 .../aerogear/AeroGearConnectorService.java      |  2 +-
 .../HierarchicalObjectRepositoryTest.java       |  2 +-
 .../aerogear/AeroGearBasicServerTest.java       |  2 +-
 .../integration/client/AutogroupIdTest.java     |  2 +-
 .../integration/client/CommitRollbackTest.java  |  2 +-
 .../client/DeadLetterAddressTest.java           |  2 +-
 .../integration/client/DeliveryOrderTest.java   |  2 +-
 .../integration/client/HangConsumerTest.java    | 42 ++++++++++----------
 .../client/InterruptedLargeMessageTest.java     | 38 +++++++++---------
 .../client/MessageConsumerRollbackTest.java     |  2 +-
 .../MessageGroupingConnectionFactoryTest.java   |  2 +-
 .../integration/client/MessageGroupingTest.java |  2 +-
 .../integration/client/MessageHandlerTest.java  |  6 +--
 .../client/MultipleThreadFilterOneTest.java     |  4 +-
 .../tests/integration/client/PagingTest.java    | 10 ++---
 .../client/ServerLocatorConnectTest.java        |  2 +-
 .../client/SessionStopStartTest.java            |  8 ++--
 .../integration/client/TemporaryQueueTest.java  |  2 +-
 .../integration/cluster/NodeManagerTest.java    |  2 +-
 .../distribution/ClusteredGroupingTest.java     | 12 +++---
 .../cluster/failover/FailBackManualTest.java    |  2 +-
 .../cluster/failover/QuorumFailOverTest.java    |  2 +-
 .../MultiThreadReattachSupportTestBase.java     |  2 +-
 .../cluster/reattach/RandomReattachTest.java    |  2 +-
 .../jms/client/NewQueueRequestorTest.java       |  2 +-
 .../jms/connection/ExceptionListenerTest.java   |  2 +-
 .../jms/jms2client/JmsContextTest.java          |  6 +--
 .../server/management/JMSServerControlTest.java |  2 +-
 .../journal/ValidateTransactionHealthTest.java  | 10 ++---
 .../ManagementWithPagingServerTest.java         |  6 +--
 .../openwire/amq/JMSConsumer2Test.java          |  2 +-
 .../amq/MessageListenerRedeliveryTest.java      |  2 +-
 .../PagingWithFailoverAndCountersTest.java      |  6 +--
 .../ra/ActiveMQMessageHandlerTest.java          |  4 +-
 .../ra/ActiveMQMessageHandlerXATest.java        |  4 +-
 .../integration/server/ExpiryRunnerTest.java    |  2 +-
 .../stomp/StompOverWebsocketTest.java           |  2 +-
 .../stomp/util/AbstractClientStompFrame.java    |  2 +-
 .../util/AbstractStompClientConnection.java     |  2 +-
 .../tests/integration/xa/BasicXaTest.java       |  2 +-
 .../tests/integration/xa/XaTimeoutTest.java     |  2 +-
 .../jms/tests/AutoAckMesageListenerTest.java    |  2 +-
 .../artemis/jms/tests/MessageConsumerTest.java  | 30 +++++++-------
 .../artemis/jms/tests/MessageProducerTest.java  |  6 +--
 .../artemis/jms/tests/MiscellaneousTest.java    |  2 +-
 .../jms/tests/TransactedSessionTest.java        |  2 +-
 .../jms/tests/message/MessageHeaderTest.java    |  2 +-
 .../paging/MeasurePagingMultiThreadTest.java    |  2 +-
 .../sends/AbstractSendReceivePerfTest.java      |  4 +-
 .../JournalCleanupCompactStressTest.java        |  6 +--
 .../tests/stress/remote/PingStressTest.java     |  2 +-
 .../jms/bridge/impl/JMSBridgeImplTest.java      |  2 +-
 .../MultiThreadAsynchronousFileTest.java        |  8 ++--
 .../core/paging/impl/PagingStoreImplTest.java   |  8 ++--
 .../impl/WildcardAddressManagerUnitTest.java    |  4 +-
 .../unit/core/server/impl/QueueImplTest.java    |  8 ++--
 142 files changed, 310 insertions(+), 310 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/tools/PrintData.java
----------------------------------------------------------------------
diff --git a/artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/tools/PrintData.java b/artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/tools/PrintData.java
index 9256acc..7c5fddf 100644
--- a/artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/tools/PrintData.java
+++ b/artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/tools/PrintData.java
@@ -289,7 +289,7 @@ public class PrintData extends LockAbstract {
 
       private final Map<Long, Set<Long>> completePages = new HashMap<>();
 
-      public PageCursorsInfo() {
+      private PageCursorsInfo() {
       }
 
       /**

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/tools/XmlDataExporter.java
----------------------------------------------------------------------
diff --git a/artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/tools/XmlDataExporter.java b/artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/tools/XmlDataExporter.java
index c3deae4..3aec34f 100644
--- a/artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/tools/XmlDataExporter.java
+++ b/artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/tools/XmlDataExporter.java
@@ -935,7 +935,7 @@ public final class XmlDataExporter extends LockAbstract {
 
       boolean wrap = true;
 
-      public PrettyPrintHandler(XMLStreamWriter target) {
+      PrettyPrintHandler(XMLStreamWriter target) {
          this.target = target;
       }
 

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/artemis-commons/src/main/java/org/apache/activemq/artemis/utils/ReusableLatch.java
----------------------------------------------------------------------
diff --git a/artemis-commons/src/main/java/org/apache/activemq/artemis/utils/ReusableLatch.java b/artemis-commons/src/main/java/org/apache/activemq/artemis/utils/ReusableLatch.java
index 4f04f22..19023ed 100644
--- a/artemis-commons/src/main/java/org/apache/activemq/artemis/utils/ReusableLatch.java
+++ b/artemis-commons/src/main/java/org/apache/activemq/artemis/utils/ReusableLatch.java
@@ -43,7 +43,7 @@ public class ReusableLatch {
    @SuppressWarnings("serial")
    private static class CountSync extends AbstractQueuedSynchronizer {
 
-      public CountSync(int count) {
+      private CountSync(int count) {
          setState(count);
       }
 

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/artemis-commons/src/main/java/org/apache/activemq/artemis/utils/TypedProperties.java
----------------------------------------------------------------------
diff --git a/artemis-commons/src/main/java/org/apache/activemq/artemis/utils/TypedProperties.java b/artemis-commons/src/main/java/org/apache/activemq/artemis/utils/TypedProperties.java
index 166f39e..eeb5783 100644
--- a/artemis-commons/src/main/java/org/apache/activemq/artemis/utils/TypedProperties.java
+++ b/artemis-commons/src/main/java/org/apache/activemq/artemis/utils/TypedProperties.java
@@ -598,7 +598,7 @@ public final class TypedProperties {
 
    private static final class NullValue extends PropertyValue {
 
-      public NullValue() {
+      private NullValue() {
       }
 
       @Override
@@ -622,11 +622,11 @@ public final class TypedProperties {
 
       final boolean val;
 
-      public BooleanValue(final boolean val) {
+      private BooleanValue(final boolean val) {
          this.val = val;
       }
 
-      public BooleanValue(final ActiveMQBuffer buffer) {
+      private BooleanValue(final ActiveMQBuffer buffer) {
          val = buffer.readBoolean();
       }
 
@@ -652,11 +652,11 @@ public final class TypedProperties {
 
       final byte val;
 
-      public ByteValue(final byte val) {
+      private ByteValue(final byte val) {
          this.val = val;
       }
 
-      public ByteValue(final ActiveMQBuffer buffer) {
+      private ByteValue(final ActiveMQBuffer buffer) {
          val = buffer.readByte();
       }
 
@@ -681,11 +681,11 @@ public final class TypedProperties {
 
       final byte[] val;
 
-      public BytesValue(final byte[] val) {
+      private BytesValue(final byte[] val) {
          this.val = val;
       }
 
-      public BytesValue(final ActiveMQBuffer buffer) {
+      private BytesValue(final ActiveMQBuffer buffer) {
          int len = buffer.readInt();
          val = new byte[len];
          buffer.readBytes(val);
@@ -714,11 +714,11 @@ public final class TypedProperties {
 
       final short val;
 
-      public ShortValue(final short val) {
+      private ShortValue(final short val) {
          this.val = val;
       }
 
-      public ShortValue(final ActiveMQBuffer buffer) {
+      private ShortValue(final ActiveMQBuffer buffer) {
          val = buffer.readShort();
       }
 
@@ -743,11 +743,11 @@ public final class TypedProperties {
 
       final int val;
 
-      public IntValue(final int val) {
+      private IntValue(final int val) {
          this.val = val;
       }
 
-      public IntValue(final ActiveMQBuffer buffer) {
+      private IntValue(final ActiveMQBuffer buffer) {
          val = buffer.readInt();
       }
 
@@ -772,11 +772,11 @@ public final class TypedProperties {
 
       final long val;
 
-      public LongValue(final long val) {
+      private LongValue(final long val) {
          this.val = val;
       }
 
-      public LongValue(final ActiveMQBuffer buffer) {
+      private LongValue(final ActiveMQBuffer buffer) {
          val = buffer.readLong();
       }
 
@@ -801,11 +801,11 @@ public final class TypedProperties {
 
       final float val;
 
-      public FloatValue(final float val) {
+      private FloatValue(final float val) {
          this.val = val;
       }
 
-      public FloatValue(final ActiveMQBuffer buffer) {
+      private FloatValue(final ActiveMQBuffer buffer) {
          val = Float.intBitsToFloat(buffer.readInt());
       }
 
@@ -831,11 +831,11 @@ public final class TypedProperties {
 
       final double val;
 
-      public DoubleValue(final double val) {
+      private DoubleValue(final double val) {
          this.val = val;
       }
 
-      public DoubleValue(final ActiveMQBuffer buffer) {
+      private DoubleValue(final ActiveMQBuffer buffer) {
          val = Double.longBitsToDouble(buffer.readLong());
       }
 
@@ -860,11 +860,11 @@ public final class TypedProperties {
 
       final char val;
 
-      public CharValue(final char val) {
+      private CharValue(final char val) {
          this.val = val;
       }
 
-      public CharValue(final ActiveMQBuffer buffer) {
+      private CharValue(final ActiveMQBuffer buffer) {
          val = (char) buffer.readShort();
       }
 
@@ -889,11 +889,11 @@ public final class TypedProperties {
 
       final SimpleString val;
 
-      public StringValue(final SimpleString val) {
+      private StringValue(final SimpleString val) {
          this.val = val;
       }
 
-      public StringValue(final ActiveMQBuffer buffer) {
+      private StringValue(final ActiveMQBuffer buffer) {
          val = buffer.readSimpleString();
       }
 

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/UDPBroadcastEndpointFactory.java
----------------------------------------------------------------------
diff --git a/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/UDPBroadcastEndpointFactory.java b/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/UDPBroadcastEndpointFactory.java
index dff18a5..e5cc1ff 100644
--- a/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/UDPBroadcastEndpointFactory.java
+++ b/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/UDPBroadcastEndpointFactory.java
@@ -113,7 +113,7 @@ public final class UDPBroadcastEndpointFactory implements BroadcastEndpointFacto
 
       private volatile boolean open;
 
-      public UDPBroadcastEndpoint() {
+      private UDPBroadcastEndpoint() {
       }
 
       public UDPBroadcastEndpoint setGroupAddress(InetAddress groupAddress) {

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/CoreNotificationType.java
----------------------------------------------------------------------
diff --git a/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/CoreNotificationType.java b/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/CoreNotificationType.java
index 1821962..ff514ad 100644
--- a/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/CoreNotificationType.java
+++ b/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/CoreNotificationType.java
@@ -43,7 +43,7 @@ public enum CoreNotificationType implements NotificationType {
 
    private final int value;
 
-   private CoreNotificationType(final int value) {
+   CoreNotificationType(final int value) {
       this.value = value;
    }
 

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientMessageImpl.java
----------------------------------------------------------------------
diff --git a/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientMessageImpl.java b/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientMessageImpl.java
index 926ac1b..a6a2231 100644
--- a/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientMessageImpl.java
+++ b/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientMessageImpl.java
@@ -318,7 +318,7 @@ public class ClientMessageImpl extends MessageImpl implements ClientMessageInter
 
    private final class DecodingContext implements BodyEncoder {
 
-      public DecodingContext() {
+      private DecodingContext() {
       }
 
       @Override

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/CompressedLargeMessageControllerImpl.java
----------------------------------------------------------------------
diff --git a/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/CompressedLargeMessageControllerImpl.java b/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/CompressedLargeMessageControllerImpl.java
index e7cc173..0e826b5 100644
--- a/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/CompressedLargeMessageControllerImpl.java
+++ b/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/CompressedLargeMessageControllerImpl.java
@@ -40,7 +40,7 @@ final class CompressedLargeMessageControllerImpl implements LargeMessageControll
 
    private final LargeMessageController bufferDelegate;
 
-   public CompressedLargeMessageControllerImpl(final LargeMessageController bufferDelegate) {
+   CompressedLargeMessageControllerImpl(final LargeMessageController bufferDelegate) {
       this.bufferDelegate = bufferDelegate;
    }
 

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/LargeMessageControllerImpl.java
----------------------------------------------------------------------
diff --git a/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/LargeMessageControllerImpl.java b/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/LargeMessageControllerImpl.java
index c3b18a3..da4d6bd 100644
--- a/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/LargeMessageControllerImpl.java
+++ b/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/LargeMessageControllerImpl.java
@@ -1141,7 +1141,7 @@ public class LargeMessageControllerImpl implements LargeMessageController {
 
    private final class FileCache {
 
-      public FileCache(final File cachedFile) {
+      private FileCache(final File cachedFile) {
          this.cachedFile = cachedFile;
       }
 
@@ -1323,13 +1323,13 @@ public class LargeMessageControllerImpl implements LargeMessageController {
       final int flowControlSize;
       final boolean continues;
 
-      public LargeData() {
+      private LargeData() {
          continues = false;
          flowControlSize = 0;
          chunk = null;
       }
 
-      public LargeData(byte[] chunk, int flowControlSize, boolean continues) {
+      private LargeData(byte[] chunk, int flowControlSize, boolean continues) {
          this.chunk = chunk;
          this.flowControlSize = flowControlSize;
          this.continues = continues;

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ServerLocatorImpl.java
----------------------------------------------------------------------
diff --git a/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ServerLocatorImpl.java b/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ServerLocatorImpl.java
index 8c71002..e7c67cf 100644
--- a/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ServerLocatorImpl.java
+++ b/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ServerLocatorImpl.java
@@ -1784,7 +1784,7 @@ public final class ServerLocatorImpl implements ServerLocatorInternal, Discovery
 
          private volatile ClientSessionFactoryInternal factory;
 
-         public Connector(TransportConfiguration initialConnector, ClientSessionFactoryInternal factory) {
+         private Connector(TransportConfiguration initialConnector, ClientSessionFactoryInternal factory) {
             this.initialConnector = initialConnector;
             this.factory = factory;
          }

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/message/impl/MessageImpl.java
----------------------------------------------------------------------
diff --git a/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/message/impl/MessageImpl.java b/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/message/impl/MessageImpl.java
index df77132..10818fa 100644
--- a/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/message/impl/MessageImpl.java
+++ b/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/message/impl/MessageImpl.java
@@ -1013,7 +1013,7 @@ public abstract class MessageImpl implements MessageInternal {
 
       private int lastPos = 0;
 
-      public DecodingContext() {
+      private DecodingContext() {
       }
 
       @Override

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/NettyConnector.java
----------------------------------------------------------------------
diff --git a/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/NettyConnector.java b/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/NettyConnector.java
index b209f89..62c405b 100644
--- a/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/NettyConnector.java
+++ b/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/NettyConnector.java
@@ -725,7 +725,7 @@ public class NettyConnector extends AbstractConnector {
       private final CountDownLatch latch = new CountDownLatch(1);
       private boolean handshakeComplete = false;
 
-      public HttpUpgradeHandler(ChannelPipeline pipeline, HttpClientCodec httpClientCodec) {
+      private HttpUpgradeHandler(ChannelPipeline pipeline, HttpClientCodec httpClientCodec) {
          this.pipeline = pipeline;
          this.httpClientCodec = httpClientCodec;
       }
@@ -798,7 +798,7 @@ public class NettyConnector extends AbstractConnector {
 
       private String cookie;
 
-      public HttpHandler() throws Exception {
+      HttpHandler() throws Exception {
          url = new URI("http", null, host, port, servletPath, null, null).toString();
       }
 

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/artemis-core-client/src/main/java/org/apache/activemq/artemis/utils/OrderedExecutorFactory.java
----------------------------------------------------------------------
diff --git a/artemis-core-client/src/main/java/org/apache/activemq/artemis/utils/OrderedExecutorFactory.java b/artemis-core-client/src/main/java/org/apache/activemq/artemis/utils/OrderedExecutorFactory.java
index b0b13ae..d80d7bd 100644
--- a/artemis-core-client/src/main/java/org/apache/activemq/artemis/utils/OrderedExecutorFactory.java
+++ b/artemis-core-client/src/main/java/org/apache/activemq/artemis/utils/OrderedExecutorFactory.java
@@ -74,7 +74,7 @@ public final class OrderedExecutorFactory implements ExecutorFactory {
       private static final int STATE_NOT_RUNNING = 0;
       private static final int STATE_RUNNING = 1;
 
-      public OrderedExecutor(Executor delegate) {
+      private OrderedExecutor(Executor delegate) {
          this.delegate = delegate;
       }
 

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/artemis-core-client/src/main/java/org/apache/activemq/artemis/utils/SoftValueHashMap.java
----------------------------------------------------------------------
diff --git a/artemis-core-client/src/main/java/org/apache/activemq/artemis/utils/SoftValueHashMap.java b/artemis-core-client/src/main/java/org/apache/activemq/artemis/utils/SoftValueHashMap.java
index b499910..17228c2 100644
--- a/artemis-core-client/src/main/java/org/apache/activemq/artemis/utils/SoftValueHashMap.java
+++ b/artemis-core-client/src/main/java/org/apache/activemq/artemis/utils/SoftValueHashMap.java
@@ -342,7 +342,7 @@ public class SoftValueHashMap<K, V extends SoftValueHashMap.ValueCache> implemen
          used = usedCounter.incrementAndGet();
       }
 
-      public AggregatedSoftReference(final K key, final V referent) {
+      AggregatedSoftReference(final K key, final V referent) {
          super(referent, refQueue);
          this.key = key;
       }

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/artemis-dto/src/main/java/org/apache/activemq/artemis/dto/XmlUtil.java
----------------------------------------------------------------------
diff --git a/artemis-dto/src/main/java/org/apache/activemq/artemis/dto/XmlUtil.java b/artemis-dto/src/main/java/org/apache/activemq/artemis/dto/XmlUtil.java
index c49dbe5..5fa8667 100644
--- a/artemis-dto/src/main/java/org/apache/activemq/artemis/dto/XmlUtil.java
+++ b/artemis-dto/src/main/java/org/apache/activemq/artemis/dto/XmlUtil.java
@@ -42,7 +42,7 @@ public class XmlUtil {
       static final Pattern pattern = Pattern.compile("\\$\\{([^\\}]+)\\}");
       private final Properties props;
 
-      public PropertiesFilter(XMLStreamReader parent, Properties props) {
+      PropertiesFilter(XMLStreamReader parent, Properties props) {
          super(parent);
          this.props = props;
       }

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/artemis-jdbc-store/src/main/java/org/apache/activemq/artemis/jdbc/store/journal/TransactionHolder.java
----------------------------------------------------------------------
diff --git a/artemis-jdbc-store/src/main/java/org/apache/activemq/artemis/jdbc/store/journal/TransactionHolder.java b/artemis-jdbc-store/src/main/java/org/apache/activemq/artemis/jdbc/store/journal/TransactionHolder.java
index c03e747..348c823 100644
--- a/artemis-jdbc-store/src/main/java/org/apache/activemq/artemis/jdbc/store/journal/TransactionHolder.java
+++ b/artemis-jdbc-store/src/main/java/org/apache/activemq/artemis/jdbc/store/journal/TransactionHolder.java
@@ -24,7 +24,7 @@ import org.apache.activemq.artemis.core.journal.RecordInfo;
 
 final class TransactionHolder {
 
-   public TransactionHolder(final long id) {
+   TransactionHolder(final long id) {
       transactionID = id;
    }
 

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/artemis-jdbc-store/src/test/java/org/apache/activemq/artemis/jdbc/file/JDBCSequentialFileFactoryTest.java
----------------------------------------------------------------------
diff --git a/artemis-jdbc-store/src/test/java/org/apache/activemq/artemis/jdbc/file/JDBCSequentialFileFactoryTest.java b/artemis-jdbc-store/src/test/java/org/apache/activemq/artemis/jdbc/file/JDBCSequentialFileFactoryTest.java
index 1a8fba4..5f7d7e6 100644
--- a/artemis-jdbc-store/src/test/java/org/apache/activemq/artemis/jdbc/file/JDBCSequentialFileFactoryTest.java
+++ b/artemis-jdbc-store/src/test/java/org/apache/activemq/artemis/jdbc/file/JDBCSequentialFileFactoryTest.java
@@ -169,7 +169,7 @@ public class JDBCSequentialFileFactoryTest {
 
       private final CountDownLatch countDownLatch;
 
-      public IOCallbackCountdown(int size) {
+      private IOCallbackCountdown(int size) {
          this.countDownLatch = new CountDownLatch(size);
       }
 

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQJMSConsumer.java
----------------------------------------------------------------------
diff --git a/artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQJMSConsumer.java b/artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQJMSConsumer.java
index f3ba6e2..c59812b 100644
--- a/artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQJMSConsumer.java
+++ b/artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQJMSConsumer.java
@@ -143,7 +143,7 @@ public class ActiveMQJMSConsumer implements JMSConsumer {
 
       private final MessageListener wrapped;
 
-      public MessageListenerWrapper(MessageListener wrapped) {
+      MessageListenerWrapper(MessageListener wrapped) {
          this.wrapped = wrapped;
       }
 

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQJMSProducer.java
----------------------------------------------------------------------
diff --git a/artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQJMSProducer.java b/artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQJMSProducer.java
index 6e37a86..17d6c3c 100644
--- a/artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQJMSProducer.java
+++ b/artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQJMSProducer.java
@@ -628,7 +628,7 @@ public final class ActiveMQJMSProducer implements JMSProducer {
 
       private final CompletionListener wrapped;
 
-      public CompletionListenerWrapper(CompletionListener wrapped) {
+      CompletionListenerWrapper(CompletionListener wrapped) {
          this.wrapped = wrapped;
       }
 

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQMessageProducer.java
----------------------------------------------------------------------
diff --git a/artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQMessageProducer.java b/artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQMessageProducer.java
index 112b535..5a0d5c3 100644
--- a/artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQMessageProducer.java
+++ b/artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQMessageProducer.java
@@ -533,9 +533,9 @@ public class ActiveMQMessageProducer implements MessageProducer, QueueSender, To
        * @param jmsMessage
        * @param producer
        */
-      public CompletionListenerWrapper(CompletionListener listener,
-                                       Message jmsMessage,
-                                       ActiveMQMessageProducer producer) {
+      private CompletionListenerWrapper(CompletionListener listener,
+                                        Message jmsMessage,
+                                        ActiveMQMessageProducer producer) {
          this.completionListener = listener;
          this.jmsMessage = jmsMessage;
          this.producer = producer;

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/artemis-jms-server/src/main/java/org/apache/activemq/artemis/jms/bridge/impl/JMSBridgeImpl.java
----------------------------------------------------------------------
diff --git a/artemis-jms-server/src/main/java/org/apache/activemq/artemis/jms/bridge/impl/JMSBridgeImpl.java b/artemis-jms-server/src/main/java/org/apache/activemq/artemis/jms/bridge/impl/JMSBridgeImpl.java
index 46cc0d4..7987320 100644
--- a/artemis-jms-server/src/main/java/org/apache/activemq/artemis/jms/bridge/impl/JMSBridgeImpl.java
+++ b/artemis-jms-server/src/main/java/org/apache/activemq/artemis/jms/bridge/impl/JMSBridgeImpl.java
@@ -1900,7 +1900,7 @@ public final class JMSBridgeImpl implements JMSBridge {
       BridgeFailoverListener failoverListener;
       private final boolean isSource;
 
-      public BridgeExceptionListener(boolean ha, BridgeFailoverListener failoverListener, boolean isSource) {
+      private BridgeExceptionListener(boolean ha, BridgeFailoverListener failoverListener, boolean isSource) {
          this.ha = ha;
          this.failoverListener = failoverListener;
          this.isSource = isSource;
@@ -1992,7 +1992,7 @@ public final class JMSBridgeImpl implements JMSBridge {
       private final boolean isSource;
       volatile FailoverEventType lastEvent;
 
-      public BridgeFailoverListener(boolean isSource) {
+      private BridgeFailoverListener(boolean isSource) {
          this.isSource = isSource;
       }
 

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/artemis-jms-server/src/main/java/org/apache/activemq/artemis/jms/server/management/JMSNotificationType.java
----------------------------------------------------------------------
diff --git a/artemis-jms-server/src/main/java/org/apache/activemq/artemis/jms/server/management/JMSNotificationType.java b/artemis-jms-server/src/main/java/org/apache/activemq/artemis/jms/server/management/JMSNotificationType.java
index 68ec9ed..5f71eff 100644
--- a/artemis-jms-server/src/main/java/org/apache/activemq/artemis/jms/server/management/JMSNotificationType.java
+++ b/artemis-jms-server/src/main/java/org/apache/activemq/artemis/jms/server/management/JMSNotificationType.java
@@ -31,7 +31,7 @@ public enum JMSNotificationType implements NotificationType {
 
    private int type;
 
-   private JMSNotificationType(int type) {
+   JMSNotificationType(int type) {
       this.type = type;
    }
 

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/artemis-journal/src/main/java/org/apache/activemq/artemis/core/io/aio/AIOSequentialFileFactory.java
----------------------------------------------------------------------
diff --git a/artemis-journal/src/main/java/org/apache/activemq/artemis/core/io/aio/AIOSequentialFileFactory.java b/artemis-journal/src/main/java/org/apache/activemq/artemis/core/io/aio/AIOSequentialFileFactory.java
index 2a79e6e..f3f12a5 100644
--- a/artemis-journal/src/main/java/org/apache/activemq/artemis/core/io/aio/AIOSequentialFileFactory.java
+++ b/artemis-journal/src/main/java/org/apache/activemq/artemis/core/io/aio/AIOSequentialFileFactory.java
@@ -359,7 +359,7 @@ public final class AIOSequentialFileFactory extends AbstractSequentialFileFactor
 
    private class PollerThread extends Thread {
 
-      public PollerThread() {
+      private PollerThread() {
          super("Apache ActiveMQ Artemis libaio poller");
       }
 

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/artemis-journal/src/main/java/org/apache/activemq/artemis/core/journal/impl/JournalBase.java
----------------------------------------------------------------------
diff --git a/artemis-journal/src/main/java/org/apache/activemq/artemis/core/journal/impl/JournalBase.java b/artemis-journal/src/main/java/org/apache/activemq/artemis/core/journal/impl/JournalBase.java
index 50632fa..e2ca84d 100644
--- a/artemis-journal/src/main/java/org/apache/activemq/artemis/core/journal/impl/JournalBase.java
+++ b/artemis-journal/src/main/java/org/apache/activemq/artemis/core/journal/impl/JournalBase.java
@@ -28,7 +28,7 @@ abstract class JournalBase implements Journal {
    protected final int fileSize;
    private final boolean supportsCallback;
 
-   public JournalBase(boolean supportsCallback, int fileSize) {
+   JournalBase(boolean supportsCallback, int fileSize) {
       if (fileSize < JournalImpl.MIN_FILE_SIZE) {
          throw new IllegalArgumentException("File size cannot be less than " + JournalImpl.MIN_FILE_SIZE + " bytes");
       }

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/artemis-journal/src/main/java/org/apache/activemq/artemis/core/journal/impl/JournalCompactor.java
----------------------------------------------------------------------
diff --git a/artemis-journal/src/main/java/org/apache/activemq/artemis/core/journal/impl/JournalCompactor.java b/artemis-journal/src/main/java/org/apache/activemq/artemis/core/journal/impl/JournalCompactor.java
index 1acbcaa..40926e0 100644
--- a/artemis-journal/src/main/java/org/apache/activemq/artemis/core/journal/impl/JournalCompactor.java
+++ b/artemis-journal/src/main/java/org/apache/activemq/artemis/core/journal/impl/JournalCompactor.java
@@ -444,7 +444,7 @@ public class JournalCompactor extends AbstractJournalUpdateTask implements Journ
 
       JournalFile usedFile;
 
-      public DeleteCompactCommand(final long id, final JournalFile usedFile) {
+      private DeleteCompactCommand(final long id, final JournalFile usedFile) {
          this.id = id;
          this.usedFile = usedFile;
       }
@@ -479,7 +479,7 @@ public class JournalCompactor extends AbstractJournalUpdateTask implements Journ
 
       private final int size;
 
-      public UpdateCompactCommand(final long id, final JournalFile usedFile, final int size) {
+      private UpdateCompactCommand(final long id, final JournalFile usedFile, final int size) {
          this.id = id;
          this.usedFile = usedFile;
          this.size = size;
@@ -501,7 +501,7 @@ public class JournalCompactor extends AbstractJournalUpdateTask implements Journ
        */
       private final JournalFile commitFile;
 
-      public CommitCompactCommand(final JournalTransaction liveTransaction, final JournalFile commitFile) {
+      private CommitCompactCommand(final JournalTransaction liveTransaction, final JournalFile commitFile) {
          this.liveTransaction = liveTransaction;
          this.commitFile = commitFile;
       }
@@ -526,7 +526,7 @@ public class JournalCompactor extends AbstractJournalUpdateTask implements Journ
        */
       private final JournalFile rollbackFile;
 
-      public RollbackCompactCommand(final JournalTransaction liveTransaction, final JournalFile rollbackFile) {
+      private RollbackCompactCommand(final JournalTransaction liveTransaction, final JournalFile rollbackFile) {
          this.liveTransaction = liveTransaction;
          this.rollbackFile = rollbackFile;
       }

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/artemis-journal/src/main/java/org/apache/activemq/artemis/core/journal/impl/JournalImpl.java
----------------------------------------------------------------------
diff --git a/artemis-journal/src/main/java/org/apache/activemq/artemis/core/journal/impl/JournalImpl.java b/artemis-journal/src/main/java/org/apache/activemq/artemis/core/journal/impl/JournalImpl.java
index e19e728..61d6800 100644
--- a/artemis-journal/src/main/java/org/apache/activemq/artemis/core/journal/impl/JournalImpl.java
+++ b/artemis-journal/src/main/java/org/apache/activemq/artemis/core/journal/impl/JournalImpl.java
@@ -2578,7 +2578,7 @@ public class JournalImpl extends JournalBase implements TestableJournal, Journal
    // Used on Load
    private static final class TransactionHolder {
 
-      public TransactionHolder(final long id) {
+      private TransactionHolder(final long id) {
          transactionID = id;
       }
 

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/artemis-native/src/test/java/org/apache/activemq/artemis/jlibaio/test/LibaioTest.java
----------------------------------------------------------------------
diff --git a/artemis-native/src/test/java/org/apache/activemq/artemis/jlibaio/test/LibaioTest.java b/artemis-native/src/test/java/org/apache/activemq/artemis/jlibaio/test/LibaioTest.java
index 617553c..71f7516 100644
--- a/artemis-native/src/test/java/org/apache/activemq/artemis/jlibaio/test/LibaioTest.java
+++ b/artemis-native/src/test/java/org/apache/activemq/artemis/jlibaio/test/LibaioTest.java
@@ -721,7 +721,7 @@ public class LibaioTest {
       String errorMessage;
       int errno;
 
-      public TestInfo() {
+      TestInfo() {
          count.incrementAndGet();
       }
 

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/artemis-protocols/artemis-mqtt-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/mqtt/MQTTProtocolManager.java
----------------------------------------------------------------------
diff --git a/artemis-protocols/artemis-mqtt-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/mqtt/MQTTProtocolManager.java b/artemis-protocols/artemis-mqtt-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/mqtt/MQTTProtocolManager.java
index e99272f..d2c0793 100644
--- a/artemis-protocols/artemis-mqtt-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/mqtt/MQTTProtocolManager.java
+++ b/artemis-protocols/artemis-mqtt-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/mqtt/MQTTProtocolManager.java
@@ -43,7 +43,7 @@ class MQTTProtocolManager implements ProtocolManager, NotificationListener {
 
    private MQTTLogger log = MQTTLogger.LOGGER;
 
-   public MQTTProtocolManager(ActiveMQServer server) {
+   MQTTProtocolManager(ActiveMQServer server) {
       this.server = server;
    }
 

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/artemis-protocols/artemis-proton-plug/src/main/java/org/proton/plug/util/CreditsSemaphore.java
----------------------------------------------------------------------
diff --git a/artemis-protocols/artemis-proton-plug/src/main/java/org/proton/plug/util/CreditsSemaphore.java b/artemis-protocols/artemis-proton-plug/src/main/java/org/proton/plug/util/CreditsSemaphore.java
index 170e875..a175805 100644
--- a/artemis-protocols/artemis-proton-plug/src/main/java/org/proton/plug/util/CreditsSemaphore.java
+++ b/artemis-protocols/artemis-proton-plug/src/main/java/org/proton/plug/util/CreditsSemaphore.java
@@ -23,7 +23,7 @@ public class CreditsSemaphore {
    @SuppressWarnings("serial")
    private static class Sync extends AbstractQueuedSynchronizer {
 
-      public Sync(int initial) {
+      private Sync(int initial) {
          setState(initial);
       }
 

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/artemis-protocols/artemis-proton-plug/src/main/java/org/proton/plug/util/ReusableLatch.java
----------------------------------------------------------------------
diff --git a/artemis-protocols/artemis-proton-plug/src/main/java/org/proton/plug/util/ReusableLatch.java b/artemis-protocols/artemis-proton-plug/src/main/java/org/proton/plug/util/ReusableLatch.java
index 87e00e0..beccc03 100644
--- a/artemis-protocols/artemis-proton-plug/src/main/java/org/proton/plug/util/ReusableLatch.java
+++ b/artemis-protocols/artemis-proton-plug/src/main/java/org/proton/plug/util/ReusableLatch.java
@@ -38,7 +38,7 @@ public class ReusableLatch {
    @SuppressWarnings("serial")
    private static class CountSync extends AbstractQueuedSynchronizer {
 
-      public CountSync(int count) {
+      private CountSync(int count) {
          setState(count);
       }
 

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/artemis-protocols/artemis-proton-plug/src/test/java/org/proton/plug/context/AbstractConnectionContextTest.java
----------------------------------------------------------------------
diff --git a/artemis-protocols/artemis-proton-plug/src/test/java/org/proton/plug/context/AbstractConnectionContextTest.java b/artemis-protocols/artemis-proton-plug/src/test/java/org/proton/plug/context/AbstractConnectionContextTest.java
index 1cf7bb2..bfa0bad 100644
--- a/artemis-protocols/artemis-proton-plug/src/test/java/org/proton/plug/context/AbstractConnectionContextTest.java
+++ b/artemis-protocols/artemis-proton-plug/src/test/java/org/proton/plug/context/AbstractConnectionContextTest.java
@@ -50,7 +50,7 @@ public class AbstractConnectionContextTest {
 
    private class TestConnectionContext extends AbstractConnectionContext {
 
-      public TestConnectionContext(AMQPConnectionCallback connectionCallback) {
+      private TestConnectionContext(AMQPConnectionCallback connectionCallback) {
          super(connectionCallback, Executors.newSingleThreadExecutor(ActiveMQThreadFactory.defaultThreadFactory()), null);
       }
 

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/artemis-protocols/artemis-proton-plug/src/test/java/org/proton/plug/test/minimalserver/MinimalServer.java
----------------------------------------------------------------------
diff --git a/artemis-protocols/artemis-proton-plug/src/test/java/org/proton/plug/test/minimalserver/MinimalServer.java b/artemis-protocols/artemis-proton-plug/src/test/java/org/proton/plug/test/minimalserver/MinimalServer.java
index 7cb7861..8729cb4 100644
--- a/artemis-protocols/artemis-proton-plug/src/test/java/org/proton/plug/test/minimalserver/MinimalServer.java
+++ b/artemis-protocols/artemis-proton-plug/src/test/java/org/proton/plug/test/minimalserver/MinimalServer.java
@@ -120,7 +120,7 @@ public class MinimalServer {
 
       AMQPServerConnectionContext connection;
 
-      public ProtocolDecoder() {
+      ProtocolDecoder() {
       }
 
       @Override

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/artemis-protocols/artemis-stomp-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/stomp/ActiveMQStompException.java
----------------------------------------------------------------------
diff --git a/artemis-protocols/artemis-stomp-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/stomp/ActiveMQStompException.java b/artemis-protocols/artemis-stomp-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/stomp/ActiveMQStompException.java
index 9fb0786..7966037 100644
--- a/artemis-protocols/artemis-stomp-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/stomp/ActiveMQStompException.java
+++ b/artemis-protocols/artemis-stomp-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/stomp/ActiveMQStompException.java
@@ -97,7 +97,7 @@ public class ActiveMQStompException extends Exception {
       public final String key;
       public final String val;
 
-      public Header(String key, String val) {
+      private Header(String key, String val) {
          this.key = key;
          this.val = val;
       }

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/artemis-protocols/artemis-stomp-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/stomp/StompProtocolManager.java
----------------------------------------------------------------------
diff --git a/artemis-protocols/artemis-stomp-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/stomp/StompProtocolManager.java b/artemis-protocols/artemis-stomp-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/stomp/StompProtocolManager.java
index b3e52af..4b6f5ba 100644
--- a/artemis-protocols/artemis-stomp-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/stomp/StompProtocolManager.java
+++ b/artemis-protocols/artemis-stomp-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/stomp/StompProtocolManager.java
@@ -75,10 +75,10 @@ class StompProtocolManager implements ProtocolManager<StompFrameInterceptor> {
 
    // Constructors --------------------------------------------------
 
-   public StompProtocolManager(final StompProtocolManagerFactory factory,
-                               final ActiveMQServer server,
-                               final List<StompFrameInterceptor> incomingInterceptors,
-                               final List<StompFrameInterceptor> outgoingInterceptors) {
+   StompProtocolManager(final StompProtocolManagerFactory factory,
+                        final ActiveMQServer server,
+                        final List<StompFrameInterceptor> incomingInterceptors,
+                        final List<StompFrameInterceptor> outgoingInterceptors) {
       this.factory = factory;
       this.server = server;
       this.executor = server.getExecutorFactory().getExecutor();

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/artemis-protocols/artemis-stomp-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/stomp/StompVersions.java
----------------------------------------------------------------------
diff --git a/artemis-protocols/artemis-stomp-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/stomp/StompVersions.java b/artemis-protocols/artemis-stomp-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/stomp/StompVersions.java
index adf360c..a41726f 100644
--- a/artemis-protocols/artemis-stomp-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/stomp/StompVersions.java
+++ b/artemis-protocols/artemis-stomp-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/stomp/StompVersions.java
@@ -26,7 +26,7 @@ public enum StompVersions {
 
    private String version;
 
-   private StompVersions(String ver) {
+   StompVersions(String ver) {
       this.version = ver;
    }
 

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/artemis-protocols/artemis-stomp-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/stomp/v11/StompFrameHandlerV11.java
----------------------------------------------------------------------
diff --git a/artemis-protocols/artemis-stomp-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/stomp/v11/StompFrameHandlerV11.java b/artemis-protocols/artemis-stomp-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/stomp/v11/StompFrameHandlerV11.java
index 6874173..91d0119 100644
--- a/artemis-protocols/artemis-stomp-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/stomp/v11/StompFrameHandlerV11.java
+++ b/artemis-protocols/artemis-stomp-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/stomp/v11/StompFrameHandlerV11.java
@@ -251,7 +251,7 @@ public class StompFrameHandlerV11 extends VersionedStompFrameHandler implements
       AtomicLong lastAccepted = new AtomicLong(0);
       StompFrame pingFrame;
 
-      public HeartBeater(long clientPing, long clientAcceptPing) {
+      private HeartBeater(long clientPing, long clientAcceptPing) {
          if (clientPing != 0) {
             serverAcceptPing = clientPing > MIN_CLIENT_PING ? clientPing : MIN_CLIENT_PING;
          }

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/artemis-rest/src/test/java/org/apache/activemq/artemis/rest/test/AutoAckTopicTest.java
----------------------------------------------------------------------
diff --git a/artemis-rest/src/test/java/org/apache/activemq/artemis/rest/test/AutoAckTopicTest.java b/artemis-rest/src/test/java/org/apache/activemq/artemis/rest/test/AutoAckTopicTest.java
index d8fe822..baf464f 100644
--- a/artemis-rest/src/test/java/org/apache/activemq/artemis/rest/test/AutoAckTopicTest.java
+++ b/artemis-rest/src/test/java/org/apache/activemq/artemis/rest/test/AutoAckTopicTest.java
@@ -150,7 +150,7 @@ public class AutoAckTopicTest extends MessageTestBase {
       private boolean isFinished = false;
       private boolean failed = false;
 
-      public NewPullSubscriber(String url) {
+      private NewPullSubscriber(String url) {
          this.url = url;
       }
 
@@ -187,7 +187,7 @@ public class AutoAckTopicTest extends MessageTestBase {
       private boolean isFinished = false;
       private boolean failed = false;
 
-      public AcceptWaitListener(String url) {
+      private AcceptWaitListener(String url) {
          this.url = url;
       }
 

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/artemis-selector/src/main/java/org/apache/activemq/artemis/selector/filter/ComparisonExpression.java
----------------------------------------------------------------------
diff --git a/artemis-selector/src/main/java/org/apache/activemq/artemis/selector/filter/ComparisonExpression.java b/artemis-selector/src/main/java/org/apache/activemq/artemis/selector/filter/ComparisonExpression.java
index 05cbbe5..bc3b333 100755
--- a/artemis-selector/src/main/java/org/apache/activemq/artemis/selector/filter/ComparisonExpression.java
+++ b/artemis-selector/src/main/java/org/apache/activemq/artemis/selector/filter/ComparisonExpression.java
@@ -79,7 +79,7 @@ public abstract class ComparisonExpression extends BinaryExpression implements B
 
       /**
        */
-      public LikeExpression(Expression right, String like, int escape) {
+      LikeExpression(Expression right, String like, int escape) {
          super(right);
 
          StringBuffer regexp = new StringBuffer(like.length() * 2);

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/artemis-selector/src/main/java/org/apache/activemq/artemis/selector/filter/ConstantExpression.java
----------------------------------------------------------------------
diff --git a/artemis-selector/src/main/java/org/apache/activemq/artemis/selector/filter/ConstantExpression.java b/artemis-selector/src/main/java/org/apache/activemq/artemis/selector/filter/ConstantExpression.java
index 010b736..8d88bbd 100755
--- a/artemis-selector/src/main/java/org/apache/activemq/artemis/selector/filter/ConstantExpression.java
+++ b/artemis-selector/src/main/java/org/apache/activemq/artemis/selector/filter/ConstantExpression.java
@@ -27,7 +27,7 @@ public class ConstantExpression implements Expression {
 
    static class BooleanConstantExpression extends ConstantExpression implements BooleanExpression {
 
-      public BooleanConstantExpression(Object value) {
+      BooleanConstantExpression(Object value) {
          super(value);
       }
 

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/artemis-selector/src/main/java/org/apache/activemq/artemis/selector/filter/UnaryExpression.java
----------------------------------------------------------------------
diff --git a/artemis-selector/src/main/java/org/apache/activemq/artemis/selector/filter/UnaryExpression.java b/artemis-selector/src/main/java/org/apache/activemq/artemis/selector/filter/UnaryExpression.java
index fb9832a..3121ac2 100755
--- a/artemis-selector/src/main/java/org/apache/activemq/artemis/selector/filter/UnaryExpression.java
+++ b/artemis-selector/src/main/java/org/apache/activemq/artemis/selector/filter/UnaryExpression.java
@@ -125,7 +125,7 @@ public abstract class UnaryExpression implements Expression {
 
    abstract static class BooleanUnaryExpression extends UnaryExpression implements BooleanExpression {
 
-      public BooleanUnaryExpression(Expression left) {
+      BooleanUnaryExpression(Expression left) {
          super(left);
       }
 

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/artemis-server-osgi/src/test/java/org/apache/activemq/artemis/osgi/ProtocolTrackerTest.java
----------------------------------------------------------------------
diff --git a/artemis-server-osgi/src/test/java/org/apache/activemq/artemis/osgi/ProtocolTrackerTest.java b/artemis-server-osgi/src/test/java/org/apache/activemq/artemis/osgi/ProtocolTrackerTest.java
index 46435cd..18e1f76 100644
--- a/artemis-server-osgi/src/test/java/org/apache/activemq/artemis/osgi/ProtocolTrackerTest.java
+++ b/artemis-server-osgi/src/test/java/org/apache/activemq/artemis/osgi/ProtocolTrackerTest.java
@@ -64,7 +64,7 @@ public class ProtocolTrackerTest {
       ServiceReference<ProtocolManagerFactory<Interceptor>> ref;
       ProtocolManagerFactory factory;
 
-      public RefFact(IMocksControl c, BundleContext context, String[] protocols) {
+      RefFact(IMocksControl c, BundleContext context, String[] protocols) {
          ref = c.createMock(ServiceReference.class);
          factory = c.createMock(ProtocolManagerFactory.class);
          expect(factory.getProtocols()).andReturn(protocols).atLeastOnce();

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/artemis-server/src/main/java/org/apache/activemq/artemis/core/config/HAPolicyConfiguration.java
----------------------------------------------------------------------
diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/config/HAPolicyConfiguration.java b/artemis-server/src/main/java/org/apache/activemq/artemis/core/config/HAPolicyConfiguration.java
index c1510d1..3ffd56a 100644
--- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/config/HAPolicyConfiguration.java
+++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/config/HAPolicyConfiguration.java
@@ -20,7 +20,7 @@ import java.io.Serializable;
 
 public interface HAPolicyConfiguration extends Serializable {
 
-   public enum TYPE {
+   enum TYPE {
       LIVE_ONLY,
       REPLICATED,
       REPLICA,

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/artemis-server/src/main/java/org/apache/activemq/artemis/core/config/StoreConfiguration.java
----------------------------------------------------------------------
diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/config/StoreConfiguration.java b/artemis-server/src/main/java/org/apache/activemq/artemis/core/config/StoreConfiguration.java
index d25cdd9..553ece5 100644
--- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/config/StoreConfiguration.java
+++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/config/StoreConfiguration.java
@@ -20,7 +20,7 @@ import java.io.Serializable;
 
 public interface StoreConfiguration extends Serializable {
 
-   public enum StoreType {
+   enum StoreType {
       FILE,
       DATABASE
    }

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/artemis-server/src/main/java/org/apache/activemq/artemis/core/filter/impl/FilterImpl.java
----------------------------------------------------------------------
diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/filter/impl/FilterImpl.java b/artemis-server/src/main/java/org/apache/activemq/artemis/core/filter/impl/FilterImpl.java
index dd9f7dd..9cacff0 100644
--- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/filter/impl/FilterImpl.java
+++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/filter/impl/FilterImpl.java
@@ -172,7 +172,7 @@ public class FilterImpl implements Filter {
 
       private final ServerMessage message;
 
-      public FilterableServerMessage(ServerMessage message) {
+      private FilterableServerMessage(ServerMessage message) {
          this.message = message;
       }
 

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/PageCacheImpl.java
----------------------------------------------------------------------
diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/PageCacheImpl.java b/artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/PageCacheImpl.java
index 8d9b872..8fd59d7 100644
--- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/PageCacheImpl.java
+++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/PageCacheImpl.java
@@ -37,7 +37,7 @@ class PageCacheImpl implements PageCache {
 
    // Constructors --------------------------------------------------
 
-   public PageCacheImpl(final Page page) {
+   PageCacheImpl(final Page page) {
       this.page = page;
    }
 

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/PageSubscriptionCounterImpl.java
----------------------------------------------------------------------
diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/PageSubscriptionCounterImpl.java b/artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/PageSubscriptionCounterImpl.java
index a28288a..54dc7e9 100644
--- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/PageSubscriptionCounterImpl.java
+++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/PageSubscriptionCounterImpl.java
@@ -351,7 +351,7 @@ public class PageSubscriptionCounterImpl implements PageSubscriptionCounter {
 
    private static class ItemOper {
 
-      public ItemOper(PageSubscriptionCounterImpl counter, long id, int add) {
+      private ItemOper(PageSubscriptionCounterImpl counter, long id, int add) {
          this.counter = counter;
          this.id = id;
          this.amount = add;

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/PageSubscriptionImpl.java
----------------------------------------------------------------------
diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/PageSubscriptionImpl.java b/artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/PageSubscriptionImpl.java
index 9eac4ce..c89161a 100644
--- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/PageSubscriptionImpl.java
+++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/PageSubscriptionImpl.java
@@ -942,7 +942,7 @@ final class PageSubscriptionImpl implements PageSubscription {
          }
       }
 
-      public PageCursorInfo(final long pageId, final int numberOfMessages, final PageCache cache) {
+      private PageCursorInfo(final long pageId, final int numberOfMessages, final PageCache cache) {
          logger.tracef("Created PageCursorInfo for pageNr=%d, numberOfMessages=%d,  cache=%s", pageId, numberOfMessages, cache);
          this.pageId = pageId;
          this.numberOfMessages = numberOfMessages;
@@ -1130,7 +1130,7 @@ final class PageSubscriptionImpl implements PageSubscription {
        */
       private volatile PagedReference cachedNext;
 
-      public CursorIterator() {
+      private CursorIterator() {
       }
 
       @Override

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/impl/PageTransactionInfoImpl.java
----------------------------------------------------------------------
diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/impl/PageTransactionInfoImpl.java b/artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/impl/PageTransactionInfoImpl.java
index 1502855..1dde309 100644
--- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/impl/PageTransactionInfoImpl.java
+++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/impl/PageTransactionInfoImpl.java
@@ -303,7 +303,7 @@ public final class PageTransactionInfoImpl implements PageTransactionInfo {
       final PagePosition pagePosition;
       final PageIterator iterator;
 
-      public LateDelivery(PageSubscription subscription, PagePosition pagePosition, PageIterator iterator) {
+      private LateDelivery(PageSubscription subscription, PagePosition pagePosition, PageIterator iterator) {
          this.subscription = subscription;
          this.pagePosition = pagePosition;
          this.iterator = iterator;
@@ -332,7 +332,7 @@ public final class PageTransactionInfoImpl implements PageTransactionInfo {
 
       private final PagingManager pagingManager;
 
-      public UpdatePageTXOperation(final StorageManager storageManager, final PagingManager pagingManager) {
+      private UpdatePageTXOperation(final StorageManager storageManager, final PagingManager pagingManager) {
          this.storageManager = storageManager;
          this.pagingManager = pagingManager;
       }

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/impl/PagingStoreImpl.java
----------------------------------------------------------------------
diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/impl/PagingStoreImpl.java b/artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/impl/PagingStoreImpl.java
index 8fec06c..f57f1b8 100644
--- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/impl/PagingStoreImpl.java
+++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/impl/PagingStoreImpl.java
@@ -937,9 +937,9 @@ public class PagingStoreImpl implements PagingStore {
          this.usedStores.add(store);
       }
 
-      public FinishPageMessageOperation(final PageTransactionInfo pageTransaction,
-                                        final StorageManager storageManager,
-                                        final PagingManager pagingManager) {
+      private FinishPageMessageOperation(final PageTransactionInfo pageTransaction,
+                                         final StorageManager storageManager,
+                                         final PagingManager pagingManager) {
          this.pageTransaction = pageTransaction;
          this.storageManager = storageManager;
          this.pagingManager = pagingManager;

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/StorageManager.java
----------------------------------------------------------------------
diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/StorageManager.java b/artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/StorageManager.java
index f92d0d8..d08b84d 100644
--- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/StorageManager.java
+++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/StorageManager.java
@@ -223,7 +223,7 @@ public interface StorageManager extends IDGenerator, ActiveMQComponent {
       DURABLE(".msg"), TEMPORARY(".tmp"), SYNC(".sync");
       final String extension;
 
-      private LargeMessageExtension(String extension) {
+      LargeMessageExtension(String extension) {
          this.extension = extension;
       }
 

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/nullpm/NullStorageLargeServerMessage.java
----------------------------------------------------------------------
diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/nullpm/NullStorageLargeServerMessage.java b/artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/nullpm/NullStorageLargeServerMessage.java
index 365954c..5b325b6 100644
--- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/nullpm/NullStorageLargeServerMessage.java
+++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/nullpm/NullStorageLargeServerMessage.java
@@ -24,11 +24,11 @@ import org.apache.activemq.artemis.core.server.impl.ServerMessageImpl;
 
 class NullStorageLargeServerMessage extends ServerMessageImpl implements LargeServerMessage {
 
-   public NullStorageLargeServerMessage() {
+   NullStorageLargeServerMessage() {
       super();
    }
 
-   public NullStorageLargeServerMessage(NullStorageLargeServerMessage other) {
+   NullStorageLargeServerMessage(NullStorageLargeServerMessage other) {
       super(other);
    }
 

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/ProtocolHandler.java
----------------------------------------------------------------------
diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/ProtocolHandler.java b/artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/ProtocolHandler.java
index fed7a75..f4fef21 100644
--- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/ProtocolHandler.java
+++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/ProtocolHandler.java
@@ -94,7 +94,7 @@ public class ProtocolHandler {
 
       private final boolean httpEnabled;
 
-      public ProtocolDecoder(boolean http, boolean httpEnabled) {
+      ProtocolDecoder(boolean http, boolean httpEnabled) {
          this.http = http;
          this.httpEnabled = httpEnabled;
       }

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/CoreProtocolManager.java
----------------------------------------------------------------------
diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/CoreProtocolManager.java b/artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/CoreProtocolManager.java
index 32edb93..410b0c0 100644
--- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/CoreProtocolManager.java
+++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/CoreProtocolManager.java
@@ -204,11 +204,11 @@ public class CoreProtocolManager implements ProtocolManager<Interceptor> {
       private final Acceptor acceptorUsed;
       private final CoreRemotingConnection rc;
 
-      public LocalChannelHandler(final Configuration config,
-                                 final ConnectionEntry entry,
-                                 final Channel channel0,
-                                 final Acceptor acceptorUsed,
-                                 final CoreRemotingConnection rc) {
+      private LocalChannelHandler(final Configuration config,
+                                  final ConnectionEntry entry,
+                                  final Channel channel0,
+                                  final Acceptor acceptorUsed,
+                                  final CoreRemotingConnection rc) {
          this.config = config;
          this.entry = entry;
          this.channel0 = channel0;

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/wireformat/BackupReplicationStartFailedMessage.java
----------------------------------------------------------------------
diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/wireformat/BackupReplicationStartFailedMessage.java b/artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/wireformat/BackupReplicationStartFailedMessage.java
index 91830f8..0564220 100644
--- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/wireformat/BackupReplicationStartFailedMessage.java
+++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/wireformat/BackupReplicationStartFailedMessage.java
@@ -36,7 +36,7 @@ public final class BackupReplicationStartFailedMessage extends PacketImpl {
 
       final int code;
 
-      private BackupRegistrationProblem(int code) {
+      BackupRegistrationProblem(int code) {
          this.code = code;
       }
 

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/wireformat/ReplicationLiveIsStoppingMessage.java
----------------------------------------------------------------------
diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/wireformat/ReplicationLiveIsStoppingMessage.java b/artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/wireformat/ReplicationLiveIsStoppingMessage.java
index 28e03cf..339cfa8 100644
--- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/wireformat/ReplicationLiveIsStoppingMessage.java
+++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/wireformat/ReplicationLiveIsStoppingMessage.java
@@ -39,7 +39,7 @@ public final class ReplicationLiveIsStoppingMessage extends PacketImpl {
       FAIL_OVER(1);
       private final int code;
 
-      private LiveStopping(int code) {
+      LiveStopping(int code) {
          this.code = code;
       }
    }

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/wireformat/ReplicationStartSyncMessage.java
----------------------------------------------------------------------
diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/wireformat/ReplicationStartSyncMessage.java b/artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/wireformat/ReplicationStartSyncMessage.java
index d31db8b..157e02b 100644
--- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/wireformat/ReplicationStartSyncMessage.java
+++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/wireformat/ReplicationStartSyncMessage.java
@@ -46,7 +46,7 @@ public class ReplicationStartSyncMessage extends PacketImpl {
 
       private byte code;
 
-      private SyncDataType(byte code) {
+      SyncDataType(byte code) {
          this.code = code;
       }
 

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/wireformat/ReplicationSyncFileMessage.java
----------------------------------------------------------------------
diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/wireformat/ReplicationSyncFileMessage.java b/artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/wireformat/ReplicationSyncFileMessage.java
index ed5901f..6999741 100644
--- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/wireformat/ReplicationSyncFileMessage.java
+++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/wireformat/ReplicationSyncFileMessage.java
@@ -53,7 +53,7 @@ public final class ReplicationSyncFileMessage extends PacketImpl {
       private byte code;
       private static final Set<FileType> ALL_OF = EnumSet.allOf(FileType.class);
 
-      private FileType(int code) {
+      FileType(int code) {
          this.code = (byte) code;
       }
 

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/artemis-server/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/HttpAcceptorHandler.java
----------------------------------------------------------------------
diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/HttpAcceptorHandler.java b/artemis-server/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/HttpAcceptorHandler.java
index 7be3bac..f92a303 100644
--- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/HttpAcceptorHandler.java
+++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/HttpAcceptorHandler.java
@@ -123,13 +123,13 @@ public class HttpAcceptorHandler extends ChannelDuplexHandler {
 
       private final ChannelPromise promise;
 
-      public ResponseRunner(final ByteBuf buffer, ChannelPromise promise) {
+      ResponseRunner(final ByteBuf buffer, ChannelPromise promise) {
          this.buffer = buffer;
          bogusResponse = false;
          this.promise = promise;
       }
 
-      public ResponseRunner() {
+      ResponseRunner() {
          bogusResponse = true;
          buffer = Unpooled.buffer(0);
          promise = channel.newPromise();
@@ -211,7 +211,7 @@ public class HttpAcceptorHandler extends ChannelDuplexHandler {
 
       final long timeReceived;
 
-      public ResponseHolder(final long timeReceived, final FullHttpResponse response) {
+      private ResponseHolder(final long timeReceived, final FullHttpResponse response) {
          this.timeReceived = timeReceived;
          this.response = response;
       }

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/BackupManager.java
----------------------------------------------------------------------
diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/BackupManager.java b/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/BackupManager.java
index d8e077c..105bea3 100644
--- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/BackupManager.java
+++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/BackupManager.java
@@ -186,10 +186,10 @@ public class BackupManager implements ActiveMQComponent {
       private boolean announcingBackup;
       private boolean backupAnnounced = false;
 
-      public BackupConnector(String name,
-                             TransportConfiguration connector,
-                             long retryInterval,
-                             ClusterManager clusterManager) {
+      private BackupConnector(String name,
+                              TransportConfiguration connector,
+                              long retryInterval,
+                              ClusterManager clusterManager) {
          this.name = name;
          this.connector = connector;
          this.retryInterval = retryInterval;
@@ -328,11 +328,11 @@ public class BackupManager implements ActiveMQComponent {
 
       private final TransportConfiguration[] tcConfigs;
 
-      public StaticBackupConnector(TransportConfiguration[] tcConfigs,
-                                   String name,
-                                   TransportConfiguration connector,
-                                   long retryInterval,
-                                   ClusterManager clusterManager) {
+      private StaticBackupConnector(TransportConfiguration[] tcConfigs,
+                                    String name,
+                                    TransportConfiguration connector,
+                                    long retryInterval,
+                                    ClusterManager clusterManager) {
          super(name, connector, retryInterval, clusterManager);
          this.tcConfigs = tcConfigs;
       }
@@ -365,11 +365,11 @@ public class BackupManager implements ActiveMQComponent {
 
       private final DiscoveryGroupConfiguration discoveryGroupConfiguration;
 
-      public DiscoveryBackupConnector(DiscoveryGroupConfiguration discoveryGroupConfiguration,
-                                      String name,
-                                      TransportConfiguration connector,
-                                      long retryInterval,
-                                      ClusterManager clusterManager) {
+      private DiscoveryBackupConnector(DiscoveryGroupConfiguration discoveryGroupConfiguration,
+                                       String name,
+                                       TransportConfiguration connector,
+                                       long retryInterval,
+                                       ClusterManager clusterManager) {
          super(name, connector, retryInterval, clusterManager);
          this.discoveryGroupConfiguration = discoveryGroupConfiguration;
       }

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/ClusterController.java
----------------------------------------------------------------------
diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/ClusterController.java b/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/ClusterController.java
index f8579be..bdb17d6 100644
--- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/ClusterController.java
+++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/ClusterController.java
@@ -306,10 +306,10 @@ public class ClusterController implements ActiveMQComponent {
       private final ChannelHandler channelHandler;
       boolean authorized = false;
 
-      public ClusterControllerChannelHandler(Channel clusterChannel,
-                                             Acceptor acceptorUsed,
-                                             CoreRemotingConnection remotingConnection,
-                                             ChannelHandler channelHandler) {
+      private ClusterControllerChannelHandler(Channel clusterChannel,
+                                              Acceptor acceptorUsed,
+                                              CoreRemotingConnection remotingConnection,
+                                              ChannelHandler channelHandler) {
          this.clusterChannel = clusterChannel;
          this.acceptorUsed = acceptorUsed;
          this.remotingConnection = remotingConnection;
@@ -396,7 +396,7 @@ public class ClusterController implements ActiveMQComponent {
 
       private ServerLocatorInternal serverLocator;
 
-      public ConnectRunnable(ServerLocatorInternal serverLocator) {
+      private ConnectRunnable(ServerLocatorInternal serverLocator) {
          this.serverLocator = serverLocator;
       }
 

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/impl/BridgeImpl.java
----------------------------------------------------------------------
diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/impl/BridgeImpl.java b/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/impl/BridgeImpl.java
index 44e608c..a978be8 100644
--- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/impl/BridgeImpl.java
+++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/impl/BridgeImpl.java
@@ -1055,7 +1055,7 @@ public class BridgeImpl implements Bridge, SessionFailureListener, SendAcknowled
 
       private final Executor executor;
 
-      public FutureConnectRunnable(Executor exe, BridgeImpl bridge) {
+      private FutureConnectRunnable(Executor exe, BridgeImpl bridge) {
          executor = exe;
          this.bridge = bridge;
       }
@@ -1071,7 +1071,7 @@ public class BridgeImpl implements Bridge, SessionFailureListener, SendAcknowled
 
       private final BridgeImpl bridge;
 
-      public ConnectRunnable(BridgeImpl bridge2) {
+      private ConnectRunnable(BridgeImpl bridge2) {
          bridge = bridge2;
       }
 

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/impl/ClusterConnectionImpl.java
----------------------------------------------------------------------
diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/impl/ClusterConnectionImpl.java b/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/impl/ClusterConnectionImpl.java
index 2b09c4c..82b1e4f 100644
--- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/impl/ClusterConnectionImpl.java
+++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/impl/ClusterConnectionImpl.java
@@ -835,12 +835,12 @@ public final class ClusterConnectionImpl implements ClusterConnection, AfterConn
 
       private volatile boolean reset = false;
 
-      public MessageFlowRecordImpl(final ServerLocatorInternal targetLocator,
-                                   final long eventUID,
-                                   final String targetNodeID,
-                                   final TransportConfiguration connector,
-                                   final SimpleString queueName,
-                                   final Queue queue) {
+      private MessageFlowRecordImpl(final ServerLocatorInternal targetLocator,
+                                    final long eventUID,
+                                    final String targetNodeID,
+                                    final TransportConfiguration connector,
+                                    final SimpleString queueName,
+                                    final Queue queue) {
          this.targetLocator = targetLocator;
          this.queue = queue;
          this.targetNodeID = targetNodeID;
@@ -1418,7 +1418,7 @@ public final class ClusterConnectionImpl implements ClusterConnection, AfterConn
 
       private final TransportConfiguration[] tcConfigs;
 
-      public StaticClusterConnector(TransportConfiguration[] tcConfigs) {
+      private StaticClusterConnector(TransportConfiguration[] tcConfigs) {
          this.tcConfigs = tcConfigs;
       }
 
@@ -1446,7 +1446,7 @@ public final class ClusterConnectionImpl implements ClusterConnection, AfterConn
 
       private final DiscoveryGroupConfiguration dg;
 
-      public DiscoveryClusterConnector(DiscoveryGroupConfiguration dg) {
+      private DiscoveryClusterConnector(DiscoveryGroupConfiguration dg) {
          this.dg = dg;
       }
 

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/qourum/QuorumManager.java
----------------------------------------------------------------------
diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/qourum/QuorumManager.java b/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/qourum/QuorumManager.java
index d510b41..76a5d5e 100644
--- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/qourum/QuorumManager.java
+++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/qourum/QuorumManager.java
@@ -257,7 +257,7 @@ public final class QuorumManager implements ClusterTopologyListener, ActiveMQCom
       private final List<VoteRunnable> runnables;
       private int size;
 
-      public VoteRunnableHolder(QuorumVote quorumVote, List<VoteRunnable> runnables, int size) {
+      private VoteRunnableHolder(QuorumVote quorumVote, List<VoteRunnable> runnables, int size) {
          this.quorumVote = quorumVote;
 
          this.runnables = runnables;
@@ -282,7 +282,7 @@ public final class QuorumManager implements ClusterTopologyListener, ActiveMQCom
       private final QuorumVote quorumVote;
       private ClusterControl clusterControl;
 
-      public VoteRunnable(TransportConfiguration serverTC, QuorumVote quorumVote) {
+      private VoteRunnable(TransportConfiguration serverTC, QuorumVote quorumVote) {
          this.serverTC = serverTC;
          this.quorumVote = quorumVote;
       }


[3/7] activemq-artemis git commit: Fix checkstyle whitespace violation

Posted by cl...@apache.org.
Fix checkstyle whitespace violation


Project: http://git-wip-us.apache.org/repos/asf/activemq-artemis/repo
Commit: http://git-wip-us.apache.org/repos/asf/activemq-artemis/commit/d0d023b2
Tree: http://git-wip-us.apache.org/repos/asf/activemq-artemis/tree/d0d023b2
Diff: http://git-wip-us.apache.org/repos/asf/activemq-artemis/diff/d0d023b2

Branch: refs/heads/master
Commit: d0d023b26259a2c365b15a89ebbdf668d4ff87e1
Parents: e493748
Author: Ville Skytt� <vi...@iki.fi>
Authored: Mon Jun 13 18:22:33 2016 +0300
Committer: Ville Skytt� <vi...@iki.fi>
Committed: Mon Jun 13 18:22:33 2016 +0300

----------------------------------------------------------------------
 .../main/java/org/apache/activemq/artemis/ra/ActiveMQRALogger.java | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/d0d023b2/artemis-ra/src/main/java/org/apache/activemq/artemis/ra/ActiveMQRALogger.java
----------------------------------------------------------------------
diff --git a/artemis-ra/src/main/java/org/apache/activemq/artemis/ra/ActiveMQRALogger.java b/artemis-ra/src/main/java/org/apache/activemq/artemis/ra/ActiveMQRALogger.java
index 7853f09..93a7b97 100644
--- a/artemis-ra/src/main/java/org/apache/activemq/artemis/ra/ActiveMQRALogger.java
+++ b/artemis-ra/src/main/java/org/apache/activemq/artemis/ra/ActiveMQRALogger.java
@@ -86,7 +86,7 @@ public interface ActiveMQRALogger extends BasicLogger {
    void unableToRollbackTX();
 
    @LogMessage(level = Logger.Level.WARN)
-   @Message(id = 152003, value = "unable to reset session after failure, we will place the MDB Inflow now in setup mode for activation={0}" , format = Message.Format.MESSAGE_FORMAT)
+   @Message(id = 152003, value = "unable to reset session after failure, we will place the MDB Inflow now in setup mode for activation={0}", format = Message.Format.MESSAGE_FORMAT)
    void unableToResetSession(String spec, @Cause Exception e);
 
    @LogMessage(level = Logger.Level.WARN)


[4/7] activemq-artemis git commit: Fix checkstyle redundant modifier violations

Posted by cl...@apache.org.
http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/MessageConsumerTest.java
----------------------------------------------------------------------
diff --git a/tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/MessageConsumerTest.java b/tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/MessageConsumerTest.java
index 45e0f3c..abd8b1e 100644
--- a/tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/MessageConsumerTest.java
+++ b/tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/MessageConsumerTest.java
@@ -1976,10 +1976,10 @@ public class MessageConsumerTest extends JMSTestCase {
 
       final AtomicBoolean running;
 
-      public ThreadCloser(final AtomicBoolean running,
-                          final Object waitMonitor,
-                          final long timeToSleep,
-                          final MessageConsumer topicConsumer) {
+      private ThreadCloser(final AtomicBoolean running,
+                           final Object waitMonitor,
+                           final long timeToSleep,
+                           final MessageConsumer topicConsumer) {
          this.running = running;
          this.waitMonitor = waitMonitor;
          this.timeToSleep = timeToSleep;
@@ -2024,10 +2024,10 @@ public class MessageConsumerTest extends JMSTestCase {
 
       final AtomicBoolean running;
 
-      public ThreadReceiver(final AtomicBoolean running,
-                            final Object waitMonitor,
-                            final long timeToWait,
-                            final MessageConsumer topicConsumer) {
+      private ThreadReceiver(final AtomicBoolean running,
+                             final Object waitMonitor,
+                             final long timeToWait,
+                             final MessageConsumer topicConsumer) {
          this.running = running;
          this.waitMonitor = waitMonitor;
          this.timeToWait = timeToWait;
@@ -3819,7 +3819,7 @@ public class MessageConsumerTest extends JMSTestCase {
       private CountDownLatch latch;
       private JMSException exception;
 
-      public ConnectionCloseMessageListener(Connection conn, CountDownLatch latch) {
+      private ConnectionCloseMessageListener(Connection conn, CountDownLatch latch) {
          this.conn = conn;
          this.latch = latch;
       }
@@ -3842,7 +3842,7 @@ public class MessageConsumerTest extends JMSTestCase {
       private CountDownLatch latch;
       private JMSException exception;
 
-      public ConnectionStopMessageListener(Connection conn, CountDownLatch latch) {
+      private ConnectionStopMessageListener(Connection conn, CountDownLatch latch) {
          this.conn = conn;
          this.latch = latch;
       }
@@ -3865,7 +3865,7 @@ public class MessageConsumerTest extends JMSTestCase {
       private CountDownLatch latch;
       private JMSException exception;
 
-      public SessionCloseMessageListener(Session session, CountDownLatch latch) {
+      private SessionCloseMessageListener(Session session, CountDownLatch latch) {
          this.session = session;
          this.latch = latch;
       }
@@ -3904,7 +3904,7 @@ public class MessageConsumerTest extends JMSTestCase {
          ActiveMQTestBase.waitForLatch(latch);
       }
 
-      public ExceptionRedelMessageListenerImpl(final Session sess) {
+      private ExceptionRedelMessageListenerImpl(final Session sess) {
          this.sess = sess;
       }
 
@@ -3994,7 +3994,7 @@ public class MessageConsumerTest extends JMSTestCase {
 
       private final boolean transacted;
 
-      public RedelMessageListenerImpl(final boolean transacted) {
+      private RedelMessageListenerImpl(final boolean transacted) {
          this.transacted = transacted;
       }
 
@@ -4070,11 +4070,11 @@ public class MessageConsumerTest extends JMSTestCase {
 
       private CountDownLatch latch = new CountDownLatch(1);
 
-      public MessageListenerImpl(final int count) {
+      private MessageListenerImpl(final int count) {
          latch = new CountDownLatch(count);
       }
 
-      public MessageListenerImpl() {
+      private MessageListenerImpl() {
          this(1);
       }
 

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/MessageProducerTest.java
----------------------------------------------------------------------
diff --git a/tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/MessageProducerTest.java b/tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/MessageProducerTest.java
index 19bb908..a9ec1c4 100644
--- a/tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/MessageProducerTest.java
+++ b/tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/MessageProducerTest.java
@@ -735,7 +735,7 @@ public class MessageProducerTest extends JMSTestCase {
       private CountDownLatch latch;
       private JMSException exception;
 
-      public CloseCompletionListener(MessageProducer p, CountDownLatch latch) {
+      private CloseCompletionListener(MessageProducer p, CountDownLatch latch) {
          this.p = p;
          this.latch = latch;
       }
@@ -762,7 +762,7 @@ public class MessageProducerTest extends JMSTestCase {
       private JMSException exception;
       private Connection conn;
 
-      public ConnectionCloseCompletionListener(Connection conn, CountDownLatch latch) {
+      private ConnectionCloseCompletionListener(Connection conn, CountDownLatch latch) {
          this.conn = conn;
          this.latch = latch;
       }
@@ -789,7 +789,7 @@ public class MessageProducerTest extends JMSTestCase {
       private JMSException exception;
       private Session session;
 
-      public SessionCloseCompletionListener(Session session, CountDownLatch latch) {
+      private SessionCloseCompletionListener(Session session, CountDownLatch latch) {
          this.session = session;
          this.latch = latch;
       }

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/MiscellaneousTest.java
----------------------------------------------------------------------
diff --git a/tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/MiscellaneousTest.java b/tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/MiscellaneousTest.java
index 4febb3d..d2eb533 100644
--- a/tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/MiscellaneousTest.java
+++ b/tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/MiscellaneousTest.java
@@ -242,7 +242,7 @@ public class MiscellaneousTest extends JMSTestCase {
 
       private boolean resultSet;
 
-      public Result() {
+      private Result() {
          success = false;
          e = null;
       }

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/TransactedSessionTest.java
----------------------------------------------------------------------
diff --git a/tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/TransactedSessionTest.java b/tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/TransactedSessionTest.java
index b814d6e..6f31649 100644
--- a/tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/TransactedSessionTest.java
+++ b/tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/TransactedSessionTest.java
@@ -697,7 +697,7 @@ public class TransactedSessionTest extends JMSTestCase {
 
       private final Connection conn;
 
-      public myReceiver(CountDownLatch startLatch, Connection conn) {
+      myReceiver(CountDownLatch startLatch, Connection conn) {
          this.startLatch = startLatch;
          this.conn = conn;
       }

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/message/MessageHeaderTest.java
----------------------------------------------------------------------
diff --git a/tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/message/MessageHeaderTest.java b/tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/message/MessageHeaderTest.java
index cbb7a9d..ad2e8d2 100644
--- a/tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/message/MessageHeaderTest.java
+++ b/tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/message/MessageHeaderTest.java
@@ -836,7 +836,7 @@ public class MessageHeaderTest extends MessageHeaderTestBase {
 
       private final ClientMessage message;
 
-      public FakeSession(final ClientMessage message) {
+      FakeSession(final ClientMessage message) {
          this.message = message;
       }
 

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/tests/performance-tests/src/test/java/org/apache/activemq/artemis/tests/performance/paging/MeasurePagingMultiThreadTest.java
----------------------------------------------------------------------
diff --git a/tests/performance-tests/src/test/java/org/apache/activemq/artemis/tests/performance/paging/MeasurePagingMultiThreadTest.java b/tests/performance-tests/src/test/java/org/apache/activemq/artemis/tests/performance/paging/MeasurePagingMultiThreadTest.java
index 87645b8..e19b190 100644
--- a/tests/performance-tests/src/test/java/org/apache/activemq/artemis/tests/performance/paging/MeasurePagingMultiThreadTest.java
+++ b/tests/performance-tests/src/test/java/org/apache/activemq/artemis/tests/performance/paging/MeasurePagingMultiThreadTest.java
@@ -69,7 +69,7 @@ public class MeasurePagingMultiThreadTest extends ActiveMQTestBase {
 
             Throwable e;
 
-            public Sender() throws Exception {
+            Sender() throws Exception {
                session = factory.createSession(false, true, true);
                producer = session.createProducer(adr);
                msg = session.createMessage(true);

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/tests/performance-tests/src/test/java/org/apache/activemq/artemis/tests/performance/sends/AbstractSendReceivePerfTest.java
----------------------------------------------------------------------
diff --git a/tests/performance-tests/src/test/java/org/apache/activemq/artemis/tests/performance/sends/AbstractSendReceivePerfTest.java b/tests/performance-tests/src/test/java/org/apache/activemq/artemis/tests/performance/sends/AbstractSendReceivePerfTest.java
index 12d6229..be8093c 100644
--- a/tests/performance-tests/src/test/java/org/apache/activemq/artemis/tests/performance/sends/AbstractSendReceivePerfTest.java
+++ b/tests/performance-tests/src/test/java/org/apache/activemq/artemis/tests/performance/sends/AbstractSendReceivePerfTest.java
@@ -126,7 +126,7 @@ public abstract class AbstractSendReceivePerfTest extends JMSTestBase {
 
       public boolean failed = false;
 
-      public MessageReceiver(String qname, long numberOfSamples) throws Exception {
+      private MessageReceiver(String qname, long numberOfSamples) throws Exception {
          super("Receiver " + qname);
          this.qName = qname;
          this.numberOfSamples = numberOfSamples;
@@ -160,7 +160,7 @@ public abstract class AbstractSendReceivePerfTest extends JMSTestBase {
 
       public boolean failed = false;
 
-      public MessageSender(String qname) throws Exception {
+      private MessageSender(String qname) throws Exception {
          super("Sender " + qname);
 
          this.qName = qname;

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/tests/stress-tests/src/test/java/org/apache/activemq/artemis/tests/stress/journal/JournalCleanupCompactStressTest.java
----------------------------------------------------------------------
diff --git a/tests/stress-tests/src/test/java/org/apache/activemq/artemis/tests/stress/journal/JournalCleanupCompactStressTest.java b/tests/stress-tests/src/test/java/org/apache/activemq/artemis/tests/stress/journal/JournalCleanupCompactStressTest.java
index 6bd2fcf..ae2b2f1 100644
--- a/tests/stress-tests/src/test/java/org/apache/activemq/artemis/tests/stress/journal/JournalCleanupCompactStressTest.java
+++ b/tests/stress-tests/src/test/java/org/apache/activemq/artemis/tests/stress/journal/JournalCleanupCompactStressTest.java
@@ -301,7 +301,7 @@ public class JournalCleanupCompactStressTest extends ActiveMQTestBase {
 
       OperationContextImpl ctx = new OperationContextImpl(executorFactory.getExecutor());
 
-      public FastAppenderTx() {
+      FastAppenderTx() {
          super("FastAppenderTX");
       }
 
@@ -373,7 +373,7 @@ public class JournalCleanupCompactStressTest extends ActiveMQTestBase {
 
       OperationContextImpl ctx = new OperationContextImpl(executorFactory.getExecutor());
 
-      public FastUpdateTx(final LinkedBlockingDeque<Long> queue) {
+      FastUpdateTx(final LinkedBlockingDeque<Long> queue) {
          super("FastUpdateTX");
          this.queue = queue;
       }
@@ -475,7 +475,7 @@ public class JournalCleanupCompactStressTest extends ActiveMQTestBase {
     */
    class SlowAppenderNoTX extends Thread {
 
-      public SlowAppenderNoTX() {
+      SlowAppenderNoTX() {
          super("SlowAppender");
       }
 

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/tests/stress-tests/src/test/java/org/apache/activemq/artemis/tests/stress/remote/PingStressTest.java
----------------------------------------------------------------------
diff --git a/tests/stress-tests/src/test/java/org/apache/activemq/artemis/tests/stress/remote/PingStressTest.java b/tests/stress-tests/src/test/java/org/apache/activemq/artemis/tests/stress/remote/PingStressTest.java
index 9f717bd..9af6b90 100644
--- a/tests/stress-tests/src/test/java/org/apache/activemq/artemis/tests/stress/remote/PingStressTest.java
+++ b/tests/stress-tests/src/test/java/org/apache/activemq/artemis/tests/stress/remote/PingStressTest.java
@@ -100,7 +100,7 @@ public class PingStressTest extends ActiveMQTestBase {
 
          int threadNumber;
 
-         public LocalThread(final int i) {
+         LocalThread(final int i) {
             super("LocalThread i = " + i);
             threadNumber = i;
          }

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/tests/timing-tests/src/test/java/org/apache/activemq/artemis/tests/timing/jms/bridge/impl/JMSBridgeImplTest.java
----------------------------------------------------------------------
diff --git a/tests/timing-tests/src/test/java/org/apache/activemq/artemis/tests/timing/jms/bridge/impl/JMSBridgeImplTest.java b/tests/timing-tests/src/test/java/org/apache/activemq/artemis/tests/timing/jms/bridge/impl/JMSBridgeImplTest.java
index 9b5116e..d322a1a 100644
--- a/tests/timing-tests/src/test/java/org/apache/activemq/artemis/tests/timing/jms/bridge/impl/JMSBridgeImplTest.java
+++ b/tests/timing-tests/src/test/java/org/apache/activemq/artemis/tests/timing/jms/bridge/impl/JMSBridgeImplTest.java
@@ -745,7 +745,7 @@ public class JMSBridgeImplTest extends ActiveMQTestBase {
       private final ClassLoader original;
       private final String knownClass = "com.class.only.visible.to.tccl.SomeClass";
 
-      public MockContextClassLoader(ClassLoader parent) {
+      private MockContextClassLoader(ClassLoader parent) {
          super(parent);
          original = Thread.currentThread().getContextClassLoader();
       }

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/tests/unit-tests/src/test/java/org/apache/activemq/artemis/tests/unit/core/asyncio/MultiThreadAsynchronousFileTest.java
----------------------------------------------------------------------
diff --git a/tests/unit-tests/src/test/java/org/apache/activemq/artemis/tests/unit/core/asyncio/MultiThreadAsynchronousFileTest.java b/tests/unit-tests/src/test/java/org/apache/activemq/artemis/tests/unit/core/asyncio/MultiThreadAsynchronousFileTest.java
index 6c638ae..fb0f966 100644
--- a/tests/unit-tests/src/test/java/org/apache/activemq/artemis/tests/unit/core/asyncio/MultiThreadAsynchronousFileTest.java
+++ b/tests/unit-tests/src/test/java/org/apache/activemq/artemis/tests/unit/core/asyncio/MultiThreadAsynchronousFileTest.java
@@ -159,10 +159,10 @@ public class MultiThreadAsynchronousFileTest extends AIOTestBase {
 
       AIOSequentialFile libaio;
 
-      public ThreadProducer(final String name,
-                            final CountDownLatch latchStart,
-                            final AIOSequentialFile libaio,
-                            final boolean sync) {
+      ThreadProducer(final String name,
+                     final CountDownLatch latchStart,
+                     final AIOSequentialFile libaio,
+                     final boolean sync) {
          super(name);
          this.latchStart = latchStart;
          this.libaio = libaio;

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/tests/unit-tests/src/test/java/org/apache/activemq/artemis/tests/unit/core/paging/impl/PagingStoreImplTest.java
----------------------------------------------------------------------
diff --git a/tests/unit-tests/src/test/java/org/apache/activemq/artemis/tests/unit/core/paging/impl/PagingStoreImplTest.java b/tests/unit-tests/src/test/java/org/apache/activemq/artemis/tests/unit/core/paging/impl/PagingStoreImplTest.java
index 498beb4..97520f3 100644
--- a/tests/unit-tests/src/test/java/org/apache/activemq/artemis/tests/unit/core/paging/impl/PagingStoreImplTest.java
+++ b/tests/unit-tests/src/test/java/org/apache/activemq/artemis/tests/unit/core/paging/impl/PagingStoreImplTest.java
@@ -634,7 +634,7 @@ public class PagingStoreImplTest extends ActiveMQTestBase {
 
       class WriterThread extends Thread {
 
-         public WriterThread() {
+         WriterThread() {
             super("PageWriter");
          }
 
@@ -668,7 +668,7 @@ public class PagingStoreImplTest extends ActiveMQTestBase {
 
       class ReaderThread extends Thread {
 
-         public ReaderThread() {
+         ReaderThread() {
             super("PageReader");
          }
 
@@ -787,11 +787,11 @@ public class PagingStoreImplTest extends ActiveMQTestBase {
 
       final SequentialFileFactory factory;
 
-      public FakeStoreFactory() {
+      FakeStoreFactory() {
          factory = new FakeSequentialFileFactory();
       }
 
-      public FakeStoreFactory(final SequentialFileFactory factory) {
+      FakeStoreFactory(final SequentialFileFactory factory) {
          this.factory = factory;
       }
 

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/tests/unit-tests/src/test/java/org/apache/activemq/artemis/tests/unit/core/postoffice/impl/WildcardAddressManagerUnitTest.java
----------------------------------------------------------------------
diff --git a/tests/unit-tests/src/test/java/org/apache/activemq/artemis/tests/unit/core/postoffice/impl/WildcardAddressManagerUnitTest.java b/tests/unit-tests/src/test/java/org/apache/activemq/artemis/tests/unit/core/postoffice/impl/WildcardAddressManagerUnitTest.java
index 23b1c65..61783ac 100644
--- a/tests/unit-tests/src/test/java/org/apache/activemq/artemis/tests/unit/core/postoffice/impl/WildcardAddressManagerUnitTest.java
+++ b/tests/unit-tests/src/test/java/org/apache/activemq/artemis/tests/unit/core/postoffice/impl/WildcardAddressManagerUnitTest.java
@@ -84,11 +84,11 @@ public class WildcardAddressManagerUnitTest extends ActiveMQTestBase {
       final SimpleString address;
       final SimpleString id;
 
-      public BindingFake(String addressParameter, String id) {
+      BindingFake(String addressParameter, String id) {
          this(SimpleString.toSimpleString(addressParameter), SimpleString.toSimpleString(id));
       }
 
-      public BindingFake(SimpleString addressParameter, SimpleString id) {
+      BindingFake(SimpleString addressParameter, SimpleString id) {
          this.address = addressParameter;
          this.id = id;
       }

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/tests/unit-tests/src/test/java/org/apache/activemq/artemis/tests/unit/core/server/impl/QueueImplTest.java
----------------------------------------------------------------------
diff --git a/tests/unit-tests/src/test/java/org/apache/activemq/artemis/tests/unit/core/server/impl/QueueImplTest.java b/tests/unit-tests/src/test/java/org/apache/activemq/artemis/tests/unit/core/server/impl/QueueImplTest.java
index e21d6d9..b98c419 100644
--- a/tests/unit-tests/src/test/java/org/apache/activemq/artemis/tests/unit/core/server/impl/QueueImplTest.java
+++ b/tests/unit-tests/src/test/java/org/apache/activemq/artemis/tests/unit/core/server/impl/QueueImplTest.java
@@ -1219,10 +1219,10 @@ public class QueueImplTest extends ActiveMQTestBase {
 
       boolean first;
 
-      public AddtoQueueRunner(final boolean first,
-                              final QueueImpl queue,
-                              final MessageReference messageReference,
-                              final CountDownLatch countDownLatch) {
+      AddtoQueueRunner(final boolean first,
+                       final QueueImpl queue,
+                       final MessageReference messageReference,
+                       final CountDownLatch countDownLatch) {
          this.queue = queue;
          this.messageReference = messageReference;
          this.countDownLatch = countDownLatch;


[2/7] activemq-artemis git commit: Fix checkstyle curly brace violations

Posted by cl...@apache.org.
Fix checkstyle curly brace violations


Project: http://git-wip-us.apache.org/repos/asf/activemq-artemis/repo
Commit: http://git-wip-us.apache.org/repos/asf/activemq-artemis/commit/e4937480
Tree: http://git-wip-us.apache.org/repos/asf/activemq-artemis/tree/e4937480
Diff: http://git-wip-us.apache.org/repos/asf/activemq-artemis/diff/e4937480

Branch: refs/heads/master
Commit: e4937480405d46a28ae36b4167c1680dd4a62386
Parents: fb56cc7
Author: Ville Skytt� <vi...@iki.fi>
Authored: Mon Jun 13 18:21:43 2016 +0300
Committer: Ville Skytt� <vi...@iki.fi>
Committed: Mon Jun 13 18:21:43 2016 +0300

----------------------------------------------------------------------
 .../activemq/artemis/cli/commands/tools/XmlDataImporter.java   | 3 +--
 .../artemis/core/buffers/impl/ChannelBufferWrapper.java        | 4 ++--
 .../main/java/org/apache/activemq/artemis/utils/Base64.java    | 3 +--
 .../activemq/artemis/core/client/impl/ClientSessionImpl.java   | 6 ++----
 .../artemis/core/client/impl/LargeMessageControllerImpl.java   | 3 +--
 .../artemis/tests/unit/core/remoting/AcceptorsTest.java        | 3 +--
 6 files changed, 8 insertions(+), 14 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/e4937480/artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/tools/XmlDataImporter.java
----------------------------------------------------------------------
diff --git a/artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/tools/XmlDataImporter.java b/artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/tools/XmlDataImporter.java
index e75aef8..694525d 100644
--- a/artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/tools/XmlDataImporter.java
+++ b/artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/tools/XmlDataImporter.java
@@ -454,8 +454,7 @@ public final class XmlDataImporter extends ActionAbstract {
                else {
                   String characters = new String(reader.getTextCharacters(), reader.getTextStart(), reader.getTextLength());
                   String trimmedCharacters = characters.trim();
-                  if (trimmedCharacters.length() > 0)  // this will skip "indentation" characters
-                  {
+                  if (trimmedCharacters.length() > 0) { // this will skip "indentation" characters
                      byte[] data = decode(trimmedCharacters);
                      out.write(data);
                   }

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/e4937480/artemis-commons/src/main/java/org/apache/activemq/artemis/core/buffers/impl/ChannelBufferWrapper.java
----------------------------------------------------------------------
diff --git a/artemis-commons/src/main/java/org/apache/activemq/artemis/core/buffers/impl/ChannelBufferWrapper.java b/artemis-commons/src/main/java/org/apache/activemq/artemis/core/buffers/impl/ChannelBufferWrapper.java
index 5c0cbdd..aea9867 100644
--- a/artemis-commons/src/main/java/org/apache/activemq/artemis/core/buffers/impl/ChannelBufferWrapper.java
+++ b/artemis-commons/src/main/java/org/apache/activemq/artemis/core/buffers/impl/ChannelBufferWrapper.java
@@ -34,8 +34,8 @@ public class ChannelBufferWrapper implements ActiveMQBuffer {
 
    public static ByteBuf unwrap(ByteBuf buffer) {
       ByteBuf parent;
-      while ((parent = buffer.unwrap()) != null && parent != buffer) // this last part is just in case the semantic
-      {                         // ever changes where unwrap is returning itself
+      while ((parent = buffer.unwrap()) != null && parent != buffer) { // this last part is just in case the semantic
+                                                                       // ever changes where unwrap is returning itself
          buffer = parent;
       }
 

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/e4937480/artemis-commons/src/main/java/org/apache/activemq/artemis/utils/Base64.java
----------------------------------------------------------------------
diff --git a/artemis-commons/src/main/java/org/apache/activemq/artemis/utils/Base64.java b/artemis-commons/src/main/java/org/apache/activemq/artemis/utils/Base64.java
index 5284246..8379fdf 100644
--- a/artemis-commons/src/main/java/org/apache/activemq/artemis/utils/Base64.java
+++ b/artemis-commons/src/main/java/org/apache/activemq/artemis/utils/Base64.java
@@ -847,8 +847,7 @@ public class Base64 {
          sbiCrop = (byte) (source[i] & 0x7f); // Only the low seven bits
          sbiDecode = DECODABET[sbiCrop];
 
-         if (sbiDecode >= Base64.WHITE_SPACE_ENC) // White space, Equals sign or better
-         {
+         if (sbiDecode >= Base64.WHITE_SPACE_ENC) { // White space, Equals sign or better
             if (sbiDecode >= Base64.EQUALS_SIGN_ENC) {
                b4[b4Posn++] = sbiCrop;
                if (b4Posn > 3) {

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/e4937480/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientSessionImpl.java
----------------------------------------------------------------------
diff --git a/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientSessionImpl.java b/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientSessionImpl.java
index c329bbd..bec10fb 100644
--- a/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientSessionImpl.java
+++ b/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientSessionImpl.java
@@ -543,13 +543,11 @@ public final class ClientSessionImpl implements ClientSessionInternal, FailureLi
    }
 
    @Override
-   public void rollback(final boolean isLastMessageAsDelivered) throws ActiveMQException
-   {
+   public void rollback(final boolean isLastMessageAsDelivered) throws ActiveMQException {
       rollback(isLastMessageAsDelivered, true);
    }
 
-   public void rollback(final boolean isLastMessageAsDelivered, final boolean waitConsumers) throws ActiveMQException
-   {
+   public void rollback(final boolean isLastMessageAsDelivered, final boolean waitConsumers) throws ActiveMQException {
       if (logger.isTraceEnabled()) {
          logger.trace("calling rollback(isLastMessageAsDelivered=" + isLastMessageAsDelivered + ")");
       }

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/e4937480/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/LargeMessageControllerImpl.java
----------------------------------------------------------------------
diff --git a/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/LargeMessageControllerImpl.java b/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/LargeMessageControllerImpl.java
index 77134ee..c3b18a3 100644
--- a/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/LargeMessageControllerImpl.java
+++ b/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/LargeMessageControllerImpl.java
@@ -1094,8 +1094,7 @@ public class LargeMessageControllerImpl implements LargeMessageController {
             throw new IndexOutOfBoundsException();
          }
 
-         if (currentPacket.chunk == null) // Empty packet as a signal to interruption
-         {
+         if (currentPacket.chunk == null) { // Empty packet as a signal to interruption
             currentPacket = null;
             streamEnded = true;
             throw new IndexOutOfBoundsException();

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/e4937480/tests/unit-tests/src/test/java/org/apache/activemq/artemis/tests/unit/core/remoting/AcceptorsTest.java
----------------------------------------------------------------------
diff --git a/tests/unit-tests/src/test/java/org/apache/activemq/artemis/tests/unit/core/remoting/AcceptorsTest.java b/tests/unit-tests/src/test/java/org/apache/activemq/artemis/tests/unit/core/remoting/AcceptorsTest.java
index f6aae80..6889393 100644
--- a/tests/unit-tests/src/test/java/org/apache/activemq/artemis/tests/unit/core/remoting/AcceptorsTest.java
+++ b/tests/unit-tests/src/test/java/org/apache/activemq/artemis/tests/unit/core/remoting/AcceptorsTest.java
@@ -31,8 +31,7 @@ import org.junit.Test;
 public class AcceptorsTest extends ActiveMQTestBase {
 
    @Test
-   public void testMultipleAcceptorsWithSameHostPortDifferentName() throws Exception
-   {
+   public void testMultipleAcceptorsWithSameHostPortDifferentName() throws Exception {
       final String acceptorFactoryClass = FakeAcceptorFactory.class.getName();
 
       Map<String, Object> params = new HashMap<>();


[5/7] activemq-artemis git commit: Fix checkstyle redundant modifier violations

Posted by cl...@apache.org.
http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/BackupTopologyListener.java
----------------------------------------------------------------------
diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/BackupTopologyListener.java b/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/BackupTopologyListener.java
index f00bf4b..9b70f27 100644
--- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/BackupTopologyListener.java
+++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/BackupTopologyListener.java
@@ -32,7 +32,7 @@ final class BackupTopologyListener implements ClusterTopologyListener {
    // Transport configuration of this node
    private final TransportConfiguration myTc;
 
-   public BackupTopologyListener(String ownId, TransportConfiguration nodeTransportConfig) {
+   BackupTopologyListener(String ownId, TransportConfiguration nodeTransportConfig) {
       this.ownId = ownId;
       this.myTc = nodeTransportConfig;
    }

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ColocatedActivation.java
----------------------------------------------------------------------
diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ColocatedActivation.java b/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ColocatedActivation.java
index 4428136..b81abb7 100644
--- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ColocatedActivation.java
+++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ColocatedActivation.java
@@ -169,7 +169,7 @@ public class ColocatedActivation extends LiveActivation {
       //the available nodes that we can request
       private final List<Pair<String, Integer>> nodes = new ArrayList<>();
 
-      public RequestBackupQuorumVote() {
+      private RequestBackupQuorumVote() {
          super(REQUEST_BACKUP_QUORUM_VOTE);
       }
 
@@ -249,11 +249,11 @@ public class ColocatedActivation extends LiveActivation {
       private String nodeID;
       private boolean backupAvailable;
 
-      public RequestBackupVote() {
+      RequestBackupVote() {
          backupsSize = -1;
       }
 
-      public RequestBackupVote(int backupsSize, String nodeID, boolean backupAvailable) {
+      RequestBackupVote(int backupsSize, String nodeID, boolean backupAvailable) {
          this.backupsSize = backupsSize;
          this.nodeID = nodeID;
          this.backupAvailable = backupAvailable;

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java
----------------------------------------------------------------------
diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java b/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java
index 00b7a3c..eaf7656 100644
--- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java
+++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java
@@ -2708,7 +2708,7 @@ public class QueueImpl implements Queue {
 
       final boolean scheduleExpiry;
 
-      public DepageRunner(boolean scheduleExpiry) {
+      private DepageRunner(boolean scheduleExpiry) {
          this.scheduleExpiry = scheduleExpiry;
       }
 
@@ -2785,7 +2785,7 @@ public class QueueImpl implements Queue {
 
       Iterator lastIterator = null;
 
-      public TotalQueueIterator() {
+      private TotalQueueIterator() {
          if (pageSubscription != null) {
             pageIter = pageSubscription.iterator();
          }
@@ -2911,7 +2911,7 @@ public class QueueImpl implements Queue {
       private float threshold;
       private long checkPeriod;
 
-      public SlowConsumerReaperRunnable(long checkPeriod, float threshold, SlowConsumerPolicy policy) {
+      private SlowConsumerReaperRunnable(long checkPeriod, float threshold, SlowConsumerPolicy policy) {
          this.checkPeriod = checkPeriod;
          this.policy = policy;
          this.threshold = threshold;

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ReplicationError.java
----------------------------------------------------------------------
diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ReplicationError.java b/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ReplicationError.java
index 63af112..55c5ada 100644
--- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ReplicationError.java
+++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ReplicationError.java
@@ -39,7 +39,7 @@ final class ReplicationError implements Interceptor {
    private final ActiveMQServer server;
    private LiveNodeLocator nodeLocator;
 
-   public ReplicationError(ActiveMQServer server, LiveNodeLocator nodeLocator) {
+   ReplicationError(ActiveMQServer server, LiveNodeLocator nodeLocator) {
       this.server = server;
       this.nodeLocator = nodeLocator;
    }

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ScheduledDeliveryHandlerImpl.java
----------------------------------------------------------------------
diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ScheduledDeliveryHandlerImpl.java b/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ScheduledDeliveryHandlerImpl.java
index 25f4aa0..b70c1b1 100644
--- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ScheduledDeliveryHandlerImpl.java
+++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ScheduledDeliveryHandlerImpl.java
@@ -165,7 +165,7 @@ public class ScheduledDeliveryHandlerImpl implements ScheduledDeliveryHandler {
 
       long deliveryTime;
 
-      public ScheduledDeliveryRunnable(final long deliveryTime) {
+      private ScheduledDeliveryRunnable(final long deliveryTime) {
          this.deliveryTime = deliveryTime;
       }
 

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ServerConsumerImpl.java
----------------------------------------------------------------------
diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ServerConsumerImpl.java b/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ServerConsumerImpl.java
index ae1f5b1..7de9fc5 100644
--- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ServerConsumerImpl.java
+++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ServerConsumerImpl.java
@@ -1094,7 +1094,7 @@ public class ServerConsumerImpl implements ServerConsumer, ReadyListener {
 
       private BodyEncoder context;
 
-      public LargeMessageDeliverer(final LargeServerMessage message, final MessageReference ref) throws Exception {
+      private LargeMessageDeliverer(final LargeServerMessage message, final MessageReference ref) throws Exception {
          largeMessage = message;
 
          largeMessage.incrementDelayDeletionCount();

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/SharedNothingLiveActivation.java
----------------------------------------------------------------------
diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/SharedNothingLiveActivation.java b/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/SharedNothingLiveActivation.java
index fcc6792..3e0d812 100644
--- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/SharedNothingLiveActivation.java
+++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/SharedNothingLiveActivation.java
@@ -363,7 +363,7 @@ public class SharedNothingLiveActivation extends LiveActivation {
       private final SimpleString nodeId;
       private final CountDownLatch latch = new CountDownLatch(1);
 
-      public NodeIdListener(SimpleString nodeId) {
+      NodeIdListener(SimpleString nodeId) {
          this.nodeId = nodeId;
       }
 

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/artemis-server/src/main/java/org/apache/activemq/artemis/core/transaction/Transaction.java
----------------------------------------------------------------------
diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/transaction/Transaction.java b/artemis-server/src/main/java/org/apache/activemq/artemis/core/transaction/Transaction.java
index 33c1eea..65b7339 100644
--- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/transaction/Transaction.java
+++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/transaction/Transaction.java
@@ -29,7 +29,7 @@ import org.apache.activemq.artemis.core.server.impl.RefsOperation;
  */
 public interface Transaction {
 
-   static enum State {
+   enum State {
       ACTIVE, PREPARED, COMMITTED, ROLLEDBACK, SUSPENDED, ROLLBACK_ONLY
    }
 

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/artemis-server/src/main/java/org/apache/activemq/artemis/core/transaction/impl/ResourceManagerImpl.java
----------------------------------------------------------------------
diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/transaction/impl/ResourceManagerImpl.java b/artemis-server/src/main/java/org/apache/activemq/artemis/core/transaction/impl/ResourceManagerImpl.java
index 51f8c49..ff41515 100644
--- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/transaction/impl/ResourceManagerImpl.java
+++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/transaction/impl/ResourceManagerImpl.java
@@ -242,7 +242,7 @@ public class ResourceManagerImpl implements ResourceManager {
 
       public final long recordID;
 
-      public HeuristicCompletionHolder(final long recordID, final Xid xid, final boolean isCommit) {
+      private HeuristicCompletionHolder(final long recordID, final Xid xid, final boolean isCommit) {
          this.recordID = recordID;
          this.xid = xid;
          this.isCommit = isCommit;

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/artemis-server/src/test/java/org/apache/activemq/artemis/core/security/jaas/PropertiesLoginModuleTest.java
----------------------------------------------------------------------
diff --git a/artemis-server/src/test/java/org/apache/activemq/artemis/core/security/jaas/PropertiesLoginModuleTest.java b/artemis-server/src/test/java/org/apache/activemq/artemis/core/security/jaas/PropertiesLoginModuleTest.java
index 8d53472..777ba50 100644
--- a/artemis-server/src/test/java/org/apache/activemq/artemis/core/security/jaas/PropertiesLoginModuleTest.java
+++ b/artemis-server/src/test/java/org/apache/activemq/artemis/core/security/jaas/PropertiesLoginModuleTest.java
@@ -141,7 +141,7 @@ public class PropertiesLoginModuleTest extends Assert {
       private final String user;
       private final String pass;
 
-      public UserPassHandler(final String user, final String pass) {
+      private UserPassHandler(final String user, final String pass) {
          this.user = user;
          this.pass = pass;
       }

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/artemis-server/src/test/java/org/apache/activemq/artemis/core/server/cluster/impl/BroadcastGroupImplTest.java
----------------------------------------------------------------------
diff --git a/artemis-server/src/test/java/org/apache/activemq/artemis/core/server/cluster/impl/BroadcastGroupImplTest.java b/artemis-server/src/test/java/org/apache/activemq/artemis/core/server/cluster/impl/BroadcastGroupImplTest.java
index b7ed643..222a11b 100644
--- a/artemis-server/src/test/java/org/apache/activemq/artemis/core/server/cluster/impl/BroadcastGroupImplTest.java
+++ b/artemis-server/src/test/java/org/apache/activemq/artemis/core/server/cluster/impl/BroadcastGroupImplTest.java
@@ -42,7 +42,7 @@ public class BroadcastGroupImplTest extends ActiveMQTestBase {
    static class BroadcastEndpointImpl implements BroadcastEndpoint {
       private BroadcastEndpointFactoryImpl factory;
 
-      public BroadcastEndpointImpl(BroadcastEndpointFactoryImpl factory) {
+      BroadcastEndpointImpl(BroadcastEndpointFactoryImpl factory) {
          this.factory = factory;
       }
 

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/artemis-server/src/test/java/org/apache/activemq/artemis/core/server/impl/ScheduledDeliveryHandlerTest.java
----------------------------------------------------------------------
diff --git a/artemis-server/src/test/java/org/apache/activemq/artemis/core/server/impl/ScheduledDeliveryHandlerTest.java b/artemis-server/src/test/java/org/apache/activemq/artemis/core/server/impl/ScheduledDeliveryHandlerTest.java
index 71e04f9..c489e12 100644
--- a/artemis-server/src/test/java/org/apache/activemq/artemis/core/server/impl/ScheduledDeliveryHandlerTest.java
+++ b/artemis-server/src/test/java/org/apache/activemq/artemis/core/server/impl/ScheduledDeliveryHandlerTest.java
@@ -288,7 +288,7 @@ public class ScheduledDeliveryHandlerTest extends Assert {
 
       final long id;
 
-      public FakeMessage(final long id) {
+      FakeMessage(final long id) {
          this.id = id;
       }
 

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/artemis-server/src/test/java/org/apache/activemq/artemis/core/settings/RepositoryTest.java
----------------------------------------------------------------------
diff --git a/artemis-server/src/test/java/org/apache/activemq/artemis/core/settings/RepositoryTest.java b/artemis-server/src/test/java/org/apache/activemq/artemis/core/settings/RepositoryTest.java
index 06acede..b7563e1 100644
--- a/artemis-server/src/test/java/org/apache/activemq/artemis/core/settings/RepositoryTest.java
+++ b/artemis-server/src/test/java/org/apache/activemq/artemis/core/settings/RepositoryTest.java
@@ -247,7 +247,7 @@ public class RepositoryTest extends ActiveMQTestBase {
          return DummyMergeable.merged.contains(i);
       }
 
-      public DummyMergeable(final Integer id) {
+      DummyMergeable(final Integer id) {
          this.id = id;
       }
 

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/artemis-server/src/test/java/org/apache/activemq/artemis/tests/util/ActiveMQTestBase.java
----------------------------------------------------------------------
diff --git a/artemis-server/src/test/java/org/apache/activemq/artemis/tests/util/ActiveMQTestBase.java b/artemis-server/src/test/java/org/apache/activemq/artemis/tests/util/ActiveMQTestBase.java
index 3e4d4c0..eee1719 100644
--- a/artemis-server/src/test/java/org/apache/activemq/artemis/tests/util/ActiveMQTestBase.java
+++ b/artemis-server/src/test/java/org/apache/activemq/artemis/tests/util/ActiveMQTestBase.java
@@ -1803,7 +1803,7 @@ public abstract class ActiveMQTestBase extends Assert {
       /**
        * @param recordsType
        */
-      public RecordTypeCounter(HashMap<Integer, AtomicInteger> recordsType) {
+      private RecordTypeCounter(HashMap<Integer, AtomicInteger> recordsType) {
          this.recordsType = recordsType;
       }
 

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/artemis-web/src/test/java/org/apache/activemq/cli/test/WebServerComponentTest.java
----------------------------------------------------------------------
diff --git a/artemis-web/src/test/java/org/apache/activemq/cli/test/WebServerComponentTest.java b/artemis-web/src/test/java/org/apache/activemq/cli/test/WebServerComponentTest.java
index f1d2abd..723e4ff 100644
--- a/artemis-web/src/test/java/org/apache/activemq/cli/test/WebServerComponentTest.java
+++ b/artemis-web/src/test/java/org/apache/activemq/cli/test/WebServerComponentTest.java
@@ -99,7 +99,7 @@ public class WebServerComponentTest extends Assert {
       private CountDownLatch latch;
       private String body;
 
-      public ClientHandler(CountDownLatch latch) {
+      ClientHandler(CountDownLatch latch) {
          this.latch = latch;
       }
 

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/examples/features/perf/perf/src/main/java/org/apache/activemq/artemis/jms/example/PerfBase.java
----------------------------------------------------------------------
diff --git a/examples/features/perf/perf/src/main/java/org/apache/activemq/artemis/jms/example/PerfBase.java b/examples/features/perf/perf/src/main/java/org/apache/activemq/artemis/jms/example/PerfBase.java
index 2ef0282..0b3e741 100644
--- a/examples/features/perf/perf/src/main/java/org/apache/activemq/artemis/jms/example/PerfBase.java
+++ b/examples/features/perf/perf/src/main/java/org/apache/activemq/artemis/jms/example/PerfBase.java
@@ -361,7 +361,7 @@ public abstract class PerfBase {
 
       private final AtomicLong count = new AtomicLong(0);
 
-      public PerfListener(final CountDownLatch countDownLatch, final PerfParams perfParams) {
+      private PerfListener(final CountDownLatch countDownLatch, final PerfParams perfParams) {
          this.countDownLatch = countDownLatch;
          this.perfParams = perfParams;
          warmingUp = perfParams.getNoOfWarmupMessages() > 0;

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/examples/features/standard/message-group/src/main/java/org/apache/activemq/artemis/jms/example/MessageGroupExample.java
----------------------------------------------------------------------
diff --git a/examples/features/standard/message-group/src/main/java/org/apache/activemq/artemis/jms/example/MessageGroupExample.java b/examples/features/standard/message-group/src/main/java/org/apache/activemq/artemis/jms/example/MessageGroupExample.java
index 4db7618..f8ee48a 100644
--- a/examples/features/standard/message-group/src/main/java/org/apache/activemq/artemis/jms/example/MessageGroupExample.java
+++ b/examples/features/standard/message-group/src/main/java/org/apache/activemq/artemis/jms/example/MessageGroupExample.java
@@ -104,7 +104,7 @@ class SimpleMessageListener implements MessageListener {
    private final String name;
    private final Map<String, String> messageReceiverMap;
 
-   public SimpleMessageListener(final String listenerName, Map<String, String> messageReceiverMap) {
+   SimpleMessageListener(final String listenerName, Map<String, String> messageReceiverMap) {
       name = listenerName;
       this.messageReceiverMap = messageReceiverMap;
    }

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/examples/features/standard/message-group2/src/main/java/org/apache/activemq/artemis/jms/example/MessageGroup2Example.java
----------------------------------------------------------------------
diff --git a/examples/features/standard/message-group2/src/main/java/org/apache/activemq/artemis/jms/example/MessageGroup2Example.java b/examples/features/standard/message-group2/src/main/java/org/apache/activemq/artemis/jms/example/MessageGroup2Example.java
index 717c454..4b24928 100644
--- a/examples/features/standard/message-group2/src/main/java/org/apache/activemq/artemis/jms/example/MessageGroup2Example.java
+++ b/examples/features/standard/message-group2/src/main/java/org/apache/activemq/artemis/jms/example/MessageGroup2Example.java
@@ -111,7 +111,7 @@ class SimpleMessageListener implements MessageListener {
    private final String name;
    final Map<String, String> messageReceiverMap;
 
-   public SimpleMessageListener(String listenerName, Map<String, String> messageReceiverMap) {
+   SimpleMessageListener(String listenerName, Map<String, String> messageReceiverMap) {
       name = listenerName;
       this.messageReceiverMap = messageReceiverMap;
    }

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/examples/features/standard/message-priority/src/main/java/org/apache/activemq/artemis/jms/example/MessagePriorityExample.java
----------------------------------------------------------------------
diff --git a/examples/features/standard/message-priority/src/main/java/org/apache/activemq/artemis/jms/example/MessagePriorityExample.java b/examples/features/standard/message-priority/src/main/java/org/apache/activemq/artemis/jms/example/MessagePriorityExample.java
index b879615..1ef0f71 100644
--- a/examples/features/standard/message-priority/src/main/java/org/apache/activemq/artemis/jms/example/MessagePriorityExample.java
+++ b/examples/features/standard/message-priority/src/main/java/org/apache/activemq/artemis/jms/example/MessagePriorityExample.java
@@ -115,7 +115,7 @@ class SimpleMessageListener implements MessageListener {
    ArrayList<TextMessage> msgReceived;
    AtomicBoolean result;
 
-   public SimpleMessageListener(ArrayList<TextMessage> msgReceived, AtomicBoolean result) {
+   SimpleMessageListener(ArrayList<TextMessage> msgReceived, AtomicBoolean result) {
       this.msgReceived = msgReceived;
       this.result = result;
    }

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/examples/features/standard/queue-selector/src/main/java/org/apache/activemq/artemis/jms/example/QueueSelectorExample.java
----------------------------------------------------------------------
diff --git a/examples/features/standard/queue-selector/src/main/java/org/apache/activemq/artemis/jms/example/QueueSelectorExample.java b/examples/features/standard/queue-selector/src/main/java/org/apache/activemq/artemis/jms/example/QueueSelectorExample.java
index 3f8f9fd..b915dd0 100644
--- a/examples/features/standard/queue-selector/src/main/java/org/apache/activemq/artemis/jms/example/QueueSelectorExample.java
+++ b/examples/features/standard/queue-selector/src/main/java/org/apache/activemq/artemis/jms/example/QueueSelectorExample.java
@@ -117,7 +117,7 @@ class SimpleMessageListener implements MessageListener {
    private final String name;
    private AtomicBoolean result;
 
-   public SimpleMessageListener(final String listener, AtomicBoolean result) {
+   SimpleMessageListener(final String listener, AtomicBoolean result) {
       name = listener;
       this.result = result;
    }

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/examples/features/standard/static-selector/src/main/java/org/apache/activemq/artemis/jms/example/StaticSelectorExample.java
----------------------------------------------------------------------
diff --git a/examples/features/standard/static-selector/src/main/java/org/apache/activemq/artemis/jms/example/StaticSelectorExample.java b/examples/features/standard/static-selector/src/main/java/org/apache/activemq/artemis/jms/example/StaticSelectorExample.java
index f3d82f5..627ef7d 100644
--- a/examples/features/standard/static-selector/src/main/java/org/apache/activemq/artemis/jms/example/StaticSelectorExample.java
+++ b/examples/features/standard/static-selector/src/main/java/org/apache/activemq/artemis/jms/example/StaticSelectorExample.java
@@ -111,7 +111,7 @@ class SimpleMessageListener implements MessageListener {
    private final String name;
    private AtomicBoolean result;
 
-   public SimpleMessageListener(final String listener, AtomicBoolean result) {
+   SimpleMessageListener(final String listener, AtomicBoolean result) {
       name = listener;
       this.result = result;
    }

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/examples/features/standard/topic-selector-example2/src/main/java/org/apache/activemq/artemis/jms/example/TopicSelectorExample2.java
----------------------------------------------------------------------
diff --git a/examples/features/standard/topic-selector-example2/src/main/java/org/apache/activemq/artemis/jms/example/TopicSelectorExample2.java b/examples/features/standard/topic-selector-example2/src/main/java/org/apache/activemq/artemis/jms/example/TopicSelectorExample2.java
index 97ece3f..037e5fb 100644
--- a/examples/features/standard/topic-selector-example2/src/main/java/org/apache/activemq/artemis/jms/example/TopicSelectorExample2.java
+++ b/examples/features/standard/topic-selector-example2/src/main/java/org/apache/activemq/artemis/jms/example/TopicSelectorExample2.java
@@ -119,7 +119,7 @@ class SimpleMessageListener implements MessageListener {
    private final String name;
    AtomicBoolean result;
 
-   public SimpleMessageListener(final String listener, AtomicBoolean result) {
+   SimpleMessageListener(final String listener, AtomicBoolean result) {
       name = listener;
       this.result = result;
    }

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/examples/features/standard/xa-send/src/main/java/org/apache/activemq/artemis/jms/example/XASendExample.java
----------------------------------------------------------------------
diff --git a/examples/features/standard/xa-send/src/main/java/org/apache/activemq/artemis/jms/example/XASendExample.java b/examples/features/standard/xa-send/src/main/java/org/apache/activemq/artemis/jms/example/XASendExample.java
index 53fed86..769727b 100644
--- a/examples/features/standard/xa-send/src/main/java/org/apache/activemq/artemis/jms/example/XASendExample.java
+++ b/examples/features/standard/xa-send/src/main/java/org/apache/activemq/artemis/jms/example/XASendExample.java
@@ -173,7 +173,7 @@ class SimpleMessageListener implements MessageListener {
    ArrayList<String> receiveHolder;
    AtomicBoolean result;
 
-   public SimpleMessageListener(ArrayList<String> receiveHolder, AtomicBoolean result) {
+   SimpleMessageListener(ArrayList<String> receiveHolder, AtomicBoolean result) {
       this.receiveHolder = receiveHolder;
       this.result = result;
    }

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/integration/activemq-aerogear-integration/src/main/java/org/apache/activemq/artemis/integration/aerogear/AeroGearConnectorService.java
----------------------------------------------------------------------
diff --git a/integration/activemq-aerogear-integration/src/main/java/org/apache/activemq/artemis/integration/aerogear/AeroGearConnectorService.java b/integration/activemq-aerogear-integration/src/main/java/org/apache/activemq/artemis/integration/aerogear/AeroGearConnectorService.java
index 0be4cd0..1fb3ca1 100644
--- a/integration/activemq-aerogear-integration/src/main/java/org/apache/activemq/artemis/integration/aerogear/AeroGearConnectorService.java
+++ b/integration/activemq-aerogear-integration/src/main/java/org/apache/activemq/artemis/integration/aerogear/AeroGearConnectorService.java
@@ -315,7 +315,7 @@ public class AeroGearConnectorService implements ConnectorService, Consumer, Mes
 
       private int retryAttempt;
 
-      public ReconnectRunnable(int retryAttempt) {
+      private ReconnectRunnable(int retryAttempt) {
          this.retryAttempt = retryAttempt;
       }
 

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/tests/extra-tests/src/test/java/org/apache/activemq/artemis/tests/extras/byteman/HierarchicalObjectRepositoryTest.java
----------------------------------------------------------------------
diff --git a/tests/extra-tests/src/test/java/org/apache/activemq/artemis/tests/extras/byteman/HierarchicalObjectRepositoryTest.java b/tests/extra-tests/src/test/java/org/apache/activemq/artemis/tests/extras/byteman/HierarchicalObjectRepositoryTest.java
index 50a6268..d981aa9 100644
--- a/tests/extra-tests/src/test/java/org/apache/activemq/artemis/tests/extras/byteman/HierarchicalObjectRepositoryTest.java
+++ b/tests/extra-tests/src/test/java/org/apache/activemq/artemis/tests/extras/byteman/HierarchicalObjectRepositoryTest.java
@@ -73,7 +73,7 @@ public class HierarchicalObjectRepositoryTest {
 
       private final int code;
 
-      public Clearer(int code) {
+      private Clearer(int code) {
          this.code = code;
       }
 

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/aerogear/AeroGearBasicServerTest.java
----------------------------------------------------------------------
diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/aerogear/AeroGearBasicServerTest.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/aerogear/AeroGearBasicServerTest.java
index 6882ca0..ded85ec 100644
--- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/aerogear/AeroGearBasicServerTest.java
+++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/aerogear/AeroGearBasicServerTest.java
@@ -203,7 +203,7 @@ public class AeroGearBasicServerTest extends ActiveMQTestBase {
       JSONObject jsonObject;
       private CountDownLatch latch;
 
-      public AeroGearHandler(CountDownLatch latch) {
+      AeroGearHandler(CountDownLatch latch) {
          this.latch = latch;
       }
 

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/AutogroupIdTest.java
----------------------------------------------------------------------
diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/AutogroupIdTest.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/AutogroupIdTest.java
index 97e0a87..487edfb 100644
--- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/AutogroupIdTest.java
+++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/AutogroupIdTest.java
@@ -203,7 +203,7 @@ public class AutogroupIdTest extends ActiveMQTestBase {
 
       private final CountDownLatch latch;
 
-      public MyMessageHandler(final CountDownLatch latch) {
+      private MyMessageHandler(final CountDownLatch latch) {
          this.latch = latch;
       }
 

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/CommitRollbackTest.java
----------------------------------------------------------------------
diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/CommitRollbackTest.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/CommitRollbackTest.java
index def7fec..ec9c041 100644
--- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/CommitRollbackTest.java
+++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/CommitRollbackTest.java
@@ -242,7 +242,7 @@ public class CommitRollbackTest extends ActiveMQTestBase {
 
       private final CountDownLatch latch;
 
-      public ackHandler(final ClientSession session, final CountDownLatch latch) {
+      private ackHandler(final ClientSession session, final CountDownLatch latch) {
          this.session = session;
          this.latch = latch;
       }

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/DeadLetterAddressTest.java
----------------------------------------------------------------------
diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/DeadLetterAddressTest.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/DeadLetterAddressTest.java
index 95289ec..8ce7a3e 100644
--- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/DeadLetterAddressTest.java
+++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/DeadLetterAddressTest.java
@@ -175,7 +175,7 @@ public class DeadLetterAddressTest extends ActiveMQTestBase {
 
       private final ClientSession clientSession;
 
-      public TestHandler(CountDownLatch latch, ClientSession clientSession) {
+      TestHandler(CountDownLatch latch, ClientSession clientSession) {
          this.latch = latch;
          this.clientSession = clientSession;
       }

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/DeliveryOrderTest.java
----------------------------------------------------------------------
diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/DeliveryOrderTest.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/DeliveryOrderTest.java
index 9fb960b..8b04ba4 100644
--- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/DeliveryOrderTest.java
+++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/DeliveryOrderTest.java
@@ -154,7 +154,7 @@ public class DeliveryOrderTest extends ActiveMQTestBase {
 
       boolean failed = false;
 
-      public Receiver(final CountDownLatch latch) {
+      Receiver(final CountDownLatch latch) {
          this.latch = latch;
       }
 

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/HangConsumerTest.java
----------------------------------------------------------------------
diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/HangConsumerTest.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/HangConsumerTest.java
index 2c88896..2be2947 100644
--- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/HangConsumerTest.java
+++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/HangConsumerTest.java
@@ -215,20 +215,20 @@ public class HangConsumerTest extends ActiveMQTestBase {
           * @param addressSettingsRepository
           * @param executor
           */
-         public MyQueueWithBlocking(final long id,
-                                    final SimpleString address,
-                                    final SimpleString name,
-                                    final Filter filter,
-                                    final SimpleString user,
-                                    final PageSubscription pageSubscription,
-                                    final boolean durable,
-                                    final boolean temporary,
-                                    final boolean autoCreated,
-                                    final ScheduledExecutorService scheduledExecutor,
-                                    final PostOffice postOffice,
-                                    final StorageManager storageManager,
-                                    final HierarchicalRepository<AddressSettings> addressSettingsRepository,
-                                    final Executor executor) {
+         MyQueueWithBlocking(final long id,
+                             final SimpleString address,
+                             final SimpleString name,
+                             final Filter filter,
+                             final SimpleString user,
+                             final PageSubscription pageSubscription,
+                             final boolean durable,
+                             final boolean temporary,
+                             final boolean autoCreated,
+                             final ScheduledExecutorService scheduledExecutor,
+                             final PostOffice postOffice,
+                             final StorageManager storageManager,
+                             final HierarchicalRepository<AddressSettings> addressSettingsRepository,
+                             final Executor executor) {
             super(id, address, name, filter, pageSubscription, user, durable, temporary, autoCreated, scheduledExecutor, postOffice, storageManager, addressSettingsRepository, executor);
          }
 
@@ -247,10 +247,10 @@ public class HangConsumerTest extends ActiveMQTestBase {
 
       class LocalFactory extends QueueFactoryImpl {
 
-         public LocalFactory(final ExecutorFactory executorFactory,
-                             final ScheduledExecutorService scheduledExecutor,
-                             final HierarchicalRepository<AddressSettings> addressSettingsRepository,
-                             final StorageManager storageManager) {
+         LocalFactory(final ExecutorFactory executorFactory,
+                      final ScheduledExecutorService scheduledExecutor,
+                      final HierarchicalRepository<AddressSettings> addressSettingsRepository,
+                      final StorageManager storageManager) {
             super(executorFactory, scheduledExecutor, addressSettingsRepository, storageManager);
          }
 
@@ -567,9 +567,9 @@ public class HangConsumerTest extends ActiveMQTestBase {
 
    class MyActiveMQServer extends ActiveMQServerImpl {
 
-      public MyActiveMQServer(Configuration configuration,
-                              MBeanServer mbeanServer,
-                              ActiveMQSecurityManager securityManager) {
+      MyActiveMQServer(Configuration configuration,
+                       MBeanServer mbeanServer,
+                       ActiveMQSecurityManager securityManager) {
          super(configuration, mbeanServer, securityManager);
       }
 

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/InterruptedLargeMessageTest.java
----------------------------------------------------------------------
diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/InterruptedLargeMessageTest.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/InterruptedLargeMessageTest.java
index 62e24fa..a4be3ad 100644
--- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/InterruptedLargeMessageTest.java
+++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/InterruptedLargeMessageTest.java
@@ -513,20 +513,20 @@ public class InterruptedLargeMessageTest extends LargeMessageTestBase {
 
       class NoPostACKQueue extends QueueImpl {
 
-         public NoPostACKQueue(long id,
-                               SimpleString address,
-                               SimpleString name,
-                               Filter filter,
-                               SimpleString user,
-                               PageSubscription pageSubscription,
-                               boolean durable,
-                               boolean temporary,
-                               boolean autoCreated,
-                               ScheduledExecutorService scheduledExecutor,
-                               PostOffice postOffice,
-                               StorageManager storageManager,
-                               HierarchicalRepository<AddressSettings> addressSettingsRepository,
-                               Executor executor) {
+         NoPostACKQueue(long id,
+                        SimpleString address,
+                        SimpleString name,
+                        Filter filter,
+                        SimpleString user,
+                        PageSubscription pageSubscription,
+                        boolean durable,
+                        boolean temporary,
+                        boolean autoCreated,
+                        ScheduledExecutorService scheduledExecutor,
+                        PostOffice postOffice,
+                        StorageManager storageManager,
+                        HierarchicalRepository<AddressSettings> addressSettingsRepository,
+                        Executor executor) {
             super(id, address, name, filter, pageSubscription, user, durable, temporary, autoCreated, scheduledExecutor, postOffice, storageManager, addressSettingsRepository, executor);
          }
 
@@ -552,11 +552,11 @@ public class InterruptedLargeMessageTest extends LargeMessageTestBase {
 
          final ExecutorFactory execFactory;
 
-         public NoPostACKQueueFactory(StorageManager storageManager,
-                                      PostOffice postOffice,
-                                      ScheduledExecutorService scheduledExecutor,
-                                      HierarchicalRepository<AddressSettings> addressSettingsRepository,
-                                      final ExecutorFactory execFactory) {
+         NoPostACKQueueFactory(StorageManager storageManager,
+                               PostOffice postOffice,
+                               ScheduledExecutorService scheduledExecutor,
+                               HierarchicalRepository<AddressSettings> addressSettingsRepository,
+                               final ExecutorFactory execFactory) {
             this.storageManager = storageManager;
             this.postOffice = postOffice;
             this.scheduledExecutor = scheduledExecutor;

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/MessageConsumerRollbackTest.java
----------------------------------------------------------------------
diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/MessageConsumerRollbackTest.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/MessageConsumerRollbackTest.java
index de9a4cc..b4a3843 100644
--- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/MessageConsumerRollbackTest.java
+++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/MessageConsumerRollbackTest.java
@@ -173,7 +173,7 @@ public class MessageConsumerRollbackTest extends ActiveMQTestBase {
 
       CountDownLatch commitLatch;
 
-      public LocalConsumer(AtomicInteger counter, CountDownLatch commitLatch) {
+      private LocalConsumer(AtomicInteger counter, CountDownLatch commitLatch) {
          this.counter = counter;
          this.commitLatch = commitLatch;
       }

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/MessageGroupingConnectionFactoryTest.java
----------------------------------------------------------------------
diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/MessageGroupingConnectionFactoryTest.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/MessageGroupingConnectionFactoryTest.java
index f38ea31..282014f 100644
--- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/MessageGroupingConnectionFactoryTest.java
+++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/MessageGroupingConnectionFactoryTest.java
@@ -124,7 +124,7 @@ public class MessageGroupingConnectionFactoryTest extends ActiveMQTestBase {
 
       private final boolean acknowledge;
 
-      public DummyMessageHandler(final CountDownLatch latch, final boolean acknowledge) {
+      private DummyMessageHandler(final CountDownLatch latch, final boolean acknowledge) {
          this.latch = latch;
          this.acknowledge = acknowledge;
       }

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/MessageGroupingTest.java
----------------------------------------------------------------------
diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/MessageGroupingTest.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/MessageGroupingTest.java
index 3da716d..03fcd03 100644
--- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/MessageGroupingTest.java
+++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/MessageGroupingTest.java
@@ -555,7 +555,7 @@ public class MessageGroupingTest extends ActiveMQTestBase {
 
       private final boolean acknowledge;
 
-      public DummyMessageHandler(final CountDownLatch latch, final boolean acknowledge) {
+      private DummyMessageHandler(final CountDownLatch latch, final boolean acknowledge) {
          this.latch = latch;
          this.acknowledge = acknowledge;
       }

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/MessageHandlerTest.java
----------------------------------------------------------------------
diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/MessageHandlerTest.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/MessageHandlerTest.java
index f73403a..cdc0c44 100644
--- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/MessageHandlerTest.java
+++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/MessageHandlerTest.java
@@ -153,7 +153,7 @@ public class MessageHandlerTest extends ActiveMQTestBase {
 
          private final CountDownLatch latch;
 
-         public MyHandler(final CountDownLatch latch) {
+         MyHandler(final CountDownLatch latch) {
             this.latch = latch;
          }
 
@@ -246,7 +246,7 @@ public class MessageHandlerTest extends ActiveMQTestBase {
 
          private final CountDownLatch latch;
 
-         public MyHandler(final CountDownLatch latch) {
+         MyHandler(final CountDownLatch latch) {
             this.latch = latch;
          }
 
@@ -326,7 +326,7 @@ public class MessageHandlerTest extends ActiveMQTestBase {
 
          private final CountDownLatch latch;
 
-         public MyHandler(final CountDownLatch latch) {
+         MyHandler(final CountDownLatch latch) {
             this.latch = latch;
          }
 

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/MultipleThreadFilterOneTest.java
----------------------------------------------------------------------
diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/MultipleThreadFilterOneTest.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/MultipleThreadFilterOneTest.java
index e8015be..b342dea 100644
--- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/MultipleThreadFilterOneTest.java
+++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/MultipleThreadFilterOneTest.java
@@ -72,7 +72,7 @@ public class MultipleThreadFilterOneTest extends ActiveMQTestBase {
 
       public final AtomicInteger errors = new AtomicInteger(0);
 
-      public SomeProducer() throws Exception {
+      SomeProducer() throws Exception {
          locator = createNonHALocator(isNetty);
          factory = locator.createSessionFactory();
          prodSession = factory.createSession(false, false);
@@ -135,7 +135,7 @@ public class MultipleThreadFilterOneTest extends ActiveMQTestBase {
 
       final AtomicInteger errors = new AtomicInteger(0);
 
-      public SomeConsumer(int nr) throws Exception {
+      SomeConsumer(int nr) throws Exception {
          locator = createNonHALocator(isNetty);
          factory = locator.createSessionFactory();
          consumerSession = factory.createSession(false, false);

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/PagingTest.java
----------------------------------------------------------------------
diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/PagingTest.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/PagingTest.java
index 41467b5..91f5b2f 100644
--- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/PagingTest.java
+++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/PagingTest.java
@@ -3022,10 +3022,10 @@ public class PagingTest extends ActiveMQTestBase {
 
       class InterruptedCursorProvider extends PageCursorProviderImpl {
 
-         public InterruptedCursorProvider(PagingStore pagingStore,
-                                          StorageManager storageManager,
-                                          Executor executor,
-                                          int maxCacheSize) {
+         InterruptedCursorProvider(PagingStore pagingStore,
+                                   StorageManager storageManager,
+                                   Executor executor,
+                                   int maxCacheSize) {
             super(pagingStore, storageManager, executor, maxCacheSize);
          }
 
@@ -5681,7 +5681,7 @@ public class PagingTest extends ActiveMQTestBase {
       private final CountDownLatch pageUp;
       private final CountDownLatch pageDone;
 
-      public DummyOperationContext(CountDownLatch pageUp, CountDownLatch pageDone) {
+      private DummyOperationContext(CountDownLatch pageUp, CountDownLatch pageDone) {
          this.pageDone = pageDone;
          this.pageUp = pageUp;
       }

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/ServerLocatorConnectTest.java
----------------------------------------------------------------------
diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/ServerLocatorConnectTest.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/ServerLocatorConnectTest.java
index ea91ccd..257592e 100644
--- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/ServerLocatorConnectTest.java
+++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/ServerLocatorConnectTest.java
@@ -156,7 +156,7 @@ public class ServerLocatorConnectTest extends ActiveMQTestBase {
       CountDownLatch latch;
       Exception e;
 
-      public Connector(ServerLocatorInternal locator, CountDownLatch latch) {
+      Connector(ServerLocatorInternal locator, CountDownLatch latch) {
          this.locator = locator;
          this.latch = latch;
       }

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/SessionStopStartTest.java
----------------------------------------------------------------------
diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/SessionStopStartTest.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/SessionStopStartTest.java
index 3d8eff6..5b1de42 100644
--- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/SessionStopStartTest.java
+++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/SessionStopStartTest.java
@@ -352,11 +352,11 @@ public class SessionStopStartTest extends ActiveMQTestBase {
 
          private boolean stop = true;
 
-         public MyHandler(final CountDownLatch latch) {
+         MyHandler(final CountDownLatch latch) {
             this.latch = latch;
          }
 
-         public MyHandler(final CountDownLatch latch, final boolean stop) {
+         MyHandler(final CountDownLatch latch, final boolean stop) {
             this(latch);
             this.stop = stop;
          }
@@ -447,11 +447,11 @@ public class SessionStopStartTest extends ActiveMQTestBase {
 
          private boolean stop = true;
 
-         public MyHandler(final CountDownLatch latch) {
+         MyHandler(final CountDownLatch latch) {
             this.latch = latch;
          }
 
-         public MyHandler(final CountDownLatch latch, final boolean stop) {
+         MyHandler(final CountDownLatch latch, final boolean stop) {
             this(latch);
             this.stop = stop;
          }

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/TemporaryQueueTest.java
----------------------------------------------------------------------
diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/TemporaryQueueTest.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/TemporaryQueueTest.java
index 26a50d6..9503ddb 100644
--- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/TemporaryQueueTest.java
+++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/TemporaryQueueTest.java
@@ -358,7 +358,7 @@ public class TemporaryQueueTest extends SingleServerTestBase {
 
          final ClientSession sess;
 
-         public MyHandler(ClientSession sess, String color, int expectedMessages) {
+         MyHandler(ClientSession sess, String color, int expectedMessages) {
             this.sess = sess;
             latch = new CountDownLatch(expectedMessages);
             this.color = color;

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/NodeManagerTest.java
----------------------------------------------------------------------
diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/NodeManagerTest.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/NodeManagerTest.java
index 901bfa3..4cba6bc 100644
--- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/NodeManagerTest.java
+++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/NodeManagerTest.java
@@ -162,7 +162,7 @@ public class NodeManagerTest extends ActiveMQTestBase {
       private NodeManager manager;
       Throwable e;
 
-      public NodeRunner(NodeManager nodeManager, NodeManagerAction action) {
+      NodeRunner(NodeManager nodeManager, NodeManagerAction action) {
          this.manager = nodeManager;
          this.action = action;
       }

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/distribution/ClusteredGroupingTest.java
----------------------------------------------------------------------
diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/distribution/ClusteredGroupingTest.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/distribution/ClusteredGroupingTest.java
index 6cacd3c..c15ded0 100644
--- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/distribution/ClusteredGroupingTest.java
+++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/distribution/ClusteredGroupingTest.java
@@ -1650,12 +1650,12 @@ public class ClusteredGroupingTest extends ClusterTestBase {
 
       private final int node;
 
-      public ThreadSender(final int msgStart,
-                          final int msgEnd,
-                          final int node,
-                          final SimpleString id,
-                          final CountDownLatch latch,
-                          final boolean wait) {
+      ThreadSender(final int msgStart,
+                   final int msgEnd,
+                   final int node,
+                   final SimpleString id,
+                   final CountDownLatch latch,
+                   final boolean wait) {
          this.msgStart = msgStart;
          this.msgEnd = msgEnd;
          this.node = node;

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/failover/FailBackManualTest.java
----------------------------------------------------------------------
diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/failover/FailBackManualTest.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/failover/FailBackManualTest.java
index 0a53f61..1dc00e3 100644
--- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/failover/FailBackManualTest.java
+++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/failover/FailBackManualTest.java
@@ -177,7 +177,7 @@ public class FailBackManualTest extends FailoverTestBase {
 
       private final TestableServer server;
 
-      public ServerStarter(TestableServer server) {
+      ServerStarter(TestableServer server) {
          this.server = server;
       }
 

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/failover/QuorumFailOverTest.java
----------------------------------------------------------------------
diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/failover/QuorumFailOverTest.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/failover/QuorumFailOverTest.java
index 955e34c..6043f88 100644
--- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/failover/QuorumFailOverTest.java
+++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/failover/QuorumFailOverTest.java
@@ -104,7 +104,7 @@ public class QuorumFailOverTest extends StaticClusterWithBackupFailoverTest {
       final String prefix;
       final Map<String, Pair<TransportConfiguration, TransportConfiguration>> nodes = new ConcurrentHashMap<>();
 
-      public TopologyListener(String string) {
+      private TopologyListener(String string) {
          prefix = string;
       }
 

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/reattach/MultiThreadReattachSupportTestBase.java
----------------------------------------------------------------------
diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/reattach/MultiThreadReattachSupportTestBase.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/reattach/MultiThreadReattachSupportTestBase.java
index e36475a..1037e04 100644
--- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/reattach/MultiThreadReattachSupportTestBase.java
+++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/reattach/MultiThreadReattachSupportTestBase.java
@@ -201,7 +201,7 @@ public abstract class MultiThreadReattachSupportTestBase extends ActiveMQTestBas
 
       private final boolean failOnCreateConnection;
 
-      public Failer(final ClientSession session, final boolean failOnCreateConnection) {
+      private Failer(final ClientSession session, final boolean failOnCreateConnection) {
          this.session = session;
 
          this.failOnCreateConnection = failOnCreateConnection;

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/reattach/RandomReattachTest.java
----------------------------------------------------------------------
diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/reattach/RandomReattachTest.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/reattach/RandomReattachTest.java
index 8d1fe32..4c48738 100644
--- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/reattach/RandomReattachTest.java
+++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/reattach/RandomReattachTest.java
@@ -1268,7 +1268,7 @@ public class RandomReattachTest extends ActiveMQTestBase {
 
       private boolean executed;
 
-      public Failer(final ClientSessionInternal session) {
+      Failer(final ClientSessionInternal session) {
          this.session = session;
       }
 

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/client/NewQueueRequestorTest.java
----------------------------------------------------------------------
diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/client/NewQueueRequestorTest.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/client/NewQueueRequestorTest.java
index 1fec02b..84a7940 100644
--- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/client/NewQueueRequestorTest.java
+++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/client/NewQueueRequestorTest.java
@@ -85,7 +85,7 @@ public class NewQueueRequestorTest extends JMSTestBase {
 
       private final QueueSender sender;
 
-      public TestMessageListener(final QueueSession sess) throws JMSException {
+      TestMessageListener(final QueueSession sess) throws JMSException {
          this.sess = sess;
          sender = sess.createSender(null);
       }

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/connection/ExceptionListenerTest.java
----------------------------------------------------------------------
diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/connection/ExceptionListenerTest.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/connection/ExceptionListenerTest.java
index 6e62231..4d9b79f 100644
--- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/connection/ExceptionListenerTest.java
+++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/connection/ExceptionListenerTest.java
@@ -75,7 +75,7 @@ public class ExceptionListenerTest extends ActiveMQTestBase {
 
       private final CountDownLatch latch;
 
-      public MyExceptionListener(final CountDownLatch latch) {
+      private MyExceptionListener(final CountDownLatch latch) {
          this.latch = latch;
       }
 

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/jms2client/JmsContextTest.java
----------------------------------------------------------------------
diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/jms2client/JmsContextTest.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/jms2client/JmsContextTest.java
index 58b284b..e3d7b6d 100644
--- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/jms2client/JmsContextTest.java
+++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/jms2client/JmsContextTest.java
@@ -559,7 +559,7 @@ public class JmsContextTest extends JMSTestBase {
       private CountDownLatch latch;
       private BytesMessage message;
 
-      public SimpleCompletionListener(CountDownLatch latch) {
+      private SimpleCompletionListener(CountDownLatch latch) {
          this.latch = latch;
       }
 
@@ -582,7 +582,7 @@ public class JmsContextTest extends JMSTestBase {
       private JMSContext context;
       private volatile Throwable error;
 
-      public InvalidMessageListener(JMSContext context, CountDownLatch latch, int id) {
+      private InvalidMessageListener(JMSContext context, CountDownLatch latch, int id) {
          this.id = id;
          this.latch = latch;
          this.context = context;
@@ -633,7 +633,7 @@ public class JmsContextTest extends JMSTestBase {
       private CountDownLatch latch;
       private Exception ex;
 
-      public JMSCOntextStopCompletionListener(JMSContext context, CountDownLatch latch) {
+      private JMSCOntextStopCompletionListener(JMSContext context, CountDownLatch latch) {
          this.context = context;
          this.latch = latch;
       }

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/server/management/JMSServerControlTest.java
----------------------------------------------------------------------
diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/server/management/JMSServerControlTest.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/server/management/JMSServerControlTest.java
index 1dd3c0a..b42bba9 100644
--- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/server/management/JMSServerControlTest.java
+++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/server/management/JMSServerControlTest.java
@@ -1031,7 +1031,7 @@ public class JMSServerControlTest extends ManagementTestBase {
 
       JMSStorageManager delegate;
 
-      public FakeJMSStorageManager(JMSStorageManager delegate) {
+      FakeJMSStorageManager(JMSStorageManager delegate) {
          this.delegate = delegate;
       }
 

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/journal/ValidateTransactionHealthTest.java
----------------------------------------------------------------------
diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/journal/ValidateTransactionHealthTest.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/journal/ValidateTransactionHealthTest.java
index a88199a..895a8f3 100644
--- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/journal/ValidateTransactionHealthTest.java
+++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/journal/ValidateTransactionHealthTest.java
@@ -178,7 +178,7 @@ public class ValidateTransactionHealthTest extends ActiveMQTestBase {
 
       long lastID = 0;
 
-      public Loader(final long expectedRecords) {
+      Loader(final long expectedRecords) {
          this.expectedRecords = expectedRecords;
       }
 
@@ -346,10 +346,10 @@ public class ValidateTransactionHealthTest extends ActiveMQTestBase {
 
       Exception e;
 
-      public LocalThread(final JournalImpl journal,
-                         final long numberOfElements,
-                         final int transactionSize,
-                         final AtomicLong nextID) {
+      LocalThread(final JournalImpl journal,
+                  final long numberOfElements,
+                  final int transactionSize,
+                  final AtomicLong nextID) {
          super();
          this.journal = journal;
          this.numberOfElements = numberOfElements;

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/management/ManagementWithPagingServerTest.java
----------------------------------------------------------------------
diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/management/ManagementWithPagingServerTest.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/management/ManagementWithPagingServerTest.java
index 6bd8a53..236403b 100644
--- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/management/ManagementWithPagingServerTest.java
+++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/management/ManagementWithPagingServerTest.java
@@ -214,7 +214,7 @@ public class ManagementWithPagingServerTest extends ManagementTestBase {
       private long delay;
       private volatile Exception error = null;
 
-      public SenderThread(SimpleString address, int num, long delay) {
+      private SenderThread(SimpleString address, int num, long delay) {
          this.address = address;
          this.num = num;
          this.delay = delay;
@@ -263,7 +263,7 @@ public class ManagementWithPagingServerTest extends ManagementTestBase {
       private long delay;
       private volatile Exception error = null;
 
-      public ReceiverThread(SimpleString queue, int num, long delay) {
+      private ReceiverThread(SimpleString queue, int num, long delay) {
          this.queue = queue;
          this.num = num;
          this.delay = delay;
@@ -303,7 +303,7 @@ public class ManagementWithPagingServerTest extends ManagementTestBase {
       private volatile boolean stop = false;
       private Exception error = null;
 
-      public ManagementThread(QueueControl queueControl) {
+      private ManagementThread(QueueControl queueControl) {
          this.queueControl = queueControl;
       }
 

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/openwire/amq/JMSConsumer2Test.java
----------------------------------------------------------------------
diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/openwire/amq/JMSConsumer2Test.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/openwire/amq/JMSConsumer2Test.java
index 3f28aa7..5b0c038 100644
--- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/openwire/amq/JMSConsumer2Test.java
+++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/openwire/amq/JMSConsumer2Test.java
@@ -69,7 +69,7 @@ public class JMSConsumer2Test extends BasicOpenWireTest {
 
          private final Message message;
 
-         public AckAndClose(Message m) {
+         AckAndClose(Message m) {
             this.message = m;
          }
 

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/openwire/amq/MessageListenerRedeliveryTest.java
----------------------------------------------------------------------
diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/openwire/amq/MessageListenerRedeliveryTest.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/openwire/amq/MessageListenerRedeliveryTest.java
index 5606a6a..e5ada02 100644
--- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/openwire/amq/MessageListenerRedeliveryTest.java
+++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/openwire/amq/MessageListenerRedeliveryTest.java
@@ -92,7 +92,7 @@ public class MessageListenerRedeliveryTest extends BasicOpenWireTest {
       public int counter;
       private final Session session;
 
-      public TestMessageListener(Session session) {
+      private TestMessageListener(Session session) {
          this.session = session;
       }
 

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/paging/PagingWithFailoverAndCountersTest.java
----------------------------------------------------------------------
diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/paging/PagingWithFailoverAndCountersTest.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/paging/PagingWithFailoverAndCountersTest.java
index de8dced..0f9f3d3 100644
--- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/paging/PagingWithFailoverAndCountersTest.java
+++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/paging/PagingWithFailoverAndCountersTest.java
@@ -97,10 +97,10 @@ public class PagingWithFailoverAndCountersTest extends ActiveMQTestBase {
 
    class TestThread extends Thread {
 
-      public TestThread() {
+      TestThread() {
       }
 
-      public TestThread(String name) {
+      TestThread(String name) {
          super(name);
       }
 
@@ -232,7 +232,7 @@ public class PagingWithFailoverAndCountersTest extends ActiveMQTestBase {
 
    class MonitorThread extends TestThread {
 
-      public MonitorThread() {
+      MonitorThread() {
          super("Monitor-thread");
       }
 

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/ra/ActiveMQMessageHandlerTest.java
----------------------------------------------------------------------
diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/ra/ActiveMQMessageHandlerTest.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/ra/ActiveMQMessageHandlerTest.java
index d2d67e2..0aab4c5 100644
--- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/ra/ActiveMQMessageHandlerTest.java
+++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/ra/ActiveMQMessageHandlerTest.java
@@ -798,7 +798,7 @@ public class ActiveMQMessageHandlerTest extends ActiveMQRATestBase {
 
       boolean throwException = true;
 
-      public ExceptionDummyMessageEndpoint(CountDownLatch latch) {
+      ExceptionDummyMessageEndpoint(CountDownLatch latch) {
          super(latch);
       }
 
@@ -820,7 +820,7 @@ public class ActiveMQMessageHandlerTest extends ActiveMQRATestBase {
       AtomicInteger messages = new AtomicInteger(0);
       AtomicInteger interrupted = new AtomicInteger(0);
 
-      public MultipleEndpoints(CountDownLatch latch, CountDownLatch latchDone, boolean pause) {
+      MultipleEndpoints(CountDownLatch latch, CountDownLatch latchDone, boolean pause) {
          super(latch);
          this.latch = latch;
          this.latchDone = latchDone;

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/ra/ActiveMQMessageHandlerXATest.java
----------------------------------------------------------------------
diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/ra/ActiveMQMessageHandlerXATest.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/ra/ActiveMQMessageHandlerXATest.java
index 11af3cd..4278ef8 100644
--- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/ra/ActiveMQMessageHandlerXATest.java
+++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/ra/ActiveMQMessageHandlerXATest.java
@@ -195,7 +195,7 @@ public class ActiveMQMessageHandlerXATest extends ActiveMQRATestBase {
 
       private Xid xid;
 
-      public XADummyEndpoint(CountDownLatch latch) {
+      XADummyEndpoint(CountDownLatch latch) {
          super(latch);
          xid = new XidImpl("xa1".getBytes(), 1, UUIDGenerator.getInstance().generateStringUUID().getBytes());
       }
@@ -242,7 +242,7 @@ public class ActiveMQMessageHandlerXATest extends ActiveMQRATestBase {
 
       boolean interrupted = false;
 
-      public PausingXADummyEndpoint(CountDownLatch latch, CountDownLatch beforeDeliveryLatch) {
+      PausingXADummyEndpoint(CountDownLatch latch, CountDownLatch beforeDeliveryLatch) {
          super(latch);
          this.beforeDeliveryLatch = beforeDeliveryLatch;
       }

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/server/ExpiryRunnerTest.java
----------------------------------------------------------------------
diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/server/ExpiryRunnerTest.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/server/ExpiryRunnerTest.java
index 57773ed..ccc0175 100644
--- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/server/ExpiryRunnerTest.java
+++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/server/ExpiryRunnerTest.java
@@ -258,7 +258,7 @@ public class ExpiryRunnerTest extends ActiveMQTestBase {
 
       private final CountDownLatch latch;
 
-      public DummyMessageHandler(final ClientConsumer consumer, final CountDownLatch latch) {
+      private DummyMessageHandler(final ClientConsumer consumer, final CountDownLatch latch) {
          this.consumer = consumer;
          this.latch = latch;
       }

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/stomp/StompOverWebsocketTest.java
----------------------------------------------------------------------
diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/stomp/StompOverWebsocketTest.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/stomp/StompOverWebsocketTest.java
index d665cc2..39cd4f7 100644
--- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/stomp/StompOverWebsocketTest.java
+++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/stomp/StompOverWebsocketTest.java
@@ -80,7 +80,7 @@ public class StompOverWebsocketTest extends StompTest {
 
       private WebSocketClientHandshaker handshaker;
 
-      public WebsocketHandler(WebSocketClientHandshaker webSocketClientHandshaker) {
+      WebsocketHandler(WebSocketClientHandshaker webSocketClientHandshaker) {
          this.handshaker = webSocketClientHandshaker;
       }
 

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/stomp/util/AbstractClientStompFrame.java
----------------------------------------------------------------------
diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/stomp/util/AbstractClientStompFrame.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/stomp/util/AbstractClientStompFrame.java
index dc2e1ed..06771bb 100644
--- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/stomp/util/AbstractClientStompFrame.java
+++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/stomp/util/AbstractClientStompFrame.java
@@ -169,7 +169,7 @@ public abstract class AbstractClientStompFrame implements ClientStompFrame {
       public String key;
       public String val;
 
-      public Header(String key, String val) {
+      private Header(String key, String val) {
          this.key = key;
          this.val = val;
       }

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/stomp/util/AbstractStompClientConnection.java
----------------------------------------------------------------------
diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/stomp/util/AbstractStompClientConnection.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/stomp/util/AbstractStompClientConnection.java
index 5c6cc6b..a4244c1 100644
--- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/stomp/util/AbstractStompClientConnection.java
+++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/stomp/util/AbstractStompClientConnection.java
@@ -303,7 +303,7 @@ public abstract class AbstractStompClientConnection implements StompClientConnec
       ClientStompFrame pingFrame;
       volatile boolean stop = false;
 
-      public Pinger(long interval) {
+      private Pinger(long interval) {
          this.pingInterval = interval;
          pingFrame = createFrame("STOMP");
          pingFrame.setBody("\n");

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/xa/BasicXaTest.java
----------------------------------------------------------------------
diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/xa/BasicXaTest.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/xa/BasicXaTest.java
index 9eef719..5bd2463 100644
--- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/xa/BasicXaTest.java
+++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/xa/BasicXaTest.java
@@ -871,7 +871,7 @@ public class BasicXaTest extends ActiveMQTestBase {
 
       private final CountDownLatch latch;
 
-      public TxMessageHandler(final ClientSession session, final CountDownLatch latch) {
+      TxMessageHandler(final ClientSession session, final CountDownLatch latch) {
          this.latch = latch;
          this.session = session;
       }

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/xa/XaTimeoutTest.java
----------------------------------------------------------------------
diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/xa/XaTimeoutTest.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/xa/XaTimeoutTest.java
index 6d02cc9..c19a200 100644
--- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/xa/XaTimeoutTest.java
+++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/xa/XaTimeoutTest.java
@@ -693,7 +693,7 @@ public class XaTimeoutTest extends ActiveMQTestBase {
 
       final CountDownLatch latch;
 
-      public RollbackCompleteOperation(final CountDownLatch latch) {
+      RollbackCompleteOperation(final CountDownLatch latch) {
          this.latch = latch;
       }
 

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/AutoAckMesageListenerTest.java
----------------------------------------------------------------------
diff --git a/tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/AutoAckMesageListenerTest.java b/tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/AutoAckMesageListenerTest.java
index 858b529..13a4699 100644
--- a/tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/AutoAckMesageListenerTest.java
+++ b/tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/AutoAckMesageListenerTest.java
@@ -99,7 +99,7 @@ public class AutoAckMesageListenerTest extends JMSTestCase {
 
       private final CountDownLatch monitor;
 
-      public AutoAckMsgListener(CountDownLatch latch, Session session) {
+      private AutoAckMsgListener(CountDownLatch latch, Session session) {
          this.monitor = latch;
          this.session = session;
       }


[7/7] activemq-artemis git commit: This closes #578

Posted by cl...@apache.org.
This closes #578


Project: http://git-wip-us.apache.org/repos/asf/activemq-artemis/repo
Commit: http://git-wip-us.apache.org/repos/asf/activemq-artemis/commit/369f2e00
Tree: http://git-wip-us.apache.org/repos/asf/activemq-artemis/tree/369f2e00
Diff: http://git-wip-us.apache.org/repos/asf/activemq-artemis/diff/369f2e00

Branch: refs/heads/master
Commit: 369f2e0063e69934ba23b0ba7e8f89f09e581f53
Parents: a624a81 3923ae4
Author: Clebert Suconic <cl...@apache.org>
Authored: Mon Jun 13 14:17:16 2016 -0400
Committer: Clebert Suconic <cl...@apache.org>
Committed: Mon Jun 13 14:17:16 2016 -0400

----------------------------------------------------------------------
 .../artemis/cli/commands/tools/PrintData.java   |  2 +-
 .../cli/commands/tools/XmlDataExporter.java     |  2 +-
 .../cli/commands/tools/XmlDataImporter.java     |  3 +-
 .../core/buffers/impl/ChannelBufferWrapper.java |  4 +-
 .../apache/activemq/artemis/utils/Base64.java   |  3 +-
 .../activemq/artemis/utils/ReusableLatch.java   |  2 +-
 .../activemq/artemis/utils/TypedProperties.java | 42 ++++++++++----------
 .../api/core/UDPBroadcastEndpointFactory.java   |  2 +-
 .../core/management/CoreNotificationType.java   |  2 +-
 .../core/client/impl/ClientMessageImpl.java     |  2 +-
 .../core/client/impl/ClientSessionImpl.java     |  6 +--
 .../CompressedLargeMessageControllerImpl.java   |  2 +-
 .../client/impl/LargeMessageControllerImpl.java |  9 ++---
 .../core/client/impl/ServerLocatorImpl.java     |  2 +-
 .../artemis/core/message/impl/MessageImpl.java  |  2 +-
 .../remoting/impl/netty/NettyConnector.java     |  4 +-
 .../artemis/utils/OrderedExecutorFactory.java   |  2 +-
 .../artemis/utils/SoftValueHashMap.java         |  2 +-
 .../apache/activemq/artemis/dto/XmlUtil.java    |  2 +-
 .../jdbc/store/journal/TransactionHolder.java   |  2 +-
 .../file/JDBCSequentialFileFactoryTest.java     |  2 +-
 .../artemis/jms/client/ActiveMQJMSConsumer.java |  2 +-
 .../artemis/jms/client/ActiveMQJMSProducer.java |  2 +-
 .../jms/client/ActiveMQMessageProducer.java     |  6 +--
 .../artemis/jms/bridge/impl/JMSBridgeImpl.java  |  4 +-
 .../server/management/JMSNotificationType.java  |  2 +-
 .../core/io/aio/AIOSequentialFileFactory.java   |  2 +-
 .../artemis/core/journal/impl/JournalBase.java  |  2 +-
 .../core/journal/impl/JournalCompactor.java     |  8 ++--
 .../artemis/core/journal/impl/JournalImpl.java  |  2 +-
 .../artemis/jlibaio/test/LibaioTest.java        |  2 +-
 .../core/protocol/mqtt/MQTTProtocolManager.java |  2 +-
 .../org/proton/plug/util/CreditsSemaphore.java  |  2 +-
 .../org/proton/plug/util/ReusableLatch.java     |  2 +-
 .../context/AbstractConnectionContextTest.java  |  2 +-
 .../plug/test/minimalserver/MinimalServer.java  |  2 +-
 .../protocol/stomp/ActiveMQStompException.java  |  2 +-
 .../protocol/stomp/StompProtocolManager.java    |  8 ++--
 .../core/protocol/stomp/StompVersions.java      |  2 +-
 .../stomp/v11/StompFrameHandlerV11.java         |  2 +-
 .../activemq/artemis/ra/ActiveMQRALogger.java   |  2 +-
 .../artemis/rest/test/AutoAckTopicTest.java     |  4 +-
 .../selector/filter/ComparisonExpression.java   |  2 +-
 .../selector/filter/ConstantExpression.java     |  2 +-
 .../selector/filter/UnaryExpression.java        |  2 +-
 .../artemis/osgi/ProtocolTrackerTest.java       |  2 +-
 .../core/config/HAPolicyConfiguration.java      |  2 +-
 .../artemis/core/config/StoreConfiguration.java |  2 +-
 .../artemis/core/filter/impl/FilterImpl.java    |  2 +-
 .../core/paging/cursor/impl/PageCacheImpl.java  |  2 +-
 .../impl/PageSubscriptionCounterImpl.java       |  2 +-
 .../cursor/impl/PageSubscriptionImpl.java       |  4 +-
 .../paging/impl/PageTransactionInfoImpl.java    |  4 +-
 .../core/paging/impl/PagingStoreImpl.java       |  6 +--
 .../core/persistence/StorageManager.java        |  2 +-
 .../nullpm/NullStorageLargeServerMessage.java   |  4 +-
 .../artemis/core/protocol/ProtocolHandler.java  |  2 +-
 .../protocol/core/impl/CoreProtocolManager.java | 10 ++---
 .../BackupReplicationStartFailedMessage.java    |  2 +-
 .../ReplicationLiveIsStoppingMessage.java       |  2 +-
 .../wireformat/ReplicationStartSyncMessage.java |  2 +-
 .../wireformat/ReplicationSyncFileMessage.java  |  2 +-
 .../impl/netty/HttpAcceptorHandler.java         |  6 +--
 .../core/server/cluster/BackupManager.java      | 28 ++++++-------
 .../core/server/cluster/ClusterController.java  | 10 ++---
 .../core/server/cluster/impl/BridgeImpl.java    |  4 +-
 .../cluster/impl/ClusterConnectionImpl.java     | 16 ++++----
 .../server/cluster/qourum/QuorumManager.java    |  4 +-
 .../server/impl/BackupTopologyListener.java     |  2 +-
 .../core/server/impl/ColocatedActivation.java   |  6 +--
 .../artemis/core/server/impl/QueueImpl.java     |  6 +--
 .../core/server/impl/ReplicationError.java      |  2 +-
 .../impl/ScheduledDeliveryHandlerImpl.java      |  2 +-
 .../core/server/impl/ServerConsumerImpl.java    |  2 +-
 .../impl/SharedNothingLiveActivation.java       |  2 +-
 .../artemis/core/transaction/Transaction.java   |  2 +-
 .../transaction/impl/ResourceManagerImpl.java   |  2 +-
 .../jaas/PropertiesLoginModuleTest.java         |  2 +-
 .../cluster/impl/BroadcastGroupImplTest.java    |  2 +-
 .../impl/ScheduledDeliveryHandlerTest.java      |  2 +-
 .../artemis/core/settings/RepositoryTest.java   |  2 +-
 .../artemis/tests/util/ActiveMQTestBase.java    |  2 +-
 .../cli/test/WebServerComponentTest.java        |  2 +-
 .../activemq/artemis/jms/example/PerfBase.java  |  2 +-
 .../jms/example/MessageGroupExample.java        |  2 +-
 .../jms/example/MessageGroup2Example.java       |  2 +-
 .../jms/example/MessagePriorityExample.java     |  2 +-
 .../jms/example/QueueSelectorExample.java       |  2 +-
 .../jms/example/StaticSelectorExample.java      |  2 +-
 .../jms/example/TopicSelectorExample2.java      |  2 +-
 .../artemis/jms/example/XASendExample.java      |  2 +-
 .../aerogear/AeroGearConnectorService.java      |  2 +-
 pom.xml                                         |  2 +-
 tests/activemq5-unit-tests/pom.xml              |  2 +-
 .../HierarchicalObjectRepositoryTest.java       |  2 +-
 .../aerogear/AeroGearBasicServerTest.java       |  2 +-
 .../integration/client/AutogroupIdTest.java     |  2 +-
 .../integration/client/CommitRollbackTest.java  |  2 +-
 .../client/DeadLetterAddressTest.java           |  2 +-
 .../integration/client/DeliveryOrderTest.java   |  2 +-
 .../integration/client/HangConsumerTest.java    | 42 ++++++++++----------
 .../client/InterruptedLargeMessageTest.java     | 38 +++++++++---------
 .../client/MessageConsumerRollbackTest.java     |  2 +-
 .../MessageGroupingConnectionFactoryTest.java   |  2 +-
 .../integration/client/MessageGroupingTest.java |  2 +-
 .../integration/client/MessageHandlerTest.java  |  6 +--
 .../client/MultipleThreadFilterOneTest.java     |  4 +-
 .../tests/integration/client/PagingTest.java    | 10 ++---
 .../client/ServerLocatorConnectTest.java        |  2 +-
 .../client/SessionStopStartTest.java            |  8 ++--
 .../integration/client/TemporaryQueueTest.java  |  2 +-
 .../integration/cluster/NodeManagerTest.java    |  2 +-
 .../distribution/ClusteredGroupingTest.java     | 12 +++---
 .../cluster/failover/FailBackManualTest.java    |  2 +-
 .../cluster/failover/QuorumFailOverTest.java    |  2 +-
 .../MultiThreadReattachSupportTestBase.java     |  2 +-
 .../cluster/reattach/RandomReattachTest.java    |  2 +-
 .../jms/client/NewQueueRequestorTest.java       |  2 +-
 .../jms/connection/ExceptionListenerTest.java   |  2 +-
 .../jms/jms2client/JmsContextTest.java          |  6 +--
 .../server/management/JMSServerControlTest.java |  2 +-
 .../journal/ValidateTransactionHealthTest.java  | 10 ++---
 .../ManagementWithPagingServerTest.java         |  6 +--
 .../openwire/amq/JMSConsumer2Test.java          |  2 +-
 .../amq/MessageListenerRedeliveryTest.java      |  2 +-
 .../PagingWithFailoverAndCountersTest.java      |  6 +--
 .../ra/ActiveMQMessageHandlerTest.java          |  4 +-
 .../ra/ActiveMQMessageHandlerXATest.java        |  4 +-
 .../integration/server/ExpiryRunnerTest.java    |  2 +-
 .../stomp/StompOverWebsocketTest.java           |  2 +-
 .../stomp/util/AbstractClientStompFrame.java    |  2 +-
 .../util/AbstractStompClientConnection.java     |  2 +-
 .../tests/integration/xa/BasicXaTest.java       |  2 +-
 .../tests/integration/xa/XaTimeoutTest.java     |  2 +-
 .../jms/tests/AutoAckMesageListenerTest.java    |  2 +-
 .../artemis/jms/tests/MessageConsumerTest.java  | 30 +++++++-------
 .../artemis/jms/tests/MessageProducerTest.java  |  6 +--
 .../artemis/jms/tests/MiscellaneousTest.java    |  2 +-
 .../jms/tests/TransactedSessionTest.java        |  2 +-
 .../jms/tests/message/MessageHeaderTest.java    |  2 +-
 .../paging/MeasurePagingMultiThreadTest.java    |  2 +-
 .../sends/AbstractSendReceivePerfTest.java      |  4 +-
 .../JournalCleanupCompactStressTest.java        |  6 +--
 .../tests/stress/remote/PingStressTest.java     |  2 +-
 .../jms/bridge/impl/JMSBridgeImplTest.java      |  2 +-
 .../MultiThreadAsynchronousFileTest.java        |  8 ++--
 .../core/paging/impl/PagingStoreImplTest.java   |  8 ++--
 .../impl/WildcardAddressManagerUnitTest.java    |  4 +-
 .../tests/unit/core/remoting/AcceptorsTest.java |  3 +-
 .../unit/core/server/impl/QueueImplTest.java    |  8 ++--
 150 files changed, 321 insertions(+), 327 deletions(-)
----------------------------------------------------------------------