You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@struts.apache.org by Lukasz Lenart <lu...@apache.org> on 2022/10/06 13:05:49 UTC
Re: Tiles support
I have prepared a PR to copy Tiles code base into the Tile plugin -
just copied what is needed by the plugin. I would like to merge it
after releasing 6.1.0
https://github.com/apache/struts/pull/608
Regards
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
wt., 9 sie 2022 o 16:43 Antonio Petrelli <an...@gmail.com>
napisał(a):
>
> Il giorno mar 9 ago 2022 alle ore 07:32 Lukasz Lenart <
> lukaszlenart@apache.org> ha scritto:
>
> > ... but from my perspective
> > Struts 2 is using just a few features of the Apache Tiles and from
> > project management perspective it will be easier to copy what is
> > needed instead of managing & releasing a whole new project (instead
> > just fixing in Struts 2, we would have to fix Tiles first, release it
> > and fix Struts - this is similar thing we have with OGNL for example).
> > Also as someone already pointed out, less dependency is better,
> > especially if we would like to prepare support for JakartaEE.
> >
>
> Ok, I'd ask the attic about this topic, though, just to be sure. I think
> there will be no problem. The only problem that I am aware of is that, if
> you want to use a project in the attic *outside* of Apache, you have to
> rename it (see iBATIS and MyBatis as an example).
> But since it is everything in Apache this might be different.
>
> Anyway, IANAL, ask the attic.
>
> Antonio
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Tiles support
Posted by Lukasz Lenart <lu...@apache.org>.
Ok, I think it's time to merge this PR and release a new version
https://github.com/apache/struts/pull/608
Regards
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Tiles support
Posted by Lukasz Lenart <lu...@apache.org>.
Great, feel free to open PR with those tests, even the generator can
stay where it is now.
czw., 13 paź 2022 o 09:16 Greg Huber <gr...@gmail.com> napisał(a):
>
> My thinking also, keep things simple. The patch includes all the tests
> for completeness, I guess as it was meant to be.
>
> On 13/10/2022 08:10, Lukasz Lenart wrote:
> > To be honest, I would like to reduce as much as possible by taking
> > some custom steps to generate something. I do not expect to have a lot
> > of issues around Tiles or new feature requests, so having this as
> > simple as possible is the way to go :)
> >
> >
> > Cheers
> > --
> > Łukasz
> > + 48 606 323 122 http://www.lenart.org.pl/
> >
> > wt., 11 paź 2022 o 11:24 Greg Huber <gr...@gmail.com> napisał(a):
> >> I thought about the autotag stuff and with the validation/tests etc,
> >> seemed a good idea to keep it, as its not that involved.
> >>
> >> Basically it uses template-suite.xml to generate the tag files and tld.
> >>
> >> I have got it all working, and passing the tests.
> >>
> >> Rather than the maven autotag plugin, I have a simple class
> >> (BuildJspAutotags) that builds the tags to
> >>
> >> /target/generated-sources/autotag
> >>
> >> And then if changing the template-suite.xml, run the build and copy
> >> manually the classes/tld back into the source.
> >>
> >> The org.apache.struts2.tiles.BuildJspAutotags.java probably needs a
> >> better home.
> >>
> >> I have committed all this to
> >>
> >> https://github.com/gregh3269/struts/tree/WW-5233-tiles
> >>
> >> I can will do another PR so can have a look?
> >>
> >> On 11/10/2022 10:00, Lukasz Lenart wrote:
> >>> I copied some auto generated classes but they depend on Autotag
> >>> classes, so I copied them as well. If something is still missing I
> >>> have a Tiles build locally and can copy other auto generated stuff.
> >>> And yes, we should avoid maintaining Autotag, it complicates things.
> >>> As far as I understand we only use / expose JSP tags, I don't know if
> >>> someone is using Freemarker/Velocity directives - we can always add
> >>> them later on request.
> >>>
> >>>
> >>> Regards
> >>> Łukasz
> >>>
> >>> niedz., 9 paź 2022 o 16:17 Greg Huber <gr...@gmail.com> napisał(a):
> >>>> Looking at it in more depth, I think we need to leave as much code as
> >>>> possible in the attic, including the autotag stuff. Keep only the parts to
> >>>> make it work, and update the tag classes manually. Having to maintain
> >>>> classes to generate the tag classes is pointless (might as well update them
> >>>> directly). If we need to generate the tld we can use the struts tld
> >>>> processor.
> >>>>
> >>>> This means we don't need all of the velocity code, support classes etc and
> >>>> should reduce the plugin packages also.
> >>>>
> >>>> I will play around with it to see what we can loose, so we only have the
> >>>> bare minimum.
> >>>>
> >>>>
> >>>> On Sun, 9 Oct 2022 at 10:52, Greg Huber <gr...@gmail.com> wrote:
> >>>>
> >>>>> Or better, try to build the tags (whatever the maven-autotag-pluging
> >>>>> did) on the plugin build?
> >>>>>
> >>>>> On 09/10/2022 10:28, Greg Huber wrote:
> >>>>>> The reason why the taglibs were missing, they are generated by tiles
> >>>>>> auto tag
> >>>>>>
> >>>>>> https://tiles.apache.org/tiles-autotag/
> >>>>>>
> >>>>>> Tiles-3 introduces a f Autotag Project, a project that automatically
> >>>>>> generates tags (or tag-like) artifact from a common template code for
> >>>>>> a range of templating languages. Today JSP tags, Freemarker directive
> >>>>>> models and Velocity directives are generated from a common template
> >>>>>> models.
> >>>>>>
> >>>>>> Do we use Freemarker directive models and Velocity directives?
> >>>>>>
> >>>>>> Maybe we don't need the autotag in the plugin as we have the tag
> >>>>>> classes now?
> >>>>>>
> >>>>>> On 06/10/2022 14:05, Lukasz Lenart wrote:
> >>>>>>> I have prepared a PR to copy Tiles code base into the Tile plugin -
> >>>>>>> just copied what is needed by the plugin. I would like to merge it
> >>>>>>> after releasing 6.1.0
> >>>>>>>
> >>>>>>> https://github.com/apache/struts/pull/608
> >>>>>>>
> >>>>>>>
> >>>>>>> Regards
> >>>>>>> --
> >>>>>>> Łukasz
> >>>>>>> + 48 606 323 122 http://www.lenart.org.pl/
> >>>>>>>
> >>>>>>> wt., 9 sie 2022 o 16:43 Antonio Petrelli <an...@gmail.com>
> >>>>>>> napisał(a):
> >>> ---------------------------------------------------------------------
> >>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> >>> For additional commands, e-mail: dev-help@struts.apache.org
> >>>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> >> For additional commands, e-mail: dev-help@struts.apache.org
> >>
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> > For additional commands, e-mail: dev-help@struts.apache.org
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Tiles support
Posted by Greg Huber <gr...@gmail.com>.
My thinking also, keep things simple. The patch includes all the tests
for completeness, I guess as it was meant to be.
On 13/10/2022 08:10, Lukasz Lenart wrote:
> To be honest, I would like to reduce as much as possible by taking
> some custom steps to generate something. I do not expect to have a lot
> of issues around Tiles or new feature requests, so having this as
> simple as possible is the way to go :)
>
>
> Cheers
> --
> Łukasz
> + 48 606 323 122 http://www.lenart.org.pl/
>
> wt., 11 paź 2022 o 11:24 Greg Huber <gr...@gmail.com> napisał(a):
>> I thought about the autotag stuff and with the validation/tests etc,
>> seemed a good idea to keep it, as its not that involved.
>>
>> Basically it uses template-suite.xml to generate the tag files and tld.
>>
>> I have got it all working, and passing the tests.
>>
>> Rather than the maven autotag plugin, I have a simple class
>> (BuildJspAutotags) that builds the tags to
>>
>> /target/generated-sources/autotag
>>
>> And then if changing the template-suite.xml, run the build and copy
>> manually the classes/tld back into the source.
>>
>> The org.apache.struts2.tiles.BuildJspAutotags.java probably needs a
>> better home.
>>
>> I have committed all this to
>>
>> https://github.com/gregh3269/struts/tree/WW-5233-tiles
>>
>> I can will do another PR so can have a look?
>>
>> On 11/10/2022 10:00, Lukasz Lenart wrote:
>>> I copied some auto generated classes but they depend on Autotag
>>> classes, so I copied them as well. If something is still missing I
>>> have a Tiles build locally and can copy other auto generated stuff.
>>> And yes, we should avoid maintaining Autotag, it complicates things.
>>> As far as I understand we only use / expose JSP tags, I don't know if
>>> someone is using Freemarker/Velocity directives - we can always add
>>> them later on request.
>>>
>>>
>>> Regards
>>> Łukasz
>>>
>>> niedz., 9 paź 2022 o 16:17 Greg Huber <gr...@gmail.com> napisał(a):
>>>> Looking at it in more depth, I think we need to leave as much code as
>>>> possible in the attic, including the autotag stuff. Keep only the parts to
>>>> make it work, and update the tag classes manually. Having to maintain
>>>> classes to generate the tag classes is pointless (might as well update them
>>>> directly). If we need to generate the tld we can use the struts tld
>>>> processor.
>>>>
>>>> This means we don't need all of the velocity code, support classes etc and
>>>> should reduce the plugin packages also.
>>>>
>>>> I will play around with it to see what we can loose, so we only have the
>>>> bare minimum.
>>>>
>>>>
>>>> On Sun, 9 Oct 2022 at 10:52, Greg Huber <gr...@gmail.com> wrote:
>>>>
>>>>> Or better, try to build the tags (whatever the maven-autotag-pluging
>>>>> did) on the plugin build?
>>>>>
>>>>> On 09/10/2022 10:28, Greg Huber wrote:
>>>>>> The reason why the taglibs were missing, they are generated by tiles
>>>>>> auto tag
>>>>>>
>>>>>> https://tiles.apache.org/tiles-autotag/
>>>>>>
>>>>>> Tiles-3 introduces a f Autotag Project, a project that automatically
>>>>>> generates tags (or tag-like) artifact from a common template code for
>>>>>> a range of templating languages. Today JSP tags, Freemarker directive
>>>>>> models and Velocity directives are generated from a common template
>>>>>> models.
>>>>>>
>>>>>> Do we use Freemarker directive models and Velocity directives?
>>>>>>
>>>>>> Maybe we don't need the autotag in the plugin as we have the tag
>>>>>> classes now?
>>>>>>
>>>>>> On 06/10/2022 14:05, Lukasz Lenart wrote:
>>>>>>> I have prepared a PR to copy Tiles code base into the Tile plugin -
>>>>>>> just copied what is needed by the plugin. I would like to merge it
>>>>>>> after releasing 6.1.0
>>>>>>>
>>>>>>> https://github.com/apache/struts/pull/608
>>>>>>>
>>>>>>>
>>>>>>> Regards
>>>>>>> --
>>>>>>> Łukasz
>>>>>>> + 48 606 323 122 http://www.lenart.org.pl/
>>>>>>>
>>>>>>> wt., 9 sie 2022 o 16:43 Antonio Petrelli <an...@gmail.com>
>>>>>>> napisał(a):
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>> For additional commands, e-mail: dev-help@struts.apache.org
>>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Tiles support
Posted by Lukasz Lenart <lu...@apache.org>.
To be honest, I would like to reduce as much as possible by taking
some custom steps to generate something. I do not expect to have a lot
of issues around Tiles or new feature requests, so having this as
simple as possible is the way to go :)
Cheers
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
wt., 11 paź 2022 o 11:24 Greg Huber <gr...@gmail.com> napisał(a):
>
> I thought about the autotag stuff and with the validation/tests etc,
> seemed a good idea to keep it, as its not that involved.
>
> Basically it uses template-suite.xml to generate the tag files and tld.
>
> I have got it all working, and passing the tests.
>
> Rather than the maven autotag plugin, I have a simple class
> (BuildJspAutotags) that builds the tags to
>
> /target/generated-sources/autotag
>
> And then if changing the template-suite.xml, run the build and copy
> manually the classes/tld back into the source.
>
> The org.apache.struts2.tiles.BuildJspAutotags.java probably needs a
> better home.
>
> I have committed all this to
>
> https://github.com/gregh3269/struts/tree/WW-5233-tiles
>
> I can will do another PR so can have a look?
>
> On 11/10/2022 10:00, Lukasz Lenart wrote:
> > I copied some auto generated classes but they depend on Autotag
> > classes, so I copied them as well. If something is still missing I
> > have a Tiles build locally and can copy other auto generated stuff.
> > And yes, we should avoid maintaining Autotag, it complicates things.
> > As far as I understand we only use / expose JSP tags, I don't know if
> > someone is using Freemarker/Velocity directives - we can always add
> > them later on request.
> >
> >
> > Regards
> > Łukasz
> >
> > niedz., 9 paź 2022 o 16:17 Greg Huber <gr...@gmail.com> napisał(a):
> >> Looking at it in more depth, I think we need to leave as much code as
> >> possible in the attic, including the autotag stuff. Keep only the parts to
> >> make it work, and update the tag classes manually. Having to maintain
> >> classes to generate the tag classes is pointless (might as well update them
> >> directly). If we need to generate the tld we can use the struts tld
> >> processor.
> >>
> >> This means we don't need all of the velocity code, support classes etc and
> >> should reduce the plugin packages also.
> >>
> >> I will play around with it to see what we can loose, so we only have the
> >> bare minimum.
> >>
> >>
> >> On Sun, 9 Oct 2022 at 10:52, Greg Huber <gr...@gmail.com> wrote:
> >>
> >>> Or better, try to build the tags (whatever the maven-autotag-pluging
> >>> did) on the plugin build?
> >>>
> >>> On 09/10/2022 10:28, Greg Huber wrote:
> >>>> The reason why the taglibs were missing, they are generated by tiles
> >>>> auto tag
> >>>>
> >>>> https://tiles.apache.org/tiles-autotag/
> >>>>
> >>>> Tiles-3 introduces a f Autotag Project, a project that automatically
> >>>> generates tags (or tag-like) artifact from a common template code for
> >>>> a range of templating languages. Today JSP tags, Freemarker directive
> >>>> models and Velocity directives are generated from a common template
> >>>> models.
> >>>>
> >>>> Do we use Freemarker directive models and Velocity directives?
> >>>>
> >>>> Maybe we don't need the autotag in the plugin as we have the tag
> >>>> classes now?
> >>>>
> >>>> On 06/10/2022 14:05, Lukasz Lenart wrote:
> >>>>> I have prepared a PR to copy Tiles code base into the Tile plugin -
> >>>>> just copied what is needed by the plugin. I would like to merge it
> >>>>> after releasing 6.1.0
> >>>>>
> >>>>> https://github.com/apache/struts/pull/608
> >>>>>
> >>>>>
> >>>>> Regards
> >>>>> --
> >>>>> Łukasz
> >>>>> + 48 606 323 122 http://www.lenart.org.pl/
> >>>>>
> >>>>> wt., 9 sie 2022 o 16:43 Antonio Petrelli <an...@gmail.com>
> >>>>> napisał(a):
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> > For additional commands, e-mail: dev-help@struts.apache.org
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Tiles support
Posted by Greg Huber <gr...@gmail.com>.
I thought about the autotag stuff and with the validation/tests etc,
seemed a good idea to keep it, as its not that involved.
Basically it uses template-suite.xml to generate the tag files and tld.
I have got it all working, and passing the tests.
Rather than the maven autotag plugin, I have a simple class
(BuildJspAutotags) that builds the tags to
/target/generated-sources/autotag
And then if changing the template-suite.xml, run the build and copy
manually the classes/tld back into the source.
The org.apache.struts2.tiles.BuildJspAutotags.java probably needs a
better home.
I have committed all this to
https://github.com/gregh3269/struts/tree/WW-5233-tiles
I can will do another PR so can have a look?
On 11/10/2022 10:00, Lukasz Lenart wrote:
> I copied some auto generated classes but they depend on Autotag
> classes, so I copied them as well. If something is still missing I
> have a Tiles build locally and can copy other auto generated stuff.
> And yes, we should avoid maintaining Autotag, it complicates things.
> As far as I understand we only use / expose JSP tags, I don't know if
> someone is using Freemarker/Velocity directives - we can always add
> them later on request.
>
>
> Regards
> Łukasz
>
> niedz., 9 paź 2022 o 16:17 Greg Huber <gr...@gmail.com> napisał(a):
>> Looking at it in more depth, I think we need to leave as much code as
>> possible in the attic, including the autotag stuff. Keep only the parts to
>> make it work, and update the tag classes manually. Having to maintain
>> classes to generate the tag classes is pointless (might as well update them
>> directly). If we need to generate the tld we can use the struts tld
>> processor.
>>
>> This means we don't need all of the velocity code, support classes etc and
>> should reduce the plugin packages also.
>>
>> I will play around with it to see what we can loose, so we only have the
>> bare minimum.
>>
>>
>> On Sun, 9 Oct 2022 at 10:52, Greg Huber <gr...@gmail.com> wrote:
>>
>>> Or better, try to build the tags (whatever the maven-autotag-pluging
>>> did) on the plugin build?
>>>
>>> On 09/10/2022 10:28, Greg Huber wrote:
>>>> The reason why the taglibs were missing, they are generated by tiles
>>>> auto tag
>>>>
>>>> https://tiles.apache.org/tiles-autotag/
>>>>
>>>> Tiles-3 introduces a f Autotag Project, a project that automatically
>>>> generates tags (or tag-like) artifact from a common template code for
>>>> a range of templating languages. Today JSP tags, Freemarker directive
>>>> models and Velocity directives are generated from a common template
>>>> models.
>>>>
>>>> Do we use Freemarker directive models and Velocity directives?
>>>>
>>>> Maybe we don't need the autotag in the plugin as we have the tag
>>>> classes now?
>>>>
>>>> On 06/10/2022 14:05, Lukasz Lenart wrote:
>>>>> I have prepared a PR to copy Tiles code base into the Tile plugin -
>>>>> just copied what is needed by the plugin. I would like to merge it
>>>>> after releasing 6.1.0
>>>>>
>>>>> https://github.com/apache/struts/pull/608
>>>>>
>>>>>
>>>>> Regards
>>>>> --
>>>>> Łukasz
>>>>> + 48 606 323 122 http://www.lenart.org.pl/
>>>>>
>>>>> wt., 9 sie 2022 o 16:43 Antonio Petrelli <an...@gmail.com>
>>>>> napisał(a):
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Tiles support
Posted by Lukasz Lenart <lu...@apache.org>.
I copied some auto generated classes but they depend on Autotag
classes, so I copied them as well. If something is still missing I
have a Tiles build locally and can copy other auto generated stuff.
And yes, we should avoid maintaining Autotag, it complicates things.
As far as I understand we only use / expose JSP tags, I don't know if
someone is using Freemarker/Velocity directives - we can always add
them later on request.
Regards
Łukasz
niedz., 9 paź 2022 o 16:17 Greg Huber <gr...@gmail.com> napisał(a):
>
> Looking at it in more depth, I think we need to leave as much code as
> possible in the attic, including the autotag stuff. Keep only the parts to
> make it work, and update the tag classes manually. Having to maintain
> classes to generate the tag classes is pointless (might as well update them
> directly). If we need to generate the tld we can use the struts tld
> processor.
>
> This means we don't need all of the velocity code, support classes etc and
> should reduce the plugin packages also.
>
> I will play around with it to see what we can loose, so we only have the
> bare minimum.
>
>
> On Sun, 9 Oct 2022 at 10:52, Greg Huber <gr...@gmail.com> wrote:
>
> > Or better, try to build the tags (whatever the maven-autotag-pluging
> > did) on the plugin build?
> >
> > On 09/10/2022 10:28, Greg Huber wrote:
> > > The reason why the taglibs were missing, they are generated by tiles
> > > auto tag
> > >
> > > https://tiles.apache.org/tiles-autotag/
> > >
> > > Tiles-3 introduces a f Autotag Project, a project that automatically
> > > generates tags (or tag-like) artifact from a common template code for
> > > a range of templating languages. Today JSP tags, Freemarker directive
> > > models and Velocity directives are generated from a common template
> > > models.
> > >
> > > Do we use Freemarker directive models and Velocity directives?
> > >
> > > Maybe we don't need the autotag in the plugin as we have the tag
> > > classes now?
> > >
> > > On 06/10/2022 14:05, Lukasz Lenart wrote:
> > >> I have prepared a PR to copy Tiles code base into the Tile plugin -
> > >> just copied what is needed by the plugin. I would like to merge it
> > >> after releasing 6.1.0
> > >>
> > >> https://github.com/apache/struts/pull/608
> > >>
> > >>
> > >> Regards
> > >> --
> > >> Łukasz
> > >> + 48 606 323 122 http://www.lenart.org.pl/
> > >>
> > >> wt., 9 sie 2022 o 16:43 Antonio Petrelli <an...@gmail.com>
> > >> napisał(a):
> >
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Tiles support
Posted by Greg Huber <gr...@gmail.com>.
Looking at it in more depth, I think we need to leave as much code as
possible in the attic, including the autotag stuff. Keep only the parts to
make it work, and update the tag classes manually. Having to maintain
classes to generate the tag classes is pointless (might as well update them
directly). If we need to generate the tld we can use the struts tld
processor.
This means we don't need all of the velocity code, support classes etc and
should reduce the plugin packages also.
I will play around with it to see what we can loose, so we only have the
bare minimum.
On Sun, 9 Oct 2022 at 10:52, Greg Huber <gr...@gmail.com> wrote:
> Or better, try to build the tags (whatever the maven-autotag-pluging
> did) on the plugin build?
>
> On 09/10/2022 10:28, Greg Huber wrote:
> > The reason why the taglibs were missing, they are generated by tiles
> > auto tag
> >
> > https://tiles.apache.org/tiles-autotag/
> >
> > Tiles-3 introduces a f Autotag Project, a project that automatically
> > generates tags (or tag-like) artifact from a common template code for
> > a range of templating languages. Today JSP tags, Freemarker directive
> > models and Velocity directives are generated from a common template
> > models.
> >
> > Do we use Freemarker directive models and Velocity directives?
> >
> > Maybe we don't need the autotag in the plugin as we have the tag
> > classes now?
> >
> > On 06/10/2022 14:05, Lukasz Lenart wrote:
> >> I have prepared a PR to copy Tiles code base into the Tile plugin -
> >> just copied what is needed by the plugin. I would like to merge it
> >> after releasing 6.1.0
> >>
> >> https://github.com/apache/struts/pull/608
> >>
> >>
> >> Regards
> >> --
> >> Łukasz
> >> + 48 606 323 122 http://www.lenart.org.pl/
> >>
> >> wt., 9 sie 2022 o 16:43 Antonio Petrelli <an...@gmail.com>
> >> napisał(a):
>
Re: Tiles support
Posted by Greg Huber <gr...@gmail.com>.
Or better, try to build the tags (whatever the maven-autotag-pluging
did) on the plugin build?
On 09/10/2022 10:28, Greg Huber wrote:
> The reason why the taglibs were missing, they are generated by tiles
> auto tag
>
> https://tiles.apache.org/tiles-autotag/
>
> Tiles-3 introduces a f Autotag Project, a project that automatically
> generates tags (or tag-like) artifact from a common template code for
> a range of templating languages. Today JSP tags, Freemarker directive
> models and Velocity directives are generated from a common template
> models.
>
> Do we use Freemarker directive models and Velocity directives?
>
> Maybe we don't need the autotag in the plugin as we have the tag
> classes now?
>
> On 06/10/2022 14:05, Lukasz Lenart wrote:
>> I have prepared a PR to copy Tiles code base into the Tile plugin -
>> just copied what is needed by the plugin. I would like to merge it
>> after releasing 6.1.0
>>
>> https://github.com/apache/struts/pull/608
>>
>>
>> Regards
>> --
>> Łukasz
>> + 48 606 323 122 http://www.lenart.org.pl/
>>
>> wt., 9 sie 2022 o 16:43 Antonio Petrelli <an...@gmail.com>
>> napisał(a):
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Tiles support
Posted by Greg Huber <gr...@gmail.com>.
The reason why the taglibs were missing, they are generated by tiles
auto tag
https://tiles.apache.org/tiles-autotag/
Tiles-3 introduces a f Autotag Project, a project that automatically
generates tags (or tag-like) artifact from a common template code for a
range of templating languages. Today JSP tags, Freemarker directive
models and Velocity directives are generated from a common template models.
Do we use Freemarker directive models and Velocity directives?
Maybe we don't need the autotag in the plugin as we have the tag classes
now?
On 06/10/2022 14:05, Lukasz Lenart wrote:
> I have prepared a PR to copy Tiles code base into the Tile plugin -
> just copied what is needed by the plugin. I would like to merge it
> after releasing 6.1.0
>
> https://github.com/apache/struts/pull/608
>
>
> Regards
> --
> Łukasz
> + 48 606 323 122 http://www.lenart.org.pl/
>
> wt., 9 sie 2022 o 16:43 Antonio Petrelli <an...@gmail.com>
> napisał(a):
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Tiles support
Posted by Greg Huber <gr...@gmail.com>.
....It might be the way I am running it but I get:
SEVERE: Error configuring application listener of class
[org.apache.struts2.tiles.StrutsTilesListener]
java.lang.NoClassDefFoundError: org/apache/tiles/startup/TilesInitializer
web.xml
<listener>
<listener-class>org.apache.struts2.tiles.StrutsTilesListener</listener-class>
</listener>
<context-param>
<param-name>org.apache.tiles.definition.DefinitionsFactory.DEFINITIONS_CONFIG</param-name>
<param-value>
/WEB-INF/tiles.xml
</param-value>
</context-param>
Do I need to make any changes to the web.xml file?
On 06/10/2022 14:19, Lukasz Lenart wrote:
> Yes
>
> W dniu czw., 6.10.2022 o 15:19 Greg Huber <gr...@gmail.com> napisał(a):
>
>> I can test it from the git branch in eclipse. Normally I would delete
>> the struts2* jars, so I guess its all of the tiles-* as well?
>>
>> On 06/10/2022 14:14, Lukasz Lenart wrote:
>>> czw., 6 paź 2022 o 15:11 Greg Huber <gr...@gmail.com> napisał(a):
>>>> Is the branch WW-5233-tiles working? I could give it a test drive.😛
>>> Yes, you can build a snapshot version out of it. That would be cool,
>> thanks!
>>>
>>> Regards
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>> For additional commands, e-mail: dev-help@struts.apache.org
>>
>> --
> (mobile)
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Tiles support
Posted by Greg Huber <gr...@gmail.com>.
Managed to get it to work.
####
I had to add all of the tag classes from tiles-jsp-3.0.8.jar to
org/apache/tiles/web/jsp/taglib
and change the package to match in the tiles-jsp.tld.
ie
org.apache.tiles.jsp.taglib.
to
org.apache.tiles.web.jsp.taglib.
####
One java class that won't compile from tiles-jsp-3.0.8.jar is:
public class GetAsStringTag extends SimpleTagSupport {
/**
* The template model.
*/
private org.apache.tiles.template.GetAsStringModel model = new
org.apache.tiles.template.GetAsStringModel();
..
}
The constructor GetAsStringModel() is undefined
####
The classes have a note of
"This file was automatically generated by Apache Tiles Autotag."
maybe these are built somehow?
Cheers
On 06/10/2022 14:19, Lukasz Lenart wrote:
> Yes
>
> W dniu czw., 6.10.2022 o 15:19 Greg Huber <gr...@gmail.com> napisał(a):
>
>> I can test it from the git branch in eclipse. Normally I would delete
>> the struts2* jars, so I guess its all of the tiles-* as well?
>>
>> On 06/10/2022 14:14, Lukasz Lenart wrote:
>>> czw., 6 paź 2022 o 15:11 Greg Huber <gr...@gmail.com> napisał(a):
>>>> Is the branch WW-5233-tiles working? I could give it a test drive.😛
>>> Yes, you can build a snapshot version out of it. That would be cool,
>> thanks!
>>>
>>> Regards
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>> For additional commands, e-mail: dev-help@struts.apache.org
>>
>> --
> (mobile)
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Tiles support
Posted by Greg Huber <gr...@gmail.com>.
I have built it now, where is the
<%@ taglib uri="http://tiles.apache.org/tags-tiles" prefix="tiles" %>
stored? It was in the tiles-jsp-3.0.8.jar file before.
If I look in
struts/plugins/tiles/target/classes/META-INF
struts/plugins/tiles/target/classes/META-INF/tld
there is only tiles-extras-jsp.tld
On 06/10/2022 14:19, Lukasz Lenart wrote:
> Yes
>
> W dniu czw., 6.10.2022 o 15:19 Greg Huber <gr...@gmail.com> napisał(a):
>
>> I can test it from the git branch in eclipse. Normally I would delete
>> the struts2* jars, so I guess its all of the tiles-* as well?
>>
>> On 06/10/2022 14:14, Lukasz Lenart wrote:
>>> czw., 6 paź 2022 o 15:11 Greg Huber <gr...@gmail.com> napisał(a):
>>>> Is the branch WW-5233-tiles working? I could give it a test drive.😛
>>> Yes, you can build a snapshot version out of it. That would be cool,
>> thanks!
>>>
>>> Regards
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>> For additional commands, e-mail: dev-help@struts.apache.org
>>
>> --
> (mobile)
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Tiles support
Posted by Lukasz Lenart <lu...@apache.org>.
Sure, looks like I forgot to copy Tiles JSP
czw., 6 paź 2022 o 18:00 Greg Huber <gr...@gmail.com> napisał(a):
>
> I can do a pr on branch WW-5233-tiles with it working?
>
> I will clean up the code also.
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Tiles support
Posted by Greg Huber <gr...@gmail.com>.
I can do a pr on branch WW-5233-tiles with it working?
I will clean up the code also.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Tiles support
Posted by Greg Huber <gr...@gmail.com>.
ok, sorry missed a delete of a jar,
...just need to fix the missing tld
/WEB-INF/jsps/tiles/tiles-page.jsp (line: [3], column: [0]) The absolute
uri: [http://tiles.apache.org/tags-tiles] cannot be resolved in either
web.xml or the jar files deployed with this application
I have this with the core, struts-tags.tld, I run build-maven compile
from the pom.xml. Is there one for tiles to generate the tld?
On 06/10/2022 14:19, Lukasz Lenart wrote:
> Yes
>
> W dniu czw., 6.10.2022 o 15:19 Greg Huber <gr...@gmail.com> napisał(a):
>
>> I can test it from the git branch in eclipse. Normally I would delete
>> the struts2* jars, so I guess its all of the tiles-* as well?
>>
>> On 06/10/2022 14:14, Lukasz Lenart wrote:
>>> czw., 6 paź 2022 o 15:11 Greg Huber <gr...@gmail.com> napisał(a):
>>>> Is the branch WW-5233-tiles working? I could give it a test drive.😛
>>> Yes, you can build a snapshot version out of it. That would be cool,
>> thanks!
>>>
>>> Regards
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>> For additional commands, e-mail: dev-help@struts.apache.org
>>
>> --
> (mobile)
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Tiles support
Posted by Lukasz Lenart <lu...@apache.org>.
Yes
W dniu czw., 6.10.2022 o 15:19 Greg Huber <gr...@gmail.com> napisał(a):
> I can test it from the git branch in eclipse. Normally I would delete
> the struts2* jars, so I guess its all of the tiles-* as well?
>
> On 06/10/2022 14:14, Lukasz Lenart wrote:
> > czw., 6 paź 2022 o 15:11 Greg Huber <gr...@gmail.com> napisał(a):
> >> Is the branch WW-5233-tiles working? I could give it a test drive.😛
> > Yes, you can build a snapshot version out of it. That would be cool,
> thanks!
> >
> >
> > Regards
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
> --
(mobile)
Re: Tiles support
Posted by Greg Huber <gr...@gmail.com>.
I can test it from the git branch in eclipse. Normally I would delete
the struts2* jars, so I guess its all of the tiles-* as well?
On 06/10/2022 14:14, Lukasz Lenart wrote:
> czw., 6 paź 2022 o 15:11 Greg Huber <gr...@gmail.com> napisał(a):
>> Is the branch WW-5233-tiles working? I could give it a test drive.😛
> Yes, you can build a snapshot version out of it. That would be cool, thanks!
>
>
> Regards
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Tiles support
Posted by Lukasz Lenart <lu...@apache.org>.
czw., 6 paź 2022 o 15:11 Greg Huber <gr...@gmail.com> napisał(a):
>
> Is the branch WW-5233-tiles working? I could give it a test drive.😛
Yes, you can build a snapshot version out of it. That would be cool, thanks!
Regards
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Tiles support
Posted by Greg Huber <gr...@gmail.com>.
Is the branch WW-5233-tiles working? I could give it a test drive.😛
On 06/10/2022 14:05, Lukasz Lenart wrote:
> I have prepared a PR to copy Tiles code base into the Tile plugin -
> just copied what is needed by the plugin. I would like to merge it
> after releasing 6.1.0
>
> https://github.com/apache/struts/pull/608
>
>
> Regards
> --
> Łukasz
> + 48 606 323 122 http://www.lenart.org.pl/
>
> wt., 9 sie 2022 o 16:43 Antonio Petrelli <an...@gmail.com>
> napisał(a):
>> Il giorno mar 9 ago 2022 alle ore 07:32 Lukasz Lenart <
>> lukaszlenart@apache.org> ha scritto:
>>
>>> ... but from my perspective
>>> Struts 2 is using just a few features of the Apache Tiles and from
>>> project management perspective it will be easier to copy what is
>>> needed instead of managing & releasing a whole new project (instead
>>> just fixing in Struts 2, we would have to fix Tiles first, release it
>>> and fix Struts - this is similar thing we have with OGNL for example).
>>> Also as someone already pointed out, less dependency is better,
>>> especially if we would like to prepare support for JakartaEE.
>>>
>> Ok, I'd ask the attic about this topic, though, just to be sure. I think
>> there will be no problem. The only problem that I am aware of is that, if
>> you want to use a project in the attic *outside* of Apache, you have to
>> rename it (see iBATIS and MyBatis as an example).
>> But since it is everything in Apache this might be different.
>>
>> Anyway, IANAL, ask the attic.
>>
>> Antonio
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org