[GitHub] [lucene] rmuir commented on pull request #11749: Remove usages of System.currentTimeMillis() from tests

[GitBox <gi...@apache.org>]

rmuir commented on PR #11749:
URL: https://github.com/apache/lucene/pull/11749#issuecomment-1238236097

   Thanks for doing this work, this change looks great!
   avoiding wall-clock time should make tests more reproducible when they fail.
   also, this change fixes tests that were configured to run for `3 seconds` or similar, to instead use a fixed number of iterations. This should REALLY help reproducibility, esp when one CPU is faster than another.
   
   I added a small comment, i think we can fix that one classification test to get the build happy here.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org