You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by "cshannon (via GitHub)" <gi...@apache.org> on 2025/02/05 14:58:42 UTC

Re: [PR] AMQ-9658 - Properly increment transport receive counter [activemq]

cshannon commented on PR #1389:
URL: https://github.com/apache/activemq/pull/1389#issuecomment-2637102058

   I am going to merge this as tests all passed, one interesting thing to note is that the counter never resets so it could easily overflow if a connection sends more than 2 gigs. It's used by the inactivity monitor (which only cares about changes and not value) so it's probably ok but we should look at moving to a long if we want to track accurate metrics at some point.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact