You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Sushil Mohanty <su...@gmail.com> on 2015/05/11 11:57:02 UTC

Review Request 34033: LENS-204 : Support union across tables in cube rewriting

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34033/
-----------------------------------------------------------

Review request for lens and Amareshwari Sriramadasu.


Bugs: LENS-204
    https://issues.apache.org/jira/browse/LENS-204


Repository: lens


Description
-------

Support for union across two or more tables in cube query rewriting.


Diffs
-----

  lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 47b9fc1 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java b7c3ee9 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DimOnlyHQLContext.java 8a23ded 
  lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java beaa551 
  lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java PRE-CREATION 
  lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java e5a6b32 
  lens-cube/src/main/java/org/apache/lens/cube/parse/UnionHQLContext.java PRE-CREATION 
  lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 3203354 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java c915353 

Diff: https://reviews.apache.org/r/34033/diff/


Testing
-------

Updated unit tests wrt union support. mvn clean test is running fine.

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [8.026s]
[INFO] Lens .............................................. SUCCESS [0.299s]
[INFO] Lens API .......................................... SUCCESS [17.493s]
[INFO] Lens API for server and extensions ................ SUCCESS [15.690s]
[INFO] Lens Cube ......................................... SUCCESS [4:13.909s]
[INFO] Lens DB storage ................................... SUCCESS [16.124s]
[INFO] Lens Query Library ................................ SUCCESS [10.275s]
[INFO] Lens Hive Driver .................................. SUCCESS [3:55.868s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [27.174s]
[INFO] Lens Server ....................................... SUCCESS [10:18.860s]
[INFO] Lens client ....................................... SUCCESS [35.250s]
[INFO] Lens CLI .......................................... SUCCESS [5:21.299s]
[INFO] Lens Examples ..................................... SUCCESS [4.412s]
[INFO] Lens Distribution ................................. SUCCESS [2.964s]
[INFO] Lens ML Lib ....................................... SUCCESS [2:22.502s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [6.153s]
[INFO] Lens Regression ................................... SUCCESS [0.909s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 28:38.764s
[INFO] Finished at: Mon May 11 13:59:03 GMT+05:30 2015
[INFO] Final Memory: 85M/1078M
[INFO] ------------------------------------------------------------------------


Thanks,

Sushil Mohanty

Re: Review Request 34033: LENS-204 : Support union across tables in cube rewriting

Posted by Sushil Mohanty <su...@gmail.com>.

> On May 11, 2015, 11:03 a.m., Amareshwari Sriramadasu wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java, line 90
> > <https://reviews.apache.org/r/34033/diff/1/?file=955204#file955204line90>
> >
> >     Is this used any more?

Not being used. Removed it.


- Sushil


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34033/#review83217
-----------------------------------------------------------


On May 11, 2015, 9:57 a.m., Sushil Mohanty wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34033/
> -----------------------------------------------------------
> 
> (Updated May 11, 2015, 9:57 a.m.)
> 
> 
> Review request for lens and Amareshwari Sriramadasu.
> 
> 
> Bugs: LENS-204
>     https://issues.apache.org/jira/browse/LENS-204
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Support for union across two or more tables in cube query rewriting.
> 
> 
> Diffs
> -----
> 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 47b9fc1 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java b7c3ee9 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DimOnlyHQLContext.java 8a23ded 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java beaa551 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java e5a6b32 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/UnionHQLContext.java PRE-CREATION 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 3203354 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java c915353 
> 
> Diff: https://reviews.apache.org/r/34033/diff/
> 
> 
> Testing
> -------
> 
> Updated unit tests wrt union support. mvn clean test is running fine.
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [8.026s]
> [INFO] Lens .............................................. SUCCESS [0.299s]
> [INFO] Lens API .......................................... SUCCESS [17.493s]
> [INFO] Lens API for server and extensions ................ SUCCESS [15.690s]
> [INFO] Lens Cube ......................................... SUCCESS [4:13.909s]
> [INFO] Lens DB storage ................................... SUCCESS [16.124s]
> [INFO] Lens Query Library ................................ SUCCESS [10.275s]
> [INFO] Lens Hive Driver .................................. SUCCESS [3:55.868s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [27.174s]
> [INFO] Lens Server ....................................... SUCCESS [10:18.860s]
> [INFO] Lens client ....................................... SUCCESS [35.250s]
> [INFO] Lens CLI .......................................... SUCCESS [5:21.299s]
> [INFO] Lens Examples ..................................... SUCCESS [4.412s]
> [INFO] Lens Distribution ................................. SUCCESS [2.964s]
> [INFO] Lens ML Lib ....................................... SUCCESS [2:22.502s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [6.153s]
> [INFO] Lens Regression ................................... SUCCESS [0.909s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 28:38.764s
> [INFO] Finished at: Mon May 11 13:59:03 GMT+05:30 2015
> [INFO] Final Memory: 85M/1078M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Sushil Mohanty
> 
>

Re: Review Request 34033: LENS-204 : Support union across tables in cube rewriting

Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34033/#review83217
-----------------------------------------------------------



lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java
<https://reviews.apache.org/r/34033/#comment134123>

    We should remove this and enableMultiFactSelect flag fully. It need not be part of this jira, can be a follow up jira after this.



lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java
<https://reviews.apache.org/r/34033/#comment134121>

    Is this used any more?



lens-cube/src/main/java/org/apache/lens/cube/parse/UnionHQLContext.java
<https://reviews.apache.org/r/34033/#comment134122>

    Instead of returning null, we might want to throw unimplemented expcetion


- Amareshwari Sriramadasu


On May 11, 2015, 9:57 a.m., Sushil Mohanty wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34033/
> -----------------------------------------------------------
> 
> (Updated May 11, 2015, 9:57 a.m.)
> 
> 
> Review request for lens and Amareshwari Sriramadasu.
> 
> 
> Bugs: LENS-204
>     https://issues.apache.org/jira/browse/LENS-204
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Support for union across two or more tables in cube query rewriting.
> 
> 
> Diffs
> -----
> 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 47b9fc1 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java b7c3ee9 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DimOnlyHQLContext.java 8a23ded 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java beaa551 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java e5a6b32 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/UnionHQLContext.java PRE-CREATION 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 3203354 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java c915353 
> 
> Diff: https://reviews.apache.org/r/34033/diff/
> 
> 
> Testing
> -------
> 
> Updated unit tests wrt union support. mvn clean test is running fine.
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [8.026s]
> [INFO] Lens .............................................. SUCCESS [0.299s]
> [INFO] Lens API .......................................... SUCCESS [17.493s]
> [INFO] Lens API for server and extensions ................ SUCCESS [15.690s]
> [INFO] Lens Cube ......................................... SUCCESS [4:13.909s]
> [INFO] Lens DB storage ................................... SUCCESS [16.124s]
> [INFO] Lens Query Library ................................ SUCCESS [10.275s]
> [INFO] Lens Hive Driver .................................. SUCCESS [3:55.868s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [27.174s]
> [INFO] Lens Server ....................................... SUCCESS [10:18.860s]
> [INFO] Lens client ....................................... SUCCESS [35.250s]
> [INFO] Lens CLI .......................................... SUCCESS [5:21.299s]
> [INFO] Lens Examples ..................................... SUCCESS [4.412s]
> [INFO] Lens Distribution ................................. SUCCESS [2.964s]
> [INFO] Lens ML Lib ....................................... SUCCESS [2:22.502s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [6.153s]
> [INFO] Lens Regression ................................... SUCCESS [0.909s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 28:38.764s
> [INFO] Finished at: Mon May 11 13:59:03 GMT+05:30 2015
> [INFO] Final Memory: 85M/1078M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Sushil Mohanty
> 
>

Re: Review Request 34033: LENS-204 : Support union across tables in cube rewriting

Posted by Sushil Mohanty <su...@gmail.com>.

> On May 11, 2015, 11:26 a.m., Rajat Khandelwal wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java, line 336
> > <https://reviews.apache.org/r/34033/diff/1/?file=955206#file955206line336>
> >
> >     So if multiple storages have the same partition, they are unioned?
> 
> Sushil Mohanty wrote:
>     Yes. Need to make the partitions across storage tables mutually exclusive to avoid duplicate counting.
> 
> Amareshwari Sriramadasu wrote:
>     We already pick minimal storage tables covering all partitions. That should remove duplicate partitions. Can you check?
> 
> Sushil Mohanty wrote:
>     yes.
> 
> Amareshwari Sriramadasu wrote:
>     Seems this issue still exists with current changes put up.
>     
>     For example : 
>     Consider following query with common partitions.
>      Range : X partitions : X1 + C (common) partitions are in S1 and X2 + C partitions are in S2. Right now, where clause is written with common partitions included.
>      Minimal storage tables covered would give : S1 covers X1+C and S2 covers X2. If we write the query with this. where clause will correctly include partitions in storage, without duplicates.
>      
>     Consider the following multi range query with multiple storages :
>     Range1 ( X ): X1 +C -> S1; X2 + C -> S2;
>     Range2 ( Y ): Y1 +C2 -> S1; Y2+C2 -> S2;
>     
>     Minimal storage cover will give : S1 -> X1+Y1+C+C1; S2 -> X2+Y2; Where clause for range should look at intersection of minimal cover and range parts. Then it will give 
>     range1's where clause : S1 -> X1+c; S2- > X2;
>     range2's where clause : S1 -> Y1+c2; S2- > Y2;

Updated patch to handle the above scenario.


- Sushil


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34033/#review83213
-----------------------------------------------------------


On May 18, 2015, 11:44 a.m., Sushil Mohanty wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34033/
> -----------------------------------------------------------
> 
> (Updated May 18, 2015, 11:44 a.m.)
> 
> 
> Review request for lens and Amareshwari Sriramadasu.
> 
> 
> Bugs: LENS-204
>     https://issues.apache.org/jira/browse/LENS-204
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Support for union across two or more tables in cube query rewriting.
> 
> 
> Diffs
> -----
> 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 31eb113 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java 230a2ee 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DimOnlyHQLContext.java 785b0e4 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java e14fcfa 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java bdc9855 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/UnionHQLContext.java PRE-CREATION 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 1fe4173 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 44826bd 
> 
> Diff: https://reviews.apache.org/r/34033/diff/
> 
> 
> Testing
> -------
> 
> Updated unit tests wrt union support. mvn clean test is running fine.
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [8.026s]
> [INFO] Lens .............................................. SUCCESS [0.299s]
> [INFO] Lens API .......................................... SUCCESS [17.493s]
> [INFO] Lens API for server and extensions ................ SUCCESS [15.690s]
> [INFO] Lens Cube ......................................... SUCCESS [4:13.909s]
> [INFO] Lens DB storage ................................... SUCCESS [16.124s]
> [INFO] Lens Query Library ................................ SUCCESS [10.275s]
> [INFO] Lens Hive Driver .................................. SUCCESS [3:55.868s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [27.174s]
> [INFO] Lens Server ....................................... SUCCESS [10:18.860s]
> [INFO] Lens client ....................................... SUCCESS [35.250s]
> [INFO] Lens CLI .......................................... SUCCESS [5:21.299s]
> [INFO] Lens Examples ..................................... SUCCESS [4.412s]
> [INFO] Lens Distribution ................................. SUCCESS [2.964s]
> [INFO] Lens ML Lib ....................................... SUCCESS [2:22.502s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [6.153s]
> [INFO] Lens Regression ................................... SUCCESS [0.909s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 28:38.764s
> [INFO] Finished at: Mon May 11 13:59:03 GMT+05:30 2015
> [INFO] Final Memory: 85M/1078M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Sushil Mohanty
> 
>

Re: Review Request 34033: LENS-204 : Support union across tables in cube rewriting

Posted by Amareshwari Sriramadasu <am...@apache.org>.

> On May 11, 2015, 11:26 a.m., Rajat Khandelwal wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java, line 336
> > <https://reviews.apache.org/r/34033/diff/1/?file=955206#file955206line336>
> >
> >     So if multiple storages have the same partition, they are unioned?
> 
> Sushil Mohanty wrote:
>     Yes. Need to make the partitions across storage tables mutually exclusive to avoid duplicate counting.
> 
> Amareshwari Sriramadasu wrote:
>     We already pick minimal storage tables covering all partitions. That should remove duplicate partitions. Can you check?
> 
> Sushil Mohanty wrote:
>     yes.

Seems this issue still exists with current changes put up.

For example : 
Consider following query with common partitions.
 Range : X partitions : X1 + C (common) partitions are in S1 and X2 + C partitions are in S2. Right now, where clause is written with common partitions included.
 Minimal storage tables covered would give : S1 covers X1+C and S2 covers X2. If we write the query with this. where clause will correctly include partitions in storage, without duplicates.
 
Consider the following multi range query with multiple storages :
Range1 ( X ): X1 +C -> S1; X2 + C -> S2;
Range2 ( Y ): Y1 +C2 -> S1; Y2+C2 -> S2;

Minimal storage cover will give : S1 -> X1+Y1+C+C1; S2 -> X2+Y2; Where clause for range should look at intersection of minimal cover and range parts. Then it will give 
range1's where clause : S1 -> X1+c; S2- > X2;
range2's where clause : S1 -> Y1+c2; S2- > Y2;


- Amareshwari


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34033/#review83213
-----------------------------------------------------------


On May 12, 2015, 8:33 a.m., Sushil Mohanty wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34033/
> -----------------------------------------------------------
> 
> (Updated May 12, 2015, 8:33 a.m.)
> 
> 
> Review request for lens and Amareshwari Sriramadasu.
> 
> 
> Bugs: LENS-204
>     https://issues.apache.org/jira/browse/LENS-204
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Support for union across two or more tables in cube query rewriting.
> 
> 
> Diffs
> -----
> 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 47b9fc1 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java b7c3ee9 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DimOnlyHQLContext.java 8a23ded 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java beaa551 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java e5a6b32 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/UnionHQLContext.java PRE-CREATION 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 3203354 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java c915353 
> 
> Diff: https://reviews.apache.org/r/34033/diff/
> 
> 
> Testing
> -------
> 
> Updated unit tests wrt union support. mvn clean test is running fine.
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [8.026s]
> [INFO] Lens .............................................. SUCCESS [0.299s]
> [INFO] Lens API .......................................... SUCCESS [17.493s]
> [INFO] Lens API for server and extensions ................ SUCCESS [15.690s]
> [INFO] Lens Cube ......................................... SUCCESS [4:13.909s]
> [INFO] Lens DB storage ................................... SUCCESS [16.124s]
> [INFO] Lens Query Library ................................ SUCCESS [10.275s]
> [INFO] Lens Hive Driver .................................. SUCCESS [3:55.868s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [27.174s]
> [INFO] Lens Server ....................................... SUCCESS [10:18.860s]
> [INFO] Lens client ....................................... SUCCESS [35.250s]
> [INFO] Lens CLI .......................................... SUCCESS [5:21.299s]
> [INFO] Lens Examples ..................................... SUCCESS [4.412s]
> [INFO] Lens Distribution ................................. SUCCESS [2.964s]
> [INFO] Lens ML Lib ....................................... SUCCESS [2:22.502s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [6.153s]
> [INFO] Lens Regression ................................... SUCCESS [0.909s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 28:38.764s
> [INFO] Finished at: Mon May 11 13:59:03 GMT+05:30 2015
> [INFO] Final Memory: 85M/1078M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Sushil Mohanty
> 
>

Re: Review Request 34033: LENS-204 : Support union across tables in cube rewriting

Posted by Amareshwari Sriramadasu <am...@apache.org>.

> On May 11, 2015, 11:26 a.m., Rajat Khandelwal wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java, line 336
> > <https://reviews.apache.org/r/34033/diff/1/?file=955206#file955206line336>
> >
> >     So if multiple storages have the same partition, they are unioned?
> 
> Sushil Mohanty wrote:
>     Yes. Need to make the partitions across storage tables mutually exclusive to avoid duplicate counting.

We already pick minimal storage tables covering all partitions. That should remove duplicate partitions. Can you check?


- Amareshwari


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34033/#review83213
-----------------------------------------------------------


On May 11, 2015, 9:57 a.m., Sushil Mohanty wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34033/
> -----------------------------------------------------------
> 
> (Updated May 11, 2015, 9:57 a.m.)
> 
> 
> Review request for lens and Amareshwari Sriramadasu.
> 
> 
> Bugs: LENS-204
>     https://issues.apache.org/jira/browse/LENS-204
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Support for union across two or more tables in cube query rewriting.
> 
> 
> Diffs
> -----
> 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 47b9fc1 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java b7c3ee9 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DimOnlyHQLContext.java 8a23ded 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java beaa551 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java e5a6b32 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/UnionHQLContext.java PRE-CREATION 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 3203354 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java c915353 
> 
> Diff: https://reviews.apache.org/r/34033/diff/
> 
> 
> Testing
> -------
> 
> Updated unit tests wrt union support. mvn clean test is running fine.
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [8.026s]
> [INFO] Lens .............................................. SUCCESS [0.299s]
> [INFO] Lens API .......................................... SUCCESS [17.493s]
> [INFO] Lens API for server and extensions ................ SUCCESS [15.690s]
> [INFO] Lens Cube ......................................... SUCCESS [4:13.909s]
> [INFO] Lens DB storage ................................... SUCCESS [16.124s]
> [INFO] Lens Query Library ................................ SUCCESS [10.275s]
> [INFO] Lens Hive Driver .................................. SUCCESS [3:55.868s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [27.174s]
> [INFO] Lens Server ....................................... SUCCESS [10:18.860s]
> [INFO] Lens client ....................................... SUCCESS [35.250s]
> [INFO] Lens CLI .......................................... SUCCESS [5:21.299s]
> [INFO] Lens Examples ..................................... SUCCESS [4.412s]
> [INFO] Lens Distribution ................................. SUCCESS [2.964s]
> [INFO] Lens ML Lib ....................................... SUCCESS [2:22.502s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [6.153s]
> [INFO] Lens Regression ................................... SUCCESS [0.909s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 28:38.764s
> [INFO] Finished at: Mon May 11 13:59:03 GMT+05:30 2015
> [INFO] Final Memory: 85M/1078M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Sushil Mohanty
> 
>

Re: Review Request 34033: LENS-204 : Support union across tables in cube rewriting

Posted by Sushil Mohanty <su...@gmail.com>.

> On May 11, 2015, 11:26 a.m., Rajat Khandelwal wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java, line 336
> > <https://reviews.apache.org/r/34033/diff/1/?file=955206#file955206line336>
> >
> >     So if multiple storages have the same partition, they are unioned?

Yes. Need to make the partitions across storage tables mutually exclusive to avoid duplicate counting.


- Sushil


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34033/#review83213
-----------------------------------------------------------


On May 11, 2015, 9:57 a.m., Sushil Mohanty wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34033/
> -----------------------------------------------------------
> 
> (Updated May 11, 2015, 9:57 a.m.)
> 
> 
> Review request for lens and Amareshwari Sriramadasu.
> 
> 
> Bugs: LENS-204
>     https://issues.apache.org/jira/browse/LENS-204
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Support for union across two or more tables in cube query rewriting.
> 
> 
> Diffs
> -----
> 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 47b9fc1 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java b7c3ee9 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DimOnlyHQLContext.java 8a23ded 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java beaa551 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java e5a6b32 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/UnionHQLContext.java PRE-CREATION 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 3203354 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java c915353 
> 
> Diff: https://reviews.apache.org/r/34033/diff/
> 
> 
> Testing
> -------
> 
> Updated unit tests wrt union support. mvn clean test is running fine.
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [8.026s]
> [INFO] Lens .............................................. SUCCESS [0.299s]
> [INFO] Lens API .......................................... SUCCESS [17.493s]
> [INFO] Lens API for server and extensions ................ SUCCESS [15.690s]
> [INFO] Lens Cube ......................................... SUCCESS [4:13.909s]
> [INFO] Lens DB storage ................................... SUCCESS [16.124s]
> [INFO] Lens Query Library ................................ SUCCESS [10.275s]
> [INFO] Lens Hive Driver .................................. SUCCESS [3:55.868s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [27.174s]
> [INFO] Lens Server ....................................... SUCCESS [10:18.860s]
> [INFO] Lens client ....................................... SUCCESS [35.250s]
> [INFO] Lens CLI .......................................... SUCCESS [5:21.299s]
> [INFO] Lens Examples ..................................... SUCCESS [4.412s]
> [INFO] Lens Distribution ................................. SUCCESS [2.964s]
> [INFO] Lens ML Lib ....................................... SUCCESS [2:22.502s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [6.153s]
> [INFO] Lens Regression ................................... SUCCESS [0.909s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 28:38.764s
> [INFO] Finished at: Mon May 11 13:59:03 GMT+05:30 2015
> [INFO] Final Memory: 85M/1078M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Sushil Mohanty
> 
>

Re: Review Request 34033: LENS-204 : Support union across tables in cube rewriting

Posted by Sushil Mohanty <su...@gmail.com>.

> On May 11, 2015, 11:26 a.m., Rajat Khandelwal wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java, line 336
> > <https://reviews.apache.org/r/34033/diff/1/?file=955206#file955206line336>
> >
> >     So if multiple storages have the same partition, they are unioned?
> 
> Sushil Mohanty wrote:
>     Yes. Need to make the partitions across storage tables mutually exclusive to avoid duplicate counting.
> 
> Amareshwari Sriramadasu wrote:
>     We already pick minimal storage tables covering all partitions. That should remove duplicate partitions. Can you check?

yes.


- Sushil


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34033/#review83213
-----------------------------------------------------------


On May 11, 2015, 9:57 a.m., Sushil Mohanty wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34033/
> -----------------------------------------------------------
> 
> (Updated May 11, 2015, 9:57 a.m.)
> 
> 
> Review request for lens and Amareshwari Sriramadasu.
> 
> 
> Bugs: LENS-204
>     https://issues.apache.org/jira/browse/LENS-204
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Support for union across two or more tables in cube query rewriting.
> 
> 
> Diffs
> -----
> 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 47b9fc1 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java b7c3ee9 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DimOnlyHQLContext.java 8a23ded 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java beaa551 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java e5a6b32 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/UnionHQLContext.java PRE-CREATION 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 3203354 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java c915353 
> 
> Diff: https://reviews.apache.org/r/34033/diff/
> 
> 
> Testing
> -------
> 
> Updated unit tests wrt union support. mvn clean test is running fine.
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [8.026s]
> [INFO] Lens .............................................. SUCCESS [0.299s]
> [INFO] Lens API .......................................... SUCCESS [17.493s]
> [INFO] Lens API for server and extensions ................ SUCCESS [15.690s]
> [INFO] Lens Cube ......................................... SUCCESS [4:13.909s]
> [INFO] Lens DB storage ................................... SUCCESS [16.124s]
> [INFO] Lens Query Library ................................ SUCCESS [10.275s]
> [INFO] Lens Hive Driver .................................. SUCCESS [3:55.868s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [27.174s]
> [INFO] Lens Server ....................................... SUCCESS [10:18.860s]
> [INFO] Lens client ....................................... SUCCESS [35.250s]
> [INFO] Lens CLI .......................................... SUCCESS [5:21.299s]
> [INFO] Lens Examples ..................................... SUCCESS [4.412s]
> [INFO] Lens Distribution ................................. SUCCESS [2.964s]
> [INFO] Lens ML Lib ....................................... SUCCESS [2:22.502s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [6.153s]
> [INFO] Lens Regression ................................... SUCCESS [0.909s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 28:38.764s
> [INFO] Finished at: Mon May 11 13:59:03 GMT+05:30 2015
> [INFO] Final Memory: 85M/1078M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Sushil Mohanty
> 
>

Re: Review Request 34033: LENS-204 : Support union across tables in cube rewriting

Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34033/#review83213
-----------------------------------------------------------



lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java
<https://reviews.apache.org/r/34033/#comment134113>

    Just use `@Getter`



lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java
<https://reviews.apache.org/r/34033/#comment134114>

    I think `super()` is implicitly called without writing.



lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java
<https://reviews.apache.org/r/34033/#comment134117>

    can be replaced with a foreach loop.



lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java
<https://reviews.apache.org/r/34033/#comment134116>

    Not needed.



lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java
<https://reviews.apache.org/r/34033/#comment134118>

    So if multiple storages have the same partition, they are unioned?



lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java
<https://reviews.apache.org/r/34033/#comment134115>

    Don't need to put again. It's already present in the map.



lens-cube/src/main/java/org/apache/lens/cube/parse/UnionHQLContext.java
<https://reviews.apache.org/r/34033/#comment134125>

    The two constructors can be replaces with lombok annotations: `AllArgsConstructor ` and `NoArgsConstructor`


- Rajat Khandelwal


On May 11, 2015, 3:27 p.m., Sushil Mohanty wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34033/
> -----------------------------------------------------------
> 
> (Updated May 11, 2015, 3:27 p.m.)
> 
> 
> Review request for lens and Amareshwari Sriramadasu.
> 
> 
> Bugs: LENS-204
>     https://issues.apache.org/jira/browse/LENS-204
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Support for union across two or more tables in cube query rewriting.
> 
> 
> Diffs
> -----
> 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 47b9fc1 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java b7c3ee9 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DimOnlyHQLContext.java 8a23ded 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java beaa551 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java e5a6b32 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/UnionHQLContext.java PRE-CREATION 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 3203354 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java c915353 
> 
> Diff: https://reviews.apache.org/r/34033/diff/
> 
> 
> Testing
> -------
> 
> Updated unit tests wrt union support. mvn clean test is running fine.
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [8.026s]
> [INFO] Lens .............................................. SUCCESS [0.299s]
> [INFO] Lens API .......................................... SUCCESS [17.493s]
> [INFO] Lens API for server and extensions ................ SUCCESS [15.690s]
> [INFO] Lens Cube ......................................... SUCCESS [4:13.909s]
> [INFO] Lens DB storage ................................... SUCCESS [16.124s]
> [INFO] Lens Query Library ................................ SUCCESS [10.275s]
> [INFO] Lens Hive Driver .................................. SUCCESS [3:55.868s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [27.174s]
> [INFO] Lens Server ....................................... SUCCESS [10:18.860s]
> [INFO] Lens client ....................................... SUCCESS [35.250s]
> [INFO] Lens CLI .......................................... SUCCESS [5:21.299s]
> [INFO] Lens Examples ..................................... SUCCESS [4.412s]
> [INFO] Lens Distribution ................................. SUCCESS [2.964s]
> [INFO] Lens ML Lib ....................................... SUCCESS [2:22.502s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [6.153s]
> [INFO] Lens Regression ................................... SUCCESS [0.909s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 28:38.764s
> [INFO] Finished at: Mon May 11 13:59:03 GMT+05:30 2015
> [INFO] Final Memory: 85M/1078M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Sushil Mohanty
> 
>

Re: Review Request 34033: LENS-204 : Support union across tables in cube rewriting

Posted by Amareshwari Sriramadasu <am...@apache.org>.

> On May 13, 2015, 9:50 a.m., Rajat Khandelwal wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java, line 34
> > <https://reviews.apache.org/r/34033/diff/2/?file=956258#file956258line34>
> >
> >     Do we need an intermediate class `UnionHQLContext`? Seems like that can be merged with this class.

I think it will be useful. We can add more union HQL contexts going forward. SingleFactMultiStorage is one of them. We can have SingleFactMultipleExpressions as another.


- Amareshwari


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34033/#review83584
-----------------------------------------------------------


On May 12, 2015, 8:33 a.m., Sushil Mohanty wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34033/
> -----------------------------------------------------------
> 
> (Updated May 12, 2015, 8:33 a.m.)
> 
> 
> Review request for lens and Amareshwari Sriramadasu.
> 
> 
> Bugs: LENS-204
>     https://issues.apache.org/jira/browse/LENS-204
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Support for union across two or more tables in cube query rewriting.
> 
> 
> Diffs
> -----
> 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 47b9fc1 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java b7c3ee9 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DimOnlyHQLContext.java 8a23ded 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java beaa551 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java e5a6b32 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/UnionHQLContext.java PRE-CREATION 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 3203354 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java c915353 
> 
> Diff: https://reviews.apache.org/r/34033/diff/
> 
> 
> Testing
> -------
> 
> Updated unit tests wrt union support. mvn clean test is running fine.
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [8.026s]
> [INFO] Lens .............................................. SUCCESS [0.299s]
> [INFO] Lens API .......................................... SUCCESS [17.493s]
> [INFO] Lens API for server and extensions ................ SUCCESS [15.690s]
> [INFO] Lens Cube ......................................... SUCCESS [4:13.909s]
> [INFO] Lens DB storage ................................... SUCCESS [16.124s]
> [INFO] Lens Query Library ................................ SUCCESS [10.275s]
> [INFO] Lens Hive Driver .................................. SUCCESS [3:55.868s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [27.174s]
> [INFO] Lens Server ....................................... SUCCESS [10:18.860s]
> [INFO] Lens client ....................................... SUCCESS [35.250s]
> [INFO] Lens CLI .......................................... SUCCESS [5:21.299s]
> [INFO] Lens Examples ..................................... SUCCESS [4.412s]
> [INFO] Lens Distribution ................................. SUCCESS [2.964s]
> [INFO] Lens ML Lib ....................................... SUCCESS [2:22.502s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [6.153s]
> [INFO] Lens Regression ................................... SUCCESS [0.909s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 28:38.764s
> [INFO] Finished at: Mon May 11 13:59:03 GMT+05:30 2015
> [INFO] Final Memory: 85M/1078M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Sushil Mohanty
> 
>

Re: Review Request 34033: LENS-204 : Support union across tables in cube rewriting

Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34033/#review83584
-----------------------------------------------------------



lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java
<https://reviews.apache.org/r/34033/#comment134597>

    Do we need an intermediate class `UnionHQLContext`? Seems like that can be merged with this class.


- Rajat Khandelwal


On May 12, 2015, 2:03 p.m., Sushil Mohanty wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34033/
> -----------------------------------------------------------
> 
> (Updated May 12, 2015, 2:03 p.m.)
> 
> 
> Review request for lens and Amareshwari Sriramadasu.
> 
> 
> Bugs: LENS-204
>     https://issues.apache.org/jira/browse/LENS-204
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Support for union across two or more tables in cube query rewriting.
> 
> 
> Diffs
> -----
> 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 47b9fc1 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java b7c3ee9 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DimOnlyHQLContext.java 8a23ded 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java beaa551 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java e5a6b32 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/UnionHQLContext.java PRE-CREATION 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 3203354 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java c915353 
> 
> Diff: https://reviews.apache.org/r/34033/diff/
> 
> 
> Testing
> -------
> 
> Updated unit tests wrt union support. mvn clean test is running fine.
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [8.026s]
> [INFO] Lens .............................................. SUCCESS [0.299s]
> [INFO] Lens API .......................................... SUCCESS [17.493s]
> [INFO] Lens API for server and extensions ................ SUCCESS [15.690s]
> [INFO] Lens Cube ......................................... SUCCESS [4:13.909s]
> [INFO] Lens DB storage ................................... SUCCESS [16.124s]
> [INFO] Lens Query Library ................................ SUCCESS [10.275s]
> [INFO] Lens Hive Driver .................................. SUCCESS [3:55.868s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [27.174s]
> [INFO] Lens Server ....................................... SUCCESS [10:18.860s]
> [INFO] Lens client ....................................... SUCCESS [35.250s]
> [INFO] Lens CLI .......................................... SUCCESS [5:21.299s]
> [INFO] Lens Examples ..................................... SUCCESS [4.412s]
> [INFO] Lens Distribution ................................. SUCCESS [2.964s]
> [INFO] Lens ML Lib ....................................... SUCCESS [2:22.502s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [6.153s]
> [INFO] Lens Regression ................................... SUCCESS [0.909s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 28:38.764s
> [INFO] Finished at: Mon May 11 13:59:03 GMT+05:30 2015
> [INFO] Final Memory: 85M/1078M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Sushil Mohanty
> 
>

Re: Review Request 34033: LENS-204 : Support union across tables in cube rewriting

Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34033/#review84138
-----------------------------------------------------------



lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java
<https://reviews.apache.org/r/34033/#comment135268>

    This might be different for each range. we might have to keep map from range to extra clause.


- Amareshwari Sriramadasu


On May 18, 2015, 11:44 a.m., Sushil Mohanty wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34033/
> -----------------------------------------------------------
> 
> (Updated May 18, 2015, 11:44 a.m.)
> 
> 
> Review request for lens and Amareshwari Sriramadasu.
> 
> 
> Bugs: LENS-204
>     https://issues.apache.org/jira/browse/LENS-204
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Support for union across two or more tables in cube query rewriting.
> 
> 
> Diffs
> -----
> 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 31eb113 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java 230a2ee 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DimOnlyHQLContext.java 785b0e4 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java e14fcfa 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java bdc9855 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/UnionHQLContext.java PRE-CREATION 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 1fe4173 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 44826bd 
> 
> Diff: https://reviews.apache.org/r/34033/diff/
> 
> 
> Testing
> -------
> 
> Updated unit tests wrt union support. mvn clean test is running fine.
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [8.026s]
> [INFO] Lens .............................................. SUCCESS [0.299s]
> [INFO] Lens API .......................................... SUCCESS [17.493s]
> [INFO] Lens API for server and extensions ................ SUCCESS [15.690s]
> [INFO] Lens Cube ......................................... SUCCESS [4:13.909s]
> [INFO] Lens DB storage ................................... SUCCESS [16.124s]
> [INFO] Lens Query Library ................................ SUCCESS [10.275s]
> [INFO] Lens Hive Driver .................................. SUCCESS [3:55.868s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [27.174s]
> [INFO] Lens Server ....................................... SUCCESS [10:18.860s]
> [INFO] Lens client ....................................... SUCCESS [35.250s]
> [INFO] Lens CLI .......................................... SUCCESS [5:21.299s]
> [INFO] Lens Examples ..................................... SUCCESS [4.412s]
> [INFO] Lens Distribution ................................. SUCCESS [2.964s]
> [INFO] Lens ML Lib ....................................... SUCCESS [2:22.502s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [6.153s]
> [INFO] Lens Regression ................................... SUCCESS [0.909s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 28:38.764s
> [INFO] Finished at: Mon May 11 13:59:03 GMT+05:30 2015
> [INFO] Final Memory: 85M/1078M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Sushil Mohanty
> 
>

Re: Review Request 34033: LENS-204 : Support union across tables in cube rewriting

Posted by Sushil Mohanty <su...@gmail.com>.

> On May 18, 2015, 12:35 p.m., Amareshwari Sriramadasu wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java, line 390
> > <https://reviews.apache.org/r/34033/diff/4/?file=962550#file962550line390>
> >
> >     checkstyle issue?

Fixed check style issue. All unit tests are running fine. Updated the latest patch in ticket.


- Sushil


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34033/#review84141
-----------------------------------------------------------


On May 18, 2015, 12:32 p.m., Sushil Mohanty wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34033/
> -----------------------------------------------------------
> 
> (Updated May 18, 2015, 12:32 p.m.)
> 
> 
> Review request for lens and Amareshwari Sriramadasu.
> 
> 
> Bugs: LENS-204
>     https://issues.apache.org/jira/browse/LENS-204
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Support for union across two or more tables in cube query rewriting.
> 
> 
> Diffs
> -----
> 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 31eb113 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java 230a2ee 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DimOnlyHQLContext.java 785b0e4 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java e14fcfa 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java bdc9855 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/UnionHQLContext.java PRE-CREATION 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 1fe4173 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 44826bd 
> 
> Diff: https://reviews.apache.org/r/34033/diff/
> 
> 
> Testing
> -------
> 
> Updated unit tests wrt union support. mvn clean test is running fine.
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [8.026s]
> [INFO] Lens .............................................. SUCCESS [0.299s]
> [INFO] Lens API .......................................... SUCCESS [17.493s]
> [INFO] Lens API for server and extensions ................ SUCCESS [15.690s]
> [INFO] Lens Cube ......................................... SUCCESS [4:13.909s]
> [INFO] Lens DB storage ................................... SUCCESS [16.124s]
> [INFO] Lens Query Library ................................ SUCCESS [10.275s]
> [INFO] Lens Hive Driver .................................. SUCCESS [3:55.868s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [27.174s]
> [INFO] Lens Server ....................................... SUCCESS [10:18.860s]
> [INFO] Lens client ....................................... SUCCESS [35.250s]
> [INFO] Lens CLI .......................................... SUCCESS [5:21.299s]
> [INFO] Lens Examples ..................................... SUCCESS [4.412s]
> [INFO] Lens Distribution ................................. SUCCESS [2.964s]
> [INFO] Lens ML Lib ....................................... SUCCESS [2:22.502s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [6.153s]
> [INFO] Lens Regression ................................... SUCCESS [0.909s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 28:38.764s
> [INFO] Finished at: Mon May 11 13:59:03 GMT+05:30 2015
> [INFO] Final Memory: 85M/1078M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Sushil Mohanty
> 
>

Re: Review Request 34033: LENS-204 : Support union across tables in cube rewriting

Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34033/#review84141
-----------------------------------------------------------

Ship it!


Ran mvn clean install and make sure no checkstyle issues.


lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java
<https://reviews.apache.org/r/34033/#comment135270>

    checkstyle issue?


- Amareshwari Sriramadasu


On May 18, 2015, 12:32 p.m., Sushil Mohanty wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34033/
> -----------------------------------------------------------
> 
> (Updated May 18, 2015, 12:32 p.m.)
> 
> 
> Review request for lens and Amareshwari Sriramadasu.
> 
> 
> Bugs: LENS-204
>     https://issues.apache.org/jira/browse/LENS-204
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Support for union across two or more tables in cube query rewriting.
> 
> 
> Diffs
> -----
> 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 31eb113 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java 230a2ee 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DimOnlyHQLContext.java 785b0e4 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java e14fcfa 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java bdc9855 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/UnionHQLContext.java PRE-CREATION 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 1fe4173 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 44826bd 
> 
> Diff: https://reviews.apache.org/r/34033/diff/
> 
> 
> Testing
> -------
> 
> Updated unit tests wrt union support. mvn clean test is running fine.
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [8.026s]
> [INFO] Lens .............................................. SUCCESS [0.299s]
> [INFO] Lens API .......................................... SUCCESS [17.493s]
> [INFO] Lens API for server and extensions ................ SUCCESS [15.690s]
> [INFO] Lens Cube ......................................... SUCCESS [4:13.909s]
> [INFO] Lens DB storage ................................... SUCCESS [16.124s]
> [INFO] Lens Query Library ................................ SUCCESS [10.275s]
> [INFO] Lens Hive Driver .................................. SUCCESS [3:55.868s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [27.174s]
> [INFO] Lens Server ....................................... SUCCESS [10:18.860s]
> [INFO] Lens client ....................................... SUCCESS [35.250s]
> [INFO] Lens CLI .......................................... SUCCESS [5:21.299s]
> [INFO] Lens Examples ..................................... SUCCESS [4.412s]
> [INFO] Lens Distribution ................................. SUCCESS [2.964s]
> [INFO] Lens ML Lib ....................................... SUCCESS [2:22.502s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [6.153s]
> [INFO] Lens Regression ................................... SUCCESS [0.909s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 28:38.764s
> [INFO] Finished at: Mon May 11 13:59:03 GMT+05:30 2015
> [INFO] Final Memory: 85M/1078M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Sushil Mohanty
> 
>

Re: Review Request 34033: LENS-204 : Support union across tables in cube rewriting

Posted by Sushil Mohanty <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34033/
-----------------------------------------------------------

(Updated May 18, 2015, 12:32 p.m.)


Review request for lens and Amareshwari Sriramadasu.


Changes
-------

Addressed review comments. Unit tests in lens-cube are running fine. Execution of other unit test cases are in progress.


Bugs: LENS-204
    https://issues.apache.org/jira/browse/LENS-204


Repository: lens


Description
-------

Support for union across two or more tables in cube query rewriting.


Diffs (updated)
-----

  lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 31eb113 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java 230a2ee 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DimOnlyHQLContext.java 785b0e4 
  lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java e14fcfa 
  lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java PRE-CREATION 
  lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java bdc9855 
  lens-cube/src/main/java/org/apache/lens/cube/parse/UnionHQLContext.java PRE-CREATION 
  lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 1fe4173 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 44826bd 

Diff: https://reviews.apache.org/r/34033/diff/


Testing
-------

Updated unit tests wrt union support. mvn clean test is running fine.

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [8.026s]
[INFO] Lens .............................................. SUCCESS [0.299s]
[INFO] Lens API .......................................... SUCCESS [17.493s]
[INFO] Lens API for server and extensions ................ SUCCESS [15.690s]
[INFO] Lens Cube ......................................... SUCCESS [4:13.909s]
[INFO] Lens DB storage ................................... SUCCESS [16.124s]
[INFO] Lens Query Library ................................ SUCCESS [10.275s]
[INFO] Lens Hive Driver .................................. SUCCESS [3:55.868s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [27.174s]
[INFO] Lens Server ....................................... SUCCESS [10:18.860s]
[INFO] Lens client ....................................... SUCCESS [35.250s]
[INFO] Lens CLI .......................................... SUCCESS [5:21.299s]
[INFO] Lens Examples ..................................... SUCCESS [4.412s]
[INFO] Lens Distribution ................................. SUCCESS [2.964s]
[INFO] Lens ML Lib ....................................... SUCCESS [2:22.502s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [6.153s]
[INFO] Lens Regression ................................... SUCCESS [0.909s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 28:38.764s
[INFO] Finished at: Mon May 11 13:59:03 GMT+05:30 2015
[INFO] Final Memory: 85M/1078M
[INFO] ------------------------------------------------------------------------


Thanks,

Sushil Mohanty

Re: Review Request 34033: LENS-204 : Support union across tables in cube rewriting

Posted by Sushil Mohanty <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34033/
-----------------------------------------------------------

(Updated May 18, 2015, 11:44 a.m.)


Review request for lens and Amareshwari Sriramadasu.


Changes
-------

1. Made necessary chnages to skip adding duplicate partitions across storage tables.
2. Added unit test for the above 
3. Fixed code conflicts and other changes required afters LENS-198.

All unit tests are running fine.

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [5.536s]
[INFO] Lens .............................................. SUCCESS [0.306s]
[INFO] Lens API .......................................... SUCCESS [13.556s]
[INFO] Lens API for server and extensions ................ SUCCESS [13.951s]
[INFO] Lens Cube ......................................... SUCCESS [4:25.292s]
[INFO] Lens DB storage ................................... SUCCESS [16.981s]
[INFO] Lens Query Library ................................ SUCCESS [10.258s]
[INFO] Lens Hive Driver .................................. SUCCESS [4:10.583s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [29.510s]
[INFO] Lens Server ....................................... SUCCESS [30:57.012s]
[INFO] Lens client ....................................... SUCCESS [42.520s]
[INFO] Lens CLI .......................................... SUCCESS [4:57.730s]
[INFO] Lens Examples ..................................... SUCCESS [3.220s]
[INFO] Lens Distribution ................................. SUCCESS [4.101s]
[INFO] Lens ML Lib ....................................... SUCCESS [2:17.416s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [7.750s]
[INFO] Lens Regression ................................... SUCCESS [0.802s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 49:17.737s
[INFO] Finished at: Mon May 18 17:07:07 GMT+05:30 2015
[INFO] Final Memory: 86M/1078M
[INFO] ------------------------------------------------------------------------


Bugs: LENS-204
    https://issues.apache.org/jira/browse/LENS-204


Repository: lens


Description
-------

Support for union across two or more tables in cube query rewriting.


Diffs (updated)
-----

  lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 31eb113 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java 230a2ee 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DimOnlyHQLContext.java 785b0e4 
  lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java e14fcfa 
  lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java PRE-CREATION 
  lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java bdc9855 
  lens-cube/src/main/java/org/apache/lens/cube/parse/UnionHQLContext.java PRE-CREATION 
  lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 1fe4173 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 44826bd 

Diff: https://reviews.apache.org/r/34033/diff/


Testing
-------

Updated unit tests wrt union support. mvn clean test is running fine.

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [8.026s]
[INFO] Lens .............................................. SUCCESS [0.299s]
[INFO] Lens API .......................................... SUCCESS [17.493s]
[INFO] Lens API for server and extensions ................ SUCCESS [15.690s]
[INFO] Lens Cube ......................................... SUCCESS [4:13.909s]
[INFO] Lens DB storage ................................... SUCCESS [16.124s]
[INFO] Lens Query Library ................................ SUCCESS [10.275s]
[INFO] Lens Hive Driver .................................. SUCCESS [3:55.868s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [27.174s]
[INFO] Lens Server ....................................... SUCCESS [10:18.860s]
[INFO] Lens client ....................................... SUCCESS [35.250s]
[INFO] Lens CLI .......................................... SUCCESS [5:21.299s]
[INFO] Lens Examples ..................................... SUCCESS [4.412s]
[INFO] Lens Distribution ................................. SUCCESS [2.964s]
[INFO] Lens ML Lib ....................................... SUCCESS [2:22.502s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [6.153s]
[INFO] Lens Regression ................................... SUCCESS [0.909s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 28:38.764s
[INFO] Finished at: Mon May 11 13:59:03 GMT+05:30 2015
[INFO] Final Memory: 85M/1078M
[INFO] ------------------------------------------------------------------------


Thanks,

Sushil Mohanty

Re: Review Request 34033: LENS-204 : Support union across tables in cube rewriting

Posted by Sushil Mohanty <su...@gmail.com>.

> On May 12, 2015, 8:47 a.m., Amareshwari Sriramadasu wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java, line 830
> > <https://reviews.apache.org/r/34033/diff/2/?file=956255#file956255line830>
> >
> >     We might have to support one/all of the facts with multiple storages for multi fact query also. Can be done in subtask. Can you park subtask for the same?

All unit tests are running fine.
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [6.025s]
[INFO] Lens .............................................. SUCCESS [0.265s]
[INFO] Lens API .......................................... SUCCESS [12.387s]
[INFO] Lens API for server and extensions ................ SUCCESS [17.103s]
[INFO] Lens Cube ......................................... SUCCESS [4:34.790s]
[INFO] Lens DB storage ................................... SUCCESS [23.056s]
[INFO] Lens Query Library ................................ SUCCESS [9.476s]
[INFO] Lens Hive Driver .................................. SUCCESS [5:15.026s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [36.286s]
[INFO] Lens Server ....................................... SUCCESS [15:48.575s]
[INFO] Lens client ....................................... SUCCESS [2:25.408s]
[INFO] Lens CLI .......................................... SUCCESS [6:51.857s]
[INFO] Lens Examples ..................................... SUCCESS [3.636s]
[INFO] Lens Distribution ................................. SUCCESS [4.836s]
[INFO] Lens ML Lib ....................................... SUCCESS [2:39.587s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [7.356s]
[INFO] Lens Regression ................................... SUCCESS [0.939s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 39:37.685s
[INFO] Finished at: Tue May 12 14:46:06 GMT+05:30 2015
[INFO] Final Memory: 86M/1078M
[INFO] ------------------------------------------------------------------------


- Sushil


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34033/#review83383
-----------------------------------------------------------


On May 12, 2015, 8:33 a.m., Sushil Mohanty wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34033/
> -----------------------------------------------------------
> 
> (Updated May 12, 2015, 8:33 a.m.)
> 
> 
> Review request for lens and Amareshwari Sriramadasu.
> 
> 
> Bugs: LENS-204
>     https://issues.apache.org/jira/browse/LENS-204
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Support for union across two or more tables in cube query rewriting.
> 
> 
> Diffs
> -----
> 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 47b9fc1 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java b7c3ee9 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DimOnlyHQLContext.java 8a23ded 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java beaa551 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java e5a6b32 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/UnionHQLContext.java PRE-CREATION 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 3203354 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java c915353 
> 
> Diff: https://reviews.apache.org/r/34033/diff/
> 
> 
> Testing
> -------
> 
> Updated unit tests wrt union support. mvn clean test is running fine.
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [8.026s]
> [INFO] Lens .............................................. SUCCESS [0.299s]
> [INFO] Lens API .......................................... SUCCESS [17.493s]
> [INFO] Lens API for server and extensions ................ SUCCESS [15.690s]
> [INFO] Lens Cube ......................................... SUCCESS [4:13.909s]
> [INFO] Lens DB storage ................................... SUCCESS [16.124s]
> [INFO] Lens Query Library ................................ SUCCESS [10.275s]
> [INFO] Lens Hive Driver .................................. SUCCESS [3:55.868s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [27.174s]
> [INFO] Lens Server ....................................... SUCCESS [10:18.860s]
> [INFO] Lens client ....................................... SUCCESS [35.250s]
> [INFO] Lens CLI .......................................... SUCCESS [5:21.299s]
> [INFO] Lens Examples ..................................... SUCCESS [4.412s]
> [INFO] Lens Distribution ................................. SUCCESS [2.964s]
> [INFO] Lens ML Lib ....................................... SUCCESS [2:22.502s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [6.153s]
> [INFO] Lens Regression ................................... SUCCESS [0.909s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 28:38.764s
> [INFO] Finished at: Mon May 11 13:59:03 GMT+05:30 2015
> [INFO] Final Memory: 85M/1078M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Sushil Mohanty
> 
>

Re: Review Request 34033: LENS-204 : Support union across tables in cube rewriting

Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34033/#review83383
-----------------------------------------------------------



lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java
<https://reviews.apache.org/r/34033/#comment134367>

    We might have to support one/all of the facts with multiple storages for multi fact query also. Can be done in subtask. Can you park subtask for the same?


- Amareshwari Sriramadasu


On May 12, 2015, 8:33 a.m., Sushil Mohanty wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34033/
> -----------------------------------------------------------
> 
> (Updated May 12, 2015, 8:33 a.m.)
> 
> 
> Review request for lens and Amareshwari Sriramadasu.
> 
> 
> Bugs: LENS-204
>     https://issues.apache.org/jira/browse/LENS-204
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Support for union across two or more tables in cube query rewriting.
> 
> 
> Diffs
> -----
> 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 47b9fc1 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java b7c3ee9 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DimOnlyHQLContext.java 8a23ded 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java beaa551 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java e5a6b32 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/UnionHQLContext.java PRE-CREATION 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 3203354 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java c915353 
> 
> Diff: https://reviews.apache.org/r/34033/diff/
> 
> 
> Testing
> -------
> 
> Updated unit tests wrt union support. mvn clean test is running fine.
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [8.026s]
> [INFO] Lens .............................................. SUCCESS [0.299s]
> [INFO] Lens API .......................................... SUCCESS [17.493s]
> [INFO] Lens API for server and extensions ................ SUCCESS [15.690s]
> [INFO] Lens Cube ......................................... SUCCESS [4:13.909s]
> [INFO] Lens DB storage ................................... SUCCESS [16.124s]
> [INFO] Lens Query Library ................................ SUCCESS [10.275s]
> [INFO] Lens Hive Driver .................................. SUCCESS [3:55.868s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [27.174s]
> [INFO] Lens Server ....................................... SUCCESS [10:18.860s]
> [INFO] Lens client ....................................... SUCCESS [35.250s]
> [INFO] Lens CLI .......................................... SUCCESS [5:21.299s]
> [INFO] Lens Examples ..................................... SUCCESS [4.412s]
> [INFO] Lens Distribution ................................. SUCCESS [2.964s]
> [INFO] Lens ML Lib ....................................... SUCCESS [2:22.502s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [6.153s]
> [INFO] Lens Regression ................................... SUCCESS [0.909s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 28:38.764s
> [INFO] Finished at: Mon May 11 13:59:03 GMT+05:30 2015
> [INFO] Final Memory: 85M/1078M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Sushil Mohanty
> 
>

Re: Review Request 34033: LENS-204 : Support union across tables in cube rewriting

Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34033/#review83591
-----------------------------------------------------------

Ship it!


This doesn't conflict with LENS-198 yet(at least on logical level), since in LENS-198, we are falling back only when no storage of a fact has a partition column. And in LENS-204, multiple storages of one fact are unioned and only when both have the part col for the queried time dim.

- Rajat Khandelwal


On May 12, 2015, 2:03 p.m., Sushil Mohanty wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34033/
> -----------------------------------------------------------
> 
> (Updated May 12, 2015, 2:03 p.m.)
> 
> 
> Review request for lens and Amareshwari Sriramadasu.
> 
> 
> Bugs: LENS-204
>     https://issues.apache.org/jira/browse/LENS-204
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Support for union across two or more tables in cube query rewriting.
> 
> 
> Diffs
> -----
> 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 47b9fc1 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java b7c3ee9 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DimOnlyHQLContext.java 8a23ded 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java beaa551 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java e5a6b32 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/UnionHQLContext.java PRE-CREATION 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 3203354 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java c915353 
> 
> Diff: https://reviews.apache.org/r/34033/diff/
> 
> 
> Testing
> -------
> 
> Updated unit tests wrt union support. mvn clean test is running fine.
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [8.026s]
> [INFO] Lens .............................................. SUCCESS [0.299s]
> [INFO] Lens API .......................................... SUCCESS [17.493s]
> [INFO] Lens API for server and extensions ................ SUCCESS [15.690s]
> [INFO] Lens Cube ......................................... SUCCESS [4:13.909s]
> [INFO] Lens DB storage ................................... SUCCESS [16.124s]
> [INFO] Lens Query Library ................................ SUCCESS [10.275s]
> [INFO] Lens Hive Driver .................................. SUCCESS [3:55.868s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [27.174s]
> [INFO] Lens Server ....................................... SUCCESS [10:18.860s]
> [INFO] Lens client ....................................... SUCCESS [35.250s]
> [INFO] Lens CLI .......................................... SUCCESS [5:21.299s]
> [INFO] Lens Examples ..................................... SUCCESS [4.412s]
> [INFO] Lens Distribution ................................. SUCCESS [2.964s]
> [INFO] Lens ML Lib ....................................... SUCCESS [2:22.502s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [6.153s]
> [INFO] Lens Regression ................................... SUCCESS [0.909s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 28:38.764s
> [INFO] Finished at: Mon May 11 13:59:03 GMT+05:30 2015
> [INFO] Final Memory: 85M/1078M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Sushil Mohanty
> 
>

Re: Review Request 34033: LENS-204 : Support union across tables in cube rewriting

Posted by Sushil Mohanty <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34033/
-----------------------------------------------------------

(Updated May 12, 2015, 8:33 a.m.)


Review request for lens and Amareshwari Sriramadasu.


Changes
-------

Addressed review comments. Running unit tests are in progress.


Bugs: LENS-204
    https://issues.apache.org/jira/browse/LENS-204


Repository: lens


Description
-------

Support for union across two or more tables in cube query rewriting.


Diffs (updated)
-----

  lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 47b9fc1 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java b7c3ee9 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DimOnlyHQLContext.java 8a23ded 
  lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java beaa551 
  lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java PRE-CREATION 
  lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java e5a6b32 
  lens-cube/src/main/java/org/apache/lens/cube/parse/UnionHQLContext.java PRE-CREATION 
  lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 3203354 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java c915353 

Diff: https://reviews.apache.org/r/34033/diff/


Testing
-------

Updated unit tests wrt union support. mvn clean test is running fine.

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [8.026s]
[INFO] Lens .............................................. SUCCESS [0.299s]
[INFO] Lens API .......................................... SUCCESS [17.493s]
[INFO] Lens API for server and extensions ................ SUCCESS [15.690s]
[INFO] Lens Cube ......................................... SUCCESS [4:13.909s]
[INFO] Lens DB storage ................................... SUCCESS [16.124s]
[INFO] Lens Query Library ................................ SUCCESS [10.275s]
[INFO] Lens Hive Driver .................................. SUCCESS [3:55.868s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [27.174s]
[INFO] Lens Server ....................................... SUCCESS [10:18.860s]
[INFO] Lens client ....................................... SUCCESS [35.250s]
[INFO] Lens CLI .......................................... SUCCESS [5:21.299s]
[INFO] Lens Examples ..................................... SUCCESS [4.412s]
[INFO] Lens Distribution ................................. SUCCESS [2.964s]
[INFO] Lens ML Lib ....................................... SUCCESS [2:22.502s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [6.153s]
[INFO] Lens Regression ................................... SUCCESS [0.909s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 28:38.764s
[INFO] Finished at: Mon May 11 13:59:03 GMT+05:30 2015
[INFO] Final Memory: 85M/1078M
[INFO] ------------------------------------------------------------------------


Thanks,

Sushil Mohanty

Re: Review Request 34033: LENS-204 : Support union across tables in cube rewriting

Posted by Amareshwari Sriramadasu <am...@apache.org>.

> On May 11, 2015, 11:27 a.m., Rajat Khandelwal wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/UnionHQLContext.java, line 69
> > <https://reviews.apache.org/r/34033/diff/1/?file=955207#file955207line69>
> >
> >     If all the methods are returning null, I wonder whether it makes sense for `UnionHQLContext` to implement `HQLContextInterface`

UnionHQLContext is implementing toHQL(). Others are all helper methods, which need not be implemented.


- Amareshwari


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34033/#review83219
-----------------------------------------------------------


On May 11, 2015, 9:57 a.m., Sushil Mohanty wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34033/
> -----------------------------------------------------------
> 
> (Updated May 11, 2015, 9:57 a.m.)
> 
> 
> Review request for lens and Amareshwari Sriramadasu.
> 
> 
> Bugs: LENS-204
>     https://issues.apache.org/jira/browse/LENS-204
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Support for union across two or more tables in cube query rewriting.
> 
> 
> Diffs
> -----
> 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 47b9fc1 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java b7c3ee9 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DimOnlyHQLContext.java 8a23ded 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java beaa551 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java e5a6b32 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/UnionHQLContext.java PRE-CREATION 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 3203354 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java c915353 
> 
> Diff: https://reviews.apache.org/r/34033/diff/
> 
> 
> Testing
> -------
> 
> Updated unit tests wrt union support. mvn clean test is running fine.
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [8.026s]
> [INFO] Lens .............................................. SUCCESS [0.299s]
> [INFO] Lens API .......................................... SUCCESS [17.493s]
> [INFO] Lens API for server and extensions ................ SUCCESS [15.690s]
> [INFO] Lens Cube ......................................... SUCCESS [4:13.909s]
> [INFO] Lens DB storage ................................... SUCCESS [16.124s]
> [INFO] Lens Query Library ................................ SUCCESS [10.275s]
> [INFO] Lens Hive Driver .................................. SUCCESS [3:55.868s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [27.174s]
> [INFO] Lens Server ....................................... SUCCESS [10:18.860s]
> [INFO] Lens client ....................................... SUCCESS [35.250s]
> [INFO] Lens CLI .......................................... SUCCESS [5:21.299s]
> [INFO] Lens Examples ..................................... SUCCESS [4.412s]
> [INFO] Lens Distribution ................................. SUCCESS [2.964s]
> [INFO] Lens ML Lib ....................................... SUCCESS [2:22.502s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [6.153s]
> [INFO] Lens Regression ................................... SUCCESS [0.909s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 28:38.764s
> [INFO] Finished at: Mon May 11 13:59:03 GMT+05:30 2015
> [INFO] Final Memory: 85M/1078M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Sushil Mohanty
> 
>

Re: Review Request 34033: LENS-204 : Support union across tables in cube rewriting

Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34033/#review83219
-----------------------------------------------------------



lens-cube/src/main/java/org/apache/lens/cube/parse/UnionHQLContext.java
<https://reviews.apache.org/r/34033/#comment134126>

    If all the methods are returning null, I wonder whether it makes sense for `UnionHQLContext` to implement `HQLContextInterface`


- Rajat Khandelwal


On May 11, 2015, 3:27 p.m., Sushil Mohanty wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34033/
> -----------------------------------------------------------
> 
> (Updated May 11, 2015, 3:27 p.m.)
> 
> 
> Review request for lens and Amareshwari Sriramadasu.
> 
> 
> Bugs: LENS-204
>     https://issues.apache.org/jira/browse/LENS-204
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Support for union across two or more tables in cube query rewriting.
> 
> 
> Diffs
> -----
> 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 47b9fc1 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java b7c3ee9 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DimOnlyHQLContext.java 8a23ded 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java beaa551 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java e5a6b32 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/UnionHQLContext.java PRE-CREATION 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 3203354 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java c915353 
> 
> Diff: https://reviews.apache.org/r/34033/diff/
> 
> 
> Testing
> -------
> 
> Updated unit tests wrt union support. mvn clean test is running fine.
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [8.026s]
> [INFO] Lens .............................................. SUCCESS [0.299s]
> [INFO] Lens API .......................................... SUCCESS [17.493s]
> [INFO] Lens API for server and extensions ................ SUCCESS [15.690s]
> [INFO] Lens Cube ......................................... SUCCESS [4:13.909s]
> [INFO] Lens DB storage ................................... SUCCESS [16.124s]
> [INFO] Lens Query Library ................................ SUCCESS [10.275s]
> [INFO] Lens Hive Driver .................................. SUCCESS [3:55.868s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [27.174s]
> [INFO] Lens Server ....................................... SUCCESS [10:18.860s]
> [INFO] Lens client ....................................... SUCCESS [35.250s]
> [INFO] Lens CLI .......................................... SUCCESS [5:21.299s]
> [INFO] Lens Examples ..................................... SUCCESS [4.412s]
> [INFO] Lens Distribution ................................. SUCCESS [2.964s]
> [INFO] Lens ML Lib ....................................... SUCCESS [2:22.502s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [6.153s]
> [INFO] Lens Regression ................................... SUCCESS [0.909s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 28:38.764s
> [INFO] Finished at: Mon May 11 13:59:03 GMT+05:30 2015
> [INFO] Final Memory: 85M/1078M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Sushil Mohanty
> 
>