You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flink.apache.org by Piotr Nowojski <pi...@data-artisans.com> on 2017/06/28 12:36:07 UTC
Switch to Scala 2.11 as a default build profile
Hi,
I propose to switch to Scala 2.11 as a default and to have a Scala 2.10 build profile. Now it is other way around. The reason for that is poor support for build profiles in Intellij, I was unable to make it work after I added Kafka 0.11 dependency (Kafka 0.11 dropped support for Scala 2.10).
As a side note, maybe we should also consider dropping Scala 2.10 support?
Piotrek
Re: Switch to Scala 2.11 as a default build profile
Posted by Jörn Franke <jo...@gmail.com>.
EMR has a flink package. Just go to advanced options and but a checkbox on flink. No need to build yourself.
> On 29. Jun 2017, at 05:56, Bowen Li <bo...@offerupnow.com> wrote:
>
> +1.
>
> AWS EMR eco system is using Scala 2.11, and breaks with Scala 2.10. We had
> to build several Flink components (e.g. flink-kinesis-connector) ourselves
> in order to run on EMR. Defaulting to Scala 2.11 will greatly reduce
> adoption cost for Flink on EMR
>
>
>> On Wed, Jun 28, 2017 at 9:34 AM, Till Rohrmann <tr...@apache.org> wrote:
>>
>> I'm +1 for changing the profile and to start a discussion to drop Scala
>> 2.10.
>>
>> Scala 2.10 is already quite old and the current stable version is 2.12. I
>> would be surprised to see many people still using Scala 2.10.
>>
>> Cheers,
>> Till
>>
>>> On Wed, Jun 28, 2017 at 4:53 PM, Ted Yu <yu...@gmail.com> wrote:
>>>
>>> Here is the KIP that drops support for Scala 2.10 in Kafka 0.11 :
>>>
>>> https://cwiki.apache.org/confluence/display/KAFKA/KIP-
>>> 119%3A+Drop+Support+for+Scala+2.10+in+Kafka+0.11
>>>
>>> FYI
>>>
>>> On Wed, Jun 28, 2017 at 7:23 AM, Piotr Nowojski <piotr@data-artisans.com
>>>
>>> wrote:
>>>
>>>> Yes, I know and I’m proposing to change this in parent pom by default
>> to
>>>> scala-2.11.
>>>>
>>>> Changing parent pom every time anyone wants to touch/build in Intellij
>>>> Kafka 0.11 connector is not a great idea. This would require a
>> developer
>>> to
>>>> constantly stash those changes or commit and revert them before
>> creating
>>> a
>>>> pull request.
>>>>
>>>> Piotrek
>>>>
>>>>> On Jun 28, 2017, at 3:49 PM, Greg Hogan <co...@greghogan.com> wrote:
>>>>>
>>>>> You don't need to use the build profile in IntelliJ, just change
>>>>> scala.version and scala.binary.version in the parent pom (recent
>>>>> refactorings made this possible without changing every pom).
>>>>>
>>>>> What is the benefit for changing the default without dropping older
>>>>> versions when contributions are still limited to the functionality of
>>> the
>>>>> old version?
>>>>>
>>>>> On Wed, Jun 28, 2017 at 8:36 AM, Piotr Nowojski <
>>> piotr@data-artisans.com
>>>>>
>>>>> wrote:
>>>>>
>>>>>> Hi,
>>>>>>
>>>>>> I propose to switch to Scala 2.11 as a default and to have a Scala
>>> 2.10
>>>>>> build profile. Now it is other way around. The reason for that is
>> poor
>>>>>> support for build profiles in Intellij, I was unable to make it work
>>>> after
>>>>>> I added Kafka 0.11 dependency (Kafka 0.11 dropped support for Scala
>>>> 2.10).
>>>>>>
>>>>>> As a side note, maybe we should also consider dropping Scala 2.10
>>>> support?
>>>>>>
>>>>>> Piotrek
>>>>
>>>>
>>>
>>
Re: Switch to Scala 2.11 as a default build profile
Posted by Bowen Li <bo...@offerupnow.com>.
+1.
AWS EMR eco system is using Scala 2.11, and breaks with Scala 2.10. We had
to build several Flink components (e.g. flink-kinesis-connector) ourselves
in order to run on EMR. Defaulting to Scala 2.11 will greatly reduce
adoption cost for Flink on EMR
On Wed, Jun 28, 2017 at 9:34 AM, Till Rohrmann <tr...@apache.org> wrote:
> I'm +1 for changing the profile and to start a discussion to drop Scala
> 2.10.
>
> Scala 2.10 is already quite old and the current stable version is 2.12. I
> would be surprised to see many people still using Scala 2.10.
>
> Cheers,
> Till
>
> On Wed, Jun 28, 2017 at 4:53 PM, Ted Yu <yu...@gmail.com> wrote:
>
> > Here is the KIP that drops support for Scala 2.10 in Kafka 0.11 :
> >
> > https://cwiki.apache.org/confluence/display/KAFKA/KIP-
> > 119%3A+Drop+Support+for+Scala+2.10+in+Kafka+0.11
> >
> > FYI
> >
> > On Wed, Jun 28, 2017 at 7:23 AM, Piotr Nowojski <piotr@data-artisans.com
> >
> > wrote:
> >
> > > Yes, I know and I’m proposing to change this in parent pom by default
> to
> > > scala-2.11.
> > >
> > > Changing parent pom every time anyone wants to touch/build in Intellij
> > > Kafka 0.11 connector is not a great idea. This would require a
> developer
> > to
> > > constantly stash those changes or commit and revert them before
> creating
> > a
> > > pull request.
> > >
> > > Piotrek
> > >
> > > > On Jun 28, 2017, at 3:49 PM, Greg Hogan <co...@greghogan.com> wrote:
> > > >
> > > > You don't need to use the build profile in IntelliJ, just change
> > > > scala.version and scala.binary.version in the parent pom (recent
> > > > refactorings made this possible without changing every pom).
> > > >
> > > > What is the benefit for changing the default without dropping older
> > > > versions when contributions are still limited to the functionality of
> > the
> > > > old version?
> > > >
> > > > On Wed, Jun 28, 2017 at 8:36 AM, Piotr Nowojski <
> > piotr@data-artisans.com
> > > >
> > > > wrote:
> > > >
> > > >> Hi,
> > > >>
> > > >> I propose to switch to Scala 2.11 as a default and to have a Scala
> > 2.10
> > > >> build profile. Now it is other way around. The reason for that is
> poor
> > > >> support for build profiles in Intellij, I was unable to make it work
> > > after
> > > >> I added Kafka 0.11 dependency (Kafka 0.11 dropped support for Scala
> > > 2.10).
> > > >>
> > > >> As a side note, maybe we should also consider dropping Scala 2.10
> > > support?
> > > >>
> > > >> Piotrek
> > >
> > >
> >
>
Re: Switch to Scala 2.11 as a default build profile
Posted by Till Rohrmann <tr...@apache.org>.
I'm +1 for changing the profile and to start a discussion to drop Scala
2.10.
Scala 2.10 is already quite old and the current stable version is 2.12. I
would be surprised to see many people still using Scala 2.10.
Cheers,
Till
On Wed, Jun 28, 2017 at 4:53 PM, Ted Yu <yu...@gmail.com> wrote:
> Here is the KIP that drops support for Scala 2.10 in Kafka 0.11 :
>
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-
> 119%3A+Drop+Support+for+Scala+2.10+in+Kafka+0.11
>
> FYI
>
> On Wed, Jun 28, 2017 at 7:23 AM, Piotr Nowojski <pi...@data-artisans.com>
> wrote:
>
> > Yes, I know and I’m proposing to change this in parent pom by default to
> > scala-2.11.
> >
> > Changing parent pom every time anyone wants to touch/build in Intellij
> > Kafka 0.11 connector is not a great idea. This would require a developer
> to
> > constantly stash those changes or commit and revert them before creating
> a
> > pull request.
> >
> > Piotrek
> >
> > > On Jun 28, 2017, at 3:49 PM, Greg Hogan <co...@greghogan.com> wrote:
> > >
> > > You don't need to use the build profile in IntelliJ, just change
> > > scala.version and scala.binary.version in the parent pom (recent
> > > refactorings made this possible without changing every pom).
> > >
> > > What is the benefit for changing the default without dropping older
> > > versions when contributions are still limited to the functionality of
> the
> > > old version?
> > >
> > > On Wed, Jun 28, 2017 at 8:36 AM, Piotr Nowojski <
> piotr@data-artisans.com
> > >
> > > wrote:
> > >
> > >> Hi,
> > >>
> > >> I propose to switch to Scala 2.11 as a default and to have a Scala
> 2.10
> > >> build profile. Now it is other way around. The reason for that is poor
> > >> support for build profiles in Intellij, I was unable to make it work
> > after
> > >> I added Kafka 0.11 dependency (Kafka 0.11 dropped support for Scala
> > 2.10).
> > >>
> > >> As a side note, maybe we should also consider dropping Scala 2.10
> > support?
> > >>
> > >> Piotrek
> >
> >
>
Re: Switch to Scala 2.11 as a default build profile
Posted by Ted Yu <yu...@gmail.com>.
Here is the KIP that drops support for Scala 2.10 in Kafka 0.11 :
https://cwiki.apache.org/confluence/display/KAFKA/KIP-119%3A+Drop+Support+for+Scala+2.10+in+Kafka+0.11
FYI
On Wed, Jun 28, 2017 at 7:23 AM, Piotr Nowojski <pi...@data-artisans.com>
wrote:
> Yes, I know and I’m proposing to change this in parent pom by default to
> scala-2.11.
>
> Changing parent pom every time anyone wants to touch/build in Intellij
> Kafka 0.11 connector is not a great idea. This would require a developer to
> constantly stash those changes or commit and revert them before creating a
> pull request.
>
> Piotrek
>
> > On Jun 28, 2017, at 3:49 PM, Greg Hogan <co...@greghogan.com> wrote:
> >
> > You don't need to use the build profile in IntelliJ, just change
> > scala.version and scala.binary.version in the parent pom (recent
> > refactorings made this possible without changing every pom).
> >
> > What is the benefit for changing the default without dropping older
> > versions when contributions are still limited to the functionality of the
> > old version?
> >
> > On Wed, Jun 28, 2017 at 8:36 AM, Piotr Nowojski <piotr@data-artisans.com
> >
> > wrote:
> >
> >> Hi,
> >>
> >> I propose to switch to Scala 2.11 as a default and to have a Scala 2.10
> >> build profile. Now it is other way around. The reason for that is poor
> >> support for build profiles in Intellij, I was unable to make it work
> after
> >> I added Kafka 0.11 dependency (Kafka 0.11 dropped support for Scala
> 2.10).
> >>
> >> As a side note, maybe we should also consider dropping Scala 2.10
> support?
> >>
> >> Piotrek
>
>
Re: Switch to Scala 2.11 as a default build profile
Posted by Piotr Nowojski <pi...@data-artisans.com>.
Yes, I know and I’m proposing to change this in parent pom by default to scala-2.11.
Changing parent pom every time anyone wants to touch/build in Intellij Kafka 0.11 connector is not a great idea. This would require a developer to constantly stash those changes or commit and revert them before creating a pull request.
Piotrek
> On Jun 28, 2017, at 3:49 PM, Greg Hogan <co...@greghogan.com> wrote:
>
> You don't need to use the build profile in IntelliJ, just change
> scala.version and scala.binary.version in the parent pom (recent
> refactorings made this possible without changing every pom).
>
> What is the benefit for changing the default without dropping older
> versions when contributions are still limited to the functionality of the
> old version?
>
> On Wed, Jun 28, 2017 at 8:36 AM, Piotr Nowojski <pi...@data-artisans.com>
> wrote:
>
>> Hi,
>>
>> I propose to switch to Scala 2.11 as a default and to have a Scala 2.10
>> build profile. Now it is other way around. The reason for that is poor
>> support for build profiles in Intellij, I was unable to make it work after
>> I added Kafka 0.11 dependency (Kafka 0.11 dropped support for Scala 2.10).
>>
>> As a side note, maybe we should also consider dropping Scala 2.10 support?
>>
>> Piotrek
Re: Switch to Scala 2.11 as a default build profile
Posted by Greg Hogan <co...@greghogan.com>.
You don't need to use the build profile in IntelliJ, just change
scala.version and scala.binary.version in the parent pom (recent
refactorings made this possible without changing every pom).
What is the benefit for changing the default without dropping older
versions when contributions are still limited to the functionality of the
old version?
On Wed, Jun 28, 2017 at 8:36 AM, Piotr Nowojski <pi...@data-artisans.com>
wrote:
> Hi,
>
> I propose to switch to Scala 2.11 as a default and to have a Scala 2.10
> build profile. Now it is other way around. The reason for that is poor
> support for build profiles in Intellij, I was unable to make it work after
> I added Kafka 0.11 dependency (Kafka 0.11 dropped support for Scala 2.10).
>
> As a side note, maybe we should also consider dropping Scala 2.10 support?
>
> Piotrek