[GitHub] [cordova-coho] erisu commented on a change in pull request #228: Updated or Sorted Exclude Commonn RAT Pattern

[GitBox <gi...@apache.org>]

erisu commented on a change in pull request #228: Updated or Sorted Exclude Commonn RAT Pattern
URL: https://github.com/apache/cordova-coho/pull/228#discussion_r274381453
 
 

 ##########
 File path: src/audit-license-headers.js
 ##########
 @@ -29,25 +29,24 @@ var repoutil = require('./repoutil');
 
 // constants
 var COMMON_RAT_EXCLUDES = [
+    // Binrary Files
     '*.wav',
     '*.webloc',
-    '*jasmine-1.2.0*',
-    'jasmine-2.0.0',
-    'topcoat-0.7.5',
+
+    // iOS Related
+    '*.xcworkspacedata',
+    '*.xccheckout',
+    '*.xcscheme',
     '*.xcodeproj',
-    '.*',
     '*-Info.plist',
     'Info.plist',
+
+    // Other
+    '.*',
+    '*.json', // Excludes all JSON files because commenting is not supported.
 
 Review comment:
   ```suggestion
       '*.json', // Excludes all JSON files because commenting is not supported.
       '*.txt', // Excludes all text files because commenting is not supported.
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org