You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tez.apache.org by "László Bodor (Jira)" <ji...@apache.org> on 2021/08/05 14:20:00 UTC
[jira] [Issue Comment Deleted] (TEZ-4231) Fix multiple history
parser and event converter issues
[ https://issues.apache.org/jira/browse/TEZ-4231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
László Bodor updated TEZ-4231:
------------------------------
Comment: was deleted
(was: | (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 34s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green} 0m 0s{color} | {color:green} No case conflicting files found. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s{color} | {color:red} The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 28s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m 55s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 49s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 46s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 50s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 0m 39s{color} | {color:blue} Used deprecated FindBugs config; considering switching to SpotBugs. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 37s{color} | {color:red} tez-tools/analyzers/job-analyzer in master has 4 extant findbugs warnings. {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 9s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 42s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 22s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 22s{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange} 0m 9s{color} | {color:orange} tez-plugins/tez-history-parser: The patch generated 1 new + 7 unchanged - 0 fixed = 8 total (was 7) {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange} 0m 10s{color} | {color:orange} tez-tools/analyzers/job-analyzer: The patch generated 2 new + 60 unchanged - 0 fixed = 62 total (was 60) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 23s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 33s{color} | {color:red} tez-tools/analyzers/job-analyzer generated 1 new + 4 unchanged - 0 fixed = 5 total (was 4) {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m 7s{color} | {color:green} tez-history-parser in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m 22s{color} | {color:green} job-analyzer in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 15s{color} | {color:green} The patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 17m 22s{color} | {color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:tez-tools/analyzers/job-analyzer |
| | Call to method of static java.text.DateFormat in org.apache.tez.analyzer.plugins.DagOverviewAnalyzer.toDateStr(long) At DagOverviewAnalyzer.java:java.text.DateFormat in org.apache.tez.analyzer.plugins.DagOverviewAnalyzer.toDateStr(long) At DagOverviewAnalyzer.java:[line 101] |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/PreCommit-TEZ-Build/45/artifact/out/Dockerfile |
| JIRA Issue | TEZ-4231 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/13013674/TEZ-4231.01.patch |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile |
| uname | Linux b8b4d4397c1e 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/tez.sh |
| git revision | master / 970d46b5f |
| Default Java | Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 |
| findbugs | https://ci-hadoop.apache.org/job/PreCommit-TEZ-Build/45/artifact/out/branch-findbugs-tez-tools_analyzers_job-analyzer-warnings.html |
| checkstyle | https://ci-hadoop.apache.org/job/PreCommit-TEZ-Build/45/artifact/out/diff-checkstyle-tez-plugins_tez-history-parser.txt |
| checkstyle | https://ci-hadoop.apache.org/job/PreCommit-TEZ-Build/45/artifact/out/diff-checkstyle-tez-tools_analyzers_job-analyzer.txt |
| findbugs | https://ci-hadoop.apache.org/job/PreCommit-TEZ-Build/45/artifact/out/new-findbugs-tez-tools_analyzers_job-analyzer.html |
| Test Results | https://ci-hadoop.apache.org/job/PreCommit-TEZ-Build/45/testReport/ |
| Max. process+thread count | 838 (vs. ulimit of 5500) |
| modules | C: tez-plugins/tez-history-parser tez-tools/analyzers/job-analyzer U: . |
| Console output | https://ci-hadoop.apache.org/job/PreCommit-TEZ-Build/45/console |
| versions | git=2.17.1 maven=3.6.0 findbugs=3.0.1 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
)
> Fix multiple history parser and event converter issues
> ------------------------------------------------------
>
> Key: TEZ-4231
> URL: https://issues.apache.org/jira/browse/TEZ-4231
> Project: Apache Tez
> Issue Type: Bug
> Reporter: László Bodor
> Assignee: László Bodor
> Priority: Major
> Attachments: TEZ-4231.01.patch, TEZ-4231.02.patch, org.apache.tez.analyzer.plugins.DagOverviewAnalyzer_dag_1602802520552_0001_1.xlsx, org.apache.tez.analyzer.plugins.InputReadErrorAnalyzer_dag_1611059352591_0000_1.xlsx, org.apache.tez.analyzer.plugins.TaskHangAnalyzer_dag_1611075832796_0000_1.xlsx
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> While using some analyzers and writing new ones, I've found some issues with SimpleHistoryParser, this jira is about to fix them. Basically I saw that:
> 1. DagInfo.getEvents() returns an array with only 1 element
> 2. All of the events (DagInfo.getEvents(), VertexInfo,getEvents()) have "0" as timestamp
> 3. HistoryEventProtoJsonConversion: TASK_FINISHED event and VERTEX_FINISHED events don't contain start time, only timetaken, so timeTaken is fix, startTime should be derivated from that, not the opposite way (this caused non-sense task durations in analyzers while parsing proto history files)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)