You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Qian Zhang <zh...@cn.ibm.com> on 2016/04/01 11:54:53 UTC
Review Request 45580: Add some log messages in 'network/cni' isolator.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45580/
-----------------------------------------------------------
Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu.
Bugs: MESOS-4759
https://issues.apache.org/jira/browse/MESOS-4759
Repository: mesos
Description
-------
Add some log messages in 'network/cni' isolator.
Diffs
-----
src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 486c382365d5293cd9d53b8b239f70a543c46792
Diff: https://reviews.apache.org/r/45580/diff/
Testing
-------
Thanks,
Qian Zhang
Re: Review Request 45580: Add some log messages in 'network/cni'
isolator.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45580/#review126678
-----------------------------------------------------------
Patch looks great!
Reviews applied: [44004, 44200, 44549, 44555, 44622, 44514, 44706, 45082, 45383, 45531, 45532, 45546, 45580]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On April 2, 2016, 3:31 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45580/
> -----------------------------------------------------------
>
> (Updated April 2, 2016, 3:31 a.m.)
>
>
> Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu.
>
>
> Bugs: MESOS-4759
> https://issues.apache.org/jira/browse/MESOS-4759
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add some log messages in 'network/cni' isolator.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 991139fac2b2583a35981a5c85f971510515cfab
>
> Diff: https://reviews.apache.org/r/45580/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 45580: Add some log messages in 'network/cni'
isolator.
Posted by Qian Zhang <zh...@cn.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45580/
-----------------------------------------------------------
(Updated April 2, 2016, 11:31 a.m.)
Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu.
Bugs: MESOS-4759
https://issues.apache.org/jira/browse/MESOS-4759
Repository: mesos
Description
-------
Add some log messages in 'network/cni' isolator.
Diffs (updated)
-----
src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 991139fac2b2583a35981a5c85f971510515cfab
Diff: https://reviews.apache.org/r/45580/diff/
Testing
-------
Thanks,
Qian Zhang
Re: Review Request 45580: Add some log messages in 'network/cni'
isolator.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45580/#review126572
-----------------------------------------------------------
Patch looks great!
Reviews applied: [44004, 44200, 44549, 44555, 44622, 44514, 44706, 45082, 45383, 45531, 45532, 45546, 45580]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On April 1, 2016, 9:54 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45580/
> -----------------------------------------------------------
>
> (Updated April 1, 2016, 9:54 a.m.)
>
>
> Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu.
>
>
> Bugs: MESOS-4759
> https://issues.apache.org/jira/browse/MESOS-4759
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add some log messages in 'network/cni' isolator.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 486c382365d5293cd9d53b8b239f70a543c46792
>
> Diff: https://reviews.apache.org/r/45580/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 45580: Add some log messages in 'network/cni'
isolator.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45580/#review126658
-----------------------------------------------------------
Fix it, then Ship it!
src/slave/containerizer/mesos/isolators/network/cni/cni.cpp (line 564)
<https://reviews.apache.org/r/45580/#comment189669>
I won't add this LOG(INFO) since the bind mount logging implies this.
src/slave/containerizer/mesos/isolators/network/cni/cni.cpp (lines 1032 - 1033)
<https://reviews.apache.org/r/45580/#comment189670>
You should put this log line in the if block.
- Jie Yu
On April 1, 2016, 9:54 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45580/
> -----------------------------------------------------------
>
> (Updated April 1, 2016, 9:54 a.m.)
>
>
> Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu.
>
>
> Bugs: MESOS-4759
> https://issues.apache.org/jira/browse/MESOS-4759
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add some log messages in 'network/cni' isolator.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 486c382365d5293cd9d53b8b239f70a543c46792
>
> Diff: https://reviews.apache.org/r/45580/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>