[GitHub] ctubbsii commented on a change in pull request #332: ACCUMULO-XXXX Use the hadoop3 shaded jars

[GitBox <gi...@apache.org>]

ctubbsii commented on a change in pull request #332: ACCUMULO-XXXX Use the hadoop3 shaded jars
URL: https://github.com/apache/accumulo/pull/332#discussion_r155403172
 
 

 ##########
 File path: server/monitor/src/test/java/org/apache/accumulo/monitor/util/AccumuloMonitorAppenderTest.java
 ##########
 @@ -174,11 +175,15 @@ private static boolean verifyAppender(AccumuloMonitorAppender parent, String new
     if (childAppenders == null || !childAppenders.hasMoreElements()) {
       return false;
     }
-    AppenderSkeleton child = (AppenderSkeleton) childAppenders.nextElement();
-    if (childAppenders.hasMoreElements()) {
-      Assert.fail("Appender should never have more than one child");
+    try {
+      AppenderSkeleton child = (AppenderSkeleton) childAppenders.nextElement();
+      if (childAppenders.hasMoreElements()) {
+        Assert.fail("Appender should never have more than one child");
+      }
+      return ("Appender for " + newLocName).equals(child.getName());
+    } catch (NoSuchElementException e) {
 
 Review comment:
   Is this an unrelated bug that we need to fix or is this a Hadoop3-specific thing?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services