You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "slachiewicz (via GitHub)" <gi...@apache.org> on 2026/10/13 21:26:49 UTC
[PR] [MDEP-654] Add copyChecksums to copy checksum files with useRepositoryLayout [maven-dependency-plugin]
slachiewicz opened a new pull request, #1737:
URL: https://github.com/apache/maven-dependency-plugin/pull/1737
Copies the `.sha1`, `.md5`, `.sha256` and `.sha512` files stored next to each artifact and POM in the local repository, instead of recomputing them, so the copies stay verifiable against what Maven downloaded. Off by default and only used with `useRepositoryLayout`. Fixes #1085.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MDEP-654] Add copyChecksums to copy checksum files with useRepositoryLayout [maven-dependency-plugin]
Posted by "slachiewicz (via GitHub)" <gi...@apache.org>.
slachiewicz merged PR #1737:
URL: https://github.com/apache/maven-dependency-plugin/pull/1737
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MDEP-654] Add copyChecksums to copy checksum files with useRepositoryLayout [maven-dependency-plugin]
Posted by "slachiewicz (via GitHub)" <gi...@apache.org>.
slachiewicz commented on code in PR #1737:
URL: https://github.com/apache/maven-dependency-plugin/pull/1737#discussion_r4325182764
##########
src/main/java/org/apache/maven/plugins/dependency/fromDependencies/CopyDependenciesMojo.java:
##########
@@ -102,6 +103,16 @@ public class CopyDependenciesMojo extends AbstractFromDependenciesMojo {
@Parameter(property = "mdep.copySignatures", defaultValue = "false")
protected boolean copySignatures;
+ /**
+ * Also copy the checksum files ({@code .sha1}, {@code .md5}, {@code .sha256} and {@code .sha512}) that sit next
+ * to each artifact and its POM in the local repository. Only used together with {@link #useRepositoryLayout};
+ * checksum files that do not exist in the local repository are skipped.
+ *
+ * @since 3.12.0
+ */
+ @Parameter(property = "mdep.copyChecksums", defaultValue = "false")
Review Comment:
Copying the checksums changes the output of every existing `useRepositoryLayout` build: consumers that ship or diff that directory would get extra files they never asked for. The switch keeps the default output unchanged, the same way `copySignatures` does for `.asc` files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MDEP-654] Add copyChecksums to copy checksum files with useRepositoryLayout [maven-dependency-plugin]
Posted by "slachiewicz (via GitHub)" <gi...@apache.org>.
slachiewicz commented on code in PR #1737:
URL: https://github.com/apache/maven-dependency-plugin/pull/1737#discussion_r4325182764
##########
src/main/java/org/apache/maven/plugins/dependency/fromDependencies/CopyDependenciesMojo.java:
##########
@@ -102,6 +103,16 @@ public class CopyDependenciesMojo extends AbstractFromDependenciesMojo {
@Parameter(property = "mdep.copySignatures", defaultValue = "false")
protected boolean copySignatures;
+ /**
+ * Also copy the checksum files ({@code .sha1}, {@code .md5}, {@code .sha256} and {@code .sha512}) that sit next
+ * to each artifact and its POM in the local repository. Only used together with {@link #useRepositoryLayout};
+ * checksum files that do not exist in the local repository are skipped.
+ *
+ * @since 3.12.0
+ */
+ @Parameter(property = "mdep.copyChecksums", defaultValue = "false")
Review Comment:
Because not everyone need checksums to be copied
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MDEP-654] Add copyChecksums to copy checksum files with useRepositoryLayout [maven-dependency-plugin]
Posted by "elharo (via GitHub)" <gi...@apache.org>.
elharo commented on code in PR #1737:
URL: https://github.com/apache/maven-dependency-plugin/pull/1737#discussion_r4269860819
##########
src/main/java/org/apache/maven/plugins/dependency/fromDependencies/CopyDependenciesMojo.java:
##########
@@ -102,6 +103,16 @@ public class CopyDependenciesMojo extends AbstractFromDependenciesMojo {
@Parameter(property = "mdep.copySignatures", defaultValue = "false")
protected boolean copySignatures;
+ /**
+ * Also copy the checksum files ({@code .sha1}, {@code .md5}, {@code .sha256} and {@code .sha512}) that sit next
+ * to each artifact and its POM in the local repository. Only used together with {@link #useRepositoryLayout};
+ * checksum files that do not exist in the local repository are skipped.
+ *
+ * @since 3.12.0
+ */
+ @Parameter(property = "mdep.copyChecksums", defaultValue = "false")
Review Comment:
Why make this a parameter? Why not just do it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org