You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Daniel Estévez <no...@github.com> on 2018/06/21 20:32:58 UTC

[jclouds/jclouds] Adds new Generally Available azure locations for Australia and France (#1219)

You can view, comment on, or merge this pull request online at:

  https://github.com/jclouds/jclouds/pull/1219

-- Commit Summary --

  * Adds new Generally Available azure locations for Australia and France

-- File Changes --

    M providers/azurecompute-arm/src/main/java/org/jclouds/azurecompute/arm/domain/Region.java (6)

-- Patch Links --

https://github.com/jclouds/jclouds/pull/1219.patch
https://github.com/jclouds/jclouds/pull/1219.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1219

Re: [jclouds/jclouds] Adds new Generally Available azure locations for Australia and France (#1219)

Posted by Ignasi Barrera <no...@github.com>.
Pushed to [master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/23e783e0) and [2.1.x](http://git-wip-us.apache.org/repos/asf/jclouds/commit/0ae9e5a0). Thanks @danielestevez!

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1219#issuecomment-400202595

Re: [jclouds/jclouds] Adds new Generally Available azure locations for Australia and France (#1219)

Posted by Ignasi Barrera <no...@github.com>.
nacx requested changes on this pull request.



> @@ -54,13 +54,17 @@
    BRAZIL_SOUTH("Brazil South", "BR"),
    AUSTRALIA_EAST("Australia East", "AU-NSW"),
    AUSTRALIA_SOUTH_EAST("Australia Southeast", "AU-VIC"),
+   AUSTRALIA_CENTRAL("Australia Central", "AU-ACT"), 
+   AUSTRALIA_CENTRAL_2("Australia Central 2", "AU-ACT2"),

The ISO code a standard code and is the same for those regions if they are geographically in the same place. Change to `AU-ACT`.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1219#pullrequestreview-131084011

Re: [jclouds/jclouds] Adds new Generally Available azure locations for Australia and France (#1219)

Posted by Ignasi Barrera <no...@github.com>.
Closed #1219.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1219#event-1700612166

Re: [jclouds/jclouds] Adds new Generally Available azure locations for Australia and France (#1219)

Posted by Daniel Estévez <no...@github.com>.
danielestevez commented on this pull request.



> @@ -54,13 +54,17 @@
    BRAZIL_SOUTH("Brazil South", "BR"),
    AUSTRALIA_EAST("Australia East", "AU-NSW"),
    AUSTRALIA_SOUTH_EAST("Australia Southeast", "AU-VIC"),
+   AUSTRALIA_CENTRAL("Australia Central", "AU-ACT"), 
+   AUSTRALIA_CENTRAL_2("Australia Central 2", "AU-ACT2"),

Done! Sorry!

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1219#discussion_r197444025