You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Mike Percy (Code Review)" <ge...@cloudera.org> on 2018/01/08 19:50:11 UTC
[kudu-CR] consensus: Reduce copy/paste for observer callbacks
Hello Alexey Serbin,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/8962
to review the following change.
Change subject: consensus: Reduce copy/paste for observer callbacks
......................................................................
consensus: Reduce copy/paste for observer callbacks
This is a net-negative line patch that unifies how the PeerMessageQueue
notifies PeerMessageQueueObserver instances that are registered with it.
The patch removes most of the copy/paste in this part of the code.
This patch has no functional changes.
Change-Id: Icbc4cb9d7b6e51a9f64d6f08c2f48d89705f5437
---
M src/kudu/consensus/consensus_queue.cc
M src/kudu/consensus/consensus_queue.h
2 files changed, 33 insertions(+), 84 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/62/8962/1
--
To view, visit http://gerrit.cloudera.org:8080/8962
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icbc4cb9d7b6e51a9f64d6f08c2f48d89705f5437
Gerrit-Change-Number: 8962
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
[kudu-CR] consensus: Reduce copy/paste for observer callbacks
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8962 )
Change subject: consensus: Reduce copy/paste for observer callbacks
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/8962/1/src/kudu/consensus/consensus_queue.cc
File src/kudu/consensus/consensus_queue.cc:
http://gerrit.cloudera.org:8080/#/c/8962/1/src/kudu/consensus/consensus_queue.cc@1323
PS1, Line 1323: void PeerMessageQueue::NotifyObserversTask(std::function<void(PeerMessageQueueObserver*)> func) {
> warning: the parameter 'func' is copied for each invocation but only used a
seems accurate
--
To view, visit http://gerrit.cloudera.org:8080/8962
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icbc4cb9d7b6e51a9f64d6f08c2f48d89705f5437
Gerrit-Change-Number: 8962
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Tue, 09 Jan 2018 00:10:21 +0000
Gerrit-HasComments: Yes
[kudu-CR] consensus: Reduce copy/paste for observer callbacks
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8962
to look at the new patch set (#2).
Change subject: consensus: Reduce copy/paste for observer callbacks
......................................................................
consensus: Reduce copy/paste for observer callbacks
This is a net-negative line patch that unifies how the PeerMessageQueue
notifies PeerMessageQueueObserver instances that are registered with it.
The patch removes most of the copy/paste in this part of the code.
This patch has no functional changes.
Change-Id: Icbc4cb9d7b6e51a9f64d6f08c2f48d89705f5437
---
M src/kudu/consensus/consensus_queue.cc
M src/kudu/consensus/consensus_queue.h
2 files changed, 35 insertions(+), 83 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/62/8962/2
--
To view, visit http://gerrit.cloudera.org:8080/8962
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Icbc4cb9d7b6e51a9f64d6f08c2f48d89705f5437
Gerrit-Change-Number: 8962
Gerrit-PatchSet: 2
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] consensus: Reduce copy/paste for observer callbacks
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8962 )
Change subject: consensus: Reduce copy/paste for observer callbacks
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/8962/1/src/kudu/consensus/consensus_queue.cc
File src/kudu/consensus/consensus_queue.cc:
http://gerrit.cloudera.org:8080/#/c/8962/1/src/kudu/consensus/consensus_queue.cc@1323
PS1, Line 1323: void PeerMessageQueue::NotifyObserversTask(std::function<void(PeerMessageQueueObserver*)> func) {
> seems accurate
Done
--
To view, visit http://gerrit.cloudera.org:8080/8962
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icbc4cb9d7b6e51a9f64d6f08c2f48d89705f5437
Gerrit-Change-Number: 8962
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Tue, 09 Jan 2018 01:47:40 +0000
Gerrit-HasComments: Yes
[kudu-CR] consensus: Reduce copy/paste for observer callbacks
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8962 )
Change subject: consensus: Reduce copy/paste for observer callbacks
......................................................................
Patch Set 1: Code-Review+1
LGTM, maybe just fix what IWYU reports.
--
To view, visit http://gerrit.cloudera.org:8080/8962
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icbc4cb9d7b6e51a9f64d6f08c2f48d89705f5437
Gerrit-Change-Number: 8962
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Comment-Date: Mon, 08 Jan 2018 21:39:31 +0000
Gerrit-HasComments: No
[kudu-CR] consensus: Reduce copy/paste for observer callbacks
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8962 )
Change subject: consensus: Reduce copy/paste for observer callbacks
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/8962
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icbc4cb9d7b6e51a9f64d6f08c2f48d89705f5437
Gerrit-Change-Number: 8962
Gerrit-PatchSet: 2
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Tue, 09 Jan 2018 02:43:14 +0000
Gerrit-HasComments: No
[kudu-CR] consensus: Reduce copy/paste for observer callbacks
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8962 )
Change subject: consensus: Reduce copy/paste for observer callbacks
......................................................................
consensus: Reduce copy/paste for observer callbacks
This is a net-negative line patch that unifies how the PeerMessageQueue
notifies PeerMessageQueueObserver instances that are registered with it.
The patch removes most of the copy/paste in this part of the code.
This patch has no functional changes.
Change-Id: Icbc4cb9d7b6e51a9f64d6f08c2f48d89705f5437
Reviewed-on: http://gerrit.cloudera.org:8080/8962
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/consensus/consensus_queue.cc
M src/kudu/consensus/consensus_queue.h
2 files changed, 35 insertions(+), 83 deletions(-)
Approvals:
Alexey Serbin: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/8962
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Icbc4cb9d7b6e51a9f64d6f08c2f48d89705f5437
Gerrit-Change-Number: 8962
Gerrit-PatchSet: 3
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>