[jira] [Commented] (ARTEMIS-1207) [Core JMS Client] Align order of when setClientId can be called with AcitveMQ5 and QPID

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ARTEMIS-1207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16038411#comment-16038411 ] 

ASF GitHub Bot commented on ARTEMIS-1207:
-----------------------------------------

GitHub user michaelandrepearce opened a pull request:

    https://github.com/apache/activemq-artemis/pull/1317

    ARTEMIS-1207: Align order of when setClientId can be called with AcitveMQ5 and QPID

    Update ActiveMQConnection to change behaviour
    Add test to avoid regression.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/michaelandrepearce/activemq-artemis ARTEMIS-1207

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1317.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1317
    
----
commit 1f09a8e3046ed2769a9a80e7851e2e9ab56041a9
Author: Michael Andre Pearce <mi...@me.com>
Date:   2017-06-06T08:54:02Z

    ARTEMIS-1207: [Core JMS Client] Align order of when setClientId can be called with AcitveMQ5 and QPID
    
    Update ActiveMQConnection to change behaviour
    Add test to avoid regression.

----


> [Core JMS Client] Align order of when setClientId can be called with AcitveMQ5 and QPID
> ---------------------------------------------------------------------------------------
>
>                 Key: ARTEMIS-1207
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1207
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>            Reporter: Michael Andre Pearce
>
> There is a difference in behaviour of when it is valid to be able to set clientId though it seems the behaviour isn't clear in JMS spec, where QPID and ActiveMQ5 allow you to set an exception listener first, where as currently Artemis requires the very first call to setClientId if you wish to set it. 
> As discussed will create and align the clients so even so not detailed in spec, a user of ActiveMQ5 client or QPID client can expect the same behaviour.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)