Re: [PR] [Improvement-18675][API] Return TASK_DEFINE_NOT_EXIST instead of NPE when taskRelation references missing task definitions [dolphinscheduler]

["wank125 (via GitHub)" <gi...@apache.org>]

wank125 commented on PR #18676:
URL: https://github.com/apache/dolphinscheduler/pull/18676#issuecomment-6034284056

   Thanks for the review @SbloodyS — good catch on the silent edge drop. Addressed in 00743a1:
   
   - `ProcessServiceImpl#transformTask` now collects pre task codes without a matching task definition and throws an explicit exception naming the missing codes (shared path; the `filter(Objects::nonNull)` is gone)
   - `WorkflowDefinitionServiceImpl#checkWorkflowNodeList` converts that failure into `TASK_DEFINE_NOT_EXIST`, so the workflow-instance update path reports the missing code instead of passing the filtered graph
   - added regression tests: direct `transformTask` failure, `checkWorkflowNodeList` conversion, and `updateWorkflowInstance` asserting the missing code is reported and that neither `saveTaskRelation` nor `saveWorkflowDefine` persists anything when the check fails
   
   The up-front validation in `generateTaskRelationList` is kept so the workflow-definition path still fails fast with the same status before reaching `transformTask`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org