You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/06/16 02:58:12 UTC
[GitHub] [incubator-doris] Kikyou1997 opened a new pull request, #10174: [fix](optimizer) Fix the default join reorder algorithm
Kikyou1997 opened a new pull request, #10174:
URL: https://github.com/apache/incubator-doris/pull/10174
# Proposed changes
Issue Number: #10167
## Problem Summary:
Default join reorder algorithm not working for the most cases.
## Checklist(Required)
1. Does it affect the original behavior: (Yes)
2. Has unit tests been added: (Yes)
3. Has document been added or modified: (No Need)
4. Does it need to update dependencies: (No)
5. Are there any changes that cannot be rolled back: (No)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #10174: [fix](optimizer) Fix the default join reorder algorithm
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #10174:
URL: https://github.com/apache/incubator-doris/pull/10174#issuecomment-1157557550
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #10174: [fix](optimizer) Fix the default join reorder algorithm
Posted by GitBox <gi...@apache.org>.
morningman merged PR #10174:
URL: https://github.com/apache/incubator-doris/pull/10174
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on a diff in pull request #10174: [fix](optimizer) Fix the default join reorder algorithm
Posted by GitBox <gi...@apache.org>.
morningman commented on code in PR #10174:
URL: https://github.com/apache/incubator-doris/pull/10174#discussion_r898980119
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/SelectStmt.java:
##########
@@ -819,19 +819,21 @@ protected boolean reorderTable(Analyzer analyzer, TableRef firstRef)
// is being added.
Preconditions.checkState(tid == candidateTableRef.getId());
List<Expr> candidateEqJoinPredicates = analyzer.getEqJoinConjunctsExcludeAuxPredicates(tid);
- List<TupleId> candidateTupleList = Lists.newArrayList();
- Expr.getIds(candidateEqJoinPredicates, candidateTupleList, null);
- int count = candidateTupleList.size();
- for (TupleId tupleId : candidateTupleList) {
- if (validTupleId.contains(tupleId) || tid == tupleId) {
- count--;
+ for (Expr candidateEqJoinPredicate : candidateEqJoinPredicates) {
+ List<TupleId> candidateTupleList = Lists.newArrayList();
+ Expr.getIds(Lists.newArrayList(candidateEqJoinPredicate), candidateTupleList, null);
+ int count = candidateTupleList.size();
+ for (TupleId tupleId : candidateTupleList) {
+ if (validTupleId.contains(tupleId) || tid == tupleId) {
Review Comment:
Can we use `==` to compare the `TupleId`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #10174: [fix](optimizer) Fix the default join reorder algorithm
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #10174:
URL: https://github.com/apache/incubator-doris/pull/10174#issuecomment-1157182760
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org