You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2016/02/04 22:18:00 UTC

Review Request 43207: Don't remove IP from the logger's environment.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43207/
-----------------------------------------------------------

Review request for mesos, Benjamin Hindman and Artem Harutyunyan.


Bugs: MESOS-4598
    https://issues.apache.org/jira/browse/MESOS-4598


Repository: mesos


Description
-------

Unsetting the `LIBPROCESS_IP` was originally unnecessary, as this variable does not result in port conflicts.  Unsetting this environment variable may cause the subprocess to exit if DNS cannot resolve the agent's hostname.


Diffs
-----

  src/slave/container_loggers/lib_logrotate.cpp 8d2f89503cd8ace1971933006a46ed4d3936ff8e 

Diff: https://reviews.apache.org/r/43207/diff/


Testing
-------

make check (OSX)


Thanks,

Joseph Wu