You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rukletsov <ru...@gmail.com> on 2015/09/02 18:34:33 UTC
Review Request 38061: Corrected include order in master.hpp
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38061/
-----------------------------------------------------------
Review request for mesos and Joris Van Remoortere.
Repository: mesos
Description
-------
See summary.
Diffs
-----
src/master/master.hpp 594dd25f9aa9b6147680d0a838a77c3222941f4b
Diff: https://reviews.apache.org/r/38061/diff/
Testing
-------
None.
Thanks,
Alexander Rukletsov
Re: Review Request 38061: Corrected include order in master.hpp
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38061/#review97565
-----------------------------------------------------------
Ship it!
Ship It!
- Guangya Liu
On 九月 2, 2015, 4:34 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38061/
> -----------------------------------------------------------
>
> (Updated 九月 2, 2015, 4:34 p.m.)
>
>
> Review request for mesos and Joris Van Remoortere.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/master.hpp 594dd25f9aa9b6147680d0a838a77c3222941f4b
>
> Diff: https://reviews.apache.org/r/38061/diff/
>
>
> Testing
> -------
>
> None.
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 38061: Corrected include order in master.hpp
Posted by Alexander Rukletsov <ru...@gmail.com>.
> On Sept. 2, 2015, 4:45 p.m., Guangya Liu wrote:
> > src/master/master.hpp, line 34
> > <https://reviews.apache.org/r/38061/diff/1/?file=1062343#file1062343line34>
> >
> > Alex, can you please show more detail for why we need to move #include <mesos/scheduler/scheduler.hpp>? Does the correct order is sub grouping interfaces in a same folder with alpha order? Thanks
Exactly right: we sort lexicographically inside the folder, nested folders after files with newlines between groups.
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38061/#review97475
-----------------------------------------------------------
On Sept. 2, 2015, 4:34 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38061/
> -----------------------------------------------------------
>
> (Updated Sept. 2, 2015, 4:34 p.m.)
>
>
> Review request for mesos and Joris Van Remoortere.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/master.hpp 594dd25f9aa9b6147680d0a838a77c3222941f4b
>
> Diff: https://reviews.apache.org/r/38061/diff/
>
>
> Testing
> -------
>
> None.
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 38061: Corrected include order in master.hpp
Posted by Guangya Liu <gy...@gmail.com>.
> On 九月 2, 2015, 4:45 p.m., Guangya Liu wrote:
> > src/master/master.hpp, line 34
> > <https://reviews.apache.org/r/38061/diff/1/?file=1062343#file1062343line34>
> >
> > Alex, can you please show more detail for why we need to move #include <mesos/scheduler/scheduler.hpp>? Does the correct order is sub grouping interfaces in a same folder with alpha order? Thanks
>
> Alexander Rukletsov wrote:
> Exactly right: we sort lexicographically inside the folder, nested folders after files with newlines between groups.
Thanks Alex, got it.
- Guangya
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38061/#review97475
-----------------------------------------------------------
On 九月 2, 2015, 4:34 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38061/
> -----------------------------------------------------------
>
> (Updated 九月 2, 2015, 4:34 p.m.)
>
>
> Review request for mesos and Joris Van Remoortere.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/master.hpp 594dd25f9aa9b6147680d0a838a77c3222941f4b
>
> Diff: https://reviews.apache.org/r/38061/diff/
>
>
> Testing
> -------
>
> None.
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 38061: Corrected include order in master.hpp
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38061/#review97475
-----------------------------------------------------------
src/master/master.hpp
<https://reviews.apache.org/r/38061/#comment153363>
Alex, can you please show more detail for why we need to move #include <mesos/scheduler/scheduler.hpp>? Does the correct order is sub grouping interfaces in a same folder with alpha order? Thanks
- Guangya Liu
On 九月 2, 2015, 4:34 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38061/
> -----------------------------------------------------------
>
> (Updated 九月 2, 2015, 4:34 p.m.)
>
>
> Review request for mesos and Joris Van Remoortere.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/master.hpp 594dd25f9aa9b6147680d0a838a77c3222941f4b
>
> Diff: https://reviews.apache.org/r/38061/diff/
>
>
> Testing
> -------
>
> None.
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 38061: Corrected include order in master.hpp
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38061/#review97493
-----------------------------------------------------------
Ship it!
Ship It!
- Joseph Wu
On Sept. 2, 2015, 9:34 a.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38061/
> -----------------------------------------------------------
>
> (Updated Sept. 2, 2015, 9:34 a.m.)
>
>
> Review request for mesos and Joris Van Remoortere.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/master.hpp 594dd25f9aa9b6147680d0a838a77c3222941f4b
>
> Diff: https://reviews.apache.org/r/38061/diff/
>
>
> Testing
> -------
>
> None.
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 38061: Corrected include order in master.hpp
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38061/#review97733
-----------------------------------------------------------
Ship it!
Ship It!
- Joris Van Remoortere
On Sept. 2, 2015, 4:34 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38061/
> -----------------------------------------------------------
>
> (Updated Sept. 2, 2015, 4:34 p.m.)
>
>
> Review request for mesos and Joris Van Remoortere.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/master.hpp 594dd25f9aa9b6147680d0a838a77c3222941f4b
>
> Diff: https://reviews.apache.org/r/38061/diff/
>
>
> Testing
> -------
>
> None.
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 38061: Corrected include order in master.hpp
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38061/#review97525
-----------------------------------------------------------
Patch looks great!
Reviews applied: [38061]
All tests passed.
- Mesos ReviewBot
On Sept. 2, 2015, 4:34 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38061/
> -----------------------------------------------------------
>
> (Updated Sept. 2, 2015, 4:34 p.m.)
>
>
> Review request for mesos and Joris Van Remoortere.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/master.hpp 594dd25f9aa9b6147680d0a838a77c3222941f4b
>
> Diff: https://reviews.apache.org/r/38061/diff/
>
>
> Testing
> -------
>
> None.
>
>
> Thanks,
>
> Alexander Rukletsov
>
>