You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by "Wellington Chevreuil (Jira)" <ji...@apache.org> on 2020/08/10 15:58:00 UTC

[jira] [Commented] (HBASE-24640) Purge use of VisibleForTesting

    [ https://issues.apache.org/jira/browse/HBASE-24640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17174407#comment-17174407 ] 

Wellington Chevreuil commented on HBASE-24640:
----------------------------------------------

+1 for the proposal on the comment summarising [this thread discussion.|https://lists.apache.org/thread.html/r9a2df6a3b58e00c0c482d8660434d8ce6075863c18700978e6ea8b21%40%3Cdev.hbase.apache.org%3E]

> Purge use of VisibleForTesting
> ------------------------------
>
>                 Key: HBASE-24640
>                 URL: https://issues.apache.org/jira/browse/HBASE-24640
>             Project: HBase
>          Issue Type: Task
>          Components: community
>    Affects Versions: 3.0.0-alpha-1, 2.4.0
>            Reporter: Nick Dimiduk
>            Priority: Major
>
> From the dev-list thread ["[DISCUSS] VisibleForTesting annotation as it pertains to our API compatibility guidelines"|https://lists.apache.org/thread.html/rc7c7c66f134fe135d0a4454a883215e26ff3d20e5a31ecd6a2d1db77%40%3Cdev.hbase.apache.org%3E], when used in classes annotated with interface audience other than IA.Private, the VisibleForTesting annotation is confusing and considered harmful. The consensus is that we do not want to use this annotation as part of the definition of our public APIs, and we need to remove the point of confusion.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)