You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by zjureel <gi...@git.apache.org> on 2017/07/10 09:57:48 UTC
[GitHub] flink pull request #4292: [FLINK-6588] Rename NumberOfFullRestarts metric
GitHub user zjureel opened a pull request:
https://github.com/apache/flink/pull/4292
[FLINK-6588] Rename NumberOfFullRestarts metric
Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful description of your changes.
- [ ] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the JIRA id)
- [ ] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [ ] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zjureel/flink FLINK-6588
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4292.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4292
----
commit 9f2023a0c93f521330e0bbfadfc6370a70714382
Author: zjureel <zj...@gmail.com>
Date: 2017-07-10T09:56:04Z
[FLINK-6588] Rename NumberOfFullRestarts metric
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4292: [FLINK-6588] Rename NumberOfFullRestarts metric
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4292
Unfortunately i agree, we already made a release with the current name so we can't change it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4292: [FLINK-6588] Rename NumberOfFullRestarts metric
Posted by zjureel <gi...@git.apache.org>.
Github user zjureel commented on the issue:
https://github.com/apache/flink/pull/4292
@zentol What do you think of @StephanEwen 's suggestion? I think this change does cause some incompatibilities for user, thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4292: [FLINK-6588] Rename NumberOfFullRestarts metric
Posted by zjureel <gi...@git.apache.org>.
Github user zjureel closed the pull request at:
https://github.com/apache/flink/pull/4292
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4292: [FLINK-6588] Rename NumberOfFullRestarts metric
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/4292
I am very hesitant to rename such metrics, because there may be production users that defined monitoring or alterting based on that metric. Those installations would be broken through this change.
For that reason, I would suggest to not do this change...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---