Re: [PR] GH-2107: Use a progress bar to show the overall upload status [jena]

["kinow (via GitHub)" <gi...@apache.org>]

kinow commented on PR #2123:
URL: https://github.com/apache/jena/pull/2123#issuecomment-2021249166

   Tests added, @neumarcx, tested `yarn test:unit`, `yarn lint`, and `yarn run test:e2e` locally and all passed.
   
   The test is an e2e test, that loads three files. There is a Cypress “interceptor” that, as the name says, intercepts network requests to the URL to handle the upload, and the test-interceptor fails every odd-time it is called.
   
   There are tests for no files selected, showing an empty progress bar (so no content shift, or very minimum, which is good!), and a test that adds three files, and confirms we get 2/3 success, and 1/3 failure, and that the progress bars (4 in total, an overall progress, and one for each file selected) are displayed correctly.
   
   :+1: 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org