You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by caneGuy <gi...@git.apache.org> on 2017/10/12 10:06:03 UTC

[GitHub] spark pull request #19482: [SPARK-22264][DEPLOY] Add timeout for eventlog re...

GitHub user caneGuy opened a pull request:

    https://github.com/apache/spark/pull/19482

    [SPARK-22264][DEPLOY] Add timeout for eventlog replaying to avoid time-cons…

    …uming replaying which will cause historyserver unavailable
    
    ## What changes were proposed in this pull request?
    
    History server will be unavailable if there is an event log file with large size.Large size here means the replaying time is too long.
    We can fix this to add a timeout for event log replaying.
    More details attached in [SPARK-22264](https://issues.apache.org/jira/browse/SPARK-22264)
    
    ## How was this patch tested?
    Exsisted unit tests.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/caneGuy/spark zhoukang/replay-timeout

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/19482.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #19482
    
----
commit a2423dda5a90741691926a40d99b085795e81fbb
Author: zhoukang <zh...@gmail.com>
Date:   2017-10-12T09:47:32Z

    [SPARK][DEPLOY] Add timeout for eventlog replaying to avoid time-consuming replaying which will cause historyserver unavailable

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19482: [SPARK-22264][DEPLOY] Add timeout for eventlog replaying...

Posted by caneGuy <gi...@git.apache.org>.
Github user caneGuy commented on the issue:

    https://github.com/apache/spark/pull/19482
  
    Ok,thanks @vanzin 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19482: [SPARK-22264][DEPLOY] Add timeout for eventlog replaying...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/19482
  
    Can one of the admins verify this patch?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19482: [SPARK-22264][DEPLOY] Add timeout for eventlog replaying...

Posted by caneGuy <gi...@git.apache.org>.
Github user caneGuy commented on the issue:

    https://github.com/apache/spark/pull/19482
  
    Cloud you help review this? @vanzin Thanks.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request #19482: [SPARK-22264][DEPLOY] Add timeout for eventlog re...

Posted by caneGuy <gi...@git.apache.org>.
Github user caneGuy closed the pull request at:

    https://github.com/apache/spark/pull/19482


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19482: [SPARK-22264][DEPLOY] Add timeout for eventlog replaying...

Posted by vanzin <gi...@git.apache.org>.
Github user vanzin commented on the issue:

    https://github.com/apache/spark/pull/19482
  
    This would be fixed by SPARK-20656 which cannot be implemented until SPARK-18085 is in. Instead of adding patch on top of patch to fix things on the SHS, I'd rather spend resources into getting the code for SPARK-18085 reviewed and checked in, so if you'd like I'd appreciated help in reviewing and testing that code instead.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org