You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by aljoscha <gi...@git.apache.org> on 2016/02/24 17:43:44 UTC
[GitHub] flink pull request: [hotfix] Expose current watermark to Triggers
GitHub user aljoscha opened a pull request:
https://github.com/apache/flink/pull/1706
[hotfix] Expose current watermark to Triggers
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aljoscha/flink window-watermark-in-trigger
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1706.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1706
----
commit 36e605c0dbca0627536799c90779459a35cf360e
Author: Aljoscha Krettek <al...@gmail.com>
Date: 2016-02-24T15:05:31Z
[hotfix] Expose current watermark to Triggers
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [hotfix] Expose current watermark to Triggers
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1706
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [hotfix] Expose current watermark to Triggers
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1706#issuecomment-188450931
Okay, makes sense.
+1 from my side
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [hotfix] Expose current watermark to Triggers
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1706#issuecomment-188352346
What is the implication of this change?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [hotfix] Expose current watermark to Triggers
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/1706#issuecomment-188448934
I want to add this because it enables triggers that can essentially discard late elements. It does not change any previous behavior but just enables some nifty custom trigger tricks.
I don't want to add big changes to the Triggers themselves this short before the release, that's why I'm only suggesting to add this small change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [hotfix] Expose current watermark to Triggers
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1706#issuecomment-188451606
Merging & including this one into the RC1 as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---