You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/03/27 16:42:44 UTC

[GitHub] [incubator-superset] enricoberti opened a new pull request #7142: [SQL Lab] Introduced ALLOW_SQL_MAX_ROW_OVERRIDE config to allow users…

enricoberti opened a new pull request #7142: [SQL Lab] Introduced ALLOW_SQL_MAX_ROW_OVERRIDE config to allow users…
URL: https://github.com/apache/incubator-superset/pull/7142
 
 
   … to specify a higher limit than SQL_MAX_ROW
   
   This also modifies the behavior of `DEFAULT_SQLLAB_LIMIT`: `SQL_MAX_ROW` will be used if `DEFAULT_SQLLAB_LIMIT` has a greater value than `SQL_MAX_ROW` and `ALLOW_SQL_MAX_ROW_OVERRIDE` is set to False
   
   For example:
   `SQL_MAX_ROW = 10`
   `ALLOW_SQL_MAX_ROW_OVERRIDE = True`
   `DEFAULT_SQLLAB_LIMIT = 5`
   allows users to specify a limit greater than 10
   
   This commit also introduces a safety net for wrong configurations, like
   `SQL_MAX_ROW = 10`
   `ALLOW_SQL_MAX_ROW_OVERRIDE = False`
   `DEFAULT_SQLLAB_LIMIT = 100`
   In this case SQL Lab will display a default limit of 10
   
   Also, as a nit, changed the limit input type from text to number
   
   Closes #6666

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org