You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Jarek Cecho <ja...@apache.org> on 2014/06/04 20:08:21 UTC
Re: Review Request 21898: Patch for SQOOP-1255 -
https://issues.apache.org/jira/browse/SQOOP-1255
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21898/#review44727
-----------------------------------------------------------
I've tried the patch on real cluster and I need to think about the export format a bit further. Otherwise I do have two small nits:
tools/src/main/java/org/apache/sqoop/tools/tool/BuiltinTools.java
<https://reviews.apache.org/r/21898/#comment79198>
It seems that the "verify" is there now twice?
tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java
<https://reviews.apache.org/r/21898/#comment79201>
Shouldn't we return false at this point?
Jarcec
- Jarek Cecho
On May 30, 2014, 5:40 p.m., Gwen Shapira wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21898/
> -----------------------------------------------------------
>
> (Updated May 30, 2014, 5:40 p.m.)
>
>
> Review request for Sqoop.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> Added tool for dumping user-generated data - connections, jobs and submissions. There's an option to dump sensitive data (i.e. passwords) as well.
>
>
> Diffs
> -----
>
> docs/src/site/sphinx/Tools.rst ad72cd1
> pom.xml 1e2f005
> tools/pom.xml 31eda1c
> tools/src/main/java/org/apache/sqoop/tools/tool/BuiltinTools.java b24cb35
> tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/21898/diff/
>
>
> Testing
> -------
>
> Manual testing. Dumping repository with and without sensitive data. Validating resulting JSON.
>
>
> Thanks,
>
> Gwen Shapira
>
>