You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@syncope.apache.org by pfrenssen <gi...@git.apache.org> on 2018/08/13 15:10:40 UTC
[GitHub] syncope pull request #80: [SYNCOPE-1355] Document how to access services whe...
GitHub user pfrenssen opened a pull request:
https://github.com/apache/syncope/pull/80
[SYNCOPE-1355] Document how to access services when using Docker Compose
Fixes https://issues.apache.org/jira/browse/SYNCOPE-1355
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pfrenssen/syncope update-docker-compose-docs
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/syncope/pull/80.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #80
----
commit 37816dd3c45a69731a9841006b274f126aa11cf9
Author: Pieter Frenssen <pi...@...>
Date: 2018-08-13T15:09:22Z
[SYNCOPE-1355] Document how to access services when using Docker Compose
----
---
[GitHub] syncope pull request #80: [SYNCOPE-1355] Document how to access services whe...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/syncope/pull/80
---
[GitHub] syncope issue #80: [SYNCOPE-1355] Document how to access services when using...
Posted by ilgrosso <gi...@git.apache.org>.
Github user ilgrosso commented on the issue:
https://github.com/apache/syncope/pull/80
The results are available at https://ci.apache.org/projects/syncope/2_1_X/getting-started.html#docker-compose-samples and will appear at https://syncope.apache.org/docs/getting-started.html#docker-compose-samples as soon as 2.1.1 is officially released (I expect soon).
---
[GitHub] syncope pull request #80: [SYNCOPE-1355] Document how to access services whe...
Posted by ilgrosso <gi...@git.apache.org>.
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/80#discussion_r209650421
--- Diff: src/main/asciidoc/getting-started/obtain.adoc ---
@@ -422,6 +422,23 @@ services:
<4> Apache Syncope Enduser UI, port `38080` exposed, working with `Master` domain
====
+How to start the containers:
+
+. Save the example file as `docker-compose.yml` in an empty directory.
+. Download and start the containers:
++
+[source,bash]
+----
+$ docker-compose up
+----
+
+The following services will be available:
--- End diff --
Please style as in https://github.com/apache/syncope/blob/master/src/main/asciidoc/getting-started/obtain.adoc#L259 e.g. "Components" under "GUI Installer"
---
[GitHub] syncope issue #80: [SYNCOPE-1355] Document how to access services when using...
Posted by ilgrosso <gi...@git.apache.org>.
Github user ilgrosso commented on the issue:
https://github.com/apache/syncope/pull/80
Thanks for your contribution @pfrenssen !
I've added a couple of comments, please address.
Please also consider [sending an ICLA](http://syncope.apache.org/contributing#How_do_I_become_a_contributor_or_a_committer.3F), thanks.
---
[GitHub] syncope issue #80: [SYNCOPE-1355] Document how to access services when using...
Posted by pfrenssen <gi...@git.apache.org>.
Github user pfrenssen commented on the issue:
https://github.com/apache/syncope/pull/80
Sure no problem! I have squashed the commits.
---
[GitHub] syncope issue #80: [SYNCOPE-1355] Document how to access services when using...
Posted by pfrenssen <gi...@git.apache.org>.
Github user pfrenssen commented on the issue:
https://github.com/apache/syncope/pull/80
Thanks for the quick review @ilgrosso! I have addressed the remarks. I will also send the ICLA by e-mail.
---
[GitHub] syncope pull request #80: [SYNCOPE-1355] Document how to access services whe...
Posted by ilgrosso <gi...@git.apache.org>.
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/80#discussion_r209648695
--- Diff: src/main/asciidoc/getting-started/obtain.adoc ---
@@ -422,6 +422,23 @@ services:
<4> Apache Syncope Enduser UI, port `38080` exposed, working with `Master` domain
====
+How to start the containers:
+
+. Save the example file as `docker-compose.yml` in an empty directory.
--- End diff --
This step is not required: you could simply do `docker-compose -f XXXX`
---
[GitHub] syncope issue #80: [SYNCOPE-1355] Document how to access services when using...
Posted by ilgrosso <gi...@git.apache.org>.
Github user ilgrosso commented on the issue:
https://github.com/apache/syncope/pull/80
Thanks for quick turnaround :+1:
Please squash your commits and I'll be glad to merge, thanks.
---