[GitHub] [iceberg] rdblue commented on a change in pull request #1481: Core: Implement Catalogs.createTable and Catalogs.dropTable

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #1481:
URL: https://github.com/apache/iceberg/pull/1481#discussion_r493965672



##########
File path: core/src/main/java/org/apache/iceberg/BaseMetastoreCatalog.java
##########
@@ -278,84 +268,6 @@ private Transaction newReplaceTableTransaction(boolean orCreate) {
     }
   }
 
-  /**
-   * Drops all data and metadata files referenced by TableMetadata.
-   * <p>
-   * This should be called by dropTable implementations to clean up table files once the table has been dropped in the
-   * metastore.
-   *
-   * @param io a FileIO to use for deletes
-   * @param metadata the last valid TableMetadata instance for a dropped table.
-   */
-  protected static void dropTableData(FileIO io, TableMetadata metadata) {

Review comment:
       Because this was `protected`, I think we should keep it and just delegate to where the method moved. We can also deprecated it and set a version when it will be removed:
   
   ```
     /**
      * ...
      * @deprecated will be removed in 0.11.0; use CatalogUtil.dropTableData instead.
      */
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org