You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by el...@apache.org on 2026/07/03 10:17:24 UTC
(superset) 01/02: fix(a11y): use aria-label instead of non-functional alt prop on filter icons
This is an automated email from the ASF dual-hosted git repository.
eschutho pushed a commit to branch fix/a11y-filter-icon-alt-prop
in repository https://gitbox.apache.org/repos/asf/superset.git
commit e09cb7463e29df7ac96b9a653814a31840f9eb52
Author: Elizabeth Thompson <es...@gmail.com>
AuthorDate: Fri Jul 3 10:07:38 2026 +0000
fix(a11y): use aria-label instead of non-functional alt prop on filter icons
WCAG 2.1 SC 4.1.2 — Level A.
---
.../components/nativeFilters/FiltersConfigModal/DraggableFilter.tsx | 2 +-
.../nativeFilters/FiltersConfigModal/FilterTitleContainer.tsx | 2 +-
.../components/nativeFilters/FiltersConfigModal/ItemTitleContainer.tsx | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/DraggableFilter.tsx b/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/DraggableFilter.tsx
index 4cb66c2ed65..ee51e1c6635 100644
--- a/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/DraggableFilter.tsx
+++ b/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/DraggableFilter.tsx
@@ -96,7 +96,7 @@ export const DraggableFilter: FC<FilterTabTitleProps> = ({
<Container isDragging={isDragging} {...attributes} {...listeners}>
<DragIcon
isDragging={isDragging}
- alt={t('Move icon')}
+ aria-label={t('Move icon')}
viewBox="4 4 16 16"
/>
<div css={{ flex: 1 }}>{children}</div>
diff --git a/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FilterTitleContainer.tsx b/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FilterTitleContainer.tsx
index 6e0bbddbb5f..19d7427917b 100644
--- a/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FilterTitleContainer.tsx
+++ b/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FilterTitleContainer.tsx
@@ -211,7 +211,7 @@ const FilterTitleContainer = forwardRef<HTMLDivElement, Props>(
event.stopPropagation();
onRemove(id);
}}
- alt={t('Remove filter')}
+ aria-label={t('Remove filter')}
data-test="filter-remove-button"
/>
)}
diff --git a/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/ItemTitleContainer.tsx b/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/ItemTitleContainer.tsx
index 1d00f81e77d..78b9186dca6 100644
--- a/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/ItemTitleContainer.tsx
+++ b/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/ItemTitleContainer.tsx
@@ -179,7 +179,7 @@ const ItemTitleContainer = forwardRef<HTMLDivElement, Props>(
event.stopPropagation();
onRemove(id);
}}
- alt={deleteAltText}
+ aria-label={deleteAltText}
/>
)}
</div>