You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/06/10 15:11:23 UTC

[GitHub] [skywalking] dagmom opened a new pull request #4898: Byte buddy can't resolve

dagmom opened a new pull request #4898:
URL: https://github.com/apache/skywalking/pull/4898


   Please answer these questions before submitting pull request
   
   - Why submit this pull request?
   - [x] Bug fix
   - [ ] New feature provided
   - [ ] Improve performance
   
   - Related issues
   
   ___
   ### Bug fix
   - Bug description.
   
   Cannot resolve type description for org.mozilla0.javascript.Script
   
   - How to fix?
   
   add ignore package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on pull request #4898: Byte buddy can't resolve

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #4898:
URL: https://github.com/apache/skywalking/pull/4898#issuecomment-643758885


   Take your time, it is not urgent. I just want to make you clear, why this PR is not reviewed. 
   
   When you are ready, feel free to open a clean PR.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] dagmom closed pull request #4898: Byte buddy can't resolve

Posted by GitBox <gi...@apache.org>.
dagmom closed pull request #4898:
URL: https://github.com/apache/skywalking/pull/4898


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on pull request #4898: Byte buddy can't resolve

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #4898:
URL: https://github.com/apache/skywalking/pull/4898#issuecomment-643744484


   The most importantly, you mixed this PR and #4846 together. You should not do this. Please submit pull requests based on the separated branches.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] dagmom commented on pull request #4898: Byte buddy can't resolve

Posted by GitBox <gi...@apache.org>.
dagmom commented on pull request #4898:
URL: https://github.com/apache/skywalking/pull/4898#issuecomment-643723660


   [ProtectiveShieldMatcher add feature for exclude some class with -Dskywalking_enhance_ignore_class_pattern, so we ignore some package](https://github.com/apache/skywalking/pull/3314)
   
   [[Agent]Add a ProtectiveShieldMatcher to prevent match exception.](https://github.com/apache/skywalking/pull/706)
   
   The problem is the same as above.
   I'll use the new branch later.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on pull request #4898: Byte buddy can't resolve

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #4898:
URL: https://github.com/apache/skywalking/pull/4898#issuecomment-643735391


   @dagmom I was not talking about the feature, we need to make this PR basically first.
   1. CI should be right, but right now, there is conflicting file.
   1. Commit logs make me confusing. I recommend you to check out from the current master, and re-format the branch. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] dagmom commented on pull request #4898: Byte buddy can't resolve

Posted by GitBox <gi...@apache.org>.
dagmom commented on pull request #4898:
URL: https://github.com/apache/skywalking/pull/4898#issuecomment-643757348


   > The most importantly, you mixed this PR and #4846 together. You should not do this. Please submit pull requests based on the separated branches.
   
   I see now, thank you for reminding me. @wu-sheng 
   
   I have new branch upstream/master on local, and I need confirm some details about `org.mozilla.javascript.Script`.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org