[GitHub] [spark] gengliangwang commented on a change in pull request #29364: [SPARK-32548][SQL] - Add Application attemptId support to SQL Rest API

[GitBox <gi...@apache.org>]

gengliangwang commented on a change in pull request #29364:
URL: https://github.com/apache/spark/pull/29364#discussion_r482703098



##########
File path: sql/core/src/test/scala/org/apache/spark/status/api/v1/sql/SqlResourceSuite.scala
##########
@@ -203,3 +210,101 @@ class SqlResourceSuite extends SparkFunSuite with PrivateMethodTester {
   }
 
 }
+
+case class Person(id: Int, name: String, age: Int)
+case class Salary(personId: Int, salary: Double)
+
+/**
+ * Sql Resource Public API Unit Tests running query and extracting the metrics.
+ */
+class SqlResourceWithActualMetricsSuite extends SharedSparkSession with SQLMetricsTestUtils {

Review comment:
       nit: Shall we move this to a single file and leave SqlResourceSuite.scala unchanged?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org