[jira] [Commented] (FLINK-10332) Move data available notification in PipelinedSubpartition out of the synchronized block

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-10332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16614131#comment-16614131 ] 

ASF GitHub Bot commented on FLINK-10332:
----------------------------------------

NicoK opened a new pull request #6693: [FLINK-10332][network] move data notification out of the synchronized block
URL: https://github.com/apache/flink/pull/6693
 
 
   ## What is the purpose of the change
   
   Currently, calls to `PipelinedSubpartition#notifyDataAvailable()` are unnecessarily executed inside a synchronized (buffers) block which may lead to lock contention which this PR fixes.
   
   Please note, that we build upon #6692.
   
   ## Brief change log
   
   - move data notification out of the synchronized block
   
   ## Verifying this change
   
   This change is already covered by existing tests.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): **no**
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: **no**
     - The serializers: **no**
     - The runtime per-record code paths (performance sensitive): **yes** (depending on output flusher interval, rather per buffer)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: **no**
     - The S3 file system connector: **no**
   
   ## Documentation
   
     - Does this pull request introduce a new feature? **no**
     - If yes, how is the feature documented? **not applicable**
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Move data available notification in PipelinedSubpartition out of the synchronized block
> ---------------------------------------------------------------------------------------
>
>                 Key: FLINK-10332
>                 URL: https://issues.apache.org/jira/browse/FLINK-10332
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Network
>    Affects Versions: 1.5.0, 1.5.1, 1.5.2, 1.5.3, 1.6.0, 1.7.0
>            Reporter: Nico Kruber
>            Assignee: Nico Kruber
>            Priority: Major
>              Labels: pull-request-available
>
> Currently, calls to {{PipelinedSubpartition#notifyDataAvailable();}} are unnecessarily executed inside a {{synchronized (buffers)}} block which may lead to lock contention.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)